May 2021 - Koha-devel - lists.koha-community.org

TT loop count VS size
by Fridolin SOMERS 10 May '21

10 May '21

Hi community, I've been on a mindblowing search on a template error :D I was thinking that "loop.count" was wrong for testing if loop is not empty, the method is "loop.size". See doc http://template-toolkit.org/docs/manual/Directives.html#section_FOREACH Looks like we use both actually : > git grep 'IF.*\.count ' origin/master | wc -l 602 > git grep 'IF.*\.size ' origin/master | wc -l 1636 So using count seems to work because it starts with 1. But in my opinion it is a wrong call. We can see for example : <a href="#images">Images ([% localimages.count || 0 | html %])</a> This is wrong no ? Should be create a coding guideline ? -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> Software and system maintainer 🦄 BibLibre, France

4 5

Help needed to test an i-tiva bug (no prior knowledge required)
by Victor Grousset/tuxayo 08 May '21

08 May '21

Hi :) Here is a bug that I tested and checked for QA. Now a test from someone else is needed. Here is the ticket: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Here is the test plan: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562#c4 Here are instructions to setup i-tiva: https://wiki.koha-community.org/wiki/External_Integration#i-tiva I'll gladly guide you via email or tchat (nickname: tuxayo) Cheers, -- Victor Grousset/tuxayo

1 0

Embedding JSON data in HTML
by dcook＠prosentient.com.au 06 May '21

06 May '21

Hi all, I was just reflecting on bugs like https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942 and reviewing https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script when I saw the following method for embedding JSON in HTML:  <script id="data" type="application/json">{"userId":1234,"userName":"John Doe","memberSince":"2000-01-01T00:00:00.000Z"}</script>  <script> const userInfo = JSON.parse(document.getElementById("data").text); console.log("User information: %o", userInfo); </script> I thought that was neat. David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

2 1

Why is config ($KOHA_CONF) stored in memcached ?
by Julian Maurice 04 May '21

04 May '21

Hi all, Maybe it's a dumb question, but I don't understand why the config is stored in memcached as: - memcached server address is in this config, so we need to read $KOHA_CONF file first in order to connect to memcached server - config is kept in memory forever ($C4::Context::context), so we shouldn't need the cache once starman has started. If you add a warning in Koha::Config::read_from_file, you'll see that the file is read 3 times per worker, even when the config already exist in cache (it's read 4 times when the cache is empty). It's read each time we call Koha::Cache->new (+ in C4::Context->new if the cache is empty) Shouldn't we read the file only in C4::Context->new (without using cache), and make Koha::Cache use C4::Context->config instead ? -- Julian Maurice BibLibre

3 5

Elasticsearch vs OpenSearch
by dcook＠prosentient.com.au 03 May '21

03 May '21

Because I'm good at stirring up trouble. https://www.techrepublic.com/google-amp/article/opensearch-aws-rolls-out-its -open-source-elasticsearch-fork/ As you may know, AWS have forked the last FOSS Elasticsearch (7.10 I think). They've announced that they're calling it OpenSearch. It's still only in alpha stage and they won't have a production-ready release for months yet, but it is interesting to keep notes on. Elastic are responsible for the vast majority of commits in Elasticsearch, so I'm somewhat skeptical about a fork, but I think there is a lot of anger at Elastic and a lot of support for OpenSearch, so who knows. I don't think there's anything to do at this stage, but just wanted to share the information for people David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

2 2

HTTP/HTTPS cheme in Base Path in API documentation
by dcook＠prosentient.com.au 03 May '21

03 May '21

Hi all, I just noticed on a HTTPS site that the Base URL at /api/v1/.html was listed as HTTP rather than HTTPS. Looking at Mojolicious::Plugin::OpenAPI, it seems that it's hard-coded to HTTP *if* a scheme isn't specified in the spec: https://github.com/jhthorsen/mojolicious-plugin-openapi/blob/master/lib/Mojo licious/Plugin/OpenAPI/SpecRenderer.pm#L406 Looking at https://swagger.io/docs/specification/2-0/api-host-and-base-path/, we could be setting "schemes" there. I'm not 100% sure what we should do here. Maybe nothing. But it just seem unfortunate to be showing a HTTP link on a HTTPS page especially for an API... David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

1 0