- Koha-devel - lists.koha-community.org

PLEASE, help me...
by paul POULAIN 16 May '02

16 May '02

Yesterday I asked for the structure of the websites table. I still have no answers. Today, I will ask for the "uploadedmarc" table structure (in acqui.simple). PLEASE, when you update you local mysql-DB, don't forget cvs ignore it, so update database.mysql immediatly, so I will be able to do the changes also... I've searched "uploadedmarc" table everywhere and could'nt find it ;-((( Thanks. This day was a boring day : searching for biblio-adding problem without any result, and trying to work on marc stuff with no more success :-\\\\\\\ -- Paul

4 8

DBI digest
by Douglas Bagnall 16 May '02

16 May '02

Alan wrote: > foreach my $dummy (@results) { > $query .= "?,"; > } # foreach > And there is probably a shorter way to do the correct number > of question marks via a count of @results. That would be the x operator. '?,' x 4 eq '?,?,?,?,' cheers, Douglas

1 0

coding practices
by paul POULAIN 16 May '02

16 May '02

I will try to build a page with "coding practices" for koha on the wiki. It will contain Alan proposal about perl/mysql proposals (use of ? where it causes no read-havoc. For example, in a prepare("select x,y,z from table where param=?"). In this case, it's undoubtfully more readable. I also want to ask about an eternal question : Do we use tab or space for indenting our programs ? I prefer tabs. For instance, soft is indented sometimes with spaces, sometimes with tabs, which makes them not easily readables. what's your opinion ? -- Paul

2 1

Question on proper/preferred DBI usage?
by Alan Millar 15 May '02

15 May '02

Hi- I hope this doesn't sound like criticism of the efforts so far; I think Koha is excellent work. However, I'm wondering about the DBI usage in the code. It appears that everything I've read on DBI says not to put variables into the SQL statement but to use placeholder parameters instead. For example, right now everything looks something like this: my $q_value=$dbh->quote($value); my $sth=$dbh->prepare("select my_field from my_table where my_criteria=$q_value"); $sth->execute; Whereas what I've read on the subject says it should be done like: my $sth=$dbh->prepare("select my_field from my_table where my_criteria=?"); $sth->execute($value); This doesn't require double the variables for all the quoting, and in a loop the prepare only has to be done once. I'm especially confused about things I see in the code like: $biblioitem->{'volume'} = $dbh->quote($biblioitem->{'volume'}); I think I'd be confused in keeping track of which things you have or haven't quoted already. I'd like to contribute to the project, and I'm happy to clean up things like this as I come across them. I'm wondering if there is a particular reason it's being done the way it is, or did it "just happen" this way? Thanks! - Alan -- ---- Alan Millar --==> am12(a)bolis.com <==--

2 2

adding biblio
by paul POULAIN 15 May '02

15 May '02

I've just commited 2 small corrections in newbiblio and addorder scripts. But my question is still here ! When you're on a basket and click on a biblio link, you're asking the system to do something strange... I explain : you call "newbiblio.pl", which mean you want to ADD a biblio/biblioitem. See, for example, barcode calculation in newbiblio.pl. Chris told me it was supposed to EDIT the biblio/biblioitem. I dig 3 hours in this code, and still does not understand what happends, where it's wrong, and how to correct. What i'm sure, is that it has a strange behaviour. Could someone (from katipo maybe) have a *deep* look and explain me or correct the problem ? -- Paul

2 1

public irc logs
by Tonnesen Steve 15 May '02

15 May '02

Anybody have any feelings on making irc logs publically available? I've got a logger running on the channel now and a web page for viewing the logs. If nobody objects to public logs, I'll post a link on the wiki. If somebody objects, I won't post the link, or I'll make the log site password protected. Steve.

2 1

Marc Branch
by Chris Cormack 14 May '02

14 May '02

Hi all As requested by Paul i have created a branch called rel-1-4-marc that ppl can use to work on the marc version. Id also like to see if we can organise some kind of group session to knock out any bugs in the rel-1-2 branch. And see if we can progress towards a 1.2.0 stable release. Perhaps we need that Release manager to crack the whip :) Chris -- Chris Cormack chris(a)katipo.co.nz Programmer 025 500 579 Katipo Communications www.katipo.co.nz

2 1

Forwarded on behalf of rosalie
by Chris Cormack 14 May '02

14 May '02

------- Forwarded message follows ------- To: rosalie(a)library.org.nz Date sent: Mon, 13 May 2002 23:26:57 -0700 From: "SOFYAN ROSYIDI" <sofyan.r(a)eudoramail.com> Send reply to: sofyan.r(a)eudoramail.com Subject: (No Subject) Organization: QUALCOMM Eudora Web-Mail (http://www.eudoramail.com:80) How to install KOHA on Windows operating system? thanks for your help, God bless u ---- Anyone want to take a crack at this? -- Chris Cormack chris(a)katipo.co.nz Programmer 025 500 579 Katipo Communications www.katipo.co.nz

1 0

Heads up
by Nicholas Rosasco 14 May '02

14 May '02

I'll be only sporadically connected to email for the next few days, just as a warning. I'm taking a look at the DocBook info (which is very new to me) I've found. Just a heads up, Nick

1 0

templates
by Tonnesen Steve 14 May '02

14 May '02

Still playing with templates... I've implemented paul's hierarchy suggestion of "theme" directories at the top. What I'd like to be able to do is specifiy an ordered list of preferred templates. For example, one might want to specify: local french default templates. If a template exists in the "local" theme, it will always be used. If a template exists in "french" but not in "local" the "french" template will be used. As a last resort, the "default" template will always be used. Should we develop a naming scheme for themes that are distributed with Koha, to keep them from squashing local or third party themes? Maybe koha-default, koha-french, koha-polish, etc? I'm thinking that Koha will probably ship with at least themes for various languages. I suppose the other option would be to have separate directories for shipped themes and local/third party themes? Steve.

1 0