- Koha-devel - lists.koha-community.org

sources gitignore under versionning
by Fridolin SOMERS 05 Apr '18

05 Apr '18

Hi, Since Bug 20267 "Add basic .gitignore", there is a .gitignore in sources under GIT versionning. You may want to add more ignore globally with : https://help.github.com/articles/ignoring-files/#create-a-global-gitignore Or per repository with .git/info/exclude Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre - software and system maintainer

1 1

Write good bug report titles and commit messages
by Jonathan Druart 04 Apr '18

04 Apr '18

Hi devs, I would like to do a little reminder about the bug report titles and commit messages. For bugs: The bug report title must shortly tell what the *bug* is, whereas the commit messages must tell what the *fix* does. Sometimes they are not related at all. For instance: - bug report titles: "Feature X is not working correctly when Y is enabled", "Click on button 'Save' does not save the record", "Saving stuff on screen X does not work", "This script generates error logs", "Mystake is misspelled in this script", "Behaviour X no longer work as expected" etc. - commit messages: "Fix Feature X when Y is enabled", "Make sure behaviour is correct when button is clicked", "Remove warnings from this script", "Correct spelling of mistake in this script", "Fix regression on behaviour X" etc. For enhancements / new feature: We could have the same title and commit messages in some cases. - bug report titles: "Add new awesome feature", "Add the ability to do that", "Code is duplicated in method Koha::Stuff->method" - commit messages: "Add new awesome feature", "Add the ability to do that", "Remove code duplication in method Koha::Stuff->method" Note that "Address comment #42" is a terrible commit message. Then, I would like to standardize the commit messages a bit. We have "Bug 12345 - ", "Bug 12345: ", "Bug 12345" and "[follow-up]", "(follow-up)", "[QA Followup]", etc. I would suggest: "Bug 12345: you commit message" And reject any commit messages with only "follow-up" (or whatever how it is written), but accept "Bug 12345: (follow-up) same commit message as before" If you forgot something, even if "Bug 12345: (follow-up) This was missing" And QA follow-ups (added by QA team member): "Bug 12345: "(QA follow-up) Add/remove this stuff" I am going to suggest these change during the next dev meetings. If accepted I will change the bug report titles and commit messages before the push during few weeks, then ask authors to do it themselves (patches from new contributors will not be rejected for that reason). You should also read or re-read: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines https://wiki.koha-community.org/wiki/Commit_messages Cheers, Jonathan

6 6

RFC for MARC holdings record support
by Ere Maijala 04 Apr '18

04 Apr '18

Hi Everyone, I've written an RFC for adding support for MARC holdings records, available here: <https://wiki.koha-community.org/wiki/MARC_Holdings_Records_RFC>. I'd be grateful for any feedback on this. I know there have been some initiatives to add (back) holdings records, but this proposal is a bit different in that it relies on the MARC format and I already have it working in a local custom branch apart from OPAC support. Regards, Ere -- Ere Maijala Kansalliskirjasto / The National Library of Finland

3 3

Koha General Meeting Reminder - 4 April 14UTC
by Owen Leonard 03 Apr '18

03 Apr '18

Hello all, This is a reminder that there will be a Koha general IRC meeting in about 24 hours, 4 April at 14UTC. Please add anything you want to discuss to the agenda. Please add your apologies if you can't make the meeting. Local time conversion: https://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+General+IRC+… Meeting agenda: https://wiki.koha-community.org/wiki/General_IRC_meeting_4_April_2018 See you there, Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org

1 0

Re: [Koha-devel] Printing patron cards results in 100% cpu
by Christopher Nighswonger 02 Apr '18

02 Apr '18

I'm not sure what is going on in this particular instance, but taking the same steps on my production system results in a PDF containing the expected cards and nearly zero CPU usage. Unless someone else can confirm the problem, I would look at something local. Perhaps a Koha update did not apply well or some such, resulting in a script not being updated. On Sun, Apr 1, 2018 at 5:22 PM, Sven Halm <sven.halm(a)shalm.de> wrote: > I've always gone the following way: > > Tools/Patron lists/Actions/Print cartridge cards > > Then I choose the template and layout and that's it. As soon as I click on > the pdf-link, the CPU goes up. > > I'll attach some screenshots to the e-mail. > > Many greetings > Sven > > ------------------------------ > *Von: *"Christopher Nighswonger" <chris.nighswonger(a)gmail.com> > *An: *"Sven Halm" <sven.halm(a)shalm.de> > *Gesendet: *Sonntag, 1. April 2018 22:35:51 > *Betreff: *Re: [Koha-devel] Printing patron cards results in 100% cpu > > It appears that no batch is passed to the script. How are you accessing it? > > Chris > > On Sun, Apr 1, 2018, 3:43 PM Sven Halm <sven.halm(a)shalm.de> wrote: > >> Hello and happy Easter! >> >> I have a problem with the patronage card printing. I also described the >> problem in Bug 20077. I got a tip from Katrin to try the mailing list. >> >> When I try to print the patron cards, the /usr/share/koha/intranet/cgi- >> bin/patroncards/create-pdf.pl does not finish and runs with 100% CPU >> load. >> >> In plack-error.log I find the following lines: >> Use of uninitialized value $batch_id in concatenation (.) or string at >> /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl line 68. >> Use of uninitialized value in multiplication (*) at >> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. >> Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm >> line 256. >> Use of uninitialized value in multiplication (*) at >> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288. >> Use of uninitialized value in multiplication (*) at >> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. >> Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm >> line 256. >> Use of uninitialized value in multiplication (*) at >> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288. >> Use of uninitialized value in multiplication (*) at >> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. >> Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm >> line 256. >> >> The problem first appeared in February 2018 after I started the Ubuntu >> updates. Unfortunately I don't remember what has been updated. >> >> Current system environment (no changes made to koha!): >> OS: Ubuntu 17.10 >> Koha-Version: >> 17.11.04.000 >> OS Version ('uname -a'): >> Linux koha 4.13.0-37-generic #42-Ubuntu SMP Wed Mar 7 14:13:23 UTC 2018 >> x86_64 >> Perl Interpreter: >> /usr/bin/perl >> Perl-Version: >> 5.026000 >> Perl @INC: >> /usr/share/koha/lib >> /usr/share/koha/installer >> /usr/share/koha/lib/installer >> /etc/perl >> /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 >> /usr/local/share/perl/5.26.0 >> /usr/lib/x86_64-linux-gnu/perl5/5.26 >> /usr/share/perl5 >> /usr/lib/x86_64-linux-gnu/perl/5.26 >> /usr/share/perl/5.26 >> /usr/local/lib/site_perl >> /usr/lib/x86_64-linux-gnu/perl-base >> MySQL-Version: >> mysql Ver 15.1 Distrib 10.1.30-MariaDB, for debian-linux-gnu (x86_64) >> using readline 5.2 >> Apache-Version: >> Server version: Apache/2.4.27 (Ubuntu) >> >> >> Unfortunately I am not able to print patron cards at the moment. It would >> be great if there was a solution for this soon. >> >> Many greetings >> Sven >> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel(a)lists.koha-community.org >> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : http://www.koha-community.org/ >> git : http://git.koha-community.org/ >> bugs : http://bugs.koha-community.org/ > > >

1 0

Koha Docs Webinar - LIVE
by Lee Jamison 31 Mar '18

31 Mar '18

Just a reminder about the Koha docs webinar is taking place now. I have set aside 17-19 UTC. Anyone who wishes to join, visit https://meet.jit.si/KohaDocsTeam -- Lee Jamison Automated Library Technician Marywood University 570-961-4586 ldjamison(a)marywood.edu

2 1

Koha Community Newsletter: March 2018
by Koha Newsletter 31 Mar '18

31 Mar '18

Fellow Koha users: The Koha Community Newsletter for March 2018 is here: https://koha-community.org/koha-community-newsletter-march-2018/ Many thanks to the folks who submitted articles and news to this month's newsletter. Please feel free to email me with any corrections or suggestions. Thanks!

1 0

new user presentation
by ck＠interleaf.ie 30 Mar '18

30 Mar '18

Hello My name is Carl, I'm a new member on this list. I have recently started working as a Developer for Interleaf - a company in Ireland providing services for libraries ( https://www.inter leaf.ie/ ). We want to give back to the Koha community, so I will be spending time on this mailing list and in Bugzilla, trying to do just that. I'm rather new to Koha, and will hang around in the background for a while to pick up on how things work around here. I've worked as a developer and with Linux & BSD systems for a few decades, and will take the time to ensure I respect your well documented guidelines. Cheers ck

5 4

Rescheduled meeting for Koha docs March meeting
by Lee Jamison 29 Mar '18

29 Mar '18

Hello all, since the meeting on the 22nd didn't come to pass (appears it was forgotten and I had an unplanned meeting at work to go to). Therefore, I'm going to reschedule it for tomorrow March 29th at 21 UTC. https://wiki.koha-community.org/wiki/Documentation_IRC_meeting_29_March_2018 Also of note in the agenda, I've scheduled the koha docs webinar I promised for March 30th. I've set aside 17-19 UTC for it to provide as much help as I can for those interested in attending. I'm figuring out the best way to do the webinar since a free zoom account only allows for one-on-one so I will provide that as soon as I figure out a solution (feel free to provide suggestions!) -- Lee Jamison Automated Library Technician Marywood University 570-961-4586 ldjamison(a)marywood.edu

2 1

User password reset question
by Graham, Stephen 27 Mar '18

27 Mar '18

Hi All - if I wanted to programmatically change a user's password what would the best way of doing this? I've just been looking at the various Perl modules for our version of Koha (16.11). modules such as C4:Members, C4:Member:Attributes etc, but cannot see any methods that can reset the password. Looking at the opac-passwd.pl CGI script which is called when changing a user password, I see that it uses a SQL update to change the password. Is this the best route to go if I wanted to change a password? Cheers, Stephen -------------------------------------- Stephen Graham Library Technology Consultant Content and Collections Team Library and Computing Services University of Hertfordshire Tel: 01707 286111 Ext: 77751 Email: s.graham4(a)herts.ac.uk

3 3