- Koha-devel - lists.koha-community.org

Bug 17908 Authority merge omnibus
by Marcel de Rooy 14 Jan '17

14 Jan '17

Hi all, There is a lot of code to *merge* on merging authorities. (Among others, bugs 5572 and 11315 and 11700 are offering parallel solutions.) I moved all relevant reports (imo) to this omnibus, and propose a strategy there to get this moving. As a self-appointed 'feature manager' I closed and blocked a few bugs in this regard. I would like to also move some patches or copy some code to other reports while keeping the attribution to the original authors. Do you agree and would you be so kind to follow along? Other thoughts ? Thanks, Marcel

2 1

Call for news: January 2016 Newsletter
by kohanews 14 Jan '17

14 Jan '17

I'm collecting news for the January newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events -- **** one month back is the cut-off ***. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the 26th of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. -- Chad Roseburg Editor, Koha Community Newsletter

1 0

Update the SQL reports (Remove biblioitems.marcxml field)
by Jonathan Druart 13 Jan '17

13 Jan '17

Hi devs, Bug 17196 is on its way to master, that means that some SQL reports from our wiki will be obsolete. https://wiki.koha-community.org/wiki/SQL_Reports_Library#Query_MARC We need to provide to libraries the examples of equivalent reports to help them updating their custom reports. It seems very easy to update the reports from the wiki, but we will need to propose the 2 versions (with and without the biblioitems.marcxml field). As the marcxml will be moved to the biblio_metadata.metadata field, the reports are very easy to update, for instance: 1/ Simple request on the biblioitems table: SELECT biblionumber, ExtractValue(marcxml, 'count(//datafield[@tag="505"])') AS count505 FROM biblioitems HAVING count505 > 1; Will become: SELECT biblionumber, ExtractValue(metadata, 'count(//datafield[@tag="505"])') AS count505 FROM biblio_metadata HAVING count505 > 1; 2/ With info from the biblio table: SELECT biblionumber, substring( ExtractValue(marcxml,'//controlfield[@tag="008"]'), 8,4 ) AS 'PUB DATE', title FROM biblioitems INNER JOIN biblio USING (biblionumber) WHERE biblionumber = 14; Will become: SELECT biblionumber, substring( ExtractValue(metadata,'//controlfield[@tag="008"]'), 8,4 ) AS 'PUB DATE', title FROM biblio_metadata INNER JOIN biblio USING (biblionumber) WHERE biblionumber = 14; 3/ Move complex query: SELECT concat(b.title, ' ', ExtractValue(m.marcxml, '//datafield[@tag="245"]/subfield[@code="b"]')) AS title, b.author, count(h.reservedate) AS 'holds' FROM biblio b LEFT JOIN biblioitems m USING (biblionumber) LEFT JOIN reserves h ON (b.biblionumber=h.biblionumber) GROUP BY b.biblionumber HAVING count(h.reservedate) >= 42; Will become: SELECT concat(b.title, ' ', ExtractValue(m.metadata, '//datafield[@tag="245"]/subfield[@code="b"]')) AS title, b.author, count(h.reservedate) AS 'holds' FROM biblio b LEFT JOIN biblio_metadata m USING (biblionumber) LEFT JOIN reserves h ON (b.biblionumber=h.biblionumber) GROUP BY b.biblionumber HAVING count(h.reservedate) >= 42; So basilly "biblioitems" becomes "biblio_metadata" and marcxml becomes "metadata". We could almost script it! The only difficulty I see is when we will need infos from the biblioitems table, we will need to add a join on biblio_metadata. I was going to add the biblio_metadata version on the wiki, but, the first example of ExtractValue is completely wrong. It says that 2 queries are equivalent ("they are equivalent") and that "they return the whole 952 field". Which is totally wrong. The work is a bit more complex than expected apparently, this wiki page need to be updated and cleaned first. Then we will be able to provide equivalent queries. Cheers, Jonathan

1 1

Re: [Koha-devel] [NEW_TOPIC] Getting bugs further
by Marcel de Rooy 13 Jan '17

13 Jan '17

> I guess there's no straight answer. It will depend on signoffers and QA people's opinion. People tend to focus on the stuff they care, lately, so that's why I said... > Sometimes people just drop some patches and wait for others to care about them. And it doesn't work like that most of the time. Shouldn’t we as a community do something about this evolving trend then? If we scare away developers by ignoring their patches, the community is not better off in the long run (imo). So, we should signoff or QA not only what we need or like. Isn’t that something for the bug wranglers too? Marcel

3 3

Re: [Koha-devel] Advice for testing bug 17710
by David Cook 12 Jan '17

12 Jan '17

I suppose in this case I rather be told what’s enough than doing my best and being told it’s not enough. I suppose we’re all time poor, but I don’t have 100% time on Koha anymore. Test::MockModule might work. Long term, it probably makes more sense to refactor get_matches, but I think it could work for now to show that the code I’m using works. Although in that case, should I put my sorting code as a function or copy and paste from the module into the test? I suppose any time a person says copy and paste, the answer is make a function… What do you mean by keep in touch with QA members? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: Tomas Cohen Arazi [mailto:tomascohen@gmail.com] Sent: Thursday, 12 January 2017 11:56 AM To: David Cook <dcook(a)prosentient.com.au> Subject: Re: [Koha-devel] Advice for testing bug 17710 David, do your best and try to keep in touch with QA members. While we enforce the introduction of regression tests, there are exceptions. We usually get grumpy when tests are trivial, and we deduce laziness on the developer side. El mié., 11 de ene. de 2017 9:33 PM, David Cook <dcook(a)prosentient.com.au <mailto:dcook@prosentient.com.au> > escribió: Hi all, I wrote a little patch to make C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch use the same logic for sorting matches, so that matches are returned consistently in the same order. However, C4::Matcher::get_matches is basically spaghetti and relies on Zebra (and a hard-coded Zebra server at that), so I’m not sure how best to test it. I was thinking maybe turning the sorting into a little function and unit testing that. Would that be sufficient? In terms of manual testing, I think matching is mostly done behind the scenes, so it would be tough to verify the output of the sort… David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/> ) ✆ +54 9351 3513384 GPG: B2F3C15F

2 1

FYI: yaz-client limitations
by Tomas Cohen Arazi 12 Jan '17

12 Jan '17

Barton told me it could be useful to share this excange I had with IdexData people during the implementation of the Zebra facets. It highlights a limitation on the yaz-client tool, and they suggest we better use zoomsh. I'm not sure if I already posted this on koha-devel, but it doesn't hurt to re-post, and might save some people some hours and headaches. Regards ---------- Forwarded message --------- From: Adam Dickmeiss <adam(a)indexdata.dk> Date: lun., 9 mar. 2015 a las 6:36 Subject: Re: [Info] Possible limit on the amount of specs on an elementset? [ZEB-663] To: Tomas Cohen Arazi <tomascohen(a)gmail.com> Cc: jira(a)indexdata.com <jira(a)indexdata.com> On 03/02/2015 12:18 PM, Tomas Cohen Arazi wrote: Hi, I compiled 2.0.60 with the aim to patch it for a problem we are facing, and I can say the problem I previously reported is still present: This a limitation in yaz-client which has a limit of 100 characters for elem command. We'll remove that limitiation. You can use zoomsh instead to play with longer facet specs. / Adam Z> elem zebra::facet::su-to:0:100,su-geo:0:100,su-ut:0:100,au:0:100,se:0:100,itype:0:100,location:0:100,holdingbranch:0:100,homebranch:0:100,tomas:0:100 Z> s 1+1 Sent presentRequest (1+1). Records: 1 Record type: XML <record xmlns="http://www.indexdata.com/zebra/"> <facet type="0" index="su-to"> </facet> <facet type="0" index="su-geo"> </facet> <facet type="0" index="su-ut"> </facet> <facet type="0" index="au"> <term coccur="2" occur="2">Adåker, Ulf</term> <term coccur="2" occur="2">Danielsson, Palle</term> <term coccur="2" occur="2">Stenson, Bobo</term> <term coccur="1" occur="1">Davis, Miles</term> <term coccur="1" occur="1">Löfcrantz, Johan</term> <term coccur="1" occur="1">Milder, Joakim</term> <term coccur="1" occur="1">Öström, Magnus</term> </facet> <facet type="0" index="se"> </facet> <facet type="0" index="itype"> </facet> <facet type="0" index="location"> </facet> <facet type="0" index="holdingbranch"> </facet> </record> nextResultSetPosition = 2 Elapsed: 0.001203 So 'holdingbranch' is the last facet it retrieves. If I thange the elementset like this: Z> elem zebra::facet::su-to:0:100,su-geo:0:100,su-ut:0:100,au:0:100,se:0:100,itype:0:100,location:0:100,tomas:0:100,homebranch:0:100,holdingbranch:0:100 I still get a 8 facet limit: Z> s 1+1 Sent presentRequest (1+1). Records: 1 Record type: XML <record xmlns="http://www.indexdata.com/zebra/"> <facet type="0" index="su-to"> </facet> <facet type="0" index="su-geo"> </facet> <facet type="0" index="su-ut"> </facet> <facet type="0" index="au"> <term coccur="2" occur="2">Adåker, Ulf</term> <term coccur="2" occur="2">Danielsson, Palle</term> <term coccur="2" occur="2">Stenson, Bobo</term> <term coccur="1" occur="1">Davis, Miles</term> <term coccur="1" occur="1">Löfcrantz, Johan</term> <term coccur="1" occur="1">Milder, Joakim</term> <term coccur="1" occur="1">Öström, Magnus</term> </facet> <facet type="0" index="se"> </facet> <facet type="0" index="itype"> </facet> <facet type="0" index="location"> </facet> <facet type="0" index="homebranch"> </facet> </record> nextResultSetPosition = 2 Elapsed: 0.003697 On Mon, Feb 9, 2015 at 5:08 PM, Tomas Cohen Arazi <tomascohen(a)gmail.com> wrote: Is there a way (or could it be) to skip the error if there are elems with results? For facets, it would be great that we could ask for n facets, and retrieve all at once. I'll try 2.0.59 in about two hours and reply. El lun., 9 de febrero de 2015 12:59, Adam Dickmeiss <adam(a)indexdata.dk> escribió: On 02/09/2015 04:51 PM, Tomas Cohen Arazi wrote: It is 2.0.44 on ubuntu 14.04. Should i try a newer? I don't see things changes with respect to facets.. But you could try 2.0.59 out. / Adam El lun., 9 de febrero de 2015 12:48, Adam Dickmeiss <adam(a)indexdata.dk> escribió: On 02/05/2015 11:27 AM, Adam Dickmeiss wrote: Hi Tomas, we'll look into this and get back to you. Please reply-all and keep [ZEB-663] contents in the subject line for future conversation. Hi Tomas, we can't see a limit of 8. Asking for more than 8 returns more than 8. And supplying any non-existing facet-field throws an error. What version of Zebra are you using? / Adam / Adam On 02/04/2015 03:59 PM, Tomas Cohen Arazi wrote: Hi, I've been playing with facets retrieval, which shines in Koha 3.18 (thanks!) One thing I noticed is that asking zebra to retrive more than 8 facets at once doesn't work (it only retrieves 8). What i did was: > elem zebra::facet::a1:0:20,...,a8:0:20,bullshit:0:20 ('bullshit' doesn't exist on the facet indexes) and > f a > s 1+1 shows the expected results. If I do > elem zebra::facet::a1:0:20,...,a7:0:20,bullshit:0:20 It fails ([25] Specified element set name not valid...) Regards -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 5353750 ext 13168 <%2B54%20351%205353750%20ext%2013168> GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F _______________________________________________ Info mailing listInfo@lists.indexdata.dkhttp://lists.indexdata.dk/cgi-bin/mailman/listinfo/info -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 5353750 ext 13168 <0351%20535-3750> GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

2 1

Advice for testing bug 17710
by David Cook 12 Jan '17

12 Jan '17

Hi all, I wrote a little patch to make C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch use the same logic for sorting matches, so that matches are returned consistently in the same order. However, C4::Matcher::get_matches is basically spaghetti and relies on Zebra (and a hard-coded Zebra server at that), so I'm not sure how best to test it. I was thinking maybe turning the sorting into a little function and unit testing that. Would that be sufficient? In terms of manual testing, I think matching is mostly done behind the scenes, so it would be tough to verify the output of the sort. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

2 1

KohaDevBox v2.0 released
by Tomas Cohen Arazi 11 Jan '17

11 Jan '17

After lots of months of work and people's contributions, we finally reached our milestone for v2.0. The original KohaDevBox functionalities are all implemented on the Ansible-driven one, and we can now focus on making it even better (we already have Elasticsearch integration, automatic superlibrarian user creation, and lots of configuration options). It can be used on Linux, Mac OS and Windows. It provides a full development and testing environment for people willing to work on the project. Read the README.md[1] file to get an idea of how easy is to get a full development environment, and the flexibility you can get with all the options we provide. Please enjoy it, and fill issues for any problem you might have. It can be improved, and we count on you to help us :-D Koha Development Team [1] https://github.com/digibib/kohadevbox -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

2 3

Zebra: the 'elements zebra::snippet' doesn't work
by Tajoli Zeno 11 Jan '17

11 Jan '17

Hi all, I trying to check my indexes in Zebra. My setup: OS: Debian jessie Koha: 3.20.7 [manual install] Zebra: 2.0.61 [install from IndexData repo] Format: UNIMARC Probably the fact that I use unimarc is relevant but I don't understand where. I do the debug described here: http://wiki.koha-community.org/wiki/Troubleshooting_Zebra#Why_does_a_search… The result of a working search is: Diagnostic message(s) from database: [25] Specified element set name not valid for specified database -- v2 addinfo 'zebra::snippet' but my ../etc/zebradb/retrieval-info-bib-dom.xml is correct: <?xml version="1.0" encoding="UTF-8"?> <retrievalinfo xmlns="http://indexdata.com/yaz"> <retrieval syntax="unimarc" name="F"> <backend syntax="xml" name="marc"> <marc inputformat="xml" outputformat="marc" inputcharset="utf-8" outputcharset="utf-8"/> </backend> </retrieval> <retrieval syntax="unimarc" name="B"> <backend syntax="xml" name="marc"> <marc inputformat="xml" outputformat="marc" inputcharset="utf-8" outputcharset="utf-8"/> </backend> </retrieval> <retrieval syntax="xml" /> <retrieval syntax="xml" name="index"/> <retrieval syntax="xml" name="marc" identifier="info:srw/schema/1/marcxml-v1.1"/> <retrieval syntax="xml" name="marcxml" identifier="info:srw/schema/1/marcxml-v1.1"/> <retrieval syntax="xml" name="zebra::*"/> </retrievalinfo> Do I need to check in other places for the setup of ' zebra::snippet' ? Bye Zeno Tajoli -- Zeno Tajoli / SVILUPPO PRODOTTI/ - Automazione Biblioteche Email: z.tajoli(a)cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)

5 13

Koha Development meeting reminder - 11 January 2016
by Nick Clemens 11 Jan '17

11 Jan '17

Hi All, The next Koha development meeting is on IRC tomorrow 11 January 2017 at 20:00 UTC You can see what that is in your local time here: https://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+Developers+I… <https://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+Developers+I…> Agenda is here: https://wiki.koha-community.org/wiki/Development_IRC_meeting_11_January_2017 Please make sure to add any topics you wish to discuss. See you all soon!

2 1