- Koha-devel - lists.koha-community.org

To React or not to React
by Kyle Hall 22 Sep '16

22 Sep '16

I have my proof of concept for using React within Koha completed! You can see it here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Please give it a try! So, I've written this development ( at least in part ) in both Angular and React. I know Angular 2 is out but here are my thoughts so far. 1) It's much easier to think in React than in Angular. React is for the most part just Javascript. It's far less opinionated than Angular. They saying goes React is Javascript and Angular is Angular. I think the flexibility of React works well within the Koha ecosystem. 2) Writing React feels much more like programming. I think it's much faster to develop reactive and ajax features in React than it is using jQuery. 3) React makes it pretty easy to create widgets that we can drop in to a given page and have just work. Pretty much anything that shows up on multiple pages would make for a good React widget. Think the holds table which is on the checkouts page and the patron details page. It is ajaxified now, but a far far cleaner version could be written in React. 4) React is just a view layer. Angular is a full MVC framework with many pieces we don't really need. I think React is probably the way to go for Koha. I like Angular but for Koha in particular, I think React is a better fit. I think we really need to get this decision made as soon as possible. If anyone has opinions, please let everyone know! Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org )

12 24

Re: [Koha-devel] To React or not to React
by Paul A 22 Sep '16

22 Sep '16

With some snipping, please see interspersed text below At 03:03 PM 9/21/2016 +0000, Kivilahti Olli-Antti wrote: >Hi there! >I don't know how I intercepted this email since I never read my email, but... Well, you've been subscribed for many years, have occasionally written, but I would agree that you "never read" ... >[snip] Kyle. I totally f***ing agree with you 10000%. >Swagger2 + React + Redux will f*** the s*** out of any ILS Koha meets. While I also find that Kyle made some good points, I am not a "list moderator" here, but would instantly chuck you out for your asterisks. I have Finnish friends who are perfectly civilized, so may I suggest kiitos and add ole varovainen sanasi ja kiel. >I was planning to start a ... 'KohaFi' ... get rid of the legacy baggage >... before we (as in Finland) can start working on that I have a ton of >stuff to do. Maybe next year ... I wish you (as in Finland [sic]) good luck. I'm holding my breath for "maybe next year" -- or hopefully even later -- for an outcome to your diatribe. Paul P.S. I will not respond to any further trolling.

1 0

Customize debian scripts.
by Rodrigo Santellan 21 Sep '16

21 Sep '16

Hi, I'm looking at the Debian scripts and I'm finding out that all the paths are hard coded. This is not really useful when installing the development version. Is worthy to change them to relatives paths? Or have it to take the enviroment variable to build the paths? Or is a waste of time? Regards

3 3

Re: [Koha-devel] To React or not to React
by Paul A 21 Sep '16

21 Sep '16

At 08:18 AM 9/19/2016 -0400, Kyle Hall wrote: >Thanks for the feedback Stefano! >Please, if anybody is *against* the use of React in Koha, please voice >your concerns! Question: what has Facebook added to js that we could not use as "regular" js? Not a show stopper, but our "gut feeling" (not fully documented, but more than anecdotal) is that all js code, given its standalone capability, has a more than proportional speed downside. And I'm not going near the licensing questions. If I understand this bug 17297 ("low enhancement") correctly, it refines itemnotes by adding granularity. If this is a "good thing", can the original coding be improved? Add an auth value? If we need js, how optional might this be? (do we know how many Koha users are truly interested?) I've always been impressed by Koha core speed, and without using such expressions as "mission creep" (or heaven forfend, code bloat) I truly recognize that enhancements are a real life necessity. Just wondering how and where they are best added while maintaining the KISS principle... Best -- Paul >Kyle > > > ><http://www.kylehall.info>http://www.kylehall.info >ByWater Solutions ( <http://bywatersolutions.com>http://bywatersolutions.com ) >Meadville Public Library ( ><http://www.meadvillelibrary.org>http://www.meadvillelibrary.org ) >Crawford County Federated Library System ( ><http://www.ccfls.org>http://www.ccfls.org ) > >On Fri, Sep 16, 2016 at 9:50 AM, Stefano Bargioni ><<mailto:bargioni@pusc.it>bargioni(a)pusc.it> wrote: >My +1 for React. Angular requires a specific skill, other than Javascript. >Stefano > >>On 15 set 2016, at 19:22, Kyle Hall >><<mailto:kyle.m.hall@gmail.com>kyle.m.hall(a)gmail.com> wrote: >> >>I have my proof of concept for usingÂ ReactÂ within Koha completed! You >>can see it here:Â >><https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297>https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 >> >>Please give it a try! >> >>So, I've written this development ( at least in part ) in both Angular >>andÂ React. I know Angular 2 is out but here are my thoughts so far. >> >>1) It's much easier to think inÂ ReactÂ than in Angular.Â ReactÂ is for >>the most part just Javascript. It's far less opinionated than Angular. >>They saying goesÂ ReactÂ is Javascript and Angular is Angular. I think >>the flexibility ofÂ ReactÂ works well within the Koha ecosystem. >> >>2) WritingÂ ReactÂ feels much more like programming. I think it's much >>faster to develop reactive and ajax features inÂ ReactÂ than it is using >>jQuery. >> >>3)Â ReactÂ makes it pretty easy to create widgets that we can drop in to >>a given page and have just work. Pretty much anything that shows up on >>multiple pages would make for a goodÂ ReactÂ widget. Think the holds >>table which is on the checkouts page and the patron details page. It is >>ajaxified now, but a far far cleaner version could be written inÂ React. >> >>4) React is just a view layer. Angular is a full MVC framework with many >>pieces we don't really need. >> >>I thinkÂ ReactÂ is probably the way to go for Koha. I like Angular but >>for Koha in particular, I thinkÂ ReactÂ is a better fit. I think we >>really need to get this decision made as soon as possible. If anyone has >>opinions, please let everyone know! >> >>Kyle >> >> >><http://www.kylehall.info/>http://www.kylehall.info >>ByWater Solutions ( >><http://bywatersolutions.com/>http://bywatersolutions.com ) >>Meadville Public Library ( >><http://www.meadvillelibrary.org/>http://www.meadvillelibrary.org ) >>Crawford County Federated Library System ( >><http://www.ccfls.org/>http://www.ccfls.org ) >>_______________________________________________ >>Koha-devel mailing list >><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>website : <http://www.koha-community.org/>http://www.koha-community.org/ >>git : <http://git.koha-community.org/>http://git.koha-community.org/ >>bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/ --- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>

6 15

Re: [Koha-devel] To React or not to React
by Paul A 21 Sep '16

21 Sep '16

At 08:34 AM 9/21/2016 -0600, Kyle Hall wrote: >Paul, that's not how it works. As I wrote earlier, if *I* sue Facebook I >could potentially lose my right to distribute software using React, but >you would be unaffected. Kyle -- not wanting to flog a dead horse (and as I wrote IANAL), but Koha is a prime example of open-source and has a track record of ensuring it remains so. Philosophically I like that. Practically, I run a charity (our members are the equity owners and I have no clue as to their love/hate relationship with Facebook) and would not want to take risks, nor have the budget to get a "legal opinion" (due diligence, and all that...) Best -- Paul >Kyle > > > ><http://www.kylehall.info>http://www.kylehall.info >ByWater Solutions ( <http://bywatersolutions.com>http://bywatersolutions.com ) >Meadville Public Library ( ><http://www.meadvillelibrary.org>http://www.meadvillelibrary.org ) >Crawford County Federated Library System ( ><http://www.ccfls.org>http://www.ccfls.org ) > >On Wed, Sep 21, 2016 at 8:30 AM, Paul A ><<mailto:paul.a@navalmarinearchive.com>paul.a(a)navalmarinearchive.com> wrote: >At 02:14 PM 9/21/2016 +0200, Mirko Tietgen wrote: >David Cook schrieb am 21.09.2016 > > The updated licence isnÃ¢t without controversy: > > > <<https://discuss.reactjs.org/t/legal-department-did-not-allow-use-of-react/3…>https://discuss.reactjs.org/t/legal-department-did-not-allow-use-of-react/3…> > > > https://discuss.reactjs.org/t/legal-department-did-not-allow-use-of-react/3… > > > > That said, I think the issue is that Facebook could revoke your > > licence to use React if you take legal action against Facebook. I > > donÃ¢t imagine the Koha community is going to do do that, so itÃ¢s > > > probably not a blocker. > >If you are right and that is the issue, does that mean Koha would >not be Free Software anymore unless everything React is reverted? > >That sounds like something I would not just push away with "i don't >imagine that happening", it sounds scary and not a way I want to go. > >I don't see how a license that can be revoked for whatever reasons >could work for us. > > >Agreed. But IANAL. However ISTR that are recent thread suggested "tens of >thousands" of potential libraries|users worldwide (based on downloads?) so >Murphy|Sod's Law will kick in sooner or later... > >Best -- P. > > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > --- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>

1 0

Authentication field on borrower.
by Rodrigo Santellan 21 Sep '16

21 Sep '16

Hi, I'm trying to figure out where the field authentication of the borrowers table is used? Regards.

3 3

[Koha::Object] Related records and calling methods from templates
by Marcel de Rooy 21 Sep '16

21 Sep '16

Hi devs, I am seeing more Koha objects that include methods for related records like Koha::Patron, sub image referring to Koha::Patron::Images. As a second example, on bug 14610 (article requests), a biblio, item, branch and borrower method is added to Koha::ArticleRequest. Obviously, they all follow the same pattern. Could we generalize that, and keep our code cleaner? And do we always need the full Koha object? For use in a template we may need only a few columns. We start passing these objects to the templates now too, making it possible to call methods from the template. It is possible, but do we really want that? More code ends up in the template, maybe harder to find since you now use borrower.method instead of borrower->method etc. Secondly, reading borrower.something might not immediately tell you that something is a method instead of a column. In other cases we have added a sort of wrapper like Branches.GetName from the Branches plugin. I am interested to know if we want to enforce this wrapper approach for instance, or just continue on the current road. Thx, Marcel

6 9

PDF::Reuse
by Christopher Nighswonger 16 Sep '16

16 Sep '16

Hi all, I'm working toward a release of PDF::Reuse. I've applied several patches submitted and uploaded a dev release to CPAN: http://search.cpan.org/~cnighs/PDF-Reuse-0.36/ There are a few more bugs on CPAN which I hope to get resolved in this release. If you know of anything that needs to be addressed, please let me know. If you have time to test, that would be greatly appreciated. I am especially concerned that nothing in this proposed release breaks features Koha is dependent upon. So testing there would be helpful as well. Kind regards, Chris

1 0

Where the field studentnumber of borrower is?
by Rodrigo Santellan 16 Sep '16

16 Sep '16

Hi, I'm migrating from Koha 2 to 3 and the field studentnumber of the table borrowers has gone? It should be now on a patron custom type? Regards and thanks for the help!

2 2

Custom authentication
by Rodrigo Santellan 15 Sep '16

15 Sep '16

Hi, I need to authenticate using a custom LDAP and a custom Web Service authentication how will be the best to implement this without forking the code. I ask this because I'm trying to migrate an old Koha 2.2.3 that has gone astray from the community and I don't want to start doing that again. What I plan to do is copy the Auth_with_ldap.pm to Auth_with_ldap_custom.pm and do my changes there. But I don't know if that is the really the best way to implement that or there is a place to put the custom authentication? Another question is about debugging, when maintaining the old one I use a lot: my $logger = C4::Context -> get_logger('C4::Auth'); and then log the data. (I'm a newbie in Perl and Koha) How can I achieve the same in the new one? I saw the Koha::Logger but is not the same. Regards! And thank for any help!

1 0