- Koha-devel - lists.koha-community.org

[NEW] What's on in Koha devel
by Jonathan Druart 09 Jun '16

09 Jun '16

Hi devs, First, sorry for the [NEW] flag, but it is to make sure everybody reading the ML will click :) I'd like to start a monthly "what's on" email which I will send to koha-devel. It comes after some discussions at the KohaCon16 with fellows that do not have the time to follow what's going on in the community and where they could help on important things. I used to send one to my partners every month to explain what I did and what I plan to do, but actually it sounds more a community report to send to the Koha developers. So here it is :) The goal is to resume in a (relatively) short email what has been developed in the previous month(s) and what testers/developers can focus on. It could be critical/major bugfixes, code refactoring/improvements or even big-but-amazing features waiting for signoff/QA. Over the last months I have mainly focused on refactoring stuffs, fix plack-related bugs and improvement issues, as well as my usual QA work. The refactoring part is not going very well, I have suspended it 2 months ago. The main problem is that the patches are no pushed as fast as I expected implying a lot of rebases which is time consuming. By refactoring I mean "moving code from old C4 modules to the new Koha namespace". The pattern I usually use in the bug report description is "Move the stuff related code to Koha::Stuff[s]" The plack-related bugs were minor, but to provide a full plack compatibility it was great to have them push quickly. Luckily they have been signed off and QAed quite quickly, only 2 are still waiting for QA. The pattern I used in the bug description was "This module is not plack safe". A few words about the performances: You have to know that since 16.05 (and maybe also 3.22) it's highly recommended to use Plack and Memcache to provide your user a good response time. We have profiled the code in several areas to find useless processing time. In some places, the code has been improved, in others it has completely been removed. Fixing plack bugs, we have found that we needed to improve our cache mechanism and we have introduced a L1 memory cache which should bring us performance gain between 3.22 and 16.05. Note that we do not have completely finished the work and some more has to been done, so stay tuned :) If you have any suggestions or leads on that, please open a bug report and assign it to me. There are 2 critical bugs waiting for signoff (bug 16554 and bug 16573), they fix the support of Ubuntu 16.04. So if you plan to install Koha on the latest Ubuntu, you should have a look at these 2 reports. A major enhancement is in the integration queue and it would be great to see some people (librarians would be awesome) involved in the testing process. It will allow a patron to place several holds on the same record (bug 14695). This feature has been expected for more than 3 years now and this is the third attempt. During the KohaCon16, I have organised a quick brainstorming about our implementation of Koha::Object[s] and how we use DBIx::Class. The goal was not to find a solution but to present the different issues we face. I'd like to bring again this discussion on koha-devel this month, listing the pros and cons of our current implementation, and gathering ideas to improve it. Hope this will be helpful for people not heavily involved on IRC or the bug tracker. Cheers, Jonathan References: Refactoring to Signoff Bug 15758 - Move the C4::Branch related code to Koha::Libraries - part 4 Bug 15803 - Koha::AuthorisedValues - Remove GetAuthorisedValueCategories Refactoring to QA Bug 15451 - Move the CSV related code to Koha::CsvProfile[s] Bug 15839 - Move the reviews related code to Koha::Reviews Bug 15801 - Move the framework related code to Koha::BiblioFramework[s] - part 2 Bug 15407 - Move the patron categories related code to Koha::Patron::Categories - part 2 Plack bugfixes to QA Bug 16441 - C4::Letters::getletter is not plack safe Bug 16443 - C4::Members::Statistics is not plack safe Performances entry points are (look at the related bugs using the show dependency graph): Bug 15342 - Performance 3.22 - Omnibus Bug 16044 - Define a L1 cache for all objects set in cache

4 3

KohaDevBox + MariaDB
by Tomas Cohen Arazi 07 Jun '16

07 Jun '16

Hi everyone, I wanted to share that we can now choose mariadb in KohaDevBox by setting mysql_engine: mariadb in the vars/user.yml file. Enjoy. -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

2 3

SQL92 keywords and naming columns
by David Cook 31 May '16

31 May '16

I was wondering if we have any advice for naming columns, especially TIMESTAMP columns, so I looked on the wiki and found that we're not supposed to use SQL92 keywords: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL2:_SQL92_keywords I'm not super familiar with all the keywords, but I'm confident that "timestamp" is one of those keywords. Here's the distribution on a dev Koha I have: 'created', 1 'created_on', 2 'date', 1 'dateadded', 1 'date_uploaded', 2 'dtcreated', 1 'lastmodified', 1 'message_date', 1 'modification_time', 1 'needed', 1 'time', 2 'timestamp', 26 'time_queued', 1 'updated', 1 'upload_timestamp', 2 'validated', 1 'valid_until', 1 I thought I'd check out DATETIME as well. Interestingly, there is a DATETIME column named "timestamp" as well: 'datearrived', 1 'datereviewed', 1 'datesent', 1 'datetime', 1 'date_approved', 1 'date_created', 3 'date_due', 2 'date_modified', 1 'date_run', 1 'issuedate', 2 'itemlost_on', 2 'lastreneweddate', 2 'last_modified', 1 'last_run', 1 'returndate', 2 'sharedate', 1 'start_time', 1 'suspend_until', 2 'timeclicked', 1 'timestamp', 1 'withdrawn_on', 2 It seems undesirable to use timestamp for things like "upload_timestamp" and "message_date" as well, as TIMESTAMP will automatically update when that row is updated as per these conditions: http://dev.mysql.com/doc/refman/5.7/en/timestamp-initialization.html. Anyway, something to think about. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Office: 02 9212 0899 Direct: 02 8005 0595

2 1

More problems with MySQL 5.7
by Bernardo Gonzalez Kriegel 30 May '16

30 May '16

Hi, testing things on MySQL 5.7 - Koha 3.22, found a new problem: memberentry.pl: DBD::mysql::st execute failed: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'kohadev.categories.categorycode' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by ... This comes trying to add a patron after fresh install, 3.22+marc21+all sample data Can we change sql_mode for Koha? Regards Bernardo -- Bernardo Gonzalez Kriegel bgkriegel(a)gmail.com

5 4

Koha Community Newsletter: May 2016
by kohanews 28 May '16

28 May '16

Fellow Koha users: The Koha Community Newsletter for May 2016 is here: https://koha-community.org/koha-community-newsletter-may-2016/ Many thanks to the folks who submitted articles and news to this month's newsletter. Please feel free to email me with any corrections or suggestions. Thanks! -- Chad Roseburg Editor, Koha Community Newsletter

1 0

POC of a new plugin system
by Julian Maurice 27 May '16

27 May '16

Hi all, A couple of months ago, we talked about how great it would be to have a more powerful plugin system (thread subject was "Country-specific forks" [1]). The current implementation have some problems. For instance, it's not possible to properly manage plugins with a VCS (bug 15879 [2] try to address this issue) Alex and I have started to write a new plugin system, as an attempt to fix the problems of the current implementation. It's still in a very "alpha" status, but we would like to hear what you think of it. Code is in BibLibre repository, branch koha-module-poc: http://git.biblibre.com/biblibre/kohac.git Features: * VCS-compatible (every directory under the modules directory and containing a module.yaml file is a module) * Allow modules to define custom "URL routes" (see module/router.pl) * Allow modules to modify the intranet top menu (so they can add a link to their custom routes) * Allow modules to have their own TT include files and TT plugins A sample module was made to demonstrate these features: http://git.biblibre.com/biblibre/koha-module-LoremIpsum.git This module creates a new page which display some "lorem ipsum" text fetched from loripsum.net, and add a link to this page in the intranet top menu. Very basic but it shows how it works. Quick start: 1. git remote add biblibre http://git.biblibre.com/biblibre/kohac.git 2. git checkout -b koha-module-poc biblibre/koha-module-poc 3. installer/data/mysql/updatedatabase.pl 4. misc/devel/update_dbix_class_files.pl 5. mkdir /path/to/modules 6. Edit $KOHA_CONF and add a line <modules_dir>/path/to/modules</modules_dir> 7. cd /path/to/modules && git clone http://git.biblibre.com/biblibre/koha-module-LoremIpsum.git LoremIpsum (note: the directory's name is important) 8. Go to Administration > Modules 9. Enable the module LoremIpsum 10. You should now see a new link in the top menu Final note: we would like to work on it during the hackfest in Thessaloniki, so if you are interested, let us know! [1] http://lists.koha-community.org/pipermail/koha-devel/2016-February/042382.h… [2] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 -- Julian Maurice <julian.maurice(a)biblibre.com> BibLibre

4 5

16.05.00-beta tagged
by Brendan Gallagher 26 May '16

26 May '16

Hi All - I have tagged a beta release of 16.05. (I did not include the release notes yet - I have run them and they look pretty clean - so yay!). I have also generated a tarball but I need access to the downloads - I am in the process of getting that worked out). The plan is that on Friday - I'll roll a RC1. I will be releasing on May 26th. (If you see something that I have missed - please don't hesitate to talk to me) Thanks, Brendan -- --------------------------------------------------------------------------------------------------------------- Brendan A. Gallagher ByWater Solutions CEO Support and Consulting for Open Source Software Installation, Data Migration, Training, Customization, Hosting and Complete Support Packages Headquarters: Santa Barbara, CA - Office: Redding, CT Phone # (888) 900-8944 http://bywatersolutions.com info(a)bywatersolutions.com

3 4

Slow Searching
by Barry Cannon 23 May '16

23 May '16

Hi, I have noticed some slow opac/intranet searching on sites and I can't seem to pinpoint the problem. The "opac-search.pl", takes between 5500ms and 7500ms for any search term - the hit count can be 10 or 16000, the search time is comparable. Running the same search, directly via the yaz-client, returns the hit count (and record dump) almost instantly. The sites are plack enabled, running Koha 3.22.06 and memcache is also configured. The zebra-out.log shows lines similar to below (which appear to be innocuous): 15:38:02-16/05 zebrasrv(1) [warn] ir_session (exception) 15:47:14-16/05 zebrasrv(2) [warn] ir_session (exception) 15:57:15-16/05 zebrasrv(3) [warn] ir_session (exception) 16:03:22-16/05 zebrasrv(4) [warn] ir_session (exception) 16:04:15-16/05 zebrasrv(5) [warn] ir_session (exception) The only other log of interest is the opac-error.log but this just displays some equally innocuous errors. On one system there are just under 100k biblios. It is a relatively small system but just to be certain I spun up a test box and assigned it 16GB RAM and 8 CPUs, SSDs for storage. I left the sysprefs as vanilla. I noticed no difference in the response time(s). The majority of sites are running Jessie. I have netdata running on the boxes and there is never any load on any resource - no slow MySQL queries either. I also tested some of the demo Koha sites, from the community site, and while they're are not as slow, they certainly appear to be slow(ish). Would anyone have any ideas on what I might have overlooked? Could this just be a perception issue (although most of the clients have raised issues). Thanks Regards Barry Cannon Interleaf Technology http://www.interleaf.ie Tel: +35312865855 Email: bc(a)interleaf.ie Skype: bar.cannon

3 3

Re: [Koha-devel] 16.05.00-beta tagged
by Paul A 20 May '16

20 May '16

At 10:04 AM 5/17/2016 -0700, Brendan Gallagher wrote: >Hi All - > >I have tagged a beta release of 16.05. I've been a bit busy lately (in part getting Koha transitioned to Ubuntu 16.04LTS), so apologize if this is a simple question : but what is version 16.05? Looked at the Wiki <https://wiki.koha-community.org/wiki/Category:Koha_Versions> which seems to stop at 3.16 -- which can't be right (or where do versions .18 - .24 fit in?) Then I found a reference to "Koha 16.05 (formerly 3.24)" -- and don't remember seeing anything about a new version numbering system. Is it written up anywhere, please? Best -- Paul >Â (I did not include the release notes yet - I have run them and they >look pretty clean - so yay!).Â I have also generated a tarball but I need >access to the downloads - I am in the process of getting that worked out). > >The plan is that on Friday - I'll roll a RC1. > >I will be releasing on May 26th. > >(If you see something that I have missed - please don't hesitate to talk >to me) > >Thanks, >Brendan > >-- >--------------------------------------------------------------------------------------------------------------- >Brendan A. Gallagher >ByWater Solutions >CEO > >Support and Consulting for Open Source Software >Installation, Data Migration, Training, Customization, Hosting >and Complete Support Packages >Headquarters: Santa Barbara, CA - Office: Redding, CT >Phone # (888) 900-8944 ><http://bywatersolutions.com>http://bywatersolutions.com ><mailto:info@bywatersolutions.com>info(a)bywatersolutions.com >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/ --- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>

2 1

Adding a dependency to Koha
by David Cook 20 May '16

20 May '16

Hi Galen (and everyone else), How does one go about adding a dependency to Koha? With https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662, I'm re-introducing a dependency on POE. Does that mean we should revert "Bug 11756: remove dependency on POE" (b67dac81cceaab356486001292cff40977682fff)? Or just simply add the dependency back into C4/Installer/PerlDependencies.pm? In that previous commit, I notice that all the "INSTALL.*" files and "install_misc/*packages" files were updated, but how much of that is necessary? Should we even retain the "INSTALL.*" files anymore? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Office: 02 9212 0899 Direct: 02 8005 0595

2 1