- Koha-devel - lists.koha-community.org

Splitting bugs into multiple patches
by Holger Meissner 23 Jan '14

23 Jan '14

Dear Koha devs, Another question. Is there any rule of thumb into how many parts a bug should be split? For example, if I add a few lines in a perl module, modify two intranet HTML templates and an OPAC HTML template. Should this be divided into three commits? Or just one, since you can't easily test the perl module without the templates? Or one part for the pm and intranet changes and another for the OPAC changes? Thank you! Holger

2 1

opac-user.tt
by Holger Meissner 23 Jan '14

23 Jan '14

Dear Koha devs, I'm working on Bug 7413 and one thing I want to do is modify opac-user.tt. I noticed that there are two versions of it: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt The later doesn't seem to be used, at least by my install. Do I need to modify both, or just bootstrap? Is there a way to switch bootstrap off, so that I can test changes in the other one? Thanks Holger

3 2

Duplicating Records = Replacing Records?
by Andrea Furin 22 Jan '14

22 Jan '14

Hi. When I try to duplicate a record, koha overwrites the old one: searching for that title (opac and biblio) returns only the last modified record - with duble koha id. Some solutions? One is to delete fields: 000@ 001@ 005@ 100a --

1 0

Advice on syncing and DBIC
by Magnus Enger 21 Jan '14

21 Jan '14

Hi! I am working on Bug 11401 - Add support for Norwegian national library card: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 The goal is to sync patrons in Koha back and forth to the Norwegian national patron database. In order to do this I need to keep track of - which patrons should be synced (they can choose to opt out of the syncing) - a sync status, to see which patrons are new, which have been changed and which are already synced - the date of the last sync I am a bit undecided about whether I should use extended patron attributes for this, or add columns to the "borrowers" table. Some pros and cons: - Attributes are less intrusive, they only need to be added to systems that want to sync with the Norwegian national patron database. - New columns could be re-used by others, to implement other syncing schemes, and they are easier to work with, as far as I can see. I am currently leaning towards adding columns. Now the thing is that I want to change the "syncstatus" every time AddMember or ModMember is called, so I want to add some logic to these subroutines, perhaps like this ("..." indicates lines that have been edited out for clarity): use Koha::Database; ... sub AddMember { my (%data) = @_; ... $data{'borrowernumber'}=InsertInTable("borrowers",\%data); # If NorwegianPatronDBEnable is enabled, we set the nllastsync attribute to something that a # cronjob will use for syncing with NL if ( C4::Context->preference('NorwegianPatronDBEnable') == 1 ) { my $borrower = Koha::Database->new->schema->resultset('Borrower')->find( $data{'borrowernumber'} ); $borrower->update( { 'syncstatus' => 'new' } ); } ... } Would that be an OK way to do it? Or is mixing in DBIC in existing subroutines like this frowned upon? Would it be cleaner to add a module like Koha::Borrower::Sync (that could be re-used by other syncing schemes), with methods like SetBorrowerSyncstatus( $patronnumber, $value ) that would then look something like this: use Koha::Database; sub SetBorrowerSyncstatus { my ( $borrowernumber, $value ) = @_; my $borrower = Koha::Database->new->schema->resultset('Borrower')->find( $borrowernumber ); $borrower->update( { 'syncstatus' => 'new' } ); } Any advice on this would be much appreciated! Best regards, Magnus

3 2

SQL Query : multiple items
by Paul A 21 Jan '14

21 Jan '14

I'm going round in circles for what I thought would be easy, and will kick myself later. Trying to write a "report" that will give me all biblios with more than 1 item: SELECT biblionumber, CONCAT('<a href=\"/cgi-bin/koha/catalogue/detail.pl?biblionumber=',biblionumber,'\">',title,'</a>') AS Title, author AS Author FROM biblio b LEFT JOIN items i USING (biblionumber) GROUP BY i.ccode HAVING COUNT(i.itemnumber)>1; works syntactically, but certainly does not give me the right answers -- it produces biblios with 0, 1, 2, etc items, and only 83 total lines when I know that there are thousands... Logic seems to have deserted me. Help please? As a bonus, I'd appreciate how to add the items.ccode into the report. Adding SELECT ccode FROM items either before or after the JOIN fails. Thanks and br -- Paul

3 3

Suggestion for OPAC theme bug fix patches
by Galen Charlton 21 Jan '14

21 Jan '14

Hi, If you're writing a patch that fixes a bug with an OPAC template file, you'll need to at least touch the Bootstrap theme, but you may also want to touch the prog theme if you think the fix should be backported back to 3.12.x or earlier. Here's my suggestion: if you do that, please put your prog and Bootstrap template changes in separate patches. That way, it will be easier for the RMaints for 3.12.x, 3.10.x, and 3.8.x to cherry-pick the appropriate patches without having to manually disentangle out the Bootstrap theme bits that don't apply. This, in turn, will likely increase the chance of your bugfix being backported. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc(a)esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org

3 2

Re: [Koha-devel] Adding Wysiwyg to (HTML) System Preferences
by David Cook 20 Jan '14

20 Jan '14

Great idea, Eric! I've opened bug 11584 for the system preferences and bug 11583 for the notices/letters. At the moment, we're using TinyMCE in other parts of Koha, so I figure it's useful to provide a consistent HTML editor across the board. Martin, I do like the idea of syntax highlighting, indenting, and linting though! MJ: As far as I know, it shouldn't have any problem preserving any hand-coded HTML, but I'll keep that in mind. Perhaps I'll write some bad HTML and see what it does with that. I'm glad to hear positive support! I'll get working on this right away. -David -----Original Message----- Date: Fri, 17 Jan 2014 06:26:15 -0500 From: Eric B?gin <eric.begin(a)inLibro.com> To: Martin Renvoize <martin.renvoize(a)ptfs-europe.com>, Koha Devel <koha-devel(a)lists.koha-community.org> Subject: Re: [Koha-devel] Adding Wysiwyg to (HTML) System Preferences Message-ID: <52D91357.1050301(a)inLibro.com> Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" I'm thinking about this type of addition for a long time so I'm all for it ! Couldn't we also use a WYSIWYG for editing notifications (when HTML is selected). Cheers, Eric B?gin Solutions inLibro inc. On 2014-01-17 06:14, Martin Renvoize wrote: > I've been thinking of doing something like this for some time, so > would love to see it happen. (and I'm sure our customers would love it) > > I was of two minds whether to implement TinyMCE as wysiwyg, or one of > the code editors out there to do syntax highlighting, indenting and > linting for all code type blocks (css, html, yaml etc), but I think > for your average user the wysiwyg approach is the right one. > > Would be happy to test a patch. > > Martin > > Martin Renvoize > Software Engineer, PTFS Europe Ltd > Content Management and Library Solutions > Skype: > Landline: 0203 286 8685 > Mobile: 07725985636 > > http://www.ptfs-europe.com > > > On 17 January 2014 11:04, MJ Ray <mjr(a)phonecoop.coop > <mailto:mjr@phonecoop.coop>> wrote: > > David Cook wrote: > > What would folks think about adding the tinymce wysiwyg to some > of the > > system preferences that deal with HTML? > > I think it would probably be a useful feature to many libraries and > tinymce seems like the best of the current rather weak bunch. > > A system preference to control it seems like a good thing. > > If you can make tinymce abort if it finds handcoded html that it can't > preserve (I don't know if this is possible), then that would be great. > > Hope that helps, > -- > MJ Ray (slef), member of www.software.coop > <http://www.software.coop>, a for-more-than-profit co-op > http://koha-community.org supporter, web and library systems > developer. > In My Opinion Only: see http://mjr.towers.org.uk/email.html > Available for hire (including development) at > http://www.software.coop/ > _______________________________________________ > Koha-devel mailing list > Koha-devel(a)lists.koha-community.org > <mailto:Koha-devel@lists.koha-community.org> > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ > > > > > _______________________________________________ > Koha-devel mailing list > Koha-devel(a)lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ ******************************************

2 2

Z39.50 searching by Publisher
by Andrea Furin 20 Jan '14

20 Jan '14

Is it possible to make a searching in Z39.50 mask also by publisher? in file z3950_search.tt I've add a: <li><label for="biblioitems.publishercode">Publisher: </label> <input type="text" id="biblioitems.publishercode" name="biblioitems.publishercode" value="[% biblioitems.publishercode %]" /></li> so the z39.50 mask has a new field, but the results mask doesn't filter with it --

1 0

Hackfest in Marseille, 2014
by Paul Poulain 20 Jan '14

20 Jan '14

Hello Koha & koha-devel mailing lists. I'm happy and proud to announce the 2014 edition of "hackfest in Marseille": http://www.biblibre.com/en/blog/hackfest-marseille-2014 ! Registrations are now open ! just drop me an email ! ( already 12 registrations -not including BibLibre staff- ) -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper

1 0

Re: [Koha-devel] Automatic renewal feature
by Holger Meissner 20 Jan '14

20 Jan '14

Galen Charlton wrote: > Yes. Here is how I suggest doing it: > > - add an auto_renew flag to both issuingrules and issues > - when a loan is made, issues.auto_renew is set to the value of issuingrules.auto_renew > from the loan rule that was applied. > - the cronjob checks issues.auto_renew -- in other words, it doesn't go back and check > issuingrules again, it just goes by the value set on the loan itself. Very well. Additionally I suppose to add norenewalbefore to issuingrules. I'm not sure what it should be called? It's about when to renew, X days or hours before due date. This would be checked by CanBookBeRenewed and could be used to control the cronjob as well as solve bug 7413. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 May I assign 7413 to myself, or just write a patch without assignment? Updated the RFC: http://wiki.koha-community.org/wiki/Automatic_renewal_RFC Regards Holger

2 1