- Koha-devel - lists.koha-community.org

Signoff please
by Marcel de Rooy 14 Jul '23

14 Jul '23

Hi, My patches below are waiting since May in the NSO queue. Could you have a look plese? Checked if they still apply just yet. 33837 Koha Architec m.de.rooy(a)rijksmuseum.nl Need --- enh Objects->filter_by_last_update: Does not allow time comparison 2023-05-26 33843 Koha Architec m.de.rooy(a)rijksmuseum.nl Need --- enh Use filter_by_last_update in Koha::Notice::Util 2023-05-26 33245 Koha Architec m.de.rooy(a)rijksmuseum.nl Need --- enh Add $patron->is_active 2023-05-30 33869 Koha Test Sui m.de.rooy(a)rijksmuseum.nl Need --- enh Move Matcher.t to db_dependent 2023-05-31 33870 Koha Test Sui m.de.rooy(a)rijksmuseum.nl Need --- enh Remove T::D::C from Sitemapper.t 2023-05-31 33871 Koha Command- m.de.rooy(a)rijksmuseum.nl Need --- enh Add where parameter to sitemap.pl 2023-05-31 Thanks ! Marcel

1 0

Tidy your code! And run the QA script!
by Tomas Cohen Arazi 14 Jul '23

14 Jul '23

Hi all. I've been trying to push as much as I can from the PQA queue, and I'm finding that most of the patches haven't been tidied up yet or have trivially caught issues (maybe not most, but a lot). For example, this is what I find when I run an up to date KTD and the code is not tidy: ``` kohadev-koha@kohadevbox:koha(master)$ qa -c 1 --run-tests testing 1 commit(s) (applied to e0df163 'fcf Bug 33933: Only show use restrict') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) WARN Koha/Recalls.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 41, now: 42) WARN t/db_dependent/Koha/Recalls.t WARN tidiness The file is less tidy than before (bad/messy lines before: 100, now: 101) Processing additional checks OK! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Recalls.t OK! ``` This is probably because they were submitted *before* we decided to enforce it on the QA tools, and it is understandable that, in some cases, it was not caught by a not-up-to-date QA command. As all testers and QA team members are encouraged to run the `qa` script before signing patches, I assume the underlying problem is that their KTD images are old and don't contain the latest QA tools version. So please make sure your KTD images or qa-test-tools clone is up to date. And run the tool, all the time! So, to sumarize: - Patch authors need to tidy the new blocks of code they introduce, or modify. - Instructions on setting perltidy on your favourite editor can be found on the wiki [1]. If your editor is missing, ask for help on IRC, the mailing list, or just use one from the documented ones. - QA members need to run the QA scripts. - You need to build the habit of pulling the latest KTD images every now and then. In case important things changed. And also run `docker system prune -a` (while KTD is running, so only the old images are cleared) - The RM will start failing patches that the QA script says have issues. Both authors and testers have the ability to run the script before submission. Every extra minute it takes to be gentle and fix the patch inline makes us have less time to push your next stuff! If you read all this, thank you! You are awesome! And I'm really glad to be working on this side-by-side with you! And I hope to share some beers and cookies in Helsinki soon! Cheers! [1] https://wiki.koha-community.org/wiki/Perltidy -- Tomás Cohen Arazi Theke Solutions (https://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F

2 1

Perl 5.38 released
by David Cook 11 Jul '23

11 Jul '23

Hi all, I don't know about you, but I don't follow Perl development super closely. But something Kyle said on Bugzilla about function decorators got me thinking about Ovid's work on Corinna, which led me to https://ovid.github.io/blog/politics-in-programming.html and then https://perldoc.perl.org/5.38.0/perldelta. It looks like 5.38 has an experimental "class" feature for defining Perl classes in a new (more common) way. Obviously we're not going to use experimental features, but it's interesting to see the direction Perl is heading. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

2 1

Faster database update checks
by David Cook 04 Jul '23

04 Jul '23

Hi all, I just wanted to bring people's attention to my bug "Bug 34088 - Schema upgrade should short circuit faster if no upgrade needs to be done". It can check if Koha needs a database update in a fraction of the time of the current code. When you have a lot of Koha databases, processing database updates (especially when there is no update to do!) takes a long time. But you can check 60 databases in about 3.5 seconds with my patch (instead of over 60 seconds). This should speed up deployments. -- On a side note, I think that having #DEBHELPER# *before* koha-upgrade-schema means that Koha is started up *before* the database is upgraded. I'd have to double-check that, but it could lead to buggy behaviour. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

1 0

Problems with pbuilder and gitlab runner
by Aleisha Amohia 30 Jun '23

30 Jun '23

Hello everyone We're having a problem with pbuilder and I wonder if anyone is experiencing the same thing, or if we're misunderstanding how this is supposed to work. We have pbuilder set up on a test server, and we've run all these commands: https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Wa… Then we set off a pipeline in Gitlab, which essentially just runs ./debian/build-git-snapshot to build our Koha package. We've noticed that we are being required to log into pbuilder and run those commands from the wiki page before every package build/pipeline. Is that expected? We would've thought that the commands only have to be run once and the environment is then saved in base.tgz and used. Has anyone else experienced this and know how to fix? -- *Aleisha Amohia (she/her)* Koha Technical Lead *Catalyst.Net Limited - Expert Open Source Solutions* *Catalyst.Net Ltd - a Catalyst IT group company* Tel: +64 4 499 2267 | www.catalyst.net.nz <http://www.catalyst.net.nz> Catalyst Logo CONFIDENTIALITY NOTICE: This email is intended for the named recipients only. It may contain privileged, confidential or copyright information. If you are not the named recipient, any use, reliance upon, disclosure or copying of this email or its attachments is unauthorised. If you have received this email in error, please reply via email or call +64 4 499 2267.

1 0

Koha Community Newsletter: June 2023
by Koha Newsletter 29 Jun '23

29 Jun '23

The Koha Community Newsletter for June 2023 is here: https://koha-community.org/koha-community-newsletter-june-2023/ Many thanks to everyone who submitted articles and news to this newsletter! Please feel free to email me with any corrections or suggestions. -- Michael Kuhn Editor, Koha Community Newsletter

1 0

Koha 23.05.01 released
by Fridolin SOMERS 28 Jun '23

28 Jun '23

Hello everyone 🤗 The Koha community is proud to announce the release of Koha 23.05.01. It is a bugfix/maintenance release including 6 enhancements, 35 bugfixes. The full release notes are available here: https://koha-community.org/koha-23-05-01-released/ Debian packages should be available soon 🎁 With a great pleasure I will be the 23.05 cooking chef this 6 months meal. Best regards 🤓 -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> Software and system maintainer 🦄 BibLibre, France

1 0

Koha 22.11.07 released
by Amorim, Pedro 26 Jun '23

26 Jun '23

The Koha community is proud to announce the release of Koha 22.11.07. Koha 22.11.07 is a bugfix/maintenance release. It includes 5 enhancements, 77 bugfixes. The full release notes are available here: https://koha-community.org/koha-22-11-07-released/ Debian packages should be available soon (Apologies for the previous announcement e-mail containing a link error! First release as release maintainer and whatnot!) Best regards Pedro Amorim Software Engineer E: pedro.amorim(a)ptfs-europe.com www.ptfs-europe.com

1 0

Koha 22.11.07 released
by Amorim, Pedro 26 Jun '23

26 Jun '23

The Koha community is proud to announce the release of Koha 22.11.07. Koha 22.11.07 is a bugfix/maintenance release. It includes 5 enhancements, 77 bugfixes. The full release notes are available here: https://koha-community.org/koha-23-05-released/ Debian packages should be available soon Best regards Pedro Amorim Software Engineer E: pedro.amorim(a)ptfs-europe.com www.ptfs-europe.com

1 0

Dockerized Koha
by David Cook 22 Jun '23

22 Jun '23

Hi all, I've noticed a few people asking about Koha in Docker in production lately. Do we have any appetite for starting to create a production-ready Dockerized Koha? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

3 4