- Koha-devel - lists.koha-community.org

Feature freeze nearly upon us
by Galen Charlton 04 Oct '13

04 Oct '13

Hi, I have marked the enhancement and new feature freeze bugs that have either passed QA or are on my exception list with the keyword rel_3_14_candidates. You can view the list here: http://bugs.koha-community.org/bugzilla3/buglist.cgi?keywords=rel_3_14_cand… Tomorrow morning I'll mark any that may have passed QA in the next four hours since the writing of this email. I'll be doing a lot of merging over the next few days, and aim to cut an alpha tarball towards the end of next week, with a beta tarball to follow some time during KohaCon. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc(a)esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org

1 0

General questions from a first-patcher
by Philippe Blouin 03 Oct '13

03 Oct '13

Holà Koha! First to present myself, I'm a new developper on Koha. I work for inLibro, which has been a Koha proponent for a while now. All our changes, enhancements and bug fixes have been local so far, meaning we patched for each library as they needed. We got a bundle of those to contribute to the community. Fixes and enhancements. To get the hang of it, I started with three small ones (after dutifully reading the wiki, blog and asking irc questions), but I'm sure I screwed up a few things. I will appreciate _any_ and _every_ constructive comments you can make on the following: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Questions: - I work with patches. I used git-bz for one, and manual for the others. Now how to I email to patch mailing list? I just copy the content? I comment it? Do I add the [PATCH] in the header or some tool could have done all that for me? (my server can't send email, so I'm not sure if git-bz should have done it) - My local branch names are bug_XXXX from the master. But I'm not sure if that must be commited. Some wiki (contribute!) only talks about sending a patch. Others (http://wiki.koha-community.org/wiki/Commit_messages) talk about it. Can you enlighten me? Long text for two questions. Sorry. But I need that clarified before I start piling up fixes :) Very best regards, Blou -- Philippe Blouin, Responsable du développement informatique Tél. : (888) 604-2627 philippe.blouin(a)inLibro.com <mailto:philippe.blouin@inLibro.com> inLibro | pour esprit libre | www.inLibro.com <http://www.inLibro.com>

5 13

Bug (or something) repeatedly loading the same URL over and over.
by Robin Sheat 03 Oct '13

03 Oct '13

I just saw a thing that I've seen a few times before, and have heard anecdotally that others have too. The problem is that something hits the same URL over and over, eventually knocking over the server. I have some theories, but they're hard to test because this is a rare thing to happen, so I want to see if anyone else has seen something like this. It seems like some kind of search complete or similar running, however CircAutocompl is off. This is a 3.6 machine, though I think I've also seen it on 3.8. Haven't had anything higher running in prod long enough to tell. The log is below. I've reordered it to be when the request is issued rather than when it finishes to make it clearer, and added my speculation in. This is a real request by a human to view details. 172.20.2.200 - - [27/Sep/2013:13:29:01 +1200] "GET /cgi-bin/koha/members/moremember.pl?borrowernumber=16653 HTTP/1.1" 200 7202 This is some kind of automatic process that autocompletes, or something, that's going out of control. There's more of them, but you get the drift: 172.20.2.200 - - [27/Sep/2013:13:29:06 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:09 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:07 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:09 +1200] "POST /cgi-bin/koha/members/member.pl HTTP/1.1" 504 270 I don't know what this is or what it's doing here: 172.20.2.200 - - [27/Sep/2013:13:29:11 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:18 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:10 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:12 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:10 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:13 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:11 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:11 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:12 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:13 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:12 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:17 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 172.20.2.200 - - [27/Sep/2013:13:29:16 +1200] "GET /cgi-bin/koha/circ/circulation.pl?borrowernumber=16653 HTTP/1.1" 504 270 It just keeps going like this until I stop apache, and when I start it up again, this doesn't immediately recur. My theory is that there's some javascript somewhere that just loses it and goes mad, but I don't know. Any ideas? This only comes up once every few months, but when it does, it can take the server down. -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF

4 7

September 2013 Koha Community Newsletter has been published
by Daniel Grobani 30 Sep '13

30 Sep '13

Hi, The September 2013 edition of the Koha Community Newsletter has been posted to http://koha-community.org/koha-community-newsletter-september-2013/. Cheers, Daniel Grobani Koha Community Newsletter Editor

1 0

Module MARC::Record doesn't set well lenght in leader.
by Zeno Tajoli 30 Sep '13

30 Sep '13

Hi to all, [sorry the previous mail is incomplete] I have a problem with creating marc21 records with module MARC::Record I create marc records from reading a text file, but the module doesn't set a correct lenght in the leader. So same subfields are cutted and I loose data inside subfiels and inside indicator. An example of problematic record: DB<10> x $record 0 MARC::Record=HASH(0x53904f8) '_fields' => ARRAY(0x5471fa8) 0 MARC::Field=HASH(0x54694b8) '_data' => 328 '_is_control_field' => 1 '_tag' => 001 '_warnings' => ARRAY(0x53bb8d8) empty array 1 MARC::Field=HASH(0x545ea10) '_data' => 'IT-RoAPU' '_is_control_field' => 1 '_tag' => 003 '_warnings' => ARRAY(0x545df00) empty array 2 MARC::Field=HASH(0x5460d78) '_data' => 20130929162908.0 '_is_control_field' => 1 '_tag' => 005 '_warnings' => ARRAY(0x592ee28) empty array [...] 15 MARC::Field=HASH(0x546b1a8) '_ind1' => 0 '_ind2' => 0 '_is_control_field' => 0 '_subfields' => ARRAY(0x541c940) 0 'a' 1 'Biblia.' 2 'p' 3 'V.T.' 4 'p' 5 'Qohélet' 6 'x' 7 'Commenti.' 8 9 9 171552 '_tag' => 630 '_warnings' => ARRAY(0x5465538) empty array 16 MARC::Field=HASH(0x5465a18) '_ind1' => ' ' '_ind2' => ' ' '_is_control_field' => 0 '_subfields' => ARRAY(0x5466cd0) 0 'a' 1 'Biblia.' 2 'p' 3 'V.T.' 4 'p' 5 'Qohélet.' 6 'l' 7 'Inglese.' 8 'f' 9 1988. 10 9 11 17155 '_tag' => 240 '_warnings' => ARRAY(0x5477168) empty array 17 MARC::Field=HASH(0x5462fa8) '_ind1' => ' ' '_ind2' => ' ' '_is_control_field' => 0 '_subfields' => ARRAY(0x541eb38) 0 'a' 1 'IT-RoAP' '_tag' => 850 '_warnings' => ARRAY(0x5931948) empty array 18 MARC::Field=HASH(0x5469788) '_ind1' => ' ' '_ind2' => ' ' '_is_control_field' => 0 '_subfields' => ARRAY(0x5472170) 0 'c' 1 32 '_tag' => 999 '_warnings' => ARRAY(0x54693f8) empty array '_leader' => '00859nam a2200265 i 4500' '_warnings' => ARRAY(0x53682b0) 0 'Invalid record length in record 324: Leader says 00859 bytes but it\'s actually 861' 1 'field does not end in end of field character in tag 630 in record 324' 2 'field does not end in end of field character in tag 240 in record 324' 3 "Invalid indicators \"\c^02\" forced to blanks in record 324 for tag 240\cJ" 4 'field does not end in end of field character in tag 850 in record 324' 5 "Invalid indicators \"3\c^ \" forced to blanks in record 324 for tag 850\cJ" 6 'field does not end in end of field character in tag 999 in record 324' 7 "Invalid indicators \"U\c^ \" forced to blanks in record 324 for tag 999\cJ" In fact indicator of tag 240 are wrong (the correct values are '02'); the real value of 240 $9 is '171553', not '17155'. The real value of 850 $a is 'IT-RoAPU', not 'IT-RoAP' The real value of 999 $c is '328', not '32' As I see the problem start for word 'Qohélet' in the tag 240 and 630. I don't know why the leght is wrong and I don't have idea how to fix it. Chees Zeno Tajoli -- Dr. Zeno Tajoli Dipartimento Gestione delle Informazioni e della Conoscenza z.tajoli(a)cineca.it fax +39 02 2135520 CINECA - Sede operativa di Segrate

4 5

Critical LDAP issue in 3.12/master
by Robin Sheat 30 Sep '13

30 Sep '13

There's a nasty bug in 3.12 that will break LDAP connections in some configurations, particularly when talking to active directory. There is a fix at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 however it needs signoff. So if you're using LDAP, auth_by_bind, and don't have an anonymous user with access to search your user database (which I get the impression is a fairly standard scenario), please have a look at this and sign it off, as I'd like to get it into a release Real Soon Now. Thanks! (PS, unrelated, I'm using a new GPG key. So if you use that, you should probably fetch this one: F8713BDF.) -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF

1 0

Module MARC::Record doesn't set well lenght in leader.
by Zeno Tajoli 29 Sep '13

29 Sep '13

Hi to all, I have a problem with creating marc21 records with module MARC::Record I create marc records from reading a text file, but the module doesn't set a correct lenght in the leader. So same subfields are cutted and I loose data inside subfiels and inside indicator. An example of problematic record: DB<10> x $record 0 MARC::Record=HASH(0x53904f8) '_fields' => ARRAY(0x5471fa8) 0 MARC::Field=HASH(0x54694b8) '_data' => 328 '_is_control_field' => 1 '_tag' => 001 '_warnings' => ARRAY(0x53bb8d8) empty array 1 MARC::Field=HASH(0x545ea10) '_data' => 'IT-RoAPU' '_is_control_field' => 1 '_tag' => 003 '_warnings' => ARRAY(0x545df00) empty array 2 MARC::Field=HASH(0x5460d78) '_data' => 20130929162908.0 '_is_control_field' => 1 '_tag' => 005 '_warnings' => ARRAY(0x592ee28) empty array [...] 15 MARC::Field=HASH(0x546b1a8) '_ind1' => 0 '_ind2' => 0 '_is_control_field' => 0 '_subfields' => ARRAY(0x541c940) 0 'a' 1 'Biblia.' 2 'p' 3 'V.T.' 4 'p' 5 'Qohélet' 6 'x' 7 'Commenti.' 8 9 9 171552 '_tag' => 630 '_warnings' => ARRAY(0x5465538) empty array 16 MARC::Field=HASH(0x5465a18) '_ind1' => ' ' '_ind2' => ' ' '_is_control_field' => 0 '_subfields' => ARRAY(0x5466cd0) 0 'a' 1 'Biblia.' 2 'p' 3 'V.T.' 4 'p' 5 'Qohélet.' 6 'l' 7 'Inglese.' 8 'f' 9 1988. 10 9 11 '_tag' => 240 '_warnings' => ARRAY(0x5477168) empty array 17 MARC::Field=HASH(0x5462fa8) '_ind1' => ' ' '_ind2' => ' ' '_is_control_field' => 0 '_subfields' => ARRAY(0x541eb38) 0 'a' 1 'IT-RoAP' '_tag' => 850 '_warnings' => ARRAY(0x5931948) empty array 18 MARC::Field=HASH(0x5469788) '_ind1' => ' ' '_ind2' => ' ' '_is_control_field' => 0 '_subfields' => ARRAY(0x5472170) 0 'c' 1 32 '_tag' => 999 '_warnings' => ARRAY(0x54693f8) empty array '_leader' => '00859nam a2200265 i 4500' '_warnings' => ARRAY(0x53682b0) 0 'Invalid record length in record 324: Leader says 00859 bytes but it\'s actually 861' 1 'field does not end in end of field character in tag 630 in record 324' 2 'field does not end in end of field character in tag 240 in record 324' 3 "Invalid indicators \"\c^02\" forced to blanks in record 324 for tag 240\cJ" 4 'field does not end in end of field character in tag 850 in record 324' 5 "Invalid indicators \"3\c^ \" forced to blanks in record 324 for tag 850\cJ" 6 'field does not end in end of field character in tag 999 in record 324' 7 "Invalid indicators \"U\c^ \" forced to blanks in record 324 for tag 999\cJ" In fact indicator of tag 240 are wrong (the correct values are '02'); -- Dr. Zeno Tajoli Dipartimento Gestione delle Informazioni e della Conoscenza z.tajoli(a)cineca.it fax +39 02 2135520 CINECA - Sede operativa di Segrate

1 0

Clone an item
by Paul 27 Sep '13

27 Sep '13

I seem to remember that there was a discussion | bug | request to be able to clone an item during the staff edit process, in the same manner that a biblio can be cloned. Could someone please point me in the right direction of any work that might already have been done on this? Many tnx and best regards Paul

2 1

3.14 feature freeze notes
by Galen Charlton 25 Sep '13

25 Sep '13

Hi, Feature slush is imminent, as is feature freeze. Here are some notes on what I expect this to mean in practice. New Features -------------------- At this point, every bug that is in a state of passed QA, with exceptions I will name below, can provisionally be considered candidates for inclusion in Koha 3.14. Any new feature or enhancement patch that reaches passed QA by 23:59 on September 25, 2013 in my time zone (UTC-7) can likewise be provisional candidates. By provisional candidate I mean the following: [1] I will review it and either push it or give an opportunity for the submitter to address QA concerns. [2] My presumption will be that the feature end up getting pushed to master. [3] This NOT, however, a guarantee that it will get pushed -- my primary concern is a stable master; if we run out of time (by which I mean the end of hackfest at KohaCon) to address quality concerns on any given patch, it's not going in. Any patches that reach passed QA between September 26, 2013 and 23:59 on October 3, 2013 will also be considered provisional candidates for release, but are more likely to be held over for post-3.14 if there are problems. In other words, enhancements that reach slush will get looked at first. Exceptions ---------------- I am giving the following enhancement bugs special dispensation to be considered for inclusion even if they miss the freeze date by a bit: * 8798: Add the use of DBIx::Class * 10565: Add a "Patron List" feature for storing and manipulating collections of patrons (depends on DBIx::Class) * 10493: Add renewal script (depends on DBIx::Class) * 10309: New OPAC theme based on Bootstrap * Bugs related to adding DOM indexing support for UNIMARC * Bugs related to LDAP * Debian packaging improvements * Bugs related to the GRS-1 deprecation announcements being discussed * Bugs related to making QueryParser enabled by default, also being discussed The following bugs currently in a passed QA state will get pushed in some form, but I will be submitting a counter-patch: 8190: Add a logging module to Koha The following bugs currently in passed QA may not get pushed: 9854: Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) -- the patch for this does not stand on its own until patches for related bugs are ready 7167: updatedatabase improvements -- I have spent a *lot* of time mulling this one over -- and in the final analysis, in my opinion it would add far too much complexity to solve a problem that can be addressed by our agreeing never to fail a patch purely on the basis of a resolvable merge conflict. To my knowledge, that is current the case. The current practice of linearly applied schema changes, while not the most flexible possible system, has been /very/ successful for the average Koha user, and I am very hesitant to risk regressions during upgrade. Organizations who deploy new developments in advance of their release -- and I appreciate why and how that happens -- ultimately must take responsibility for managing schema updates for their customers. However, I do have thoughts on a possible compromise that can provide a /simple/ mechanism to specify that specific updates are to be bypassed. I'll will think on this some more and update the bug by the end of the week. But sneak preview -- if we make it possible for DBrevs to be identified by both the version number and a tag (such as the bug number, for example), it would be simple to set up a mechanism for somebody to inject DBrevs in advance of a release without having to know the version number that ultimately gets assigned, then have updatedatabase.pl bypass reapplying those specific revisions -- without having any effect on a stock Koha database. This wouldn't solve everything, if the schema and data changes for the update get modified during the patch review process, but that's part of the risk anybody assumes by running in advance of master. Bugfixes ------------- There is no specific freeze date for bugfixes except the constraints imposed by string freeze at the end of October. However, I cannot guarantee that all bugfixes that reach passed QA before release will make it in; patches that stabilize new enhancements will take precedence during the month of October. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc(a)esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org

3 3

Coding guidelines and Plack
by Marcel de Rooy 25 Sep '13

25 Sep '13

Hi all, Had a discussion with Jonathan on bug 9032 about the use of variables and requirements for Plack. Our coding guidelines do not yet mention Plack. Should we add a PERL rule that prohibits defining lexical variables (my $var) at the outermost block (file level) ? Is it also needed to move script subroutines to module level? Other requirements? It would be beneficial if we could update the coding guidelines accordingly.. Thanks, Marcel

3 3