- Koha-devel - lists.koha-community.org

Fixing perltidy in ktd
by David Cook 10 Mar '23

10 Mar '23

Hi Tomas, I saw you, Katrin, and Jonathan writing in #koha about perltidy. When I've tried previously to perltidy in ktd using the ":Tidy" command, it seemed to change the style to something incompatible with https://wiki.koha-community.org/wiki/Coding_Guidelines If I type "vi Koha.pm", then ":echo $MYVIMRC", it tells me I'm using the /root/.vimrc file. I'm not overwriting that, so it's the default file that ships with ktd. I don't have a good example off the top of my head though. I've just tried perltidying debian/scripts/koha-log4perl from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791. There are things that look weird to me but after reviewing the coding guidelines, maybe I've been wrong all this time. For example: - my $snippet = get_snippet({ - instance => $instance, - component => $component, - }); - if ($snippet){ + my $snippet = get_snippet( + { + instance => $instance, + component => $component, + } + ); I always thought we preferred to keep the brackets on the same line (like in all the JS examples on the wiki). It looks like perltidy sometimes mangles the whitespace for comments as well. I'd correctly indented a comment and then perltidy stripped all the whitespace except for 2 leading spaces. That all said. overall it probably does look better, so maybe the out of the box perltidy is good enough, and if the same perltidy file is applied across the board I suppose it doesn't matter. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

3 3

Not ignoring you...
by David Cook 10 Mar '23

10 Mar '23

Hi all, Looks like a number of you have been sending emails and it probably seems like I've ignored you. but it turns out they've been going to my Junk Mail. Sorry about that! David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

1 0

Re: [Koha-devel] help: // Koha rest api error (401)
by Eric Phetteplace 09 Mar '23

09 Mar '23

Hi Esharat, You should keep the listserv copied on replies so others can see the conversation, learn from it, or respond. I don't know what the issue could be then. Are you performing the same requests from the RESTer extension, as in first getting a token and then using it in an authorization header? Small note, 443 isn't a subdomain, it's a port number. Your request would look like: response = requests.get(f"https://{mydomain}:443/api/v1/quotes", headers=auth2) but it is also more likely to be 8443 if your HTTP port is 8080. But if the RESTer client works with whatever you're doing, then the ports are not the issue. As I said, your code works for me as written, and if another client successfully requests something from your server then it is configured correctly. If you are not sharing the exact code you're running, that might help, or if you show the actual response data (a 401 should still have some data encoded in it) or any error stack traces. Best, ERIC PHETTEPLACE Systems Librarian, Libraries (he/him) ephetteplace(a)cca.edu *CCA is situated on the traditional unceded lands of the **Chochenyo and Ramaytush Ohlone** peoples.* Black-owned bookstores in Oakland: Ashay by the Bay <https://ashaybythebay.com/>, Marcus Books <https://www.facebook.com/marcus.books/> :(){ :|: & };: On Tue, Mar 7, 2023 at 9:04 AM Esharat Mia <esharat(a)esharat.me> wrote: > Dear Phetteplace, > Hope you are well. Thank you so much for your response. > I tried with 443 with sub domain. But I faced same issues. For your kind > information, I tested my api using RESTer chrome extension, it worked. I > enable all api setting from koha adminstration. Need any editional > configuration in server side? > > > ---- On Tue, 07 Mar 2023 22:56:23 +0600 * ephetteplace(a)cca.edu > <ephetteplace(a)cca.edu> * wrote ---- > > Hi Esharat, > > Your code should work but it has a few things that don't make sense. > > Are you sure you have the setting "RESTOAuth2ClientCredentials" on your > Koha? That is one guess. > > My other thought is that you are requesting an HTTPS resource from a URL > on port 8080. This looks like you might be running Koha locally; usually, > HTTP requests are to port 80 and HTTPS to 443 and when you run things > locally those are often shifted up eight thousand spots to 8080 and 8443. > So basically—are you sure your server sends HTTPS responses on port 8080? > Are you able to load https://{mydomain}:8080 in a browser? You said > you're getting a 401 error, which means you're get a response, so this > seems unlikely to be the problem (you would see a connection error and not > receive a response if it was). > > I was able to test successfully with your code so I don't necessarily > think these are issues either, but there are a few pieces that don't make > sense. The HTTPS connection that's initialized at the top is never used. As > far as I know, the requests library doesn't magically pick up an existing > connection and use it, nor is this necessary (requests will make a > connection for you). Also, your second request uses a "content-type: > application/json" HTTP header but it is a GET request, content-type is a > header for *the type of data you're sending* but GET requests do not send > anything. You probably meant to have an "accept: application/json" header > instead. But again, I tried on our instance with that code and Koha did not > seem to mind. > > Best, > > ERIC PHETTEPLACE Systems Librarian, Libraries (he/him) > > ephetteplace(a)cca.edu > > > *CCA is situated on the traditional unceded lands of the **Chochenyo and > Ramaytush Ohlone** peoples.* > > Black-owned bookstores in Oakland: Ashay by the Bay > <https://ashaybythebay.com/>, Marcus Books > <https://www.facebook.com/marcus.books/> > > :(){ :|: & };: > > > On Tue, Mar 7, 2023 at 12:59 AM Esharat Mia <esharat(a)esharat.me> wrote: > > Dear All, > Hope this email finds you well. I am facing a error koha rest api , I > explained below - > I use the below code base for the koha rest api . When I check the bywater > koha demo site's rest api, it's working fine but When I checked my demo > koha site, getting authentication error(401) > I entered the correct client id and secret ssl certificate installed > correctly. My api worked properly using the chrome *RESTer* tool. Thanks > in advance . > > *import requests* > *import json* > *import os* > *from requests.structures import CaseInsensitiveDict* > *import http.client* > *conn = http.client.HTTPSConnection("http://123.49.46.157:8080/ > <http://123.49.46.157:8080/>")* > > *#from dotenv import load_dotenv* > > *#load_dotenv()* > *data = {* > *"client_id": "e877bce0-78bc-4d39-a0c1-2df7fccb1397",* > *"client_secret": "461cda1a-665d-4d24-a0e0-dace5f83a1f4",* > *"grant_type": "client_credentials",* > > *}* > > *response = requests.post > <http://requests.post>("http://123.49.46.157:8080/api/v1/oauth/token > <http://123.49.46.157:8080/api/v1/oauth/token>", data=data)* > > *credentials = response.json()* > *print(credentials)* > *access_token = credentials['access_token']* > *print("Access_token: ",access_token)* > *#auth2 = CaseInsensitiveDict()* > *auth2={"content-type":"application/json","authorization": f"Bearer > {access_token}"}* > > *print(auth2)* > *response = requests.request("GET", > "http://123.49.46.157:8080/api/v1/patrons > <http://123.49.46.157:8080/api/v1/patrons>", headers=auth2* > *)* > > *print(response)* > > Regrads, > Esharat Mia > > > _______________________________________________ > Koha-devel mailing list > Koha-devel(a)lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > > >

2 2

Koha rest api error
by Esharat Mia 07 Mar '23

07 Mar '23

Dear All, Hope this email finds you well. I am facing a error koha rest api , I explained below - I use the below code base for the koha rest api . When I check the bywater koha demo site's rest api, it's working fine but When I checked my demo koha site, getting authentication error(401) I entered the correct client id and secret ssl certificate installed correctly. My api worked properly using the chrome RESTer tool. Thanks in advance . import requests import json import os from requests.structures import CaseInsensitiveDict import http.client conn = http.client.HTTPSConnection("http://123.49.46.157:8080/") #from dotenv import load_dotenv #load_dotenv() data = { "client_id": "e877bce0-78bc-4d39-a0c1-2df7fccb1397", "client_secret": "461cda1a-665d-4d24-a0e0-dace5f83a1f4", "grant_type": "client_credentials", } response = requests.post("http://123.49.46.157:8080/api/v1/oauth/token", data=data) credentials = response.json() print(credentials) access_token = credentials['access_token'] print("Access_token: ",access_token) #auth2 = CaseInsensitiveDict() auth2={"content-type":"application/json","authorization": f"Bearer {access_token}"} print(auth2) response = requests.request("GET", "http://123.49.46.157:8080/api/v1/patrons", headers=auth2 ) print(response) Regrads, Esharat Mia

2 1

Request for signoff
by Marcel de Rooy 03 Mar '23

03 Mar '23

Hi all, I could use some help getting two patches further: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Sync comments in database with schema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426 Allow plugin to generate userid when creating patrons Thanks in advance, Marcel

1 0

Problem configuring apache with mpm_itk
by Christian Calle Jahuira 02 Mar '23

02 Mar '23

Hi all, I found the following detail when installing koha 22.11 on ubuntu 18.4. ###### root@PC:/home/christianjcj# sudo koha-create --create-db biblioteca AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.1.1. Set the 'ServerName' directive globally to suppress this message AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.1.1. Set the 'ServerName' directive globally to suppress this message Koha requires mpm_itk to be enabled within Apache in order to run. Typically this can be enabled with: sudo a2dismod mpm_event ; sudo a2enmod mpm_itk root@PC:/home/christianjcj# ###### Can you help me. Thank you -- Christian Jhonny Calle Jahuira Consultor de Sistemas de Informacion Ingeniero de Sistemas - Bibliotecologia Email: christianjcj(a)gmail.com Cel: 78977773

2 2

Koha Community Newsletter: February 2023
by Koha Newsletter 27 Feb '23

27 Feb '23

The Koha Community Newsletter for February 2023 is here: https://koha-community.org/koha-community-newsletter-february-2023/ Many thanks to everyone who submitted articles and news to this newsletter! Please feel free to email me with any corrections or suggestions. -- Michael Kuhn Editor, Koha Community Newsletter

1 0

Permissions on Pootle
by Tiago Murakami 24 Feb '23

24 Feb '23

Hi, I´m a librarian in Brazil. I had Pootle permissions for translation, but, I only have them for suggestions. What is the best way to ask for permission to translate Pootle in pt-BR? Thanks in advance, -- Tiago Murakami

2 2

Koha 22.11.03 release
by Renvoize, Martin 23 Feb '23

23 Feb '23

Hello, Bonjour, Ola, Kia ora, 今日は, The Koha community is pleased to announce the release of version 22.11.03. This release is a bugfix/maintenance release with a small number of minor architectural enhancements to aid in the continued maintenance of this version. It includes 40 enhancements and 87 bugfixes. For full release notes, please visit https://koha-community.org/koha-22-11-03-released/ Thanks for anybody involved! 🚀 Martin Renvoize, MPhys (Hons) Head of Development and Community Engagement E: martin.renvoize(a)ptfs-europe.com P: +44 (0) 1483 378728 M: +44 (0) 7725 985636 www.ptfs-europe.com

1 0

Random data in CGI Vars
by Julian Maurice 23 Feb '23

23 Feb '23

Hello, I've been encountering strange bugs on two different Koha instances (both 21.11). When cataloguing new records, instead of the record being saved, users are being redirected to an empty cataloguing form (like if they clicked on "New record"). They have to use "Back" and submit the form again until it works. I suspected something going wrong in how the form data was being sent to Koha so I added the following line in cataloguing/addbiblio.pl warn Data::Dumper->Dump([{ $input->Vars }], ['Vars']) . "\n"; right after CGI->new And indeed there is something going wrong. Some of the variables are replaced by random data. Here's an example: 'tag_041_subfield_a_452653_624274' => '', '' => "Ly[\x{1cf}^KJ{)Z\x{fffd}(-D<\x{fffd}\x{fffd}\x{fffd}BN", 'tag_856_code_x_883542_376496' => 'x', Sometimes the 'op' parameter is replaced by random data, and that's why we see this strange behaviour. Have you ever experienced something like this ? Do you know where it could come from ? -- Julian Maurice BibLibre

1 0