- Koha-devel - lists.koha-community.org

Proposal to change Bugzilla Status and Patch Status values
by Ian Walls 09 Jan '12

09 Jan '12

Fellow Koha-ckers, A comment on bug 7167 ( http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167) has gotten my interest re-awakened about a proposed Bugzilla revision that had been floated earlier this release cycle. I'd like to remove Patch Status, and move all those values to the regular Status field. This has the following advantages: - Status is a built-in field, so it's got much richer support in Bugzilla. For example, status workflows can be added. Patch Status is a custom field, and is just a list of values - We would no longer lose the Priority value of a bug by having to set it to Patch Sent in order to get the Patch Status values visible - Statuses can be updated as part of submitting an attachment like a patch, streamlining the patch submission process (fewer clicks to keep all the fields up to date). I'd also like to add a new status, "In Discussion", for bug reports that have deeper procedural, philsophical or technical implications outside that of mere coding (bug 7167 being an example). We're not using Status for anything else, so there is no trade-off there. This is really how the Status field is meant to be used. We will, however, have to rebuild the canned searches that look for patches that Need Signoff, are Signed Off, and are Passed QA/Failed QA. The other difficulty of this proposal is that we'll need to turn off automatic bug emails for a bit while we make the bulk changes to the Patch Statuses; otherwise, we'll all get spammed to high heaven with meaningless updates when the migration occurs. What do people think? Does this sound like a reasonable change to make? Any objections? Cheers, -Ian -- Ian Walls Lead Development Specialist ByWater Solutions ALA Midwinter Booth #2048 Phone # (888) 900-8944 http://bywatersolutions.com ian.walls(a)bywatersolutions.com Twitter: @sekjal

11 13

Re: [Koha-devel] link_bibs_to_authorities.pl can corrupt records
by Archives and Collections Society 06 Jan '12

06 Jan '12

At 03:02 PM 1/6/2012 -0500, Ian Walls wrote: >Paul, >The <http://link_bibs_to_authorities.pl>link_bibs_to_authorities.pl script >is hardcoded to ALWAYS erase manual links.Â I'm not sure what the >reasoning is behind that.Â But, every time you run it, any link you've >done manually that the script can't automatically figure out will be >removed.Â Nature of the beast (for now, at least). What is "any link you've done manually"?, please. More than 90% of our input is Z39.50 and "default" item cataloguing. OK - a total screw-up that is included without any warning whatsoever in the standard distribution of 3.6.1 ??? From the bug report <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5683> Chris Cormack 2011-06-01 21:13:23 UTC Pushed to master Jared Camins-Esakov 2011-07-08 14:37:02 UTC Seems to be working now. Closing. If it's "nature of the beast" why isn't the "beast" mentioned somewhere? What on earth is the reason for this .pl to be included in any distribution? More... >2012/1/6 Chris Cormack ><<mailto:chris@bigballofwax.co.nz>chris(a)bigballofwax.co.nz> >Im assuming you did this on your testing/staging server right? >Id restore that from backup, then try applying the patch and see if you >get better behaviour. >If so, then do it on your production machine. what "patch"??? And yes -- I can restore from a previous sqldump, and only lose +/- 100 biblios. We're in pre-production and when we got the zebra indexing working properly, I told our volunteers to start inputting to 3.6.1 *only* (not duplicate on 3.2) so that I could look into any difficulties they experienced as cataloguers. I had no way at all of knowing that a pl script included in the "latest stable distribution" could possibly demolish the whole db. Again, what "patch" and where do I find it? Might I suggest that someone re-opens the bug (I have attempted to annotate it) and removes this dangerous script from public distribution (or at least includes a very visible warning.) Best - Paul >Chris >On 7 Jan 2012 08:47, "Paul" <<mailto:paul.a@aandc.org>paul.a(a)aandc.org> wrote: >Bug 5683 (<http://link_bibs_to_authorities.pl>link_bibs_to_authorities.pl >can corrupt records) was signed off some months ago, but is perhaps a >little too cryptic for me to follow in detail. Â Can someone help? As far >as I can see, without remedial action, this is catastrophic. > >Following difficulties we have had migrating 3.2 to 3.6.1, someone on the >users mailing list suggested we should run ><http://link_bibs_to_authorities.pl>link_bibs_to_authorities.pl -- (db has >~10k authorities and ~15k biblios) -- so I did just that, and have >APPARENTLY DEMOLISHED *EVERY* LINK IN THE DB. Â From my notes: > >paul@nelson:/usr/share/koha$ >./bin/<http://link_bibs_to_authorities.pl>link_bibs_to_authorities.pl > >Bib authority heading linking report >------------------------------------ >Number of bibs checked: Â Â Â 14911 >Number of bibs modified: Â Â Â 14886 >Number of bibs with errors: Â 0 > >but - the staff interface no longer correctly finds authorities !!! > >[1] Manually link (staff client) auth "Lubbock" to bib "Arctic Whalers" -- >now linked, 35 other Lubbock bibs not linked. Â Is this a question of >zebra re-indexing? > >So: Â KOHA_CONF=/etc/koha/koha-conf.xml PERL5LIB=/usr/share/koha/lib >./bin/migration_tools/<http://rebuild_zebra.pl>rebuild_zebra.pl -a -r -v >and Â KOHA_CONF=/etc/koha/koha-conf.xml PERL5LIB=/usr/share/koha/lib >./bin/migration_tools/<http://rebuild_zebra.pl>rebuild_zebra.pl -b -r -v -x > >koha@nelson:/usr/share/koha$ >./bin/<http://link_bibs_to_authorities.pl>link_bibs_to_authorities.pl >... processed 100 records >/ ... / >... processed 14900 records > >Bib authority heading linking report >------------------------------------ >Number of bibs checked: Â Â Â 14911 >Number of bibs modified: Â Â Â 1 >Number of bibs with errors: Â 0 >koha@nelson:/usr/share/koha$ > >All this did was to *un-link" the bib/auth link that I had manually >entered at [1] above. Could someone involved with signing off bug 5683 >please explain why link==unlink? > >Help - please. > >Paul > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > > > >-- >Ian Walls >Lead Development Specialist >ByWater Solutions >ALA Midwinter Booth #2048 >Phone # (888) 900-8944 ><http://bywatersolutions.com>http://bywatersolutions.com ><mailto:ian.walls@bywatersolutions.com>ian.walls(a)bywatersolutions.com >Twitter: @sekjal >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/ --- Archives and Collections (ACS) Society 205, Main Street, Picton, Ontario, K0K 2T0, Canada http://www.AandC.org Canadian Charitable Organization 88721 9921 RR0001 Dedicated to maritime conservation and education.

2 1

link_bibs_to_authorities.pl can corrupt records
by Paul 06 Jan '12

06 Jan '12

Bug 5683 (link_bibs_to_authorities.pl can corrupt records) was signed off some months ago, but is perhaps a little too cryptic for me to follow in detail. Can someone help? As far as I can see, without remedial action, this is catastrophic. Following difficulties we have had migrating 3.2 to 3.6.1, someone on the users mailing list suggested we should run link_bibs_to_authorities.pl -- (db has ~10k authorities and ~15k biblios) -- so I did just that, and have APPARENTLY DEMOLISHED *EVERY* LINK IN THE DB. From my notes: paul@nelson:/usr/share/koha$ ./bin/link_bibs_to_authorities.pl Bib authority heading linking report ------------------------------------ Number of bibs checked: 14911 Number of bibs modified: 14886 Number of bibs with errors: 0 but - the staff interface no longer correctly finds authorities !!! [1] Manually link (staff client) auth "Lubbock" to bib "Arctic Whalers" -- now linked, 35 other Lubbock bibs not linked. Is this a question of zebra re-indexing? So: KOHA_CONF=/etc/koha/koha-conf.xml PERL5LIB=/usr/share/koha/lib ./bin/migration_tools/rebuild_zebra.pl -a -r -v and KOHA_CONF=/etc/koha/koha-conf.xml PERL5LIB=/usr/share/koha/lib ./bin/migration_tools/rebuild_zebra.pl -b -r -v -x koha@nelson:/usr/share/koha$ ./bin/link_bibs_to_authorities.pl ... processed 100 records / ... / ... processed 14900 records Bib authority heading linking report ------------------------------------ Number of bibs checked: 14911 Number of bibs modified: 1 Number of bibs with errors: 0 koha@nelson:/usr/share/koha$ All this did was to *un-link" the bib/auth link that I had manually entered at [1] above. Could someone involved with signing off bug 5683 please explain why link==unlink? Help - please. Paul

4 3

Database updates on master [IMPORTANT]
by Paul Poulain 06 Jan '12

06 Jan '12

Hello, a very important information: After a long discussion with chris_c and chris_n, it seems I made a mistake and have found a hidden problem. * the hidden problem (that was hidden for me, and probably for most of you. both chris where aware) : in 3.4 and 3.6, when a patch with a updatedatabase was backported, it was backported with another number. It means that when you upgrade from 3.2 to 3.4 then 3.6, you get some error message about duplicate key of things like that. I've checked, those SQL errors are all harmless (and chris already had checked in fact). * my mistake: as I thought patches for 3.6 should have a 3.6 number and patches for master (future 3.8) should have a 3.7 number, i've pushed 3 patches with an updatedatabase numbered 3.6.x That was a bad idea, and I'll have to modify those updatedatabase, i'll do it now. So, anyone running master should get a "free" updatedatabase in the next hours. By free I mean the 3 DB revs that will be applied have already been applied, that will just be a number change. So, 1-take care, 2- don't worry. Also note that this problem will be solved once the new database mechanism will be pushed, as it will be non-linear, so the numbering won't refer to a release number anymore. HTH -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

1 0

Anonymous OPAC Search History
by Julian Maurice 05 Jan '12

05 Jan '12

Hello all, I have a question about this commit (I didn't succeed to find the corresponding bug in Bugzilla) commit feeafa8168965183ba8651cf3113c3c32af863ec Author: Henri-Damien LAURENT <henridamien.laurent(a)biblibre.com> AuthorDate: Mon Aug 24 22:10:25 2009 +0200 Commit: Henri-Damien LAURENT <henridamien.laurent(a)biblibre.com> CommitDate: Wed Sep 30 11:22:21 2009 +0200 Adding Opac-SearchHistory feature Enables ppl to store their search history and delete the whole history Adding Storable required by Opac-Search-History Signed-off-by: Galen Charlton <gmcharlt(a)gmail.com> It adds the possibility for users to store their search queries. It's possible for both logged users and anonymous users. More than that, if an anonymous user with a search history log in, the whole anonymous history is loaded and stored as the user search history. Isn't there any privacy problems with this feature? I mean, if user_1 do some search as an anonymous user, and then user_2 go on the same computer and log in, the whole user_1 search history is saved into user_2 search history. This behaviour has been reported as a bug by some BibLibre customers, that's why I ask. -- Julian Maurice <julian.maurice(a)biblibre.com> BibLibre

3 2

work on the database (call for wiki discussion)
by Paul Poulain 05 Jan '12

05 Jan '12

Hello, Jonathan & me took 3 hours working on database design. We've created a wiki page with all the mistakes we've found. The page is http://wiki.koha-community.org/wiki/DB_schema_bugs you're welcomed to read it, add anything that could have been forgotten, or discuss what must be discussed. There are 2 kinds of entries in this page: * italic lines => we've found the problem, we don't have a solution, feel free to add your voice to the discussion tab of the wiki (http://wiki.koha-community.org/wiki/Talk:DB_schema_bugs, I already have filled it to ease the talk) * non italic lines => unless we made a mistake, those don't need to de discussed, they are obvious mistakes we will fix ASAP (which does not mean soon ;-) ) Enter the game ! -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

3 3

Cleaning up some files
by Marcel de Rooy 05 Jan '12

05 Jan '12

Paul, If the tests in t/db_dependent/lib and its subdir KohaTest are not working and should not be used anymore, could you please remove them from master? The files in t/data/db_schemas could be moved to docs/db_schemas, or deleted too. They just show the koha structure on some moments in time. Thanks, Marcel Van: Chris Cormack [mailto:chris@bigballofwax.co.nz] Verzonden: donderdag 22 december 2011 11:16 Aan: Marcel de Rooy CC: koha-devel(a)lists.koha-community.org Onderwerp: RE: [Koha-devel] Error on test in KohaTest They shouldn't be anymore, they dont work. Use the .t ones Chris On 22 Dec 2011 20:47, "Marcel de Rooy" <M.de.Rooy(a)rijksmuseum.nl<mailto:M.de.Rooy@rijksmuseum.nl>> wrote: Thanks, but how should they be run then? > -----Oorspronkelijk bericht----- > Van: Chris Cormack [mailto:chris@bigballofwax.co.nz<mailto:chris@bigballofwax.co.nz>] > Verzonden: donderdag 22 december 2011 02:27 > Aan: Marcel de Rooy > CC: koha-devel(a)lists.koha-community.org<mailto:koha-devel@lists.koha-community.org> > Onderwerp: Re: [Koha-devel] Error on test in KohaTest > > 2011/12/20 Marcel de Rooy <M.de.Rooy(a)rijksmuseum.nl<mailto:M.de.Rooy@rijksmuseum.nl>>: > > Hi, > > > > > > > > What am I doing wrong here? > > > > > > > > [marcel@RKM004 testclone]$ perl > > t/db_dependent/lib/KohaTest/AuthoritiesMarc.pm > > > > Invalid CODE attribute: Test( 1 ) at > > t/db_dependent/lib/KohaTest/AuthoritiesMarc.pm line 39 > > > > BEGIN failed--compilation aborted at > > t/db_dependent/lib/KohaTest/AuthoritiesMarc.pm line 39. > > > > > > > > [marcel@RKM004 testclone]$ perl t/db_dependent/lib/KohaTest/Search.pm > > > > Invalid CODE attribute: Test( 1 ) at t/db_dependent/lib/KohaTest/Search.pm > > line 35 > > > > BEGIN failed--compilation aborted at t/db_dependent/lib/KohaTest/Search.pm > > line 35. > > > > > > > The tests in that dir are not designed to be run that way, in fact we > should probably just remove them. > > The real tests for those files are > t/db_dependent/Search.t > and > t/AuthoritiesMarc_MARC21.t > t/AuthoritiesMarc.t > t/AuthoritiesMarc_UNIMARC.t > > Chris

1 0

TEST sending email and email administration
by Henri-Damien LAURENT 04 Jan '12

04 Jan '12

my little message -- Henri-Damien LAURENT BibLibre

1 0

sample databases for sandboxes
by Paul Poulain 02 Jan '12

02 Jan '12

Hello, In my RM application, I spoke of sandboxes that could be used for non-techies to test and signoff patches. I've started to work on this system, something should be visible this month. The system will work that way: * you reach a dedicated page * on this page, you enter 3 things (maybe some more to come) : - the bugzilla patch number you want to test - your email-address (to have a mail once your sandbox is set) - the database you want to setup, from a list of available sample databases * you hit the "OK" button * a few minuts later, you get a mail in your mailbox saying it's done * you connect to the sandbox, and, on the main page, you see if everything went well and you can work on this sandbox. QUESTION/REQUEST: if you have a sample database you'd like to see in the list, just send it to me by email, with some details about the content of this example database, that will be seen by ppl that want to test patches. For example : "this database has 1000 records, 100 patrons, with IndependantBranches=ON, and holds are not enabled anywhere. login with test/test to be superlibrarian from library A, and libB/libB to be a non-superlibrarian from library B" FAQ about this system: Q: how will we manage concurrency ? A: there won't be any automatic checking. But the timestamp of the creation of every sandbox will be visible on mainpage. So if the sandbox is very young, use another one ! If you've any doubt, go Q: what if something went wrong when applying the patch ? A: just add a comment on bugzilla to say "tried to test this patch with sandbox system, it does not work, you get the following message: <copy here the message you saw on mainpage>>". It will mean this patch must be tested by a developer with larger skills than this basic sandbox system has. Q: I want to setup my own sandboxes, how can I do that ? A: go to http://git.biblibre.com, and you'll see a project here with all the code (ie: still to be done) Q: I've tested the patch, and everything went well, what's next ? A: just go to bugzilla, change the status to "signed-off" and add a comment to say "i've tested, works well, signed-off". The RM or the QA team will take care of officially adding your signature to the patch. Q: how long will last a given sandbox setup ? A: Every night, everything will be reseted, Koha will be updated against an uptodate master. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

1 0

DataTables How-To
by Julian Maurice 30 Dec '11

30 Dec '11

Hi all! I just wrote a brief explanation on how to use the jQuery library DataTables in Koha pages. Here is the link http://wiki.koha-community.org/wiki/DataTables_HowTo Please feel free to give feedback and to contribute ;-) -- Julian Maurice <julian.maurice(a)biblibre.com> BibLibre

1 0