April 2002 - Koha-devel - lists.koha-community.org

CVS: koha ChangeLog,1.1.2.1,1.1.2.2
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv21257 Modified Files: Tag: rel-1-2 ChangeLog Log Message: added recent updates Index: ChangeLog =================================================================== RCS file: /cvsroot/koha/koha/ChangeLog,v retrieving revision 1.1.2.1 retrieving revision 1.1.2.2 diff -C2 -r1.1.2.1 -r1.1.2.2 *** ChangeLog 25 Apr 2002 13:59:37 -0000 1.1.2.1 --- ChangeLog 25 Apr 2002 16:15:52 -0000 1.1.2.2 *************** *** 1,2 **** --- 1,10 ---- + 2002-04-25 09:12 pate + + * output.t, testKoha.pl: added tests for Output.pm (nearing + complete coverage) + + * C4/Output.pm: added prototyping where possible, cleaned up some + compiler warnings + 2002-04-25 06:57 pate

1 0

CVS: koha testKoha.pl,1.1.2.2,1.1.2.3 output.t,1.1.2.1,1.1.2.2
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv19694 Modified Files: Tag: rel-1-2 testKoha.pl output.t Log Message: more tests in output.t and a cleanup for testKoha.pl Index: testKoha.pl =================================================================== RCS file: /cvsroot/koha/koha/testKoha.pl,v retrieving revision 1.1.2.2 retrieving revision 1.1.2.3 diff -C2 -r1.1.2.2 -r1.1.2.3 *** testKoha.pl 25 Apr 2002 14:49:32 -0000 1.1.2.2 --- testKoha.pl 25 Apr 2002 16:11:50 -0000 1.1.2.3 *************** *** 5,8 **** # please add many tests here ! runtests 'koha.t'; ! runtests 'output.t'; --- 5,8 ---- # please add many tests here ! runtests ('koha.t', 'output.t'); ! Index: output.t =================================================================== RCS file: /cvsroot/koha/koha/Attic/output.t,v retrieving revision 1.1.2.1 retrieving revision 1.1.2.2 diff -C2 -r1.1.2.1 -r1.1.2.2 *** output.t 25 Apr 2002 14:49:32 -0000 1.1.2.1 --- output.t 25 Apr 2002 16:11:50 -0000 1.1.2.2 *************** *** 1,3 **** ! BEGIN { $| = 1; print "1..6\n"; } END {print "not ok 1\n" unless $loaded;} use C4::Output; --- 1,3 ---- ! BEGIN { $| = 1; print "1..17\n"; } END {print "not ok 1\n" unless $loaded;} use C4::Output; *************** *** 45,49 **** # 1 row, no background image if ("<tr valign=top bgcolor=red><td>text</td></tr>\n" eq ! mktablerow(1,'red','text','')) { print "ok 5\n"; } else { --- 45,49 ---- # 1 row, no background image if ("<tr valign=top bgcolor=red><td>text</td></tr>\n" eq ! mktablerow(1,'red','text')) { print "ok 5\n"; } else { *************** *** 57,59 **** --- 57,169 ---- print "not ok 6\n"; } + #2 rows, no background image + if ("<tr valign=top bgcolor=red><td>text</td><td>text</td></tr>\n" eq + mktablerow(2,'red','text','text')) { + print "ok 7\n"; + } else { + print "not ok 7\n"; + } + + # 2 rows, background image + if ("<tr valign=top bgcolor=red><td background=\"foo.jpg\">text</td><td background=\"foo.jpg\">text</td></tr>\n" eq + mktablerow(2,'red','text','text', 'foo.jpg')) { + print "ok 8\n"; + } else { + print "not ok 8\n"; + } + + # + # ensure mktableft returns the proper value + # + + if ("</table>\n" eq mktableft()) { + print "ok 9\n"; + } else { + print "not ok 9\n"; + } + + + # + # skipping mkform for now + # + + # + # skipping mkform3 for now + # + + # + # skipping mkformnotable for now + # + + # + # skipping mkform2 for now + # + # + # ensure endpage returns the proper value + # + + if ("</body></html>\n" eq endpage()) { + print "ok 10\n"; + } else { + print "not ok 10\n"; + } + + + # + # ensure mklink returns the right value + # + + if ("<a href=\"foo.html\">foo</a>" eq mklink('foo.html', 'foo')) { + print "ok 11\n"; + } else { + print "not ok 11\n"; + } + + # + # ensure mkheadr returns the proper value + # + + if ("foo " eq mkheadr(1,'foo')) { + print "ok 12\n"; + } else { + print "not ok 12\n"; + } + + if ("foo" eq mkheadr(2,'foo')) { + print "ok 13\n"; + } else { + print "not ok 13\n"; + } + + if ("foo" eq mkheadr(3,'foo')) { + print "ok 14\n"; + } else { + print "not ok 14\n"; + } + + # + # test &center and &endcenter + # + + if ("<CENTER>\n" eq center()) { + print "ok 15\n"; + } else { + print "not ok15\n"; + } + + if ("</CENTER>\n" eq endcenter()) { + print "ok 16\n"; + } else { + print "not ok 16\n"; + } + + # + # ensure bold returns proper value + # + + if ("foo" eq bold('foo')) { + print "ok 17\n"; + } else { + print "not ok\n"; + }

1 0

CVS: koha/C4 Output.pm,1.6.2.1,1.6.2.2
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv11670 Modified Files: Tag: rel-1-2 Output.pm Log Message: fixed an unitialized variable error in &mktablerow Index: Output.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Output.pm,v retrieving revision 1.6.2.1 retrieving revision 1.6.2.2 diff -C2 -r1.6.2.1 -r1.6.2.2 *** Output.pm 25 Apr 2002 14:50:16 -0000 1.6.2.1 --- Output.pm 25 Apr 2002 15:51:33 -0000 1.6.2.2 *************** *** 147,162 **** my $string="<tr valign=top bgcolor=$colour>"; while ($i <$cols){ ! if ($data[$cols] ne ''){ ! #check for backgroundimage ! $string.="<td background=\"$data[$cols]\">"; ! } else { ! $string.="<td>"; ! } ! if ($data[$i] eq "") { ! $string.="   </td>"; ! } else { ! $string.="$data[$i]</td>"; ! } ! $i++; } $string=$string."</tr>\n"; --- 147,161 ---- my $string="<tr valign=top bgcolor=$colour>"; while ($i <$cols){ ! if (defined $data[$cols]) { # if there is a background image ! $string.="<td background=\"$data[$cols]\">"; ! } else { # if there's no background image ! $string.="<td>"; ! } ! if ($data[$i] eq "") { ! $string.="   </td>"; ! } else { ! $string.="$data[$i]</td>"; ! } ! $i++; } $string=$string."</tr>\n";

1 0

CVS: koha/C4 Output.pm,1.6,1.6.2.1
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv19867 Modified Files: Tag: rel-1-2 Output.pm Log Message: adding prototypes, and fixing compiler warnings Index: Output.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Output.pm,v retrieving revision 1.6 retrieving revision 1.6.2.1 diff -C2 -r1.6 -r1.6.2.1 *** Output.pm 21 Apr 2002 04:45:21 -0000 1.6 --- Output.pm 25 Apr 2002 14:50:16 -0000 1.6.2.1 *************** *** 72,82 **** # make all your functions, whether exported or not; ! sub startpage{ return("<html>\n"); } ! sub gotopage{ ! my ($target) = @_; ! print " goto target = $target "; my $string = "<META HTTP-EQUIV=Refresh CONTENT=\"0;URL=http:$target\">"; return $string; --- 72,82 ---- # make all your functions, whether exported or not; ! sub startpage() { return("<html>\n"); } ! sub gotopage($) { ! my ($target) = shift; ! #print " goto target = $target "; my $string = "<META HTTP-EQUIV=Refresh CONTENT=\"0;URL=http:$target\">"; return $string; *************** *** 84,90 **** ! sub startmenu{ # edit the paths in here ! my ($type)=@_; if ($type eq 'issue') { open (FILE,"$path/issues-top.inc") || die; --- 84,90 ---- ! sub startmenu($) { # edit the paths in here ! my ($type)=shift; if ($type eq 'issue') { open (FILE,"$path/issues-top.inc") || die; *************** *** 104,109 **** my @string=<FILE>; close FILE; ! my $count=@string; ! # $string[$count]="<BLOCKQUOTE>"; return @string; } --- 104,109 ---- my @string=<FILE>; close FILE; ! # my $count=@string; ! # $string[$count]="<BLOCKQUOTE>"; return @string; } *************** *** 132,136 **** } ! sub mktablehdr { return("<table border=0 cellspacing=0 cellpadding=5>\n"); } --- 132,136 ---- } ! sub mktablehdr() { return("<table border=0 cellspacing=0 cellpadding=5>\n"); } *************** *** 341,345 **** $ltext = $ltext." (Req)"; } ! @order[$posn] =mktablerow(2,'white',$ltext,$text); } } --- 341,345 ---- $ltext = $ltext." (Req)"; } ! $order[$posn] =mktablerow(2,'white',$ltext,$text); } }

1 0

CVS: koha output.t,NONE,1.1.2.1 testKoha.pl,1.1.2.1,1.1.2.2
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv19608 Modified Files: Tag: rel-1-2 testKoha.pl Added Files: Tag: rel-1-2 output.t Log Message: started building tests for C4::Output --- NEW FILE --- BEGIN { $| = 1; print "1..6\n"; } END {print "not ok 1\n" unless $loaded;} use C4::Output; $loaded = 1; print "ok 1\n"; # # ensure &startpage returns correct value # if ("<html>\n" eq startpage()) { print "ok 2\n"; } else { print "not ok 2\n"; } # # Check that &gotopage returns proper value # if ("<META HTTP-EQUIV=Refresh CONTENT=\"0;URL=http:foo\">" eq gotopage('foo')) { print "ok 3\n"; } else { print "not ok 3\n"; } # # skipping &startmenu for now # # # skipping &endmenu for now # # ensure &mktablehdr returns a proper value # if ("<table border=0 cellspacing=0 cellpadding=5>\n" eq mktablehdr()) { print "ok 4\n"; } else { print "not ok 4\n"; } # # ensure &mktablerow returns a proper value # # 1 row, no background image if ("<tr valign=top bgcolor=red><td>text</td></tr>\n" eq mktablerow(1,'red','text','')) { print "ok 5\n"; } else { print "not ok 5\n"; } # 1 row, background image if ("<tr valign=top bgcolor=red><td background=\"foo.jpg\">text</td></tr>\n" eq mktablerow(1,'red','text','foo.jpg')) { print "ok 6\n"; } else { print "not ok 6\n"; } Index: testKoha.pl =================================================================== RCS file: /cvsroot/koha/koha/testKoha.pl,v retrieving revision 1.1.2.1 retrieving revision 1.1.2.2 diff -C2 -r1.1.2.1 -r1.1.2.2 *** testKoha.pl 24 Apr 2002 22:08:10 -0000 1.1.2.1 --- testKoha.pl 25 Apr 2002 14:49:32 -0000 1.1.2.2 *************** *** 6,7 **** --- 6,8 ---- # please add many tests here runtests 'koha.t'; + runtests 'output.t';

1 0

CVS: koha koha.t,1.1.2.1,1.1.2.2
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv19015 Modified Files: Tag: rel-1-2 koha.t Log Message: quick fixup to tests Index: koha.t =================================================================== RCS file: /cvsroot/koha/koha/koha.t,v retrieving revision 1.1.2.1 retrieving revision 1.1.2.2 diff -C2 -r1.1.2.1 -r1.1.2.2 *** koha.t 25 Apr 2002 13:58:09 -0000 1.1.2.1 --- koha.t 25 Apr 2002 14:48:12 -0000 1.1.2.2 *************** *** 20,39 **** # Check that &fixEthnicity returns correct values # ! if ('Maori' eq fixEthnicity('maori') { print "ok 3\n"; } else { print "not ok 3\n"; } ! if ('European/Pakeha' eq fixEthnicity('european') { print "ok 4\n"; } else { print "not ok 4\n"; } ! if ('Pacific Islander' eq fixEthnicity('pi') { print "ok 5\n"; } else { print "not ok 5\n"; } ! if ('Asian' eq fixEthnicity('asian') { print "ok 6\n"; } else { --- 20,39 ---- # Check that &fixEthnicity returns correct values # ! if ('Maori' eq fixEthnicity('maori')) { print "ok 3\n"; } else { print "not ok 3\n"; } ! if ('European/Pakeha' eq fixEthnicity('european')) { print "ok 4\n"; } else { print "not ok 4\n"; } ! if ('Pacific Islander' eq fixEthnicity('pi')) { print "ok 5\n"; } else { print "not ok 5\n"; } ! if ('Asian' eq fixEthnicity('asian')) { print "ok 6\n"; } else {

1 0

CVS: koha ChangeLog,1.1,1.1.2.1
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv30153 Modified Files: Tag: rel-1-2 ChangeLog Log Message: Index: ChangeLog =================================================================== RCS file: /cvsroot/koha/koha/ChangeLog,v retrieving revision 1.1 retrieving revision 1.1.2.1 diff -C2 -r1.1 -r1.1.2.1 *** ChangeLog 20 Apr 2002 03:39:30 -0000 1.1 --- ChangeLog 25 Apr 2002 13:59:37 -0000 1.1.2.1 *************** *** 1,2 **** --- 1,6 ---- + 2002-04-25 06:57 pate + + * koha.t: added fixEthnicity tests + 2002-04-17 14:35 pate

1 0

CVS: koha koha.t,1.1,1.1.2.1
by Pat Eyler 25 Apr '02

25 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv29710 Modified Files: Tag: rel-1-2 koha.t Log Message: added fixEthnicity tests Index: koha.t =================================================================== RCS file: /cvsroot/koha/koha/koha.t,v retrieving revision 1.1 retrieving revision 1.1.2.1 diff -C2 -r1.1 -r1.1.2.1 *** koha.t 8 Apr 2002 23:44:43 -0000 1.1 --- koha.t 25 Apr 2002 13:58:09 -0000 1.1.2.1 *************** *** 1,3 **** ! BEGIN { $| = 1; print "1..2\n"; } END {print "not ok 1\n" unless $loaded;} use C4::Koha; --- 1,3 ---- ! BEGIN { $| = 1; print "1..6\n"; } END {print "not ok 1\n" unless $loaded;} use C4::Koha; *************** *** 5,8 **** --- 5,11 ---- print "ok 1\n"; + # + # test that &slashifyDate returns correct (non-US) date + # $date = "01/01/2002"; $newdate = &slashifyDate("2002-01-01"); *************** *** 12,14 **** --- 15,41 ---- } else { print "not ok 2\n"; + } + + # + # Check that &fixEthnicity returns correct values + # + if ('Maori' eq fixEthnicity('maori') { + print "ok 3\n"; + } else { + print "not ok 3\n"; + } + if ('European/Pakeha' eq fixEthnicity('european') { + print "ok 4\n"; + } else { + print "not ok 4\n"; + } + if ('Pacific Islander' eq fixEthnicity('pi') { + print "ok 5\n"; + } else { + print "not ok 5\n"; + } + if ('Asian' eq fixEthnicity('asian') { + print "ok 6\n"; + } else { + print "not ok 6\n"; }

1 0

Project Management
by Nicholas Rosasco 25 Apr '02

25 Apr '02

In the interests of getting everyone on the same page.... as I will, with Chris's blessing, attempt to bring order from (minor) chaos. For the sake of clarity and forward progress: In the wiki... (which is truly one of the best collab. doc. tools I've seen): So at least I know where to look Major features and notes about how to implement them live on the http://www.saas.nsw.edu.au/wiki/index.php?page=KohaFeatureRequests page. Who is actually writing a feature them lives in the RoadMap (http://www.saas.nsw.edu.au/wiki/index.php?page=KohaRoadmap) Also -- As you write it, please document what you are doing in the code, as well. Which version a new feature appears in goes into the RoadMap. When a bug is fixed, a note about it goes into the Roadmap. Try to keep a running note in the roadmap as to where you are with stuff -- nothing complex, on the order of "need to fix a few more things, then I'm done". When a version is released (ie, ceases to be listed as DEVEL), that versions chunk of the Roadmap becomes the Changelog. Things needed answers (from Chris, in particular) should probably go in the ToDo list. I'd suggest you put recent questions on top. You might also email them to Chris with a header like 'Koha Need Answer' in the subject line at the same time. If you have a brilliant feature idea... put it in FeatureRequest and I [Nick] will try to be sure that that it moves into the RoadMap list in some sort of semilogical fashion -- we're all trying to get too many things in at once. 'Nick Place This' in the subj. line of an email to me (nrosasco(a)acm.org) might be a good idea to make sure I see it. I suggest we all try to hold to this way of tracking things so that we don't step on each other, and to use CVS as much as logically possible so everyone can see where the code is. If you have a "personal version" of Koha please either upload with a label as to what it is, or (maybe better) send it to Chris and have him look at it -- I count 2 to 4 derivative or personal versions out there. Nick

2 1

Re: [Koha-devel] CVS branched
by Chris Cormack 25 Apr '02

25 Apr '02

On Wed, Apr 24, 2002 at 06:14:32PM -0400, Pat Eyler said: > > Important Note: > > We should use the rel-1-2 branch to do the bug-fix and clean up leading to > the 1.1.2 release ... the main trunk is where development leading to 1.2, > 1.3 and beyond should always happen. As we get ready to release a new > version, we'll branch it and start stabilizing on the branch. > Ahh yes Whoops sorry about, Thats a much better way of doing it. Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

2 1