April 2002 - Koha-devel - lists.koha-community.org

CVS: koha moremember.pl,1.10,1.11
by Pat Eyler 15 Apr '02

15 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv14378 Modified Files: moremember.pl Log Message: moved ethnicity fixups into C4::Koha, eventually to be replaced with a better (non-NZ specific) solution. Index: moremember.pl =================================================================== RCS file: /cvsroot/koha/koha/moremember.pl,v retrieving revision 1.10 retrieving revision 1.11 diff -C2 -r1.10 -r1.11 *** moremember.pl 8 Apr 2002 23:44:43 -0000 1.10 --- moremember.pl 15 Apr 2002 16:17:21 -0000 1.11 *************** *** 1,11 **** #!/usr/bin/perl ! #script to do a borrower enquiery/brin up borrower details etc ! #written 20/12/99 by chris(a)katipo.co.nz ! #Displays all the detailas about a borrower ! #needs html removed and to use the C4::Output more, but its tricky ! #last modified 21/1/2000 by chris(a)katipo.co.nz ! #modifiecd 31/1/2001 by chris(a)katipo.co.nz to not allow items on request ! #to be renewed use strict; use C4::Output; --- 1,14 ---- #!/usr/bin/perl ! # script to do a borrower enquiry/bring up borrower details etc ! # Displays all the details about a borrower ! # written 20/12/99 by chris(a)katipo.co.nz ! # last modified 21/1/2000 by chris(a)katipo.co.nz ! # modified 31/1/2001 by chris(a)katipo.co.nz ! # to not allow items on request to be renewed ! # ! # needs html removed and to use the C4::Output more, but its tricky ! # ! use strict; use C4::Output; *************** *** 22,31 **** - # FIXME - # this hash is never assigned, though it is used (as a placeholder?) - # - my %env; - print $input->header; #start the page and read in includes print startpage(); --- 25,30 ---- print $input->header; + #start the page and read in includes print startpage(); *************** *** 38,69 **** $data->{'dateofbirth'} = slashifyDate($data->{'dateofbirth'}); ! # FIXME ! # turn the ethnicity into a function and make it generalizable ! # check these files to see if one convention or the other makes sense ! # boraccount.pl ! # imemberentry.pl ! # jmemberentry.pl ! # mancredit.pl ! # maninvoice.pl ! # member.pl ! # memberentry.pl ! # moremember.pl ! # moremember.pl ! # pay.pl ! # placerequest.pl ! # readingrec.pl ! # ! if ($data->{'ethnicity'} eq 'maori'){ ! $data->{'ethnicity'} = 'Maori'; ! } ! if ($data->{'ethnicity'}eq 'european'){ ! $data->{'ethnicity'} = 'European/Pakeha'; ! } ! if ($data->{'ethnicity'}eq 'pi'){ ! $data->{'ethnicity'} = 'Pacific Islander'; ! } ! if ($data->{'ethnicity'}eq 'asian'){ ! $data->{'ethnicity'} = 'Asian'; ! } print <<printend --- 37,41 ---- $data->{'dateofbirth'} = slashifyDate($data->{'dateofbirth'}); ! $data->{'ethnicity'} = fixEthnicity($data->{'ethnicity'}); print <<printend

1 0

Upcoming emails from Nicholas
by Chris Cormack 15 Apr '02

15 Apr '02

Hi All This is just a bit of a heads up. Ive asked Nick to help me with coordinating Koha work a bit more. Now we have a few ppl actively working on the code, im finding im loosing track of who is working on what, etc. So I think Nick is going to email around, find out what everyones up to, and build some kinda status report, and make some suggestions in how to move forward. A suggestion he has made already, which I think has merit, is creating a development/stable situation. So we have a stable release cvs tree , and bugfixes and tidy ups get added to that. While we work on new features in the development tree. When new features become stable and tested enuff, we shift them into the stable tree and do a new release. Also I feel we need to be doing more regular releases, so that bugfixes are getting out into the public. Any other suggestions gratefully accepted. Oh, an idea ive just had myself, playing with Roger's wiki to work on the install, I think this is a good way to work on collaborative documentation. Perhaps we could put todo list type things up there, that ppl could add/modify to? Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

4 5

Method of setting path to koha.conf
by Roger Buck 15 Apr '02

15 Apr '02

Noticed that current CVS version of C4/Database.pm includes a hard-coded path to koha.conf. (I think) that would create a problem if a non default path to koha.conf is specified in Output.pm? Should the method of setting path-to-koha.conf be changed? R.

1 0

CVS: koha/acqui addorder.pl,1.2,1.3
by Gynn Lomax 15 Apr '02

15 Apr '02

Update of /cvsroot/koha/koha/acqui In directory usw-pr-cvs1:/tmp/cvs-serv23750/acqui Modified Files: addorder.pl Log Message: Acquisitions::newbiblioitem updated to be usable for new acqui.simple addorder.pl and updatebibitem.pl modified to use new newbiblioitem Index: addorder.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui/addorder.pl,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -r1.2 -r1.3 *** addorder.pl 10 Apr 2002 05:47:07 -0000 1.2 --- addorder.pl 15 Apr 2002 05:33:33 -0000 1.3 *************** *** 48,55 **** if ($existing eq 'no'){ #if it doesnt create it ! $bibnum=newbiblio({ title => $title, ! author =>$author, ! copyright => $copyright }); ! $bibitemnum=newbiblioitem($bibnum,$itemtype,$isbn); newsubtitle($bibnum); modbiblio($bibnum,$title,$author,$copyright,$series); --- 48,57 ---- if ($existing eq 'no'){ #if it doesnt create it ! $bibnum = &newbiblio({ title => $title, ! author =>$author, ! copyright => $copyright }); ! $bibitemnum = &newbiblioitem({ biblionumber => $bibnum, ! itemtype => $itemtype, ! isben => $isbn }); newsubtitle($bibnum); modbiblio($bibnum,$title,$author,$copyright,$series);

1 0

CVS: koha updatebibitem.pl,1.3,1.4
by Gynn Lomax 15 Apr '02

15 Apr '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv23750 Modified Files: updatebibitem.pl Log Message: Acquisitions::newbiblioitem updated to be usable for new acqui.simple addorder.pl and updatebibitem.pl modified to use new newbiblioitem Index: updatebibitem.pl =================================================================== RCS file: /cvsroot/koha/koha/updatebibitem.pl,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** updatebibitem.pl 12 Feb 2002 21:07:53 -0000 1.3 --- updatebibitem.pl 15 Apr 2002 05:33:33 -0000 1.4 *************** *** 84,88 **** my $loan; if ($flag eq 'notall' && $flag2 eq 'leastone'){ ! $bibitemnum=newbiblioitem($bibnum,$itemtype,$volumeddesc,$classification); modbibitem($bibitemnum,$itemtype,$isbn,$publishercode,$publicationdate,$classification,$dewey,$subclass,$illus,$pages,$volumeddesc,$notes,$size,$place); if ($itemtype =~ /REF/){ --- 84,91 ---- my $loan; if ($flag eq 'notall' && $flag2 eq 'leastone'){ ! $bibitemnum = &newbiblioitem({ biblionumber => $bibnum, ! itemtype => $itemtype, ! volumeddesc => $volumeddesc, ! classification => $classification }); modbibitem($bibitemnum,$itemtype,$isbn,$publishercode,$publicationdate,$classification,$dewey,$subclass,$illus,$pages,$volumeddesc,$notes,$size,$place); if ($itemtype =~ /REF/){

1 0

CVS: koha/C4 Acquisitions.pm,1.3,1.4
by Gynn Lomax 15 Apr '02

15 Apr '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv23750/C4 Modified Files: Acquisitions.pm Log Message: Acquisitions::newbiblioitem updated to be usable for new acqui.simple addorder.pl and updatebibitem.pl modified to use new newbiblioitem Index: Acquisitions.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Acquisitions.pm,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** Acquisitions.pm 10 Apr 2002 05:49:17 -0000 1.3 --- Acquisitions.pm 15 Apr 2002 05:33:33 -0000 1.4 *************** *** 18,22 **** &findall &needsmod &delitem &delbibitem &delbiblio &delorder &branches &getallorders &getrecorders &updatecurrencies &getorder &getcurrency &updaterecorder ! &updatecost &checkitems &modnote); %EXPORT_TAGS = ( ); # eg: TAG => [ qw!name1 name2! ], --- 18,22 ---- &findall &needsmod &delitem &delbibitem &delbiblio &delorder &branches &getallorders &getrecorders &updatecurrencies &getorder &getcurrency &updaterecorder ! &updatecost &checkitems &modnote &getitemtypes &getbiblio); %EXPORT_TAGS = ( ); # eg: TAG => [ qw!name1 name2! ], *************** *** 546,565 **** sub newbiblioitem { ! my ($bibnum,$itemtype,$isbn,$volinf,$class)=@_; ! my $dbh=C4Connect; ! my $query="Select max(biblioitemnumber) from biblioitems"; ! my $sth=$dbh->prepare($query); $sth->execute; ! my $data=$sth->fetchrow_arrayref; ! my $bibitemnum=$$data[0]; ! $bibitemnum++; $sth->finish; ! $query="insert into biblioitems (biblionumber,biblioitemnumber, ! itemtype,isbn,volumeddesc,classification) ! values ! ($bibnum,$bibitemnum,'$itemtype','$isbn','$volinf','$class')"; ! $sth=$dbh->prepare($query); ! # print $query; $sth->execute; $sth->finish; $dbh->disconnect; --- 546,603 ---- sub newbiblioitem { ! my ($biblioitem) = @_; ! my $dbh = C4Connect; ! my $query = "Select max(biblioitemnumber) from biblioitems"; ! my $sth = $dbh->prepare($query); ! my $data; ! my $bibitemnum; ! ! $biblioitem->{'volume'} = $dbh->quote($biblioitem->{'volume'}); ! $biblioitem->{'number'} = $dbh->quote($biblioitem->{'number'}); ! $biblioitem->{'classification'} = $dbh->quote($biblioitem->{'classification'}); ! $biblioitem->{'itemtype'} = $dbh->quote($biblioitem->{'itemtype'}); ! $biblioitem->{'isbn'} = $dbh->quote($biblioitem->{'isbn'}); ! $biblioitem->{'issn'} = $dbh->quote($biblioitem->{'issn'}); ! $biblioitem->{'dewey'} = $dbh->quote($biblioitem->{'dewey'}); ! $biblioitem->{'subclass'} = $dbh->quote($biblioitem->{'subclass'}); ! $biblioitem->{'publicationyear'} = $dbh->quote($biblioitem->{'publicationyear'}); ! $biblioitem->{'publishercode'} = $dbh->quote($biblioitem->{'publishercode'}); ! $biblioitem->{'volumedate'} = $dbh->quote($biblioitem->{'volumedate'}); ! $biblioitem->{'volumeddesc'} = $dbh->quote($biblioitem->{'volumeddesc'}); $biblioitem->{'illus'} = $dbh->quote($biblioitem->{'illus'}); ! $biblioitem->{'pages'} = $dbh->quote($biblioitem->{'pages'}); ! $biblioitem->{'notes'} = $dbh->quote($biblioitem->{'notes'}); ! $biblioitem->{'size'} = $dbh->quote($biblioitem->{'size'}); ! $biblioitem->{'place'} = $dbh->quote($biblioitem->{'place'}); ! $sth->execute; ! $data = $sth->fetchrow_arrayref; ! $bibitemnum = $$data[0] + 1; ! $sth->finish; ! ! $query = "insert into biblioitems set ! biblioitemnumber = $bibitemnum, ! biblionumber = $biblioitem->{'biblionumber'}, ! volume = $biblioitem->{'volume'}, ! number = $biblioitem->{'number'}, ! classification = $biblioitem->{'classification'}, ! itemtype = $biblioitem->{'itemtype'}, ! isbn = $biblioitem->{'isbn'}, ! issn = $biblioitem->{'issn'}, ! dewey = $biblioitem->{'dewey'}, ! subclass = $biblioitem->{'subclass'}, ! publicationyear = $biblioitem->{'publicationyear'}, ! publishercode = $biblioitem->{'publishercode'}, ! volumedate = $biblioitem->{'volumedate'}, ! volumeddesc = $biblioitem->{'volumeddesc'}, ! illus = $biblioitem->{'illus'}, ! pages = $biblioitem->{'pages'}, ! notes = $biblioitem->{'notes'}, ! size = $biblioitem->{'size'}, ! place = $biblioitem->{'place'}"; ! ! $sth = $dbh->prepare($query); $sth->execute; + $sth->finish; $dbh->disconnect; *************** *** 580,590 **** sub newsubtitle { ! my ($bibnum)=@_; ! my $dbh=C4Connect; ! my $query="insert into bibliosubtitle (biblionumber) values ! ($bibnum)"; ! my $sth=$dbh->prepare($query); ! # print $query; $sth->execute; $sth->finish; $dbh->disconnect; --- 618,631 ---- sub newsubtitle { ! my ($bibnum, $subtitle) = @_; ! my $dbh = C4Connect; ! $subtitle = $dbh->quote($subtitle); ! my $query = "insert into bibliosubtitle set ! biblionumber = $bibnum, ! subtitle = $subtitle"; ! my $sth = $dbh->prepare($query); ! $sth->execute; + $sth->finish; $dbh->disconnect; *************** *** 1026,1034 **** $sth->finish; } $sth->finish; $dbh->disconnect; } ! END { } # module clean-up code here (global destructor) --- 1067,1117 ---- $sth->finish; } + $sth->finish; $dbh->disconnect; } ! sub getitemtypes { ! my $dbh = C4Connect; ! my $query = "select * from itemtypes"; ! my $sth = $dbh->prepare($query); ! # || die "Cannot prepare $query" . $dbh->errstr; ! my $count = 0; ! my @results; + $sth->execute; + # || die "Cannot execute $query\n" . $sth->errstr; + while (my $data = $sth->fetchrow_hashref) { + @results[$count] = $data; + $count++; + } # while + + $sth->finish; + $dbh->disconnect; + return($count, @results); + } # sub getitemtypes + + + sub getbiblio { + my ($biblionumber) = @_; + my $dbh = C4Connect; + my $query = "Select * from biblio where biblionumber = $biblionumber"; + my $sth = $dbh->prepare($query); + # || die "Cannot prepare $query" . $dbh->errstr; + my $count = 0; + my @results; + + $sth->execute; + # || die "Cannot execute $query" . $sth->errstr; + while (my $data = $sth->fetchrow_hashref) { + $results[$count] = $data; + $count++; + } # while + $sth->finish; + $dbh->disconnect; + return($count, @results); + } # sub getbiblio + + + END { } # module clean-up code here (global destructor)

1 0

Member Authentication via Internet
by Roger Buck 13 Apr '02

13 Apr '02

I understand that Koha web services are on the agenda but have need for something more immediate. Despite this being a quick and dirty, would obviously be preferable if our work here could help support the main stream development. Current Situation: A school (Department of Education and Training, New South Wales) library specialising in education resources for kids with learning difficulties. The library is only staffed 3 days per week and most borrowing is currently done via fax, postal mail and telephone. Most borrowers are teachers and/or librarians (around 4,000 items and 1,500 borrowers). Our most immediate need is for borrowers to reserve items via Internet for issue (mostly) via postal service. To that end, we need two discrete levels of user access to OPAC services: 1. Public - browse only 2. Members - Registered members authenticated via login using personal username + password (NOT barcode). Members need to browse OPAC and make on-line requests. Currently, getting the service up and running is main priority. Security of user data is non critical as the server will initially only require population of resources database + user authentication data. The full libaray database will not (yet) be exported to koha. What I have done: Isolated a sub-set of the koha *.pl files to provide a working "development" environment for above. on-line opac files are: subjectsearch.pl detail.pl modrequest.pl renewscript.pl reservereport.pl login.pl moredetail.pl request.pl search.pl moremember.pl soupermail Most of the above have been minimally hacked - mostly to simplify the user interface and remove admin features. I have merged request.pl and placerequest.pl I have created a login script to handle authentication login.pl I have added javascript to opac-top.in to handle extended use of cookies for authentication and tracking. I am using "soupermail" ( soupermail.sourceforge.net ) for handling of email requests. All of the above has been done to enable testing and proof of concept. I now need to modify tables for authentication. I was thinking of adding "loginname" and "password" to "borrowers" (the existing "users" table doesn't seem to be appropriate to do that?). Have the devel team given any consideration to how Internet authentication to opac may be handled? Any general suggestions or guidelines so that I don't stray too far away from the intended approach (I assuming my own hacks will only be required short term - until these features are part of the main koha distro.) Also, I'd obviously like to make whatever I do useful to the project. I am only a perl beginner so not proposing any of the above would be useful for the "official" development effort... but still very keen to help in whatever way you might think would be most productive. _Any_ feedback very gratefully appreciated. Thanks. R.

1 0

CVS: koha/C4 Search.pm,1.17,1.18
by Chris Cormack 11 Apr '02

11 Apr '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv29372/C4 Modified Files: Search.pm Log Message: Fixing the subject search i broke ;) Index: Search.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Search.pm,v retrieving revision 1.17 retrieving revision 1.18 diff -C2 -r1.17 -r1.18 *** Search.pm 10 Apr 2002 07:59:28 -0000 1.17 --- Search.pm 10 Apr 2002 09:55:17 -0000 1.18 *************** *** 671,675 **** my $subclass; my $true=0; ! if (($dewey, $subclass) = $sti->fetchrow){ $true=1; } --- 671,675 ---- my $subclass; my $true=0; ! if (($dewey, $subclass) = $sti->fetchrow || $type eq 'subject'){ $true=1; } *************** *** 793,797 **** $i++; } ! $sth->finish; $dbh->disconnect; return(@results); --- 793,810 ---- $i++; } ! $sth->finish; ! my $query2="Select * from aqorders where biblionumber=$biblionumber"; ! my $sth2=$dbh->prepare($query2); ! $sth2->execute; ! my $data; ! my $ocount; ! if ($data=$sth2->fetchrow_hashref){ ! $ocount=$data->{'quantity'} - $data->{'quantityreceived'}; ! if ($ocount > 0){ ! $results[$i]="$data->{'title'}\t$data->{'barcode'}\t$ocount\tOn Order\t\t$data->{'itemnumber'}\t$data->{'itemtype'}\t\t$data->{'biblioitemnumber'}\t$data->{'volumeddesc'}"; ! } ! } ! $sth2->finish; ! $dbh->disconnect; return(@results); *************** *** 855,861 **** my ($bibnum,$type)=@_; my $dbh=C4Connect; ! my $query="Select *,biblio.notes from biblio,biblioitems,bibliosubtitle where biblio.biblionumber=$bibnum ! and biblioitems.biblionumber=$bibnum and ! (bibliosubtitle.biblionumber=$bibnum)"; # print $query; my $sth=$dbh->prepare($query); --- 868,878 ---- my ($bibnum,$type)=@_; my $dbh=C4Connect; ! my $query="Select *,biblio.notes ! from biblio,biblioitems ! left join bibliosubtitle on ! biblio.biblionumber=bibliosubtitle.biblionumber ! ! where biblio.biblionumber=$bibnum ! and biblioitems.biblionumber=$bibnum"; # print $query; my $sth=$dbh->prepare($query);

4 3

CVS: koha-html/intranet-html/images front-admin.gif,NONE,1.1 front-mouseover-admin.gif,NONE,1.1 front-circulation.gif,1.1.1.1,1.2 koha-front-background.gif,1.1.1.1,1.2
by Paul POULAIN 10 Apr '02

10 Apr '02

Update of /cvsroot/koha/koha-html/intranet-html/images In directory usw-pr-cvs1:/tmp/cvs-serv11610/images Modified Files: front-circulation.gif koha-front-background.gif Added Files: front-admin.gif front-mouseover-admin.gif Log Message: added /admin/ links on index.html page --- NEW FILE --- GIF89ao% + Š.€.ox"37¡-fk|%<?--oq ,,*(,{|$\]RS ÍÎ WY[^a×ØÙ×2D?5œàáâãäåæçèéêëìŸ4íðñòóôõö÷7994üü3ÿ0bÄ" 0 S¡³gÍ¢¢ö%ÄgØP â£G`Â°b!,þ[*^{J·Ùµ(&2»É·¯_.ÿ Lž°á;}"Ê°šÑ£nÁ[·²](DjèÛÌ¹³çÏ CMºŽéÑ3h^Íºµë×°cËÝ¯ö¯À`$HÌBCBte6ËÈ¯Yòµ¹sO§KN=ë¬ëaÅ-Xa1$kÔÊÈSñÐ!šû÷ðãËO¿ŸýûøëK¿¿ÿÿ XábTh¹eSXâ¢6êè£¡ÈwhP2 45aZa6hàÓš€b Í5¥Šªêª¬¶êê«°ÇA¬ŽÖjëžæªë®¹ràëbAí§à:£ÅZvÍ>4ëì³ÎÒNkíµØfkmµÚvë³7ôðížäkî¹èŠ«îºÓîâ./Ÿ PØ÷S ~*æ_žæØü®øä/ùðÇ':ç©7ïüóÐG/ýó¬äºZ?Éî 3|ßNšþY Úa}6Ùp¯mŸ6iï6ØgÏ-ÿüJúñ Ç Líý÷/O}\&í1ûÌ@2Ð lÙÒ&HÁ Zð ÆÂþk{a fÂáË¡wÈÃúP;ËEYxñåM<ºW@ x[ÛzÖ5Å*V«R©E.zñÔ2WžØEÆ2ñhLã³ÞÅ}xG2hw¬%2ñxUZ Sõd£ê# ùÇ@U>ÁF"YÈC2V¯&IÉJZòTÌ¯Þþ kBv!š@¿RòšänQ³|ÇRõbFõ¿k\ *X4§IÍ Á ØÌŠ6·ÉM5) i8GÚACPŽìÛ5ŠÀTCî'*EtûyEÉÔpŽ F œæ©PKßÕªZõªI2£Ìšg0ATª¬0DA TÑšZ×ÊÖ«¬% )}uHÀ^ Q«mc%è à.à l \ÀÈ --- NEW FILE --- GIF89ao% «ÕX®×] ÆV|Ccz6¥LžÜq¹Ütš]¿ß³Ñx§ÃpJU5¹Ó]ÉäÄÞœÖÆ1Ì3»/Í8Î<Ï@©5EX¡ÐC¡ÐD¢ÑE£ÑG€ÒI£ÑHÅDv4¥ÒJ¥ÒLŠÓMžC§ÓOYp*šÔQ§ÓPšÓQ©ÔSªÕU°×a)2³Ùg¶Úm·Ûo©ÉfžÛq¹Üs»ÝvºÜu®ÎnœÞ{ÁàÃá5=%ÅâÆâÇãÈãÉä±Ç§lkyNÉãÊä€¹y² 9GpYw% 64.(&!B|è@°`Bº<Š¡Ã Xx $3jÂ1H?~@ðÁÇéuürdÉ(WIÒdL,iŸŒéqŠK73vìÙ²&L8}*³èÎCsþ<UéSšMuò ªiR§@rêuìR¬_µRÍJ§T£þ÷tàË§ÏF -R "4dáËÃ-#~hÀJ0"KL².2»\¹òeÍ;Kþ¬sgÒM{Æ\ZŽkÔ¡EÃVœ4íÉ³_³NíóîËa÷Î-û÷mÜÆuÛVÞyêÍ,X Hqâúýû¡{àœ0tž¥ #J dF>€8N¥@.9ãY¹¢ZÖHŠ*IåR¢fÁ¥&u×ñÕ×vÝQXá Æçuøá 0b{a`A!5êè£B0IVÚÒ€<Xêš€>Pª©H~ j§Z)§jj©®*ª«úê€Ò:+©·Šªª¬»â«¯¿ÖdR\rÑµ0° |ù¥'!OdH Vû¡8dÁaCß¡J'ó5€Iã.··d'æÒnºàÂ.'äv[_CéÖçî»œØ7/Ÿê^Â.5÷Â{p%æ°¿ ðžöþñoŒ8ÌÆ£ÛPŸói\pÈLrº¿$(âSW²'4kÐ ^øY@ ï£Ï@TÁ È¢²Å0tñ\£³ø-±\£ÃÈF/¶Ño$ãÓ8G7quü¢ïF>Êñqü#éH;Ò€#ßH=R}Äc!É3ZòÌ€mþ°x²@\ ,ë4;EŽ@C¶p9Tåß§3Ï®!GØÀô§»Ü-yÍ£ó|iºèe{Ä$]0y<`&³zÇì%2×LÞaïy»#Ç¹Íã-sŒÜ^2°RÈ#<ÀÇ>€~Öµ`ËX^YØÐ« :Ñq@ÊHÇ h ºP2šCJÑ&Ô¡mèE+Jt µhP ¡#hH%zQŽ£+E)@I Ò*ôŠ5ý(N/ ÓÊ4:=õhDBÒ¶T:%ÅšRºÔŠô©O¥uêþí B^Hß ^ÙÄzÖóãÜÎà'Là¬pZÕÖ0µ!m]«[ã*×·º®h¥+^áº×¹Úõ¯åë\×žªµ¯zœë`ýØÆÖµ±U,dWÁJÖ°µle ÛVÆNö¯ElaGKÚÒŽCÇ<èžl4ÈvÕU¡ Q8€žÇ5nrÜ0(·žÊ]®s¡Ë\æ&Áºîu§kÝèr÷»Ï¥®s±Üí7ŒÍ=ïvµKÞãVŒæn|µ»ÞöÊ7»Ïín}ï«ßõú¿ê}Là ®à±2þt²íË@ÐyÎ³«ŒõªoK-*6$&±GLâøÄ(N±WÌâ»øÅ0±gãÐøÆ8^q Büµª>.OO+/á"_öYÃ0q:ùÉP²§Œ`RùÊõ99>uÞ³íÀ2dWÒ³È>2>lEžùÍp³çLç:ÛùÎxÎ³÷Ìç>ûùÏŽ Mh9÷ðÐZŽ ð¢;=NÌd&û0lO4ÛsÍXr ÍéN{úÓ µšGMê:/ RªT€íúFÅR°{Tš?õz×ÃîSì:mªÜçN÷ºÛýîxÏ»Þ÷Îw»Cþ5*U×JÀ³!ð6üq)VËÃýténW®k>c¿Š6ÃùÌØU^xæ2[7ìÒþôô)ç±¹|ŠGhB±-+ÌxÍu.~·Cf öþö·t@&8t žØø5€CrQ,næCBJ®ŠÞ¶~£9íç~;ÃOapÜbL¡g;¢×ÖÃyÓôM/þMÐ<×;Ïyš·<He 7èôZäfàás3 "q;àfÇ{A09ð !è¡ëñ3pœq_Ya9ceég e kylormévYkY@%U×ácWñ+`Çþ7-U©aPG !(99IQ©>` =áB¡«I§ £¥¡É©ù¶µùŽ¹¬® Á9ôP¢9ŒIížtu!ÊÒ~ñù°@±a N°?Ã Hã å2ç êyì1ëíÙòÉöYŸpàúÉ êÐòBðéüÙûùè© ïY öYñ01q¯Å¯u3SÖ)109 Index: front-circulation.gif =================================================================== RCS file: /cvsroot/koha/koha-html/intranet-html/images/front-circulation.gif,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -C2 -r1.1.1.1 -r1.2 Binary files /tmp/cvsz3I7xa and /tmp/cvscSPNWa differ Index: koha-front-background.gif =================================================================== RCS file: /cvsroot/koha/koha-html/intranet-html/images/koha-front-background.gif,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -C2 -r1.1.1.1 -r1.2 Binary files /tmp/cvs7DGhec and /tmp/cvsOh4fae differ

1 0

CVS: koha/C4 Search.pm,1.16,1.17
by Chris Cormack 10 Apr '02

10 Apr '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv30778/C4 Modified Files: Search.pm Log Message: Working on a fix to speed up title and author searches Index: Search.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Search.pm,v retrieving revision 1.16 retrieving revision 1.17 diff -C2 -r1.16 -r1.17 *** Search.pm 13 Mar 2002 07:36:49 -0000 1.16 --- Search.pm 10 Apr 2002 07:59:28 -0000 1.17 *************** *** 463,471 **** my $i=1; $query="select *,biblio.author,biblio.biblionumber from ! biblioitems,biblio left join additionalauthors on additionalauthors.biblionumber =biblio.biblionumber ! where biblioitems.biblionumber=biblio.biblionumber ! and ((biblio.author like '$key[0]%' or biblio.author like '% $key[0]%' or additionalauthors.author like '$key[0]%' or additionalauthors.author --- 463,470 ---- my $i=1; $query="select *,biblio.author,biblio.biblionumber from ! biblio left join additionalauthors on additionalauthors.biblionumber =biblio.biblionumber ! where ((biblio.author like '$key[0]%' or biblio.author like '% $key[0]%' or additionalauthors.author like '$key[0]%' or additionalauthors.author *************** *** 505,524 **** #or seriestitle like '%$search->{'title'}%')"; } ! if ($search->{'class'} ne ''){ ! my @temp=split(/\|/,$search->{'class'}); ! my $count=@temp; ! $query.= "and ( itemtype='$temp[0]'"; ! for (my $i=1;$i<$count;$i++){ ! $query.=" or itemtype='$temp[$i]'"; ! } ! $query.=") "; ! } ! if ($search->{'dewey'} ne ''){ ! $query.=" and dewey='$search->{'dewey'}' "; ! } ! if ($search->{'illustrator'} ne ''){ ! $query.=" and illus like '%".$search->{'illustrator'}."%' "; ! } ! $query.=" group by biblio.biblionumber"; } else { --- 504,508 ---- #or seriestitle like '%$search->{'title'}%')"; } ! $query.=" group by biblio.biblionumber"; } else { *************** *** 540,548 **** my $count=@key; my $i=1; ! $query="select * from biblio,biblioitems left join bibliosubtitle on biblio.biblionumber=bibliosubtitle.biblionumber where - biblioitems.biblionumber=biblio.biblionumber and (((title like '$key[0]%' or title like '% $key[0]%' or title like '% $key[0]')"; while ($i<$count){ --- 524,531 ---- my $count=@key; my $i=1; ! $query="select * from biblio left join bibliosubtitle on biblio.biblionumber=bibliosubtitle.biblionumber where (((title like '$key[0]%' or title like '% $key[0]%' or title like '% $key[0]')"; while ($i<$count){ *************** *** 563,581 **** } $query=$query."))"; - if ($search->{'class'} ne ''){ - my @temp=split(/\|/,$search->{'class'}); - my $count=@temp; - $query.= " and ( itemtype='$temp[0]'"; - for (my $i=1;$i<$count;$i++){ - $query.=" or itemtype='$temp[$i]'"; - } - $query.=")"; - } - if ($search->{'dewey'} ne ''){ - $query.=" and dewey='$search->{'dewey'}' "; - } - if ($search->{'illustrator'} ne ''){ - $query.=" and illus like '%".$search->{'illustrator'}."%' "; - } } } elsif ($search->{'class'} ne ''){ --- 546,549 ---- *************** *** 681,691 **** my $limit= $num+$offset; while (my $data=$sth->fetchrow_hashref){ ! my $sti=$dbh->prepare("select dewey,subclass from biblioitems where biblionumber=$data->{'biblionumber'}"); $sti->execute; ! my ($dewey, $subclass) = $sti->fetchrow; $dewey=~s/\.*0*$//; ($dewey == 0) && ($dewey=''); ($dewey) && ($dewey.=" $subclass"); $sti->finish; if ($count > $offset && $count <= $limit){ if ($type ne 'subject' && $type ne 'precise'){ --- 649,682 ---- my $limit= $num+$offset; while (my $data=$sth->fetchrow_hashref){ ! my $query="select dewey,subclass from biblioitems where biblionumber=$data->{'biblionumber'}"; ! if ($search->{'class'} ne ''){ ! my @temp=split(/\|/,$search->{'class'}); ! my $count=@temp; ! $query.= " and ( itemtype='$temp[0]'"; ! for (my $i=1;$i<$count;$i++){ ! $query.=" or itemtype='$temp[$i]'"; ! } ! $query.=")"; ! } ! if ($search->{'dewey'} ne ''){ ! $query.=" and dewey='$search->{'dewey'}' "; ! } ! if ($search->{'illustrator'} ne ''){ ! $query.=" and illus like '%".$search->{'illustrator'}."%' "; ! } ! #print $query; ! my $sti=$dbh->prepare($query); $sti->execute; ! my $dewey; ! my $subclass; ! my $true=0; ! if (($dewey, $subclass) = $sti->fetchrow){ ! $true=1; ! } $dewey=~s/\.*0*$//; ($dewey == 0) && ($dewey=''); ($dewey) && ($dewey.=" $subclass"); $sti->finish; + if ($true == 1){ if ($count > $offset && $count <= $limit){ if ($type ne 'subject' && $type ne 'precise'){ *************** *** 699,702 **** --- 690,694 ---- } $count++; + } } $sth->finish;

1 0