August 2011 - Koha-devel - lists.koha-community.org

Testing updatedatabase.pl changes
by Marcel de Rooy 10 Aug '11

10 Aug '11

Hi all, In order to test such changes, I normally make an edit like: $DBversion = "3.05.00.xxx"; if (1||C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do("UPDATE marc_subfield_structure SET kohafield = NULL WHERE tagfield = 952 AND tagsubfield = 'f' AND kohafield = 'items.coded_location_qualifier'"); print "Upgrade to $DBversion done (remove non-existant 'items.coded_location_qualifier' column)\n"; #SetVersion($DBversion); } Note the 1 in the if and the # before SetVersion. This prevents an error on the wrong comparison (string comparison is: lt) and also an XXX in my Koha testversion. I suppose that not everybody makes such changes and therefore some updatedatabase changes are not tested well ?? (I just had one at hand while signing off.) In patch 6536 I included the following lines to eliminate such changes for testing: @@ -4396,6 +4408,10 @@ sub TransformToNum { my $version = shift; # remove the 3 last . to have a Perl number $version =~ s/(.*\..*)\.(.*)\.(.*)/$1$2$3/; + # three X's at the end indicate that you are testing patch with dbrev + # change it into 999 + # prevents error on a < comparison between strings (should be: lt) + $version =~ s/XXX$/999/; return $version; } sub SetVersion { - my $kohaversion = TransformToNum(shift); + return if $_[0]=~ /XXX$/; + #you are testing a patch with a db revision; do not change version + my $kohaversion = TransformToNum($_[0]); if (C4::Context->preference('Version')) { my $finish=$dbh->prepare("UPDATE systempreferences SET value=? WHERE variable='Version'"); $finish->execute($kohaversion); My question is: Does anybody object to submitting this change as a separate patch in order to facilitate db rev testing? I think it is an advantage to leave the version as is when you are only testing the db rev. Thanks, Marcel

4 6

cannot to configure/install Koha via the Admin Page and cannot open Client Page
by Sangduen Pongput 09 Aug '11

09 Aug '11

Dear All, I had done as follow http://wiki.koha-community.org/wiki/Koha_on_Ubuntu with fresh ubuntu 10.10 but it cannot run Admin Page or client page . When I use http://127.0.1.1 it show -- It works as apache run but it don't have anything more than apache runing for http://127.0.1.1:8080 it show cannot find virtalhost How can I fix it. Thank for all to help Best regards, Sangduen Pongput Librarian The Secretariat of the Senate, Bureau of Parliamentary Studies, Library and Museum Group 4 U-Thong Nai Road, Dusit District, Bangkok 10300 THAILAND Tel +662 831 9313- 4 Mobile Phone +66 89 122 5347 Fax +662 831 9308 or +662 831 9314 m091225347(a)yahoo.com

2 1

Restricting access to acquisition baskets
by Edgar Fuß 09 Aug '11

09 Aug '11

Currently, while booksellers.pl tries to restrict a user's ability to view baskets, that's easily circumvented simply by altering the basketno CGI parameter to, e.g. baket.pl. I can think of three ways to close this security hole: 1. Check permissions in every script that deals with baskets. This would probably require an addition to C4::Auth. 2. Randomise basket numbers. 3. Add a random key to each basket that must be given as a CGI parameter (in addition to basketno) in order for a script to allow access to that basket. Please note that for my own part, I'm unaffected by this problem. I have only a single branch and allow access to all that branches' baskets anyway. Nevertheless, I would give implementing a fix a try if there is consensus on which way to go.

2 5

Duplicate records remain after being unstaged, cleaned
by Hartman, David W. - GBTS Library 09 Aug '11

09 Aug '11

Hello! I added book records (all original records), then when I imported some copy 2s, I noticed errors. I reversed the import but the duplicate records remained. They were supposed to be copy 2s, etc. but now they are in the catalog as multiple records. I did reverse the record import but the records have remained. When I try to manually delete them it says the record does not exist .. yet it shows up in the catalog... any ideas how to delete these records? Any help would be great. David

3 2

email_in.pl feature
by Paul Poulain 08 Aug '11

08 Aug '11

Hello, I see on http://www.bugzilla.org/docs/3.0/html/api/email_in.html that there is a feature to create a bug with an email, and this script does that. 2 questions: * is it activated on our bugzilla ? * how/where can I find this script and set it up on my laptop ? A 3rd question : is there such a feature for the wiki, that would let me create a page from an email ? How do I want that: I have a spreadsheet of 134 improvements being sponsored by a library and developed by BibLibre, and it would be a nightmare to enter all of this manually on both wiki & bugzilla ! -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

1 1

KohaCon11, a visa for India, but which one
by Paul Poulain 08 Aug '11

08 Aug '11

Hi Kousthuba & al, I think many countries are like France and need a visa to come to the KohaCon. What kind of visa should we request ? A tourist visa, and we don't say we're coming to a conference ? A conference visa (can you provide the requested invitation to the conference ?) ? a business visa (I don't think so: it's not related to any topic for the business visa) Thanks for your feedback. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

2 1

Re: [Koha-devel] Patch format
by Chris Cormack 07 Aug '11

07 Aug '11

On 1 August 2011 10:17, Edgar Fuß <ef(a)math.uni-bonn.de> wrote: >> If you use git format-patch and then git send-email to send it to the >> koha-patches mailing list. > Oh well, I'll try this tomorrow. It's past midnight in my timezone now. > >> that's not as nessecary the mailing list is the main place > Is that information somehow pushed back to bugzilla? Or how do I know someone already posted a patch to the list for a bug I would start to work on? > >> This is the way the other 147 developers do it > I don't quite think I would regard myself a Koha developer. > I'm sort of hopping from one Open Source project to another. So it's sometimes difficult for me to get accustomed to the project's bug reporting policy. However, Koha seems to be the first project I met preferring git patches git format-patch'ed git send-email'ed to a patches list. I'll try to get accustomed to that. Here are some good resources http://wiki.koha-community.org/wiki/Version_Control_Using_Git http://wiki.koha-community.org/wiki/Set_an_email_alias_for_Koha_patches http://wiki.koha-community.org/wiki/Sign_off_on_patches http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow Chris

5 11

eval "use Some::Module"
by Edgar Fuß 07 Aug '11

07 Aug '11

There are several places in Koha (I blindly copied one of them myself) that do eval "use Some::Module" without checking $@ afterwards. Not being a Perl expert myself, I thought that was some clever thing I didn't understand. I lately asked my personal Perl guru about it, and he replied is was plain broken. In fact, it leads to strange errors when sending an email to a bookseller fails. The relevant files are acqui/addorderiso2709.pl, acqui/basketgroup.pl and tools/inventory.pl. There is one correct use in t/db_dependent/lib/KohaTest.pm There is also this strange use of ``eval require'': BEGIN { # find Koha's Perl modules # test carefully before changing this use FindBin; eval { require "$FindBin::Bin/kohalib.pl" }; } all over the place. I can't make any sense out of this.

2 1

One final question ... mapping holdings .... 4 holdings??
by Hartman, David W. - GBTS Library 05 Aug '11

05 Aug '11

I am almost there .. I read online to use these mappings for local holdings (using MARCEDIT) .... when I do I get 4 holdings (see below) Barcode is mapped to 952$p Call number 952$o Item Type Code 952$y Location (branch) code 952$b From: David Hartman [mailto:hartmad@hotmail.com] Sent: Friday, August 05, 2011 5:27 PM To: Hartman, David W. - GBTS Library Subject: 4 holdings?? JUnit in action by Tahchiev, Peter</cgi-bin/koha/opac-search.pl?q=au:Tahchiev,%20Peter%20> Series: . 1Physical details: xxiv, 360 p. : ill. ; 24 cm.Subject(s): 1. JAVA (COMPUTER PROGRAM LANGUAGE)</cgi-bin/koha/opac-search.pl?q=su:1.%20JAVA%20COMPUTER%20PROGRAM%20LANGUAGE> | 2. OBJECT-ORIENTED PROGRAMMING (COMPUTER SCIENCE )</cgi-bin/koha/opac-search.pl?q=su:2.%20OBJECT-ORIENTED%20PROGRAMMING%20COMPUTER%20SCIENCE%20>Year: 2011 Tags from this library: No tags from this library for this title. * Holdings ( 4 )</cgi-bin/koha/opac-detail.pl?biblionumber=12601#holdings> * Title Notes</cgi-bin/koha/opac-detail.pl?biblionumber=12601#descriptions> * Comments ( 0 )</cgi-bin/koha/opac-detail.pl?biblionumber=12601#comments> Item type Location Call Number Status Date Due BT Library - FL Available 005.7 JAVA H18 (Browse Shelf</cgi-bin/koha/opac-detail.pl?biblionumber=12601&shelfbrowse_itemnumber=37513#shelfbrowser>) Available Available [/opac-tmpl/prog/itemtypeimg/bridge/book.gif] Books Available JUnit in action by Tahchiev, Peter</cgi-bin/koha/opac-search.pl?q=au:Tahchiev,%20Peter%20> Series: . 1Physical details: xxiv, 360 p. : ill. ; 24 cm.Subject(s): 1. JAVA (COMPUTER PROGRAM LANGUAGE)</cgi-bin/koha/opac-search.pl?q=su:1.%20JAVA%20COMPUTER%20PROGRAM%20LANGUAGE> | 2. OBJECT-ORIENTED PROGRAMMING (COMPUTER SCIENCE )</cgi-bin/koha/opac-search.pl?q=su:2.%20OBJECT-ORIENTED%20PROGRAMMING%20COMPUTER%20SCIENCE%20>Year: 2011 Tags from this library: No tags from this library for this title. * Holdings ( 4 )</cgi-bin/koha/opac-detail.pl?biblionumber=12601#holdings> * Title Notes</cgi-bin/koha/opac-detail.pl?biblionumber=12601#descriptions> * Comments ( 0 )</cgi-bin/koha/opac-detail.pl?biblionumber=12601#comments> Item type Location Call Number Status Date Due BT Library - FL Available 005.7 JAVA H18 (Browse Shelf</cgi-bin/koha/opac-detail.pl?biblionumber=12601&shelfbrowse_itemnumber=37513#shelfbrowser>) Available Available [/opac-tmpl/prog/itemtypeimg/bridge/book.gif] Books Available

2 4

Is there any way to delete recently added patrons?
by Hartman, David W. - GBTS Library 05 Aug '11

05 Aug '11

I made a mistake on a recent import of patrons that affected hundreds of records .. It looks like recently added patrons cannot be deleted .. So .. Can I delete the entire contents of the data file and start over with csv import. How can this be done? David W. Hartman Global Business Technology Strategy Library Team Disney 336N 407 828 4250 (8-222) FAX 407 828 4868

2 1