December 2017 - Koha-devel - lists.koha-community.org

Add a digest option for AUTO_RENEWALS Notice
by Owen Leonard 13 Dec '17

13 Dec '17

Is anyone currently working on, or have plans to work on Bug 19736, "Add a digest option for AUTO_RENEWALS Notice?" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736 -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org

1 0

Bug 18539 - Forbid Koha::Objects->find calls in list context
by Julian Maurice 13 Dec '17

13 Dec '17

Hi developers, I stumbled upon a line of code recently and I can't figure out why it has be done this way. I hope you can help me :) The line in question is in Koha::Objects::find: croak 'Cannot use "->find" in list context' if wantarray; I read the two bugs (18539 and 18179) and the link given by Jonathan but I still don't understand why the call in list context has been forbidden. Why not simply return undef (an explicit undef) when no records have be found ? It would work as expected in scalar and list contexts. Here is a possible rewrite of 'find' to better explain what I mean: sub find { my ( $self, @pars ) = @_; my $object = undef; @pars = grep { defined } @pars; if (@pars) { my $result = $self->_resultset()->find(@pars); if ($result) { $object = $self->object_class()->_new_from_dbic($result); } } return $object; } @a = Koha::Patrons->find('foo'); # would result in @a = (undef) {a => K::P->find('foo'), b => 'bar'}; # would result in {a => undef, b => 'bar'} Please tell me what you think. -- Julian Maurice <julian.maurice(a)biblibre.com> BibLibre

3 4

Bug 19767: serial-issues.pl unused?
by Owen Leonard 12 Dec '17

12 Dec '17

Bug 19767 - serial-issues.pl is unused and should be removed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 I think serial-issues.pl, serial-issues.tt, and serial-issues-full.tt are obsolete and should be removed. Does anyone know of any reason not to? -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org

5 5

SIG DIE in returns.pl
by Fridolin SOMERS 12 Dec '17

12 Dec '17

Hie, With plack when some code fails, there is always in log a reference to circ/returns.pl o_O at start of stack trace. I found that there is in this page : use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) }; Added by commit bb6277ffcc593685554112d770ac273c9efeda33 Bug 14464: Add ability to cancel waiting holds from checkin screen Is this for debug purpopse only ? Why only this page ? Should it be moved to plack.psgi ? Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre - software and system maintainer

6 6

error with Z39.50
by Johan Seyfferdt 11 Dec '17

11 Dec '17

Hello, sorry for asking another question We ran into another error this time with z39.50. We added several servers but when trying to use this service we get the following error. Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> at /usr/share/perl5/MARC/File/XML.pm line 568. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. Any help will be greatly appreciated! Johan

2 1

Koha 17.11.00 package / repository rollover
by Mirko Tietgen 11 Dec '17

11 Dec '17

Good news everyone, the Debian package for Koha 17.11.00 is now available from the community repository. With the new major release, the repository structure will change slightly. Koha 17.11 is now 'stable'. Koha 17.05 is now 'oldstable' Koha 16.11 is still maintained, but no futher Debian packages are provided. The last packaged version 16.11.14 is available from the 16.11 pocket of the repository. Koha 16.05 has had its last release two weeks ago and is no longer maintained. The final version 16.05.19 is now available from the 16.05 pocket of the repository. Please check the wiki for detailed apt configuration information: https://wiki.koha-community.org/wiki/Koha_on_Debian#Set_up_package_sources Have a nice weekend, Mirko

4 3

Patrons endpoint help needed
by Tomas Cohen Arazi 08 Dec '17

08 Dec '17

Hi everyone, I've submitted a patchset to bug 19784 [1]. This is my starting point for the umbrella bug (19774). Next endpoints to fix are /acquisitions/vendors, /cities, /holds and /illrequests. Those are easier IMHO. On the /patrons one, I already changed - borrowernumber -> patron_id - branchcode -> library_id - categorycode -> category_id The needed code for this (or any) attribute rename is already done. The remaining work is mostly adding the mappings we would like to add, to the _to_model and _to_api functions. I now need help from you on the parameter names (patrons have really misleading attribute names, and they don't match the UI most of the time). Please comment here, and preferably on the bug itself. If you contribute a patch for your proposed change, please add a test on the specific attribute on one of the GET tests too. We try to cover all the special cases with tests. Ah, snake case was picked at some point, so 'cardnumber' could become 'card_number', for example. Thanks for any input. [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

1 1

newbie would appreciate help!
by Johan Seyfferdt 08 Dec '17

08 Dec '17

Hello. Thank you for adding me to this mailing list. I have a question. I am a sysadmin in St Petersburg, Russia and we are in the process of moving to Koha. So I am a newbie :) I chosed the unimarc option as our database is in rusmarc. We have our database in .mrc format, it is about 27 000 books in cyrilic, english and german. I was able to setup koha import that database but the search function does not work. I did a lot of googling, i tried kooha 16.05, 16.11, 17.05 on Debain 8 and 9 but without avail... Any help will be truly appreciated! as i am truly stuck. Johan Seyfferdt

4 3

Update koha-misc4dev
by Jonathan Druart 07 Dec '17

07 Dec '17

Hi devs, If you are using the koha-misc4dev (in a devbox for instance), you should update it to use the new commit I have just pushed. It will fix an error caused by bug 19724 In a dev box: `cd /home/vagrant/misc4dev; git fetch origin; git rebase origin/master` should do the job Cheers, Jonathan

1 0

REST api: some needed changes / vote proposal
by Tomas Cohen Arazi 07 Dec '17

07 Dec '17

Hi everyone, we've moved forward with the REST api devs, and some decisions we made at the beginning should be dealt with now, before it is too late :-D Right now the so-called REST api consists in 5 endpoints. Vendors: - /acquisitions/vendors - /acquisitions/vendors/{vendor_id} Cities: - /cities - /cities/{cityid} Holds: - /holds - /holds/{reserve_id} Patrons: - /patrons - /patrons/{borrowernumber} Illrequests: - /illrequests When implementing the vendors endpoint, I followed the api first approach, which implies we first think of the api itself, and how it is going to be used, and then think about the implementation. The result is that the exposed attribute names don't match the DB columns (because we picked more meaningful names), and (for example) unused attributes aren't even exposed. When it comes to the previously integrated endpoints, they mostly mimick the DB structure and thus the external api consumers see things that are highly inconsistent: We call them holds, but the ID is reserve_id instead of just hold_id, same for borrowernumber instead of patron_id. New endpoints are being developed with this in mind, but the already implemented ones need to get fixed. As the REST api is already at its first stages I suggest we just change those attributes and notify on the release notes about the change, but it is worth being voted. So I added it to next's dev meeting agenda. It is an urgent decision, as some of fields that would be renamed, are FK for the new endpoints being developed. I hope everyone interested on this gets involved in the discussion on this thread, and we can move forward just voting on the dev meeting. Thanks in advance! -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

3 2