July 2018 - Koha-devel - lists.koha-community.org

Koha reports wiki
by Cab Vinton 22 Jul '18

22 Jul '18

Hi, All -- Apologies for the cross-posting. The clean up of the Reports wiki page appears to have got stalled out: https://wiki.koha-community.org/wiki/SQL_Reports_Library (Large no. of duplicate listings of reports for holds, patrons, & circulation (HPC), which also appear on corresponding pages -- https://wiki.koha-community.org/wiki/SQL_Reports_Holds, etc.) I've identified the reports on the main page that aren't cross-listed (19 in total). I'd like to relocate these & then delete all the listings under the HPC categories on the main page. I suspect these pages see a lot of use, however, so I don't want to barge in and inadvertently make things worse. Anything I should be aware of before jumping in? All best, Cab Vinton, Director Plaistow Public Library Plaistow, NH

4 10

Client-side git hooks
by David Cook 21 Jul '18

21 Jul '18

Hi all, How many of you are using client-side git hooks? That is, git hooks that are in your working directory. A while ago, I added a "pre-commit" git hook in my Koha git working directory, which runs a little Python script every time I make a commit. It's nothing fancy. Basically it gets a list of all the files I'm changing in Git and for a ".pl" or a ".pm" file, it runs "perl -c", which compiles the Perl code without running it (with a caveat about BEGIN{} blocks which do get run at compile time so could be a problem if you're running untrusted code especially as a privileged user.). The Python script gets the exit code of that operation, and if there's an error, it uses an exit code of 1 itself and prevents the commit from happening. I've attached some sample code to the bottom of this email under "__PYTHON_SCRIPT__". I find that it's a nice way of catching errors. Maybe you write some code and you don't think you need to test it, or you tested it but you made a last minute change and that last minute change has a typo. this catches that kind of things - at least if it's an error which prevents successful compilation. Anyway, I was just porting a patch between different versions of Koha, and everything looked good at a glance and the code merge was successful, but the commit failed because one variable name in one line of the many lines changed was slightly different. The error messages told me exactly where to go and then it was obvious what the problem was and what to do. Anyway, I just thought I'd share that. Maybe everyone is already using client-side git hooks, but I thought I'd share just in case someone else finds it useful. Especially as it saved my bacon just now. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 __PYTHON_SCRIPT__ #!/usr/bin/env python import subprocess, os errors = 0 output = subprocess.check_output(["git","diff","--cached","--name-only","--diff-filte r=ACMR"]) lines = output.split('\n') for line in lines: if line: filename, file_extension = os.path.splitext(line) print(filename) print(file_extension) if file_extension == ".pl" or file_extension == ".pm": rv = subprocess.call(["perl","-c",line]) if rv: errors += 1 if errors > 0: exit(1)

5 4

Asynchronous standup
by Nick Clemens 20 Jul '18

20 Jul '18

Shib for a few sites Working on rancor to get dgi stuff rebased Pushing to master Education hour on authentication Took off to help build the pit for our friends annual pig roast, pics later -- Nick Clemens Sonic Screwdriver (Development Support) ByWater Solutions IRC: kidclamp

1 0

Update your misc4dev repo
by Jonathan Druart 20 Jul '18

20 Jul '18

Hi devs, Since bug 20287 there is not more AddMember subroutine and misc4dev was using it. You will need to update it (the repo from gitlab/koha-community), especially if you are using a devbox. Cheers, Jonathan

2 4

Easy sign off
by David Cook 20 Jul '18

20 Jul '18

Hi all, If anyone is looking for an easy sign off, consider checking out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097. It has a bit of set up in the test plan in terms of the acquisitions interface, but the actual patch is just adding a closing tag for an optgroup element. Modern browsers automatically add the missing tag, but I just noticed it was missing by accident and thought I'd fix it. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

1 0

Discussion about internal API design.
by Martin Renvoize 19 Jul '18

19 Jul '18

The Koha namespace is already starting to suffer from many of the issues we encountered within C4, with rather organic growth. I've been trying to promote some api design discussions in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983. To summarise, rather than adding lots of ->search_for_x, ->search_for_y, ->search_for_z methods to our objects I'd like to come up with some guidelines on code re-use and method naming conventions. (along with improving our current perldoc procedure to make the docs more informative and helpful, but let's cover that in another bug ;) ). Please take a look at the example code options I've presented in the bug and chip in with your thoughts, suggestions. Jonathan has already made some great suggestions and I'd love to see us working towards having clearer conventions and more code re-use. Thanks in advance, *Martin Renvoize* Development Manager *T:* +44 (0) 1483 378728 *F:* +44 (0) 800 756 6384 *E:* martin.renvoize(a)ptfs-europe.com www.ptfs-europe.com <https://www.ptfs-europe.com> Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info(a)ptfs-europe.com

1 0

CSS issue in Ordering information on /cgi-bin/koha/acqui/supplier.pl
by David Cook 19 Jul '18

19 Jul '18

I haven't checked master yet, but in the 17.xx versions, I'm noticing it is really difficult to click the dropdown for "List prices are:" in "Ordering information" on /cgi-bin/koha/acqui/supplier.pl. When I look using the F12 tools in Chrome, I see that later "ol" elements are overlapping earlier "li" elements. So the "ol" for the tax options is sitting on top of the "li" for "List prices are:". Only a tiny part of the "li" is clickable underneath that "ol". It looks like the floats in the "li" element are causing the sizing of the "ol" to be no good. See https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_cont ext. There are a number of strategies for fixing this but I'm not sure what the best one would be here. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

3 3

MySQL/MariaDB Auto-increment Persistence
by David Cook 16 Jul '18

16 Jul '18

Hi all, This may or may not have already done the rounds, but I figure it doesn't hurt to bring it up again, as I just learned about it, so maybe it will be news to some of you still. MariaDB 10.2.4 (from 17 Feb 2017) has "Persistent AUTO_INCREMENT for InnoDB (MDEV-6076)". MySQL 8.0 (I think maybe 8.0.1 from April 2017) has "the current maximum auto-increment value is persisted, preventing the reuse of previously allocated values." (https://dev.mysql.com/doc/refman/8.0/en/innodb-auto-increment-handling.html ). I reckon this is great news, as I've found this particular issue to be a perpetual thorn in my side. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

1 0

Sparql and koha opac (wikidata and bnf to try things)
by Claire Hernandez 16 Jul '18

16 Jul '18

Hi, I wanted to try and learn about semantic web and sparql. So I give it a try in a opac-detail view. This patch is just a poc and really not for production. I wanted to know if this type of work is relevant to you. I know in community previous work was done but maybe you can share where you are now with linked data ? Just 2 words about the dev : * Simple syspref called "Explore", 3 possibilities: nothing, Bnf (national library in france) and Wikidata * Some datas are fetched, I suppose I have an ark in my biblio * I display "simple information", there is no complicated query Possibles "next" : * Not one source (bnf or wikidata), but cross fetch between sources (ex: bnf + wikidata + europeana + geonames + whatever ;) * Having a "local triple store" or not doing real time to have information display quicker * More complicated queries to display timeline for date or exploring period, exploring "notable work" or "author collaborated with" etc. The dev is probably not as clean as you wish, and I prefer to share something to talk about - even not perfect - than nothing. I plan to write a blog post about what I learn. Tell me if you are interested, it could encourage me to do it :p Claire.

2 3

Call for News: July 2018 Newsletter
by kohanews 14 Jul '18

14 Jul '18

I'm collecting news for the July newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events , **** one month back is the cut-off ****. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the 26th of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. Thank you! -- Chad Roseburg Editor, Koha Community Newsletter

1 0