- Koha-devel - lists.koha-community.org

Inconsistent Display of Search Results
by Roger Buck 30 Mar '02

30 Mar '02

I notice that some OPAC search results do not return information about "Item Type, Class, Branch, Date Due " etc. For example: This one DOES NOT show information when accessed via OPAC: http://opac.katipo.co.nz/cgi-bin/koha/detail.pl?type=opac&bib=7921&title=Th… ..but the same seach DOES show information when accessed via intra: http://hlt.katipo.co.nz/cgi-bin/koha/detail.pl?type=intra&bib=7921&title=Th… This one shows information via OPAC: http://opac.katipo.co.nz/cgi-bin/koha/detail.pl?type=opac&bib=38542&title=A… ..and shows information via intra also: http://hlt.katipo.co.nz/cgi-bin/koha/detail.pl?type=intra&bib=38542&title=A… Why don't both entries show the information, both when accessed via OPAC and via intra?

2 1

Draft documentation
by Nicholas Rosasco 29 Mar '02

29 Mar '02

Before I go too much farther and start bugging :) the developers for assistance filling in some blanks, could I get some happy/unhappy feedback on the draft documentation at: http://etome.net/Koha/docs/ please send comments to nsr_koha(a)hotmail.com Thanks, Nick

1 0

Re: [Koha-devel] Issues with "issues"
by Roger Buck 29 Mar '02

29 Mar '02

Chris Cormack wrote: > > On Fri, Mar 29, 2002 at 07:02:15PM +1100, Roger Buck said: > > Chris Cormack wrote: > > [--snip--] > > > It wouldnt be hard to do a report per borrower. > > > If its something ppl would find useful? > > > > This is part of something more related to web based reservation. > > > > I will have a short term need for web users to lodge a request > > (via koha OPAC) to borrow via the net. The librarians will then > > process the request and send out the resource by mail. [--snip--] > You could quick and dirty backend a formmail behind the opac. > > Since koha isnt the authoritive database, you cant really do > anything more clever because you will run into all sorts of > race conditions. OK now you mention it - I hadn't even considered that! > Email is probably the easiest/simplest and therefore least > likely to bust stuff solution. Thanks for the feedback. I'll let you know when/how it works out. R.

1 0

Issues with "issues"
by Roger Buck 29 Mar '02

29 Mar '02

Links in intranet-html/issues/index.html point to missing files such as: countissues.pl countreturns.pl ... and so on. I also note a reference to missing "kumara" directory. Shame they are missing, they look really useful :^) R.

2 7

Acquisition errors
by Roger Buck 28 Mar '02

28 Mar '02

Using koha CVS I have MySQL-3-23-44-1, perl-500503-12 and have just installed latest DBD::mysql fron cpan on RH6.2 (with all RH ERRATA installed). When adding new item to library inventory I get DBD errors - /var/log/messages says: DBD::mysql::st execute failed: You have an error in your SQL syntax near '' at line 2 at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 275. If I change the '' to "" all is well.... DBD::mysql::st fetchrow failed: fetch() without execute() at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 276. ... I dunno about this one. I assume that the final error (below) is because 'lccn' is missing from one or more tables - If so, should lccn be added to "newitems" and/or others? DBD::mysql::st execute failed: Unknown column 'lccn' in 'field list' at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 207. Any hints on where to look to solve one or more of the above? Thanks, R.

1 1

Hello World
by Roger Buck 28 Mar '02

28 Mar '02

Just declaring my presence on the list. Thanks, R.

1 0

Bibliosubtitle table
by Chris Cormack 27 Mar '02

27 Mar '02

Hi all Im seriously considering combining the bibliosubtitle table with the biblio table. It seems like an unnessecary join to me, and is really slowing author searches down. Can anyone think of why this might be a bad idea. Im going to try it out on our test database. Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

1 1

1.1.2 Release
by Chris Cormack 27 Mar '02

27 Mar '02

Hi all Im beginning to think that 1.1.1 is so out of date, that we should release a 1.1.2 which tidies up at least all the missing files in 1.1.1 and the bugs. Perhaps leave the marc stuff out? What do ppl think? Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

2 2

CVS: koha pay.pl,1.2,1.3
by Chris Cormack 26 Mar '02

26 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv8133 Modified Files: pay.pl Log Message: Shifting writeoff code back into pay.pl (redirecting to writeoff.pl was breaking when the borrower owes a lot of fines) Index: pay.pl =================================================================== RCS file: /cvsroot/koha/koha/pay.pl,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -r1.2 -r1.3 *** pay.pl 2 Apr 2001 22:51:26 -0000 1.2 --- pay.pl 27 Mar 2002 00:02:40 -0000 1.3 *************** *** 9,15 **** use C4::Search; use C4::Accounts2; - my $input=new CGI; my $bornum=$input->param('bornum'); if ($bornum eq ''){ --- 9,18 ---- use C4::Search; use C4::Accounts2; + use C4::Database; + use C4::Stats; + my $input=new CGI; + #print $input->header; my $bornum=$input->param('bornum'); if ($bornum eq ''){ *************** *** 53,140 **** my $total=$input->param('total'); if ($check ==0){ if ($total ne ''){ recordpayment(\%env,$bornum,$total); } ! my ($numaccts,$accts,$total)=getboracctrecord('',\%bor); ! print $input->header; ! print startpage(); ! print startmenu('member'); ! print <<printend ! <FONT SIZE=6><em>Pay Fines for $data->{'firstname'} $data->{'surname'}</em></FONT><P> ! <center> ! <p> ! <TABLE CELLSPACING=0 CELLPADDING=5 border=1 > ! <TR VALIGN=TOP> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>FINES & CHARGES</TD> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>AMOUNT OWING</TD> ! </TR> ! <form action=/cgi-bin/koha/pay.pl method=post> ! <input type=hidden name=bornum value=$bornum> printend ; ! for (my $i=0;$i<$numaccts;$i++){ ! if ($accts->[$i]{'amountoutstanding'} > 0){ ! $accts->[$i]{'amount'}+=0.00; ! $accts->[$i]{'amountoutstanding'}+=0.00; ! print <<printend ! <tr VALIGN=TOP > ! <TD><input type=radio name=payfine$i value=no checked>Unpaid ! <input type=radio name=payfine$i value=yes>Pay ! <input type=radio name=payfine$i value=wo>Writeoff ! <input type=hidden name=itemnumber$i value=$accts->[$i]{'itemnumber'}> ! <input type=hidden name=accounttype$i value=$accts->[$i]{'accounttype'}> ! <input type=hidden name=amount$i value=$accts->[$i]{'amount'}> ! <input type=hidden name=out$i value=$accts->[$i]{'amountoutstanding'}> ! <input type=hidden name=bornum$i value=$bornum> ! <input type=hidden name=accountno$i value=$accts->[$i]{'accountno'}> ! </td> ! <TD>$accts->[$i]{'description'} $accts->[$i]{'title'}</td> ! <TD>$accts->[$i]{'accounttype'}</td> ! <td>$accts->[$i]{'amount'}</td> ! <TD>$accts->[$i]{'amountoutstanding'}</td> ! </tr> printend ; ! } ! } ! print <<printend ! <tr VALIGN=TOP > ! <TD></td> ! <TD colspan=2><b>Total Due</b></td> ! ! <TD><b>$total</b></td> ! ! </tr> ! ! ! ! <tr VALIGN=TOP > ! <TD></td> ! <TD colspan=3><b>AMOUNT PAID</b></td> ! <TD><input type=text name=total value="" SIZE=7></td> ! </tr> ! <tr VALIGN=TOP > ! <TD colspan=5 align=right> ! <INPUT TYPE="image" name="submit" VALUE="pay" height=42 WIDTH=187 BORDER=0 src="/images/pay-fines.gif"></td> ! </tr> ! </form> ! </table> ! ! ! ! ! ! ! <br clear=all> ! <p>   </p> printend ; ! print endmenu('member'); ! print endpage(); } else { ! my $quety=$input->query_string; ! print $input->redirect("/cgi-bin/koha/sec/writeoff.pl?$quety"); } --- 56,189 ---- my $total=$input->param('total'); if ($check ==0){ + print $input->header; if ($total ne ''){ recordpayment(\%env,$bornum,$total); } ! my ($numaccts,$accts,$total)=getboracctrecord('',\%bor); ! ! print startpage(); ! print startmenu('member'); ! print <<printend ! <FONT SIZE=6><em>Pay Fines for $data->{'firstname'} $data->{'surname'}</em></FONT><P> ! <center> ! <p> ! <TABLE CELLSPACING=0 CELLPADDING=5 border=1 > ! <TR VALIGN=TOP> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>FINES & CHARGES</TD> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>AMOUNT OWING</TD> ! </TR> ! <form action=/cgi-bin/koha/pay.pl method=post> ! <input type=hidden name=bornum value=$bornum> printend ; ! for (my $i=0;$i<$numaccts;$i++){ ! if ($accts->[$i]{'amountoutstanding'} > 0){ ! $accts->[$i]{'amount'}+=0.00; ! $accts->[$i]{'amountoutstanding'}+=0.00; ! print <<printend ! <tr VALIGN=TOP > ! <TD><input type=radio name=payfine$i value=no checked>Unpaid ! <input type=radio name=payfine$i value=yes>Pay ! <input type=radio name=payfine$i value=wo>Writeoff ! <input type=hidden name=itemnumber$i value=$accts->[$i]{'itemnumber'}> ! <input type=hidden name=accounttype$i value=$accts->[$i]{'accounttype'}> ! <input type=hidden name=amount$i value=$accts->[$i]{'amount'}> ! <input type=hidden name=out$i value=$accts->[$i]{'amountoutstanding'}> ! <input type=hidden name=bornum$i value=$bornum> ! <input type=hidden name=accountno$i value=$accts->[$i]{'accountno'}> ! </td> ! <TD>$accts->[$i]{'description'} $accts->[$i]{'title'}</td> ! <TD>$accts->[$i]{'accounttype'}</td> ! <td>$accts->[$i]{'amount'}</td> ! <TD>$accts->[$i]{'amountoutstanding'}</td> ! </tr> printend ; ! } ! } ! print <<printend ! <tr VALIGN=TOP > ! <TD></td> ! <TD colspan=2><b>Total Due</b></td> ! <TD><b>$total</b></td> ! </tr> ! <tr VALIGN=TOP > ! <TD colspan=5 align=right> ! <INPUT TYPE="image" name="submit" VALUE="pay" height=42 WIDTH=187 BORDER=0 src="/images/pay-fines.gif"></td> ! </tr> ! </form> ! </table> ! <br clear=all> ! <p>   </p> printend ; ! print endmenu('member'); ! print endpage(); } else { ! # my $quety=$input->query_string; ! # print $input->redirect("/cgi-bin/koha/sec/writeoff.pl?$quety"); ! my%inp; ! my @name=$input->param; ! for (my $i=0;$i<@name;$i++){ ! my $test=$input->param($name[$i]); ! if ($test eq 'wo'){ ! my $temp=$name[$i]; ! $temp=~ s/payfine//; ! $inp{$name[$i]}=$temp; ! } ! } ! my $bornum; ! while ( my ($key, $value) = each %inp){ ! # print $key,$value; ! my $accounttype=$input->param("accounttype$value"); ! $bornum=$input->param("bornum$value"); ! my $itemno=$input->param("itemnumber$value"); ! my $amount=$input->param("amount$value"); ! if ($accounttype eq 'Res'){ ! my $accountno=$input->param("accountno$value"); ! writeoff($bornum,$accountno,$itemno,$accounttype,$amount); ! } else { ! writeoff($bornum,'',$itemno,$accounttype,$amount); ! } ! } ! $bornum=$input->param('bornum'); ! print $input->redirect("/cgi-bin/koha/pay.pl?bornum=$bornum"); ! } ! ! ! sub writeoff{ ! my ($bornum,$accountnum,$itemnum,$accounttype,$amount)=@_; ! my $user=$input->remote_user; ! $user=~ s/Levin/C/; ! $user=~ s/Foxton/F/; ! $user=~ s/Shannon/S/; ! my $dbh=C4Connect; ! my $env; ! my $query="Update accountlines set amountoutstanding=0 where "; ! if ($accounttype eq 'Res'){ ! $query.="accounttype='Res' and accountno='$accountnum' and borrowernumber='$bornum'"; ! } else { ! $query.="accounttype='$accounttype' and itemnumber='$itemnum' and borrowernumber='$bornum'"; ! } ! my $sth=$dbh->prepare($query); ! # print $query; ! $sth->execute; ! $sth->finish; ! $query="select max(accountno) from accountlines"; ! $sth=$dbh->prepare($query); ! $sth->execute; ! my $account=$sth->fetchrow_hashref; ! $sth->finish; ! $account->{'max(accountno)'}++; ! $query="insert into accountlines (borrowernumber,accountno,itemnumber,date,amount,description,accounttype) ! values ('$bornum','$account->{'max(accountno)'}','$itemnum',now(),'$amount','Writeoff','W')"; ! $sth=$dbh->prepare($query); ! $sth->execute; ! $sth->finish; ! # print $query; ! $dbh->disconnect; ! UpdateStats($env,$user,'writeoff',$amount,'','','',$bornum); }

1 0

CVS: koha/updater updatedatabase,1.3,1.4
by Finlay Thompson 25 Mar '02

25 Mar '02

Update of /cvsroot/koha/koha/updater In directory usw-pr-cvs1:/tmp/cvs-serv25940/updater Modified Files: updatedatabase Log Message: added database patchs to the updater/updatedatabase script changes the type of the datesent and datearrived fields in the branchtransfers table from date to datetime. completely re-organises the branchcategories table. As this has previously been unused it shouldnt effect anyone. Index: updatedatabase =================================================================== RCS file: /cvsroot/koha/koha/updater/updatedatabase,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** updatedatabase 19 Nov 2001 23:28:59 -0000 1.3 --- updatedatabase 26 Mar 2002 05:08:52 -0000 1.4 *************** *** 105,108 **** --- 105,157 ---- } + # extending the timestamp in branchtransfers... + my %branchtransfers; + + my $sth=$dbh->prepare("show columns from branchtransfers"); + $sth->execute; + while (my ($column, $type, $null, $key, $default, $extra) = $sth->fetchrow) { + $branchtransfers{$column}=$type; + } + + unless ($branchtransfers{'datesent'} eq 'datetime') { + print "Setting type of datesent in branchtransfers to datetime.\n"; + my $sti=$dbh->prepare("alter table branchtransfers change datesent datesent datetime"); + $sti->execute; + } + + unless ($branchtransfers{'datearrived'} eq 'datetime') { + print "Setting type of datearrived in branchtransfers to datetime.\n"; + my $sti=$dbh->prepare("alter table branchtransfers change datearrived datearrived datetime"); + $sti->execute; + } + + # changing the branchcategories table around... + my %branchcategories; + + my $sth=$dbh->prepare("show columns from branchcategories"); + $sth->execute; + while (my ($column, $type, $null, $key, $default, $extra) = $sth->fetchrow) { + $branchcategories{$column}=$type; + } + + unless ($branchcategories{'categorycode'} eq 'varchar(4)') { + print "Setting type of categorycode in branchcategories to varchar(4),\n and making the primary key.\n"; + my $sti=$dbh->prepare("alter table branchcategories change categorycode categorycode varchar(4) not null"); + $sti->execute; + $sti=$dbh->prepare("alter table branchcategories add primary key (categorycode)"); + $sti->execute; + } + + unless ($branchcategories{'branchcode'} eq 'varchar(4)') { + print "Setting type of branchcode in branchcategories to varchar(4).\n"; + my $sti=$dbh->prepare("alter table branchcategories change branchcode branchcode varchar(4)"); + $sti->execute; + } + + unless ($branchcategories{'codedescription'} eq 'text') { + print "Replacing branchholding in branchcategories with codedescription text.\n"; + my $sti=$dbh->prepare("alter table branchcategories change branchholding codedescription text"); + $sti->execute; + } $sth->finish;

1 0