- Koha-devel - lists.koha-community.org

intro
by Pat Eyler 02 Apr '02

02 Apr '02

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello all, I'm a sometime long-time unix/linux systems admin who's done a bit of webmastering, perl dbi & cgi work, and assorted other bits. I'm interested in free software in general and in library automation. I've started looking at the code in koha and have started to do a bit of work on it. While I'm trying to learn my way around the code, I'm trying to do some refactoring to make things easier on myself (and, hopefully, everyone else). My initial goals are: to move duplicated code into a seperate module build up unit tests around the code I work on start hacking on bugs/feature requests from Sourceforge If anyone has pointers for things I ought to look into, I'd love to see them. Thanks for offering up such a great gift. - -pate ps. BTW, if you see FIXME in a comment, that's just me skulking around ... -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjyqM3kACgkQvc7sCWw+PCc14gCePwQzy2dSGdXVDrFUHQCPIIOi gAwAn3mQUdFdoW6tayxGuJOD2g0klgMD =2DJ+ -----END PGP SIGNATURE-----

1 0

CVS: koha/acqui.simple addbookslccn.pl,1.2,1.3 addbooks.pl,1.3,1.4
by Chris Cormack 30 Mar '02

30 Mar '02

Update of /cvsroot/koha/koha/acqui.simple In directory usw-pr-cvs1:/tmp/cvs-serv14281 Modified Files: addbookslccn.pl addbooks.pl Log Message: Fixed the holding branch insertion code. It was inserting the correct homebranch but was still inserting the wrong home branch Index: addbookslccn.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui.simple/addbookslccn.pl,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -r1.2 -r1.3 *** addbookslccn.pl 31 Mar 2002 02:48:18 -0000 1.2 --- addbookslccn.pl 31 Mar 2002 06:50:08 -0000 1.3 *************** *** 260,264 **** $sth=$dbh->prepare("insert into items (itemnumber, biblionumber, biblioitemnumber,barcode, itemnotes, holdingbranch, homebranch, dateaccessioned, replacementprice) values ($itemnumber, ! $biblionumber, $biblioitemnumber, $barcode, $q_itemnotes, 'STWE', $q_homebranch, '$date', $replacementprice)"); $sth->execute; } --- 260,264 ---- $sth=$dbh->prepare("insert into items (itemnumber, biblionumber, biblioitemnumber,barcode, itemnotes, holdingbranch, homebranch, dateaccessioned, replacementprice) values ($itemnumber, ! $biblionumber, $biblioitemnumber, $barcode, $q_itemnotes, $q_homebranch, $q_homebranch, '$date', $replacementprice)"); $sth->execute; } Index: addbooks.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui.simple/addbooks.pl,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** addbooks.pl 31 Mar 2002 01:18:36 -0000 1.3 --- addbooks.pl 31 Mar 2002 06:50:08 -0000 1.4 *************** *** 262,269 **** my $date=(1900+$datearr[5])."-".($datearr[4]+1)."-".$datearr[3]; my $q_homebranch=$dbh->quote($input->param('homebranch')); ! $sth=$dbh->prepare("insert into items (itemnumber, biblionumber, biblioitemnumber,barcode, itemnotes, holdingbranch, homebranch, dateaccessioned, replacementprice) values ($itemnumber, ! $biblionumber, $biblioitemnumber, $barcode, $q_itemnotes, 'STWE', $q_homebranch, '$date', $replacementprice)"); $sth->execute; } --- 262,271 ---- my $date=(1900+$datearr[5])."-".($datearr[4]+1)."-".$datearr[3]; my $q_homebranch=$dbh->quote($input->param('homebranch')); ! my $query="insert into items (itemnumber, biblionumber, biblioitemnumber,barcode, itemnotes, holdingbranch, homebranch, dateaccessioned, replacementprice) values ($itemnumber, ! $biblionumber, $biblioitemnumber, $barcode, $q_itemnotes, $q_homebranch, $q_homebranch, '$date', $replacementprice)"; ! $sth=$dbh->prepare($query); $sth->execute; + # print $query; } *************** *** 322,328 **** foreach my $key (sort(keys %$branches)) { print "<option value=\"$key\">$branches->{$key}->{'branchname'}</option>"; ! # $key, '=', $branches->{$key}, "\n"; ! } ! # <option value='STWE'>Stewart Elementary<option value='MEZ'>Meziadin Elementary print << "EOF"; </select></td></tr> --- 324,328 ---- foreach my $key (sort(keys %$branches)) { print "<option value=\"$key\">$branches->{$key}->{'branchname'}</option>"; ! } print << "EOF"; </select></td></tr>

1 0

CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
by Chris Cormack 30 Mar '02

30 Mar '02

Update of /cvsroot/koha/koha/acqui.simple In directory usw-pr-cvs1:/tmp/cvs-serv9617 Modified Files: addbookslccn.pl Log Message: Fixing branches Index: addbookslccn.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui.simple/addbookslccn.pl,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -r1.1 -r1.2 *** addbookslccn.pl 6 Nov 2001 18:15:00 -0000 1.1 --- addbookslccn.pl 31 Mar 2002 02:48:18 -0000 1.2 *************** *** 12,16 **** use C4::Acquisitions; use C4::Output; ! my $input = new CGI; --- 12,16 ---- use C4::Acquisitions; use C4::Output; ! use C4::Circulation::Circ2; my $input = new CGI; *************** *** 311,315 **** <input type=hidden name=biblioitemnumber value=$biblioitemnumber> <table> ! <tr><td>BARCODE</td><td><input name=barcode size=10 value=$maxbarcode> Home Branch: <select name=homebranch><option value='STWE'>Stewart Elementary<option value='MEZ'>Meziadin Elementary</select></td></tr> </tr><td colspan=2>Replacement Price: <input name=replacementprice size=10></td></tr> <tr><td>Notes</td><td><textarea name=notes rows=4 cols=40 --- 311,322 ---- <input type=hidden name=biblioitemnumber value=$biblioitemnumber> <table> ! <tr><td>BARCODE</td><td><input name=barcode size=10 value=$maxbarcode> Home Branch: <select name=homebranch> ! EOF ! my $branches=getbranches(); ! foreach my $key (sort(keys %$branches)) { ! print "<option value=\"$key\">$branches->{$key}->{'branchname'}</option>"; ! } ! print << "EOF"; ! </select></td></tr> </tr><td colspan=2>Replacement Price: <input name=replacementprice size=10></td></tr> <tr><td>Notes</td><td><textarea name=notes rows=4 cols=40

3 4

CVS: koha/acqui.simple addbooks.pl,1.2,1.3
by Chris Cormack 30 Mar '02

30 Mar '02

Update of /cvsroot/koha/koha/acqui.simple In directory usw-pr-cvs1:/tmp/cvs-serv25830 Modified Files: addbooks.pl Log Message: Draws list of branches from the branches table now, when adding an item Index: addbooks.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui.simple/addbooks.pl,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -r1.2 -r1.3 *** addbooks.pl 6 Nov 2001 18:25:30 -0000 1.2 --- addbooks.pl 31 Mar 2002 01:18:36 -0000 1.3 *************** *** 12,16 **** use C4::Acquisitions; use C4::Output; ! my $input = new CGI; --- 12,16 ---- use C4::Acquisitions; use C4::Output; ! use C4::Circulation::Circ2; my $input = new CGI; *************** *** 156,159 **** --- 156,161 ---- sub newbiblioitem { + #print + # print "in here"; my $biblionumber=$input->param('biblionumber'); my $volume=$input->param('volume'); *************** *** 198,202 **** $biblioitemnumber++; ($q_isbn='') if ($q_isbn eq 'NULL'); ! $sth=$dbh->prepare("insert into biblioitems (biblioitemnumber, biblionumber, volume, number, classification, itemtype, isbn, issn, lccn, dewey, subclass, publicationyear, publishercode, volumedate, volumeddesc, illus, pages, --- 200,204 ---- $biblioitemnumber++; ($q_isbn='') if ($q_isbn eq 'NULL'); ! my $query="insert into biblioitems (biblioitemnumber, biblionumber, volume, number, classification, itemtype, isbn, issn, lccn, dewey, subclass, publicationyear, publishercode, volumedate, volumeddesc, illus, pages, *************** *** 204,208 **** $q_number, $q_classification, $q_itemtype, $q_isbn, $q_issn, $q_lccn, $q_dewey, $q_subclass, $q_publicationyear, $q_publishercode, $q_volumedate, $q_volumeddesc, ! $q_illus, $q_pages, $q_notes, $q_size, $q_place)"); $sth->execute; my @subjectheadings=split(/\n/,$subjectheadings); --- 206,212 ---- $q_number, $q_classification, $q_itemtype, $q_isbn, $q_issn, $q_lccn, $q_dewey, $q_subclass, $q_publicationyear, $q_publishercode, $q_volumedate, $q_volumeddesc, ! $q_illus, $q_pages, $q_notes, $q_size, $q_place)"; ! $sth=$dbh->prepare($query); ! # print $query; $sth->execute; my @subjectheadings=split(/\n/,$subjectheadings); *************** *** 311,315 **** <input type=hidden name=biblioitemnumber value=$biblioitemnumber> <table> ! <tr><td>BARCODE</td><td><input name=barcode size=10 value=$maxbarcode> Home Branch: <select name=homebranch><option value='STWE'>Stewart Elementary<option value='MEZ'>Meziadin Elementary</select></td></tr> </tr><td colspan=2>Replacement Price: <input name=replacementprice size=10></td></tr> <tr><td>Notes</td><td><textarea name=notes rows=4 cols=40 --- 315,330 ---- <input type=hidden name=biblioitemnumber value=$biblioitemnumber> <table> ! <tr><td>BARCODE</td><td><input name=barcode size=10 value=$maxbarcode> ! Home Branch: <select name=homebranch> ! EOF ! ! my $branches=getbranches(); ! foreach my $key (sort(keys %$branches)) { ! print "<option value=\"$key\">$branches->{$key}->{'branchname'}</option>"; ! # $key, '=', $branches->{$key}, "\n"; ! } ! # <option value='STWE'>Stewart Elementary<option value='MEZ'>Meziadin Elementary ! print << "EOF"; ! </select></td></tr> </tr><td colspan=2>Replacement Price: <input name=replacementprice size=10></td></tr> <tr><td>Notes</td><td><textarea name=notes rows=4 cols=40

3 2

Re: [Koha-devel] Inconsistent Display of Search Results
by Chris Cormack 30 Mar '02

30 Mar '02

On Sun, Mar 31, 2002 at 10:42:32AM +1000, Roger Buck said: > > Yes it does make sense... but when I enter stuff here, nothin shows - in > Bilio Record, Total number of items always = 0 > > Another addbooks.pl problem? > I just sent a message to you off list about this. Its actually to do with ItemInfo which is in Search.pm which is called by detail.pl. ItemInfo depends on some data in the branch table. I think this is whats breaking it. Can you do a select * from branches and the same for biblio, biblioitems and items please? Then I hopefully can spot whats going wrong Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

2 2

Inconsistent Display of Search Results
by Roger Buck 30 Mar '02

30 Mar '02

I notice that some OPAC search results do not return information about "Item Type, Class, Branch, Date Due " etc. For example: This one DOES NOT show information when accessed via OPAC: http://opac.katipo.co.nz/cgi-bin/koha/detail.pl?type=opac&bib=7921&title=Th… ..but the same seach DOES show information when accessed via intra: http://hlt.katipo.co.nz/cgi-bin/koha/detail.pl?type=intra&bib=7921&title=Th… This one shows information via OPAC: http://opac.katipo.co.nz/cgi-bin/koha/detail.pl?type=opac&bib=38542&title=A… ..and shows information via intra also: http://hlt.katipo.co.nz/cgi-bin/koha/detail.pl?type=intra&bib=38542&title=A… Why don't both entries show the information, both when accessed via OPAC and via intra?

2 1

Draft documentation
by Nicholas Rosasco 29 Mar '02

29 Mar '02

Before I go too much farther and start bugging :) the developers for assistance filling in some blanks, could I get some happy/unhappy feedback on the draft documentation at: http://etome.net/Koha/docs/ please send comments to nsr_koha(a)hotmail.com Thanks, Nick

1 0

Re: [Koha-devel] Issues with "issues"
by Roger Buck 28 Mar '02

28 Mar '02

Chris Cormack wrote: > > On Fri, Mar 29, 2002 at 07:02:15PM +1100, Roger Buck said: > > Chris Cormack wrote: > > [--snip--] > > > It wouldnt be hard to do a report per borrower. > > > If its something ppl would find useful? > > > > This is part of something more related to web based reservation. > > > > I will have a short term need for web users to lodge a request > > (via koha OPAC) to borrow via the net. The librarians will then > > process the request and send out the resource by mail. [--snip--] > You could quick and dirty backend a formmail behind the opac. > > Since koha isnt the authoritive database, you cant really do > anything more clever because you will run into all sorts of > race conditions. OK now you mention it - I hadn't even considered that! > Email is probably the easiest/simplest and therefore least > likely to bust stuff solution. Thanks for the feedback. I'll let you know when/how it works out. R.

1 0

Issues with "issues"
by Roger Buck 28 Mar '02

28 Mar '02

Links in intranet-html/issues/index.html point to missing files such as: countissues.pl countreturns.pl ... and so on. I also note a reference to missing "kumara" directory. Shame they are missing, they look really useful :^) R.

2 7

Acquisition errors
by Roger Buck 28 Mar '02

28 Mar '02

Using koha CVS I have MySQL-3-23-44-1, perl-500503-12 and have just installed latest DBD::mysql fron cpan on RH6.2 (with all RH ERRATA installed). When adding new item to library inventory I get DBD errors - /var/log/messages says: DBD::mysql::st execute failed: You have an error in your SQL syntax near '' at line 2 at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 275. If I change the '' to "" all is well.... DBD::mysql::st fetchrow failed: fetch() without execute() at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 276. ... I dunno about this one. I assume that the final error (below) is because 'lccn' is missing from one or more tables - If so, should lccn be added to "newitems" and/or others? DBD::mysql::st execute failed: Unknown column 'lccn' in 'field list' at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 207. Any hints on where to look to solve one or more of the above? Thanks, R.

1 1