- Koha-devel - lists.koha-community.org

Also...
by Nicholas Rosasco 04 Mar '02

04 Mar '02

Idly, besides MARC features, do we want to do a feature-request list, while you all are in the process of polishing and intergrating the MARC and other items? I see the traffic on the various DB reorg/changes and am curious to know what else is on various wish lists. Since the faq is basically done, I can handle tracking that... Nick

3 7

about budgets (aqbudget/aqbookfund and aqorderbreakdown tables)
by paul POULAIN 02 Mar '02

02 Mar '02

aqbudget is connected to aqbookfund to exprim how much budget we can spend every year. In aqbudget there is a startdate/enddate, so I think this table is supposed to contain a record for every book fund and every year. But in the sample table there is only one year datas. More important, aqorderbreakdown describes books bought. this table points only to aqbookfundid, so I conclude I have no way to find which year this order mus be related to. So I conclude multi-year budgets are not managed by koha. Am I right ? If yes, so we could merge aqbudget and aqbookfund, or at least, in my admin tool, i could merge them on screens. Note : This afternoon is the most important rugby match of the year for europe : France-England. I try to work while looking at this match, but i'm not sure I will be very productive ;-)))) -- Paul

2 1

what are biblio, biblioitems and items tables
by paul POULAIN 01 Mar '02

01 Mar '02

I can't understand what means the 3 tables biblio biblioitems and items. A biblio contains the datas for a book we can have, or not have in our library. It contains the fact that such a document EXISTS. An item is a data to explain that we POSSESS a biblio, where, since when, at which costs... But what's the hell is a biblioitem ? Where is it used ? How could be a definition constraint with biblio/item be writen if mySQL supported them ? Thank's -- Paul

2 3

whops... (reverse engeneering again)
by paul POULAIN 01 Mar '02

01 Mar '02

forget to add the doc... here it is Note it's done with openOffice.org and saved as html -- Paul

2 1

reverse engeneering on DB...
by paul POULAIN 01 Mar '02

01 Mar '02

I try to understand very well how the 1.1 version of koha works (the exact structure of the DB). I wrote a few words for every table. I will enhance the doc in the future, as I understand better everything. By the way, a few tables remains un-understandable to me, so if someone could lighten me ;-) Last word : many tables seems useless, so if you confirm they are, I could add a "drop table" to my SQL patch. Bye -- Paul

1 0

Primary key does not exist !!!!!!!
by paul POULAIN 28 Feb '02

28 Feb '02

Hi everybody, This is my 1st message on this list. I'm a new developper of koha. Coming from france. I've almost a half time job to work on koha to help reaching the 1.2 version, with MARC support. When it will be done, we will use it here, in france, in at least 4 libraries with 80 000 books (christian libraries). Presently I'm working on admin tool to administer avery parameter table. It should be released on CVS soon. My fisrt post is to CRY because of a BIG proble in the DB structure: In most tables there is no primary key defined. On some of them there are indexes, but no pk. It's very, very dirty, ugly, infamous, ridiculous (and every -y or -ous term you could find ;-)) from a theoric point of vue, It's the source of perf caveats, (joins make heavy use of primary key. In fact, almost every "join" are usually on a pk of the right part of the expression) It's the cause of some bugs in a practical point of vue : it's not possible to use "append" sql command, which is VERY practical when you have to store datas (the same form is shares for insert and modify actions...) So, unless there is a very important reason to do so (and I don't know what could be such a reason...), I think a primary key must be defined for every table in the DB... Who can include them in the db schema ? If you want a SQL patch to correct the DB, I should be able to spend a few hours to do it. Note : for a 1st post, it may seem to be very critic. As you will see later, I'm usually a happy man ;-))))) It's just that I've work a lot on many DB (mySQL, Interbase, Informix...) and I'm very surprised with this problem. I don't blame anybody. -- Paul

2 1

CVS: koha/maint catmaintain.pl,1.2,1.3
by Chris Cormack 26 Feb '02

26 Feb '02

Update of /cvsroot/koha/koha/maint In directory usw-pr-cvs1:/tmp/cvs-serv31272/maint Modified Files: catmaintain.pl Log Message: Fixed apostrophe ' handling Index: catmaintain.pl =================================================================== RCS file: /cvsroot/koha/koha/maint/catmaintain.pl,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -r1.2 -r1.3 *** catmaintain.pl 15 Mar 2001 10:15:51 -0000 1.2 --- catmaintain.pl 26 Feb 2002 09:31:15 -0000 1.3 *************** *** 25,28 **** --- 25,29 ---- my $sub2=$results->[$i]->{'subject'}; $sub2=~ s/ /%20/g; + $sub2=~ s/\'/%27/g; print "\"<a href=\"/cgi-bin/koha/maint/catmaintain.pl?type=allsub&sub=$sub\" onclick=\'messenger(\"/cgi-bin/koha/maint/catmaintain.pl?type=modsub&sub=$sub2\");window1.focus()\'>$results->[$i]->{'subject'}\"</a><br>\n"; } *************** *** 85,88 **** --- 86,90 ---- print "<input type=hidden name=type value=catmain>"; print "Show all Titles beginning with <input type=text name=title><br>"; + print "Item Number <INPUT TYPE=\"text\" SIZE=\"25\" NAME=\"item\"><br>"; print "<input type=submit value=Show>"; print "</form>";

1 0

CVS: koha/C4 Maintainance.pm,1.3,1.4
by Chris Cormack 26 Feb '02

26 Feb '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv31272/C4 Modified Files: Maintainance.pm Log Message: Fixed apostrophe ' handling Index: Maintainance.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Maintainance.pm,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** Maintainance.pm 15 Mar 2001 10:15:51 -0000 1.3 --- Maintainance.pm 26 Feb 2002 09:31:14 -0000 1.4 *************** *** 76,80 **** my ($sub,$oldsub)=@_; my $dbh=C4Connect; ! my $query="update bibliosubject set subject='$sub' where subject='$oldsub'"; my $sth=$dbh->prepare($query); $sth->execute; --- 76,82 ---- my ($sub,$oldsub)=@_; my $dbh=C4Connect; ! $sub=$dbh->quote($sub); ! $oldsub=$dbh->quote($oldsub); ! my $query="update bibliosubject set subject=$sub where subject=$oldsub"; my $sth=$dbh->prepare($query); $sth->execute;

1 0

CVS: koha/acqui basket.pl,1.1.1.1,1.2
by Chris Cormack 26 Feb '02

26 Feb '02

Update of /cvsroot/koha/koha/acqui In directory usw-pr-cvs1:/tmp/cvs-serv25553/acqui Modified Files: basket.pl Log Message: Fix for displaying prices Index: basket.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui/basket.pl,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -C2 -r1.1.1.1 -r1.2 *** basket.pl 19 Dec 2000 23:45:56 -0000 1.1.1.1 --- basket.pl 26 Feb 2002 09:06:19 -0000 1.2 *************** *** 15,21 **** print startpage; ! print startmenu('acquisitions'); ! #print $count; my ($count2,@booksellers)=bookseller($results[0]->{'booksellerid'}); --- 15,26 ---- print startpage; ! my @inp=startmenu('acquisitions'); ! my $count3=@inp; ! for (my $i=0;$i<$count3;$i++){ ! $inp[$i]=~ s/leftmargin=0 topmargin=0\>/leftmargin=0 topmargin=0 onload='update(orderform)'\>/; ! } ! print @inp; ! # print $count; my ($count2,@booksellers)=bookseller($results[0]->{'booksellerid'}); *************** *** 25,39 **** Authorised By: $results[0]->{'authorisedby'}<br> $results[0]->{'entrydate'}; - </div> ! <FONT SIZE=6><em>Shopping Basket For: <a href=supplier.pl?id=$results[0]->{'booksellerid'}></a> $booksellers[0]->{'name'}</em></FONT> ! ! <a href=newbasket.pl?id=$results[0]->{'booksellerid'}&basket=$basket>Add more orders</a> ! ! <CENTER> - <FORM ACTION="/cgi-bin/koha/search.pl" method=post> ! <b>Search ISBN, Title or Author:</b> <INPUT TYPE="text" SIZE="25" NAME="recieve"> </form> <p> --- 30,39 ---- Authorised By: $results[0]->{'authorisedby'}<br> $results[0]->{'entrydate'}; </div> ! <FONT SIZE=6><em>Shopping Basket For: <a href=supplier.pl?id=$results[0]->{'booksellerid'}></a> $booksellers[0]->{'name'}</em></FONT> ! <a href=newbasket.pl?id=$results[0]->{'booksellerid'}&basket=$basket>Add more orders</a> <CENTER> <FORM ACTION="/cgi-bin/koha/search.pl" method=post> ! <b>Search ISBN, Title or Author:</b> <INPUT TYPE="text" SIZE="25" NAME="recieve"> </form> <p> *************** *** 41,124 **** <table border=0 cellspacing=0 cellpadding=5> <tr valign=top bgcolor=#99cc33> ! <td background="/images/background-mem.gif"><b>ORDER</b></td> ! <td background="/images/background-mem.gif"><b>ISBN</b></td> ! <td background="/images/background-mem.gif"><b>TITLE</b></td> ! <td background="/images/background-mem.gif"><b>AUTHOR</b></td> ! <td background="/images/background-mem.gif"><b>RRP</b></td><td background="/images/background-mem.gif"><b>\$EST</b></td><td background="/images/background-mem.gif"><b>QUANTITY</b></td><td background="/images/background-mem.gif"><b>TOTAL</b></td></tr> printend ; for (my $i=0;$i<$count;$i++){ my $rrp=$results[$i]->{'listprice'}; if ($results[$i]->{'currency'} ne 'NZD'){ ! $rrp=curconvert($results[$i]->{'currency'},$rrp); } - print <<EOP <tr valign=top bgcolor=#ffffcc> ! <td>$results[$i]->{'ordernumber'}</td> ! <td>$results[$i]->{'isbn'}</td> ! <td><a href="newbiblio.pl?ordnum=$results[$i]->{'ordernumber'}&id=$results[$i]->{'booksellerid'}&basket=$basket">$results[$i]->{'title'}</a></td> ! <td>$results[$i]->{'author'}</td> ! <td>\$<input type=text name=rrp$i size=6 value="$results[$i]->{'rrp'}"></td> ! <td>\$<input type=text name=eup$i size=6 value="$results[$i]->{'ecost'}"></td> ! <td><input type=text name=quantity$i size=6 value=$results[$i]->{'quantity'}></td> ! <td>\$<input type=text name=total$i size=10 value=16.95></td> ! <input type=hidden name=ordnum$i value=$results[$i]->{'ordernumber'}> ! <input type=hidden name=bibnum$i value=$results[$i]->{'biblionumber'}> </tr> - EOP ; } ! # onchange='update(this.form)'></td> print "<input type=hidden name=number value=$count> <input type=hidden name=basketno value=\"$basket\">"; print <<EOP <tr valign=top bgcolor=white> ! ! <td colspan=6 rowspan=3 bgcolor=#cccc99 background="/images/background-mem.gif"> ! <b>HELP</b><br> ! To cancel an order, just change the quantity to 0 and click "save changes".<br> ! To change any of the catalogue or accounting information attached to an order, click on the title.<br> ! To add new orders to this supplier, start with a search. </td> ! <td><b>SubTotal</b></td> ! <td>\$<input type=text name=subtotal size=10></td> ! </tr> ! <tr valign=top bgcolor=white> ! <td><b>GST</b></td> ! <td>\$<input type=text name=gst size=10></td> ! ! </tr> ! ! <tr valign=top bgcolor=white> ! ! ! <td><b>TOTAL</b></td> ! <td>\$<input type=text name=grandtotal size=10></td> ! ! </tr> ! <tr valign=top bgcolor=white> ! <td></td> ! <td></td> ! <td></td> ! <td></td> ! <td></td> ! <td></td> ! <td colspan=3><input type=image name=submit src=/images/save-changes.gif border=0 width=187 height=42 align=right></td> ! ! </tr> ! ! ! ! </table> ! </CENTER> ! ! ! EOP ! ; print endmenu('acquisitions'); --- 41,116 ---- <table border=0 cellspacing=0 cellpadding=5> <tr valign=top bgcolor=#99cc33> ! <td background="/images/background-mem.gif"><b>ORDER</b></td> ! <td background="/images/background-mem.gif"><b>ISBN</b></td> ! <td background="/images/background-mem.gif"><b>TITLE</b></td> ! <td background="/images/background-mem.gif"><b>AUTHOR</b></td> ! <td background="/images/background-mem.gif"><b>RRP</b></td> ! <td background="/images/background-mem.gif"><b>\$EST</b></td> ! <td background="/images/background-mem.gif"><b>QUANTITY</b></td> ! <td background="/images/background-mem.gif"><b>TOTAL</b></td></tr> printend ; + + + my $line_total; # total of each line + my $sub_total; # total of line totals + my $gist; # GST + my $grand_total; # $subttotal + $gist + for (my $i=0;$i<$count;$i++){ my $rrp=$results[$i]->{'listprice'}; if ($results[$i]->{'currency'} ne 'NZD'){ ! $rrp=curconvert($results[$i]->{'currency'},$rrp); } + $line_total=$results[$i]->{'quantity'}*$results[$i]->{'ecost'}; + $sub_total+=$line_total; + $gist=sprintf("%.2f",$sub_total*0.125); + $grand_total=$sub_total+$gist; + print <<EOP <tr valign=top bgcolor=#ffffcc> ! <td>$results[$i]->{'ordernumber'}</td> ! <td>$results[$i]->{'isbn'}</td> ! <td><a href="newbiblio.pl?ordnum=$results[$i]->{'ordernumber'}&id=$results[$i]->{'booksellerid'}&basket=$basket">$results[$i]->{'title'}</a></td> ! <td>$results[$i]->{'author'}</td> ! <td>\$<input type=text name=rrp$i size=6 value="$results[$i]->{'rrp'}"></td> ! <td>\$<input type=text name=eup$i size=6 value="$results[$i]->{'ecost'}"></td> ! <td><input type=text name=quantity$i size=6 value=$results[$i]->{'quantity'} onchange='update(this.form)'></td> ! <td>\$<input type=text name=total$i size=10 value=$line_total></td> ! <input type=hidden name=ordnum$i value=$results[$i]->{'ordernumber'}> ! <input type=hidden name=bibnum$i value=$results[$i]->{'biblionumber'}> </tr> EOP ; } ! # print "<input type=hidden name=number value=$count> <input type=hidden name=basketno value=\"$basket\">"; print <<EOP + <tr valign=top bgcolor=white><td colspan=6 rowspan=3 bgcolor=#cccc99 background="/images/background-mem.gif"> + <b>HELP</b><br> + To cancel an order, just change the quantity to 0 and click "save changes".<br> + To change any of the catalogue or accounting information attached to an order, click on the title.<br> + To add new orders to this supplier, start with a search. </td> + <td><b>SubTotal</b></td> + <td>\$<input type=text name=subtotal size=10 value=$sub_total></td></tr> <tr valign=top bgcolor=white> ! <td><b>GST</b></td> ! <td>\$<input type=text name=gst size=10 value=$gist></td></tr> ! <tr valign=top bgcolor=white><td><b>TOTAL</b></td> ! <td>\$<input type=text name=grandtotal size=10 value=$grand_total></td></tr> <tr valign=top bgcolor=white> ! <td></td> ! <td></td> ! <td></td> ! <td></td> ! <td></td> ! <td></td> ! <td colspan=3><input type=image name=submit src=/images/save-changes.gif border=0 width=187 height=42 align=right></td></tr> </table> ! </CENTER> EOP ! ; print endmenu('acquisitions');

1 0

CVS: koha/C4 Search.pm,1.13,1.14
by Chris Cormack 20 Feb '02

20 Feb '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv15057/C4 Modified Files: Search.pm Log Message: Making a "fix" to normal title search Index: Search.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Search.pm,v retrieving revision 1.13 retrieving revision 1.14 diff -C2 -r1.13 -r1.14 *** Search.pm 20 Feb 2002 20:53:29 -0000 1.13 --- Search.pm 20 Feb 2002 21:05:19 -0000 1.14 *************** *** 675,682 **** my $count=@key; my $i=1; ! $query="select * from biblio,bibliosubtitle,biblioitems where ! (biblio.biblionumber=bibliosubtitle.biblionumber and ! biblioitems.biblionumber=biblio.biblionumber) and (((title like '$key[0]%' or title like '% $key[0]%' or title like '% $key[0]')"; while ($i<$count){ --- 675,683 ---- my $count=@key; my $i=1; ! $query="select * from biblio,biblioitems ! left join bibliosubtitle on ! biblio.biblionumber=bibliosubtitle.biblionumber where ! biblioitems.biblionumber=biblio.biblionumber and (((title like '$key[0]%' or title like '% $key[0]%' or title like '% $key[0]')"; while ($i<$count){ *************** *** 796,800 **** } } ! #print $query; if ($type ne 'precise' && $type ne 'subject'){ if ($search->{'author'} ne ''){ --- 797,801 ---- } } ! print $query; if ($type ne 'precise' && $type ne 'subject'){ if ($search->{'author'} ne ''){

1 0