- Koha-devel - lists.koha-community.org

CVS: koha/circ circulation2.pl,NONE,1.1 circulation.pl,1.21,1.22
by Finlay Thompson 13 Mar '02

13 Mar '02

Update of /cvsroot/koha/koha/circ In directory usw-pr-cvs1:/tmp/cvs-serv10323 Modified Files: circulation.pl Added Files: circulation2.pl Log Message: This is the begining of a process of dividing up circulation.pl This script deals with the branch and printer selection stuff --- NEW FILE --- #!/usr/bin/perl use strict; use CGI qw/:standard/; use C4::Circulation::Circ2; use C4::Output; use C4::Print; use DBI; # this is a reorganisation of circulation.pl # dividing it up into three scripts...... # this will be the first one that chooses branch and printer settings.... my %env; my $headerbackgroundcolor='#99cc33'; my $circbackgroundcolor='#ffffcc'; my $circbackgroundcolor='white'; my $linecolor1='#ffffcc'; my $linecolor2='white'; my $backgroundimage="/images/background-mem.gif"; my $query=new CGI; my $branches=getbranches(\%env); my $printers=getprinters(\%env); my $branch=$query->param('branch'); my $printer=$query->param('printer'); ($branch) || ($branch=$query->cookie('branch')); ($printer) || ($printer=$query->cookie('printer')); my $oldbranch; my $oldprinter; if ($query->param('selectnewbranchprinter')) { $oldbranch=$branch; $oldprinter=$printer; $branch=''; $printer=''; } $env{'branchcode'}=$branch; $env{'printer'}=$printer; $env{'queue'}=$printer; # set up select options.... my $branchcount=0; my $printercount=0; my $branchoptions; my $printeroptions; foreach (keys %$branches) { (next) unless ($_); (next) if (/^TR$/); $branchcount++; my $selected=''; ($selected='selected') if ($_ eq $oldbranch); $branchoptions.="<option value=$_ $selected>$branches->{$_}->{'branchname'}\n"; } foreach (keys %$printers) { (next) unless ($_); $printercount++; my $selected=''; ($selected='selected') if ($_ eq $oldprinter); $printeroptions.="<option value=$_ $selected>$printers->{$_}->{'printername'}\n"; } # if there is only one.... if ($printercount==1) { ($printer)=keys %$printers; } if ($branchcount==1) { ($branch)=keys %$branches; } my $branchcookie=$query->cookie(-name=>'branch', -value=>"$branch", -expires=>'+1y'); my $printercookie=$query->cookie(-name=>'printer', -value=>"$printer", -expires=>'+1y'); my ($printerform, $branchform); if ($printercount>1) { $printerform=<<"EOF"; <table border=0 cellpadding=5 cellspacing=0 bgcolor='#dddddd' > <tr><td><select name=printer> $printeroptions </select></td></tr> </table> <input type=hidden name=branch value=$printer> EOF } else { my ($printer) = keys %$printers; $printerform=<<"EOF"; <input type=hidden name=printer value=$printer> EOF } if ($branchcount>1) { $branchform=<<"EOF"; <table border=0 cellpadding=5 cellspacing=0 bgcolor='#dddddd' > <tr><td> <select name=branch> $branchoptions </select> </td></tr> </table> <input type=hidden name=branch value=$branch> EOF } else { my ($branch) = keys %$branches; $branchform=<<"EOF"; <input type=hidden name=printer value=$printer> EOF } # set header with cookie.... print $query->header(-type=>'text/html',-expires=>'now', -cookie=>[$branchcookie,$printercookie]); print startpage(); print startmenu('circulation'); if ($branch and $printer) { print << "EOF"; <p align=right> <FONT SIZE=2 face="arial, helvetica"> <a href=circulation.pl?module=issues&branch=$branch&printer=$printer&print>Next Borrower</a> || <a href=circulation.pl?module=returns&branch=$branch&printer=$printer>Returns</a> || <a href=branchtransfers.pl>Transfer Book</a></font> <input type=hidden name=module value=issues> <input type=hidden name=branch value=$branch> <input type=hidden name=printer value=$printer> <input type=hidden name=barcode value=" "> </p> <table align=left border=0 cellpadding=5 cellspacing=0 > <tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage> <font color=black><b>Branch and Printer Settings<b></font> </td></tr> <tr><td> <b>Branch:</b> $branches->{$branch}->{'branchname'} </td><td><b>Printer:</b>$printers->{$printer}->{'printername'} </td></tr> <tr><td colspace=2> <a href=circulation2.pl?selectnewbranchprinter=1>Select new branch and printer</a> </td></tr> </table> <img src="/images/holder.gif" width=24 height=50 align=left> <table border=0 cellpadding=5 cellspacing=0 bgcolor='#dddddd' align=right> <form method=get> <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black> <b>Enter borrower card number<br> or partial last name</b></font> </td></tr> <tr><td><input name=findborrower></td></tr> </form> </table> EOF } else { print << "EOF"; <form method=post action=/cgi-bin/koha/circ/circulation2.pl> <table border=0 cellpadding=5 cellspacing=0> <tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage> <font color=black><b>Please Set Branch and Printer</b></font></td></tr> <tr><td> $branchform </td> <td> $printerform </td></tr> </table> <input type="submit" value="Change Settings" type="changesettings"> </form> EOF } print endmenu('circulation'); print endpage(); Index: circulation.pl =================================================================== RCS file: /cvsroot/koha/koha/circ/circulation.pl,v retrieving revision 1.21 retrieving revision 1.22 diff -C2 -r1.21 -r1.22 *** circulation.pl 12 Mar 2002 21:04:32 -0000 1.21 --- circulation.pl 14 Mar 2002 01:04:00 -0000 1.22 *************** *** 154,157 **** --- 154,158 ---- print endmenu('circulation'); print endpage(); + sub default { print << "EOF";

1 0

CVS: koha/C4/Circulation Circ2.pm,1.20,1.21
by Finlay Thompson 13 Mar '02

13 Mar '02

Update of /cvsroot/koha/koha/C4/Circulation In directory usw-pr-cvs1:/tmp/cvs-serv19044/C4/Circulation Modified Files: Circ2.pm Log Message: Added a transferbook subroutine that is called from /circ/branchtransfers.pl It writes a new line in the branchtransfers table and changes the currentbranch field in items. Index: Circ2.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Circulation/Circ2.pm,v retrieving revision 1.20 retrieving revision 1.21 diff -C2 -r1.20 -r1.21 *** Circ2.pm 25 Nov 2001 20:17:53 -0000 1.20 --- Circ2.pm 13 Mar 2002 21:13:42 -0000 1.21 *************** *** 25,29 **** @ISA = qw(Exporter); @EXPORT = qw(&getbranches &getprinters &getpatroninformation &currentissues &getiteminformation &findborrower &issuebook &returnbook ! &find_reserves); %EXPORT_TAGS = ( ); # eg: TAG => [ qw!name1 name2! ], --- 25,29 ---- @ISA = qw(Exporter); @EXPORT = qw(&getbranches &getprinters &getpatroninformation &currentissues &getiteminformation &findborrower &issuebook &returnbook ! &find_reserves &transferbook); %EXPORT_TAGS = ( ); # eg: TAG => [ qw!name1 name2! ], *************** *** 184,187 **** --- 184,205 ---- $dbh->disconnect; return(\@borrowers); + } + + + sub transferbook { + my ($env, $iteminformation, $barcode) = @_; + my $messages; + my $dbh=&C4Connect; + #new entry in branchtransfers.... + my $sth = $dbh->prepare("insert into branchtransfers (itemnumber, frombranch, datearrived, tobranch) values($iteminformation->{'itemnumber'}, '$env->{'frbranchcd'}', now(), '$env->{'tobranchcd'}')"); + $sth->execute || return (0,"database error: $sth->errstr"); + $sth->finish; + #update holdingbranch in items ..... + $sth = $dbh->prepare("update items set holdingbranch='$env->{'tobranchcd'}' where items.itemnumber=$iteminformation->{'itemnumber'}"); + $sth->execute || return (0,"database error: $sth->errstr"); + $sth->execute; + $sth->finish; + $dbh->disconnect; + return (1, $messages); }

1 0

CVS: koha/circ branchtransfers.pl,1.1,1.2
by Finlay Thompson 13 Mar '02

13 Mar '02

Update of /cvsroot/koha/koha/circ In directory usw-pr-cvs1:/tmp/cvs-serv17154/circ Modified Files: branchtransfers.pl Log Message: Fixed a small problem in the <form>, not hidden inputs are getting passed correctly. Index: branchtransfers.pl =================================================================== RCS file: /cvsroot/koha/koha/circ/branchtransfers.pl,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -r1.1 -r1.2 *** branchtransfers.pl 12 Mar 2002 21:04:32 -0000 1.1 --- branchtransfers.pl 13 Mar 2002 21:07:41 -0000 1.2 *************** *** 38,41 **** --- 38,42 ---- # collect the stack of books already transfered so they can printed... + my @messages; my %transfereditems; my $ritext = ''; *************** *** 45,49 **** (next) unless (/bc-(\d*)/); my $counter=$1; - (next) if ($counter>20); my $barcode=$query->param("bc-$counter"); my $frbcd=$query->param("fb-$counter"); --- 46,49 ---- *************** *** 60,64 **** #if the barcode has been entered action that and write a message and onto the top of the stack... my $iteminformation; ! my @messages; my $todaysdate; if (my $barcode=$query->param('barcode')) { --- 60,64 ---- #if the barcode has been entered action that and write a message and onto the top of the stack... my $iteminformation; ! my $todaysdate; if (my $barcode=$query->param('barcode')) { *************** *** 93,111 **** my $entrytext= << "EOF"; <form method=post action=/cgi-bin/koha/circ/branchtransfers.pl> ! <table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd > <tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage> <font color=black><b>Select Branch</b></font></td></tr> ! <tr><td>Destination Branch:</td><td> ! <select name=tobranchcd> $tobranchoptions </select> ! </td></tr> ! ! </table><table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd > ! <tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage> <font color=black><b>Enter Book Barcode</b></font></td></tr> <tr><td>Item Barcode:</td><td><input name=barcode size=10></td></tr> </table> - <input type=hidden name=tobranchcd value=$tobranchcd> $ritext EOF --- 93,109 ---- my $entrytext= << "EOF"; <form method=post action=/cgi-bin/koha/circ/branchtransfers.pl> ! <table border=0 cellpadding=5 cellspacing=0 bgcolor='#dddddd' > <tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage> <font color=black><b>Select Branch</b></font></td></tr> ! <tr><td>Destination Branch:</td> ! <td><select name=tobranchcd> $tobranchoptions </select></td></tr></table> ! <table border=0 cellpadding=5 cellspacing=0 bgcolor='#dddddd' ><tr> ! <td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage> <font color=black><b>Enter Book Barcode</b></font></td></tr> <tr><td>Item Barcode:</td><td><input name=barcode size=10></td></tr> </table> <input type=hidden name=tobranchcd value=$tobranchcd> $ritext + </form> EOF *************** *** 167,196 **** print endmenu('circulation'); print endpage; - - - ############################################################################ - # - # this is the database query that will go into C4::Circuation::Circ2 - # - - use DBI; - use C4::Database; - - sub transferbook { - my ($env, $iteminformation, $barcode) = @_; - my $messages; - my $dbh=&C4Connect; - #new entry in branchtransfers.... - my $sth = $dbh->prepare("insert into branchtransfers (itemnumber, frombranch, datearrived, tobranch) values($iteminformation->{'itemnumber'}, '$env->{'frbranchcd'}', now(), '$env->{'tobranchcd'}')"); - $sth->execute || return (0,"database error: $sth->errstr"); - $sth->finish; - #update holdingbranch in items ..... - $sth = $dbh->prepare("update items set holdingbranch='$env->{'tobranchcd'}' where items.itemnumber=$iteminformation->{'itemnumber'}"); - $sth->execute || return (0,"database error: $sth->errstr"); - $sth->execute; - $sth->finish; - $dbh->disconnect; - return (1, $messages); - } - --- 165,167 ----

1 0

CVS: koha search.pl,1.4,1.5
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv31173 Modified Files: search.pl Log Message: Removing reference to the FrontSearch subroutine as its never called Index: search.pl =================================================================== RCS file: /cvsroot/koha/koha/search.pl,v retrieving revision 1.4 retrieving revision 1.5 diff -C2 -r1.4 -r1.5 *** search.pl 5 Oct 2001 20:13:20 -0000 1.4 --- search.pl 13 Mar 2002 07:46:43 -0000 1.5 *************** *** 1,8 **** #!/usr/bin/perl #script to provide intranet (librarian) advanced search facility - #modified 9/11/1999 by chris(a)katipo.co.nz - #adding an extra comment to play with CVS (Si, 19/11/99) - #modified 29/12/99 by chris(a)katipo.co.nz to be usavle by opac as well - #modified by chris 10/11/00 to fix dewey search use strict; --- 1,4 ---- *************** *** 32,36 **** } ! #print $input->dump; my $blah; my %search; --- 28,32 ---- } ! #print $input->Dump; my $blah; my %search; *************** *** 58,61 **** --- 54,59 ---- my $dewey=validate($input->param('dewey')); $search{'dewey'}=$dewey; + my $branch=validate($input->param('branch')); + $search{'branch'}=$branch; my @results; my $offset=$input->param('offset'); *************** *** 69,75 **** print startpage(); print startmenu($type); #print $search{'ttype'}; ! if ($type ne 'opac'){ print mkheadr(1,'Catalogue Search Results'); } else { print mkheadr(1,'Opac Search Results'); --- 67,76 ---- print startpage(); print startmenu($type); + #print $type; #print $search{'ttype'}; ! if ($type eq 'intra'){ print mkheadr(1,'Catalogue Search Results'); + } elsif ($type eq 'catmain'){ + print mkheadr(1,'Catalogue Maintenance'); } else { print mkheadr(1,'Opac Search Results'); *************** *** 85,96 **** } else { if ($keyword ne ''){ - # print "hey"; ($count,@results)=&KeywordSearch(\$blah,'intra',\%search,$num,$offset); - } elsif ($search{'front'} ne '') { - ($count,@results)&FrontSearch(\$blah,'intra',\%search,$num,$offset); - # print "hey"; }elsif ($title ne '' || $author ne '' || $illustrator ne '' || $dewey ne '' || $class ne '') { ($count,@results)=&CatSearch(\$blah,'loose',\%search,$num,$offset); - # print "hey"; } } --- 86,92 ----

1 0

CVS: koha/C4 Search.pm,1.15,1.16
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv30271/C4 Modified Files: Search.pm Log Message: Tidy up, removing deprecated routines Index: Search.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Search.pm,v retrieving revision 1.15 retrieving revision 1.16 diff -C2 -r1.15 -r1.16 *** Search.pm 13 Mar 2002 03:26:43 -0000 1.15 --- Search.pm 13 Mar 2002 07:36:49 -0000 1.16 *************** *** 18,24 **** @ISA = qw(Exporter); @EXPORT = qw(&CatSearch &BornameSearch &ItemInfo &KeywordSearch &subsearch ! &itemdata &bibdata &GetItems &borrdata &getacctlist &itemnodata &itemcount ! &OpacSearch &borrdata2 &NewBorrowerNumber &bibitemdata &borrissues ! &getboracctrecord &ItemType &itemissues &FrontSearch &subject &subtitle &addauthor &bibitems &barcodes &findguarantees &allissues &systemprefs &findguarantor); --- 18,24 ---- @ISA = qw(Exporter); @EXPORT = qw(&CatSearch &BornameSearch &ItemInfo &KeywordSearch &subsearch ! &itemdata &bibdata &GetItems &borrdata &itemnodata &itemcount ! &borrdata2 &NewBorrowerNumber &bibitemdata &borrissues ! &getboracctrecord &ItemType &itemissues &subject &subtitle &addauthor &bibitems &barcodes &findguarantees &allissues &systemprefs &findguarantor); *************** *** 117,255 **** } - sub OpacSearch { - my ($env,$type,$search,$num,$offset)=@_; - my $dbh = &C4Connect; - $search->{'keyword'}=~ s/'/\\'/g; - my @key=split(' ',$search->{'keyword'}); - my $count=@key; - my $i=1; - my @results; - my $query ="Select count(*) from biblio where - ((title like '$key[0]%' or title like '% $key[0]%')"; - while ($i < $count){ - $query=$query." and (title like '$key[$i]%' or title like '% $key[$i]%')"; - $i++; - } - $query=$query.") or ((author like '$key[0]%' or author like '% $key[0]%')"; - $i=1; - while ($i < $count){ - $query=$query." and (author like '$key[$i]%' or author like '% $key[$i]%')"; - $i++; - } - $query.=") or ((seriestitle like '$key[0]%' or seriestitle like '% $key[0]%')"; - for ($i=1;$i<$count;$i++){ - $query.=" and (seriestitle like '$key[$i]%' or seriestitle like '% $key[$i]%')"; - } - $query.= ") or ((notes like '$key[0]%' or notes like '% $key[0]%')"; - for ($i=1;$i<$count;$i++){ - $query.=" and (notes like '$key[$i]%' or notes like '% $key[$i]%')"; - } - $query=$query.") order by title"; - my $sth=$dbh->prepare($query); - $sth->execute; - my $data=$sth->fetchrow_hashref; - my $count=$data->{'count(*)'}; - $sth->finish; - $query=~ s/count$\*$/\*/; - $query= $query." limit $offset,$num"; - $sth=$dbh->prepare($query); - # print $query; - $sth->execute; - $i=0; - while (my $data=$sth->fetchrow_hashref){ - my $sti=$dbh->prepare("select dewey,subclass from biblioitems where biblionumber=$data->{'biblionumber'}"); - $sti->execute; - my ($dewey, $subclass) = $sti->fetchrow; - $dewey=~s/0*$//; - ($dewey == 0) && ($dewey=''); - ($dewey) && ($dewey.=" $subclass"); - $sti->finish; - $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$dewey"; - $i++; - } - $sth->finish; - $dbh->disconnect; - return($count,@results); - } - - - - sub FrontSearch { - my ($env,$type,$search,$num,$offset)=@_; - my $dbh = &C4Connect; - $search->{'front'}=~ s/ +$//; - $search->{'front'}=~ s/'/\\'/; - my @key=split(' ',$search->{'front'}); - my $count=@key; - my $i=1; - my @results; - my $query ="Select * from biblio,bibliosubtitle where - biblio.biblionumber=bibliosubtitle.biblionumber and - ((title like '$key[0]%' or title like '% $key[0]%' - or subtitle like '$key[0]%' or subtitle like '% $key[0]%' - or author like '$key[0]%' or author like '% $key[0]%')"; - while ($i < $count){ - $query=$query." and (title like '%$key[$i]%' or subtitle like '%$key[$i]%')"; - $i++; - } - $query=$query.") group by biblio.biblionumber order by author,title"; - print $query; - my $sth=$dbh->prepare($query); - $sth->execute; - $i=0; - while (my $data=$sth->fetchrow_hashref){ - my $sti=$dbh->prepare("select dewey,subclass from biblioitems where biblionumber=$data->{'biblionumber'}"); - $sti->execute; - my ($dewey, $subclass) = $sti->fetchrow; - $dewey=~s/\.*0*$//; - ($dewey == 0) && ($dewey=''); - ($dewey) && ($dewey.=" $subclass"); - $sti->finish; - $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey"; - # print $results[$i]; - $i++; - } - $sth->finish; - $sth=$dbh->prepare("Select biblionumber from bibliosubject where subject - like '%$search->{'keyword'}%'"); - $sth->execute; - while (my $data=$sth->fetchrow_hashref){ - my $sth2=$dbh->prepare("Select * from biblio where - biblionumber=$data->{'biblionumber'}"); - $sth2->execute; - while (my $data2=$sth2->fetchrow_hashref){ - - $results[$i]="$data2->{'author'}\t$data2->{'title'}\t$data2->{'biblionumber'}\t$data->{'copyrightdate'}"; - # print $results[$i]; - $i++; - } - $sth2->finish; - } - my $i2=1; - @results=sort @results; - my @res; - my $count=@results; - $i=1; - $res[0]=$results[0]; - while ($i2 < $count){ - if ($results[$i2] ne $res[$i-1]){ - $res[$i]=$results[$i2]; - $i++; - } - $i2++; - } - $i2=0; - my @res2; - $count=@res; - while ($i2 < $num && $i2 < $count){ - $res2[$i2]=$res[$i2+$offset]; - # print $res2[$i2]; - $i2++; - } - $sth->finish; - $dbh->disconnect; - return($i,@res2); - } - sub KeywordSearch { --- 117,120 ---- *************** *** 797,801 **** } } ! print $query; if ($type ne 'precise' && $type ne 'subject'){ if ($search->{'author'} ne ''){ --- 662,666 ---- } } ! #print $query; if ($type ne 'precise' && $type ne 'subject'){ if ($search->{'author'} ne ''){ *************** *** 1276,1308 **** return($data2->{'count(*)'},$data->{'count(*)'},$data3->{'sum(amountoutstanding)'}); } ! ! sub getacctlist { ! my ($env,$params) = @_; ! my $dbh=C4Connect; ! my @acctlines; ! my $numlines; ! my $query = "Select borrowernumber, accountno, date, amount, description, ! dispute, accounttype, amountoutstanding, barcode, title ! from accountlines,items,biblio ! where borrowernumber = $params->{'borrowernumber'} "; ! if ($params->{'acctno'} ne "") { ! my $query = $query." and accountlines.accountno = $params->{'acctno'} "; ! } ! my $query = $query." and accountlines.itemnumber = items.itemnumber ! and items.biblionumber = biblio.biblionumber ! and accountlines.amountoutstanding<>0 order by date"; ! my $sth=$dbh->prepare($query); ! # print $query; ! $sth->execute; ! my $total=0; ! while (my $data=$sth->fetchrow_hashref){ ! $acctlines[$numlines] = $data; ! $numlines++; ! $total = $total+ $data->{'amountoutstanding'}; ! } ! return ($numlines,\@acctlines,$total); ! $sth->finish; ! $dbh->disconnect; ! } sub getboracctrecord { --- 1141,1145 ---- return($data2->{'count(*)'},$data->{'count(*)'},$data3->{'sum(amountoutstanding)'}); } ! sub getboracctrecord {

1 0

CVS: koha opac-search.pl,1.2,NONE
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv26150 Removed Files: opac-search.pl Log Message: Deprecated searching is all handled by search.pl --- opac-search.pl DELETED ---

1 0

CVS: koha moremember.pl,1.8,1.9
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv14561 Modified Files: moremember.pl Log Message: Getting Iteminfo in Search to only display correct reserves (mainly used on detail.pl) and another typo fix in moremember.pl Index: moremember.pl =================================================================== RCS file: /cvsroot/koha/koha/moremember.pl,v retrieving revision 1.8 retrieving revision 1.9 diff -C2 -r1.8 -r1.9 *** moremember.pl 13 Mar 2002 02:46:07 -0000 1.8 --- moremember.pl 13 Mar 2002 03:26:43 -0000 1.9 *************** *** 227,231 **** # } #check item is not reserved ! my ($rescount,$reserves)=Findgroupreserve($issue->[$i]{'biblioitemnumber'},''); if ($rescount >0){ print "<TD><a href=/cgi-bin/koha/request.pl?bib=$issue->[$i]{'biblionumber'}>On Request - no renewals</a></td></tr>"; --- 227,231 ---- # } #check item is not reserved ! my ($rescount,$reserves)=Findgroupreserve($issue->[$i]{'biblioitemnumber'},$issue->[$i]{'biblionumber'}); if ($rescount >0){ print "<TD><a href=/cgi-bin/koha/request.pl?bib=$issue->[$i]{'biblionumber'}>On Request - no renewals</a></td></tr>";

1 0

CVS: koha/C4 Search.pm,1.14,1.15 Reserves2.pm,1.3,1.4
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha/C4 In directory usw-pr-cvs1:/tmp/cvs-serv14561/C4 Modified Files: Search.pm Reserves2.pm Log Message: Getting Iteminfo in Search to only display correct reserves (mainly used on detail.pl) and another typo fix in moremember.pl Index: Search.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Search.pm,v retrieving revision 1.14 retrieving revision 1.15 diff -C2 -r1.14 -r1.15 *** Search.pm 20 Feb 2002 21:05:19 -0000 1.14 --- Search.pm 13 Mar 2002 03:26:43 -0000 1.15 *************** *** 908,912 **** } if ($datedue eq ''){ ! my ($rescount,$reserves)=FindReserves($biblionumber,''); if ($rescount >0){ $datedue='Request'; --- 908,913 ---- } if ($datedue eq ''){ ! my ($rescount,$reserves)=Findgroupreserve($data->{'biblioitemnumber'},$biblionumber); ! if ($rescount >0){ $datedue='Request'; Index: Reserves2.pm =================================================================== RCS file: /cvsroot/koha/koha/C4/Reserves2.pm,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** Reserves2.pm 13 Mar 2002 02:03:57 -0000 1.3 --- Reserves2.pm 13 Mar 2002 03:26:43 -0000 1.4 *************** *** 92,103 **** sub Findgroupreserve { ! my ($bibitem)=@_; my $dbh=C4Connect; $bibitem=$dbh->quote($bibitem); ! my $query="Select * from reserves,reserveconstraints where ! reserves.biblionumber=reservesconstraints.biblionumber and ! and reserveconstraints.biblioitemnumber=$bibitem and reserves.cancellationdate is NULL and (reserves.found <> 'F' or reserves.found is NULL)"; my $sth=$dbh->prepare($query); $sth->execute; --- 92,110 ---- sub Findgroupreserve { ! my ($bibitem,$biblio)=@_; my $dbh=C4Connect; $bibitem=$dbh->quote($bibitem); ! my $query="Select * from reserves ! left join reserveconstraints on ! reserves.biblionumber=reserveconstraints.biblionumber ! where ! reserves.biblionumber=$biblio and ! ((reserveconstraints.biblioitemnumber=$bibitem ! and reserves.borrowernumber=reserveconstraints.borrowernumber ! and reserves.reservedate=reserveconstraints.reservedate) ! or reserves.constrainttype='a') and reserves.cancellationdate is NULL and (reserves.found <> 'F' or reserves.found is NULL)"; + # print $query; my $sth=$dbh->prepare($query); $sth->execute;

1 0

CVS: koha moremember.pl,1.7,1.8
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv3635 Modified Files: moremember.pl Log Message: Typo fix (doh!) Index: moremember.pl =================================================================== RCS file: /cvsroot/koha/koha/moremember.pl,v retrieving revision 1.7 retrieving revision 1.8 diff -C2 -r1.7 -r1.8 *** moremember.pl 13 Mar 2002 02:03:56 -0000 1.7 --- moremember.pl 13 Mar 2002 02:46:07 -0000 1.8 *************** *** 227,231 **** # } #check item is not reserved ! my ($rescount,$reserves)=Findgroupreserve($issue->[$i]{'biblionumber'},''); if ($rescount >0){ print "<TD><a href=/cgi-bin/koha/request.pl?bib=$issue->[$i]{'biblionumber'}>On Request - no renewals</a></td></tr>"; --- 227,231 ---- # } #check item is not reserved ! my ($rescount,$reserves)=Findgroupreserve($issue->[$i]{'biblioitemnumber'},''); if ($rescount >0){ print "<TD><a href=/cgi-bin/koha/request.pl?bib=$issue->[$i]{'biblionumber'}>On Request - no renewals</a></td></tr>";

1 0

CVS: koha moremember.pl,1.6,1.7
by Chris Cormack 12 Mar '02

12 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv24070 Modified Files: moremember.pl Log Message: Fix so that reserves are only showing for the biblioitem not the biblio on the moremembers screen Index: moremember.pl =================================================================== RCS file: /cvsroot/koha/koha/moremember.pl,v retrieving revision 1.6 retrieving revision 1.7 diff -C2 -r1.6 -r1.7 *** moremember.pl 2 May 2001 21:11:41 -0000 1.6 --- moremember.pl 13 Mar 2002 02:03:56 -0000 1.7 *************** *** 60,63 **** --- 60,75 ---- Card Number: $data->{'cardnumber'}<BR> + printend + ; + if ($data->{'categorycode'} eq 'C'){ + my $data2=borrdata('',$data->{'guarantor'}); + $data->{'streetaddress'}=$data2->{'streetaddress'}; + $data->{'city'}=$data2->{'city'}; + $data->{'physstreet'}=$data2->{'phystreet'}; + $data->{'streetcity'}=$data2->{'streetcity'}; + $data->{'phone'}=$data2->{'phone'}; + $data->{'phoneday'}=$data2->{'phoneday'}; + } + print <<printend Postal Address: $data->{'streetaddress'}, $data->{'city'}<BR> Home Address: $data->{'physstreet'}, $data->{'streetcity'}<BR> *************** *** 65,69 **** Phone (Daytime): $data->{'phoneday'}<BR> Fax: $data->{'faxnumber'}<BR> ! E-mail: <a href="mailto:$data->{'emailaddress'}">$data->{'emailaddress'}</a><P> Membership Number: $data->{'borrowernumber'}<BR> Membership: $data->{'categorycode'}<BR> --- 77,82 ---- Phone (Daytime): $data->{'phoneday'}<BR> Fax: $data->{'faxnumber'}<BR> ! E-mail: <a href="mailto:$data->{'emailaddress'}">$data->{'emailaddress'}</a><br> ! Textmessaging:$data->{'textmessaging'}<p> Membership Number: $data->{'borrowernumber'}<BR> Membership: $data->{'categorycode'}<BR> *************** *** 80,89 **** Relationship: $data->{'altrelationship'}<BR> Notes: $data->{'altnotes'}<P> - Guarantees: printend ; ! my ($count,$guarantees)=findguarantees($data->{'borrowernumber'}); ! for (my $i=0;$i<$count;$i++){ ! print "<A HREF=\"/cgi-bin/koha/moremember.pl?bornum=$guarantees->[$i]->{'borrowernumber'}\">$guarantees->[$i]->{'cardnumber'}</a><br>"; } print <<printend --- 93,113 ---- Relationship: $data->{'altrelationship'}<BR> Notes: $data->{'altnotes'}<P> printend ; ! ! if ($data->{'categorycode'} ne 'C'){ ! print " Guarantees:"; ! my ($count,$guarantees)=findguarantees($data->{'borrowernumber'}); ! for (my $i=0;$i<$count;$i++){ ! print "<A HREF=\"/cgi-bin/koha/moremember.pl?bornum=$guarantees->[$i]->{'borrowernumber'}\">$guarantees->[$i]->{'cardnumber'}</a><br>"; ! } ! } else { ! print "Guarantor:"; ! my ($guarantor)=findguarantor($data->{'borrowernumber'}); ! if ($guarantor->{'borrowernumber'} == 0){ ! print "no guarantor<br>"; ! } else { ! print "<A HREF=\"/cgi-bin/koha/moremember.pl?bornum=$guarantor->{'borrowernumber'}\">$guarantor->{'cardnumber'}</a><br>"; ! } } print <<printend *************** *** 203,207 **** # } #check item is not reserved ! my ($rescount,$reserves)=FindReserves($issue->[$i]{'biblionumber'},''); if ($rescount >0){ print "<TD><a href=/cgi-bin/koha/request.pl?bib=$issue->[$i]{'biblionumber'}>On Request - no renewals</a></td></tr>"; --- 227,231 ---- # } #check item is not reserved ! my ($rescount,$reserves)=Findgroupreserve($issue->[$i]{'biblionumber'},''); if ($rescount >0){ print "<TD><a href=/cgi-bin/koha/request.pl?bib=$issue->[$i]{'biblionumber'}>On Request - no renewals</a></td></tr>"; *************** *** 258,262 **** $reserves->[$i]{'reservedate'}="$temp[2]/$temp[1]/$temp[0]"; print "<tr VALIGN=TOP > ! <TD><a href=\"/cgi-bin/koha/request.pl?bib=$reserves->[$i]{'biblionumber'}\">$reserves->[$i]{'title'}</a></td> <TD>$reserves->[$i]{'reservedate'}</td> <input type=hidden name=biblio value=$reserves->[$i]{'biblionumber'}> --- 282,286 ---- $reserves->[$i]{'reservedate'}="$temp[2]/$temp[1]/$temp[0]"; print "<tr VALIGN=TOP > ! <TD><a href=\"/cgi-bin/koha/request.pl?bib=$reserves->[$i]{'biblionumber'}\">$reserves->[$i]{'btitle'}</a></td> <TD>$reserves->[$i]{'reservedate'}</td> <input type=hidden name=biblio value=$reserves->[$i]{'biblionumber'}>

1 0