- Koha-devel - lists.koha-community.org

TestBuilder float and decimal format differs from the values returned by database
by Lari Taskula 08 Feb '21

08 Feb '21

Hi devs, While working on patron data export ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 ), I was trying to generate a bunch of test data with TestBuilder, and then compare them to what was returned by DBIx's search(). Unfortunately I couldn't do this, because most decimals from DBI/DBIx are returned in a different formatting to what TestBuilder has. Running an is_deeply() to compare the objects fails with: # Structures begin differing at: # $got->[0]{amount} = '90203.710000' (value returned by DBIx) # $expected->[0]{amount} = '90203.71' (value in HASHref generated by TestBuilder) This is because TestBuilder's _gen_real() forces the formatting to 2 decimal places. But there's more - My original idea to solve this issue was by using "column_info" provided by DBIx, and formatting the value to maximum decimal places allowed. But even if you follow the column's size definition, you will notice that there is a different behavior between data types "float"/"double" and "decimal". If it's a decimal, it stays in "stringified" format with all those trailing zeroes, but if it's a float, all the insignificant zeroes are dropped from the end. At some layer lower than DBIx (perhaps DBD::mysql?) there appears to be some formatting magic. A concrete example of this is when you have a FLOAT(10,4) and DECIMAL(10,4) columns and store "10.1000" in both columns, in the end the float becomes 10.1 and the decimal "10.1000". It's the same result with both DBI and DBIx. However, for example mariadb-client chooses to format both values as "10.1000". My other solution was to reload the row generated by DBIx in TestBuilder::_storeColumnValues() with discard_changes/get_from_storage method, but that 1. doesn't work for tables that do not have primary key (e.g. statistics), see DBIx::Class::ResultSource::_pri_cols_or_die(): Operation requires a primary key to be declared on 'Statistic' via set_primary_key at /home/koha/Koha/t/lib/TestBuilder.pm line 362 2. adds some overhead, although only into tests I would appreciate some ideas or improvements. I've created a Bug for this issue, see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 . There is a test to demonstrate the issue, and the previously mentioned attempts to solve this issue. P.S. Somewhat related bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 -- Lari Taskula CEO, Hypernova Oy PL 16 80101 Joensuu, Finland

2 2

Cross-browser automated testing in Javascript (Puppeteer/Playwright)
by dcook＠prosentient.com.au 04 Feb '21

04 Feb '21

Hi all, What do people think about doing our cross-browser automated testing in Javascript rather than Perl? We're already using Node.js for generating Koha's CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff _interface. I've been playing with Puppeteer and Playwright lately for non-test related browser automation, and they're pretty easy to work with. Playwright is based on Puppeteer, and their basic APIs are the same, so fairly interchangeable. (We'd need to use another library like Jest or Playwright-test to do the test evaluation.) It looks like we only have 6 files that use Selenium, so it wouldn't be a big drama to replace them. There is a Perl library https://metacpan.org/pod/Playwright but it's just a wrapper around Playwright anyway and it's so new that I'd be a bit wary of using it. David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

2 2

Zebra ICU / phrases-icu.xml / Bug 27299
by dcook＠prosentient.com.au 01 Feb '21

01 Feb '21

Hi all, Indexdata have confirmed that the default phrases-icu.xml shipped with Zebra (and Koha) is misconfigured. They're updating the default one in Zebra and I have a patch to update Koha at Bug 27299: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 It's an easy enough change to make, and I'll be updating it for all my ICU libraries. I encourage all you Zebra ICU users out there to update your phrases-icu.xml as I've suggested on Bugzilla. I think that you'll find it makes a world of difference. Cheers, David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

2 2

Koha Community Newsletter: January 2021
by Koha Newsletter 31 Jan '21

31 Jan '21

The Koha Community Newsletter for January 2021 is here: https://koha-community.org/koha-community-newsletter-january-2021/ Many thanks to everyone who submitted articles and news to last month's newsletter! Please feel free to email me with any corrections or suggestions. -- Michael Kuhn Editor, Koha Community Newsletter

1 0

Elasticsearch changing licences
by dcook＠prosentient.com.au 27 Jan '21

27 Jan '21

Hi all, Have folk heard that Elastic is changing the Elasticsearch licence? Depending on your sources and your beliefs, this may or may not matter, but certainly something to be aware of. https://www.elastic.co/pricing/faq/licensing David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595

12 23

To add a new filed to search (with ElasticSearch)
by Zeno Tajoli 26 Jan '21

26 Jan '21

Hi to all, how can I add a new field to search, if I use ElasticSearch ? As I have check on wiki and on documentation, I need to use .yaml files. As I know is not possible to add new fields with "Search engine configuration (Elasticsearch)". Or is it possible ? Cheers Zeno Tajoli -- Zeno Tajoli System Librarian

2 1

Re: [Koha-devel] [Koha] Coverflow not working koha 20.05
by Tomas Cohen Arazi 25 Jan '21

25 Jan '21

Make sure you use the latest coverflow .kpz from the site, and make sure you restart all the things after uploading it. Also, I found that the move of OPACMainUserBlock into the news section, produced undesired effects. Also, verify there's no stray JavaScript in OPACUserJS (related to Coverflow. of course) El sáb, 23 ene 2021 a las 11:15, MAMCET Library (<mamcet.library10(a)gmail.com>) escribió: > Hi > I have did all the setup and everything seems to be ok also but coverflow > does not load on the OPAC page of Koha, Please suggest. I am using ubuntu > MATE 20.4 LTS and Koha 20.05. > _______________________________________________ > > Koha mailing list http://koha-community.org > Koha(a)lists.katipo.co.nz > Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha > -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F

1 0

REST API / MARC fields
by Marcel de Rooy 24 Jan '21

24 Jan '21

Hi all, Any thoughts here about how we should handle updating fields in MARC which have no specific corresponding database field. I am thinking about e.g. a persistent identifier in MARC21 field 024 or an OCLC number in field 035. Could we add REST API entries for such changes as well? They will only generate changes in the marcxml for now.. Thanks, Marcel

4 4

Release of Koha 20.05.08
by Andrew Fuerste-Henry 22 Jan '21

22 Jan '21

Hi folks! The Koha community is proud to announce the release of Koha 20.05.08! Koha 20.05.08 is a bugfix/maintenance release. It includes 4 enhancements, 35 bugfixes. The full release notes can be found here: https://koha-community.org/koha-20-05-08-released/ -- Andrew Fuerste-Henry Educator (he/him/his) ByWater Solutions bywatersolutions.com Phone:(888)900-8944 <(888)%20900-8944> What is Koha? <http://bywatersolutions.com/what-is-koha/>

1 0

Release of Koha 20.11.02
by Fridolin SOMERS 22 Jan '21

22 Jan '21

Hello everyone 🤗 The Koha community is proud to announce the release of Koha 20.11.02. It is a maintenance release including 10 enhancements, 50 bugfixes. Contains 5 critical bugfixes especially : Bug 27509 - cn_sort value is lost when editing an item without changing cn_source or itemcallnumber The full release notes are available here: https://koha-community.org/koha-20-11-02-released/ Debian packages should be available in a few days. Best regards 🐌 -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> Software and system maintainer 🦄 BibLibre, France

1 0