- Koha-devel - lists.koha-community.org

New Rest API RFCs
by Josef Moravec 27 Oct '18

27 Oct '18

Hello developers, Me and Michal Denar were thinking a bit about some REST api endpoints, write down some rfcs and would like to see any comment on them ;) Thanks in advance https://wiki.koha-community.org/wiki/Checkouts_endpoint_RFC https://wiki.koha-community.org/wiki/Availability_endpoints_RFC In this one we heavily used Katrin's comments and proposed new object definition, thanks Katrin ;) https://wiki.koha-community.org/wiki/Items_endpoint_RFC -- Josef Moravec josef.moravec(a)gmail.com

6 5

Is finesMode = test still operational and sending emails?
by Magnus Enger 27 Oct '18

27 Oct '18

Hi! The help of the cronjob fines.pl says: This script calculates and charges overdue fines to patron accounts. The Koha system preference 'finesMode' controls whether the fines are calculated and charged to the patron accounts ("Calculate and charge"); calculated and emailed to the admin but not applied ("Calculate (but only for mailing to the admin)"); or not calculated ("Don't calculate"). I have a library set up with finesMode = test and as far as I can tell everything is as it should be. But no emails are sent to KohaAdminEmailAddress. Reading through fines.pl I can see it generating a file, but not doing any emailing. Am I missing something or did we loose the emailing somewhere along the way? Best regards, Magnus

2 1

bulkmarcimport -d and -fk
by Stefano Bargioni 27 Oct '18

27 Oct '18

Hi, all, before adding a bug, I'd like to discuss this issue with others. For testing, I installed Koha 18.06.00.032 and Elasticsearch on a Debian 8 virtual machine, using packages koha-common and koha-elasticsearch. Mysql is "mysql Ver 14.14 Distrib 5.5.60, for debian-linux-gnu (x86_64) using readline 6.3". bulkmarcimport.pl -d fails with errors like Cannot truncate a table referenced in a foreign key constraint when going to truncate tables biblio, biblioitems, items. The -fk option is required. This is probably due to the more strict "way of life" of Mysql. Do we need to force -fk when -d is specified? Or simply we have to update the -h documentation? Thx. Stefano

2 1

Escape all the TT variables! (aka prevent XSS vulnerabilities)
by Jonathan Druart 26 Oct '18

26 Oct '18

Hi devs, This needs an update. Bug 13618 has been pushed to master. Now you will have to escape all the variables template-side. See the wiki page to understand why and how - https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_filter_all_th… There is a test in the QA script (missing_filter) as well as a test in the codebase to catch missing filters (xt/find-missing-filters.t) To make things easier you can use the misc script (misc/devel/ add_missing_filters.pl) to automatically add the missing filters! Cheers, Jonathan

1 0

SQL-modes wiki page
by Jonathan Druart 26 Oct '18

26 Oct '18

Hi, I have opened a wiki page to try and explain the problems we are facing (and trying to fix) with the SQL modes. I let you read carefully this page and tell me if something is not clear enough:https://wiki.koha-community.org/wiki/SQL_modes Cheers, Jonathan

2 1

The order of "use"
by Mark Tompsett 25 Oct '18

25 Oct '18

Greetings, I was looking at bug 21641, and noticed the patch was explicitly stating C4::Accounts:: on the function in question. I vaguely recalled this sort of symptom shows itself in a knotted “use” mess. C4::Circulation –> C4::Members –> C4::Accounts C4::Circulation –> C4::Accounts C4::Circulation –> C4::Overdues –> C4::Accounts What is the best order to list these? C4::Accounts last? Is putting the C4::Accounts:: on the function in question still something we should do anyways? Feedback appreciated, Mark Tompsett

3 6

Re: [Koha-devel] Price format in order by email
by Holger Meissner 24 Oct '18

24 Oct '18

Thank you, Barton! [%- USE Price -%] [% <<aqorders.listprice>> | $Price %] did the trick :)

2 1

Price format in order by email
by Holger Meissner 24 Oct '18

24 Oct '18

Dear koha devs, when we send an order by email <<aqorders.listprice>> is formatted with decimal point and six decimal places, in spite of syspref CurrencyFormat set to EUR. Is anyone working on this? Is there some kind of workaround? koha version 17.11.10.000. Thanks, Holger

2 1

Koha 17.11.11 release
by Fridolin SOMERS 24 Oct '18

24 Oct '18

The Koha community is proud to announce the release of Koha 17.11.11. This is a maintenance release. The full release notes are available at https://koha-community.org/koha-17-11-11-release/ Debian packages will be upgraded in a few days. I've proposed to continue maitaining 17.11.x in Koha 19.05 roles. Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre, France - software and system maintainer

1 0

Generic OpenIDConnect client
by David Cook 24 Oct '18

24 Oct '18

Hi all, About 4 years ago, I wrote a generic OpenIDConnect client, and kept telling myself that I would upstream it but I never did. until now: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586. I wrote it for 1 specific client, so it exists heavily in a set of "Prosentient" namespaces and some of the code is legacy from 3.14 and could be replaced by modern code (I'm looking at you Koha::Prosentient::Borrowers), but maybe people can try it out and give me some feedback to make it worthy of a sign off, or people can adapt it and I can give feedback. (I already have some things I would like to change. I think I overuse base64url. but it is essential when working with JWTs. I think I just got carried away with a substitution command once.) I know we already have the GoogleOpenIdConnect. I actually wrote this code before that code existed, but I don't think my code would work for Google the way it is now. It would probably need some alterations. Anyway, I was sick of telling myself that I would upstream it one day, so I sat down and made a patch and now it's shared. Cheers, David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

3 4