- Koha-devel - lists.koha-community.org

Bug 15395: Internationalization, plural forms, context and more
by Julian Maurice 30 Oct '18

30 Oct '18

Hi all, This bug has been signed off more than a year ago but it is still not Passed QA. It seems that not everyone agree on it. It should probably be discussed during an IRC meeting, but in the meantime, I wrote a wiki page [1] to better explain what it is supposed to do and created a thread on framavox [2] to gather opinions. If you have some time, I would really appreciate feedback on this feature. Thanks. [1] https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_co… [2] https://framavox.org/d/2juWqIMz/internationalization-plural-forms-context-a… PS: framavox.org is a free software (Loomio) hosted by a French association (Framasoft) promoting free software. It only requires an e-mail address to create an account. -- Julian Maurice <julian.maurice(a)biblibre.com> BibLibre

1 0

wrong url/uri filters
by Jonathan Druart 30 Oct '18

30 Oct '18

Hi devs, Another quick update about the ongoing work on the variable filtering. Bug 21526 fixes the href attributes for links in a naive way (replacing html with uri), but there are a few wrong replacements that have been done (uri should have been url instead). I tried to fix them today with a follow-up on the bug, but it is not ready yet. If you find internal links that do not work it is certainly caused by this bug. Instead of opening a new bug report, please make sure the follow-up fixes the issue. Cheers, Jonathan

1 0

Kanopy and SIP2 hack
by Mark Alexander 27 Oct '18

27 Oct '18

Our little library is preparing to use the Kanopy video streaming service. Kanopy can use SIP2 to query our Koha server for the purpose of user authentication. That's great; I can enable SIP2 pretty easily. The problem is that our librarian wants to put limits on which patrons can use Kanopy. The idea is that we don't want to allow more than one person per household to be able stream videos; otherwise mom, pop, and all the kids could go crazy one weekend on a Buffy The Vampire Slayer binge, for example. But Kanopy and Koha don't have a way to impose this kind of limit. So I came up with the following idea, which does seem to work in my test VM: 1. Add a new patron attribute called "KANOPY_OK", which has a yes/no value. Set it to yes for those patrons that will be allowed access to Kanopy. 2. Hack the SIP server code for "handle patron status" to check the incoming client's IP address against a Kanopy-provided list of IP addresses. If there is a match, authenticate the patron only if their "KANOPY_OK" atribute is "yes" (actually "1"). But I hate the fact that I had to hack Koha to do this (see part of the hack below). Am I'm going at this the wrong way? Would it make more sense to enhance the plugin architecture to add a SIP2 patron filter function like the one below? Is this just too ugly to ever be considered seriously? Thanks in advance, Mark P.S. Here's the main part of the hack, which is a function that is called from handle_patron_status and handle_patron_info. my @kanopy_ips = ( "208.66.24.46", "104.239.197.182", "18.209.148.51", "34.232.89.121", "34.234.81.211", "34.235.227.70", "34.235.53.173", "52.203.108.44" ); sub sip2_check_patron { my ( $patron, $server ) = @_; if ( $patron ) { my $ipaddr = $server->{server}->{client}->peerhost; foreach my $kanopy ( @kanopy_ips ) { if ( $ipaddr =~ /^(::ffff:)?\Q$kanopy\E$/ ) { my $borrowernumber = $patron->{borrowernumber}; my $value = C4::Members::Attributes::GetBorrowerAttributeValue( $borrowernumber, 'KANOPY_OK' $ return $value eq "1"; } } } return 1; }

2 5

New Rest API RFCs
by Josef Moravec 27 Oct '18

27 Oct '18

Hello developers, Me and Michal Denar were thinking a bit about some REST api endpoints, write down some rfcs and would like to see any comment on them ;) Thanks in advance https://wiki.koha-community.org/wiki/Checkouts_endpoint_RFC https://wiki.koha-community.org/wiki/Availability_endpoints_RFC In this one we heavily used Katrin's comments and proposed new object definition, thanks Katrin ;) https://wiki.koha-community.org/wiki/Items_endpoint_RFC -- Josef Moravec josef.moravec(a)gmail.com

6 5

Is finesMode = test still operational and sending emails?
by Magnus Enger 27 Oct '18

27 Oct '18

Hi! The help of the cronjob fines.pl says: This script calculates and charges overdue fines to patron accounts. The Koha system preference 'finesMode' controls whether the fines are calculated and charged to the patron accounts ("Calculate and charge"); calculated and emailed to the admin but not applied ("Calculate (but only for mailing to the admin)"); or not calculated ("Don't calculate"). I have a library set up with finesMode = test and as far as I can tell everything is as it should be. But no emails are sent to KohaAdminEmailAddress. Reading through fines.pl I can see it generating a file, but not doing any emailing. Am I missing something or did we loose the emailing somewhere along the way? Best regards, Magnus

2 1

bulkmarcimport -d and -fk
by Stefano Bargioni 27 Oct '18

27 Oct '18

Hi, all, before adding a bug, I'd like to discuss this issue with others. For testing, I installed Koha 18.06.00.032 and Elasticsearch on a Debian 8 virtual machine, using packages koha-common and koha-elasticsearch. Mysql is "mysql Ver 14.14 Distrib 5.5.60, for debian-linux-gnu (x86_64) using readline 6.3". bulkmarcimport.pl -d fails with errors like Cannot truncate a table referenced in a foreign key constraint when going to truncate tables biblio, biblioitems, items. The -fk option is required. This is probably due to the more strict "way of life" of Mysql. Do we need to force -fk when -d is specified? Or simply we have to update the -h documentation? Thx. Stefano

2 1

Escape all the TT variables! (aka prevent XSS vulnerabilities)
by Jonathan Druart 26 Oct '18

26 Oct '18

Hi devs, This needs an update. Bug 13618 has been pushed to master. Now you will have to escape all the variables template-side. See the wiki page to understand why and how - https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_filter_all_th… There is a test in the QA script (missing_filter) as well as a test in the codebase to catch missing filters (xt/find-missing-filters.t) To make things easier you can use the misc script (misc/devel/ add_missing_filters.pl) to automatically add the missing filters! Cheers, Jonathan

1 0

SQL-modes wiki page
by Jonathan Druart 26 Oct '18

26 Oct '18

Hi, I have opened a wiki page to try and explain the problems we are facing (and trying to fix) with the SQL modes. I let you read carefully this page and tell me if something is not clear enough:https://wiki.koha-community.org/wiki/SQL_modes Cheers, Jonathan

2 1

The order of "use"
by Mark Tompsett 25 Oct '18

25 Oct '18

Greetings, I was looking at bug 21641, and noticed the patch was explicitly stating C4::Accounts:: on the function in question. I vaguely recalled this sort of symptom shows itself in a knotted “use” mess. C4::Circulation –> C4::Members –> C4::Accounts C4::Circulation –> C4::Accounts C4::Circulation –> C4::Overdues –> C4::Accounts What is the best order to list these? C4::Accounts last? Is putting the C4::Accounts:: on the function in question still something we should do anyways? Feedback appreciated, Mark Tompsett

3 6

Re: [Koha-devel] Price format in order by email
by Holger Meissner 24 Oct '18

24 Oct '18

Thank you, Barton! [%- USE Price -%] [% <<aqorders.listprice>> | $Price %] did the trick :)

2 1