- Koha-devel - lists.koha-community.org

Plugin development question...
by Mark Tompsett 12 Jun '15

12 Jun '15

Greetings, Patches for Koha have a work flow in terms of sign offs, QA, and then pushing. Is there any kind of process for Plugins? I’m discussing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 with Indranil Das Gupta, and that seems to be the question on our minds. GPML, Mark Tompsett

1 0

Where should I put this?
by Mark Tompsett 11 Jun '15

11 Jun '15

Greetings, One of the bugs I was working on needs a function which is duplicated in a a couple places, so I was thinking it would be best to place it somewhere. The question is where? sub getUserBranchAndCategorycode { my $borrowernumber = 0; my $homebranch = q{}; my $categorycode = q{}; if (C4::Context->userenv) { $borrowernumber = C4::Context->userenv->{'number'} || 0; $homebranch = C4::Context->userenv->{'branch'} || q{}; } if ($borrowernumber) { $categorycode = C4::Members::GetBorrowerCategorycode($borrowernumber); } return { ‘branch’ => $homebranch, ‘categorycode’ => $categorycode }; } GPML, Mark Tompsett

3 3

viewlog bug
by long_sam.tw 11 Jun '15

11 Jun '15

Dear koha floks, I found viewlog bugs. If you turn on [ExtendedPatronAttributes], then view Home › Patrons › Modification log Software error: Undefined subroutine &main::GetBorrowerAttributes called at /usr/share/koha/intranet/cgi-bin/tools/viewlog.pl line 82. Bug fix modify viewlog.pl line 82 change my $attributes = GetBorrowerAttributes( $data->{'borrowernumber'} ); to my $attributes = C4::Members::Attributes::GetBorrowerAttributes( $data->{'borrowernumber'} ); Koha version : 3.16.11, 3.18.7, 3.20 Help me patch viewlogs next release version. Thanks a lot 龍山

3 3

OPAC Validation error
by Mark Tompsett 10 Jun '15

10 Jun '15

Greetings, I was trying to clean up our HTML in our OPACNavRight, etc. and hit this error: Error: Bad value unapi-server for attribute rel on element link: The string unapi-server is not a registered keyword. >From line 32, column 1; to line 32, column 123 I was wondering if some HTML Guru with Koha experience might be able to explain the best way to correct this error. GPML, Mark Tompsett

3 2

Dangerously useful?
by Mark Tompsett 05 Jun '15

05 Jun '15

Greetings, If you are like me, you get a lot of branches going, and trimming back takes too much time to check if they have been pushed, etc. etc. Here’s my attempt at a script. Obviously, my branches have bug_#### on them, and a few that don’t and obviously are unrelated to bugzilla. :) Enjoy, Mark Tompsett #!/bin/bash if [[ ! -d ~/bugs2check ]]; then echo "Creating report directory..." mkdir ~/bugs2check fi git checkout master BRANCH=`git status | grep "On branch" | cut -f3- -d' '` if [[ $BRANCH != "master" ]]; then echo "Handle your commits first." exit fi echo > ~/bugs2check/REPORT BUGS=`git branch | grep "bug_[0-9][0-9]*$" | cut -f2 -d'_' | sort -u` for i in `echo $BUGS`; do wget -O- http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=$i > ~/bugs2check/$i 2> /dev/null STATUS=`grep static_bug ~/bugs2check/$i | cut -f2 -d'>'` echo $i - $STATUS | tee -a ~/bugs2check/REPORT done BUGS2DEL=`grep 'Pushed to Master' ~/bugs2check/REPORT | cut -f1 -d' '` for i in `echo $BUGS2DEL`; do BRANCHES=`git branch | grep bug_$i` read -p "Delete $BRANCHES? " -n 1 -r echo # (optional) move to a new line if [[ $REPLY =~ ^[Yy]$ ]]; then for j in `echo $BRANCHES`; do git branch -D $j done fi done BUGS2DEL=`grep 'Pushed to Stable' ~/bugs2check/REPORT | cut -f1 -d' '` for i in `echo $BUGS2DEL`; do BRANCHES=`git branch | grep bug_$i` read -p "Delete $BRANCHES? " -n 1 -r echo # (optional) move to a new line if [[ $REPLY =~ ^[Yy]$ ]]; then for j in `echo $BRANCHES`; do git branch -D $j done fi done BUGS2DEL=`grep 'CLOSED' ~/bugs2check/REPORT | cut -f1 -d' '` for i in `echo $BUGS2DEL`; do BRANCHES=`git branch | grep bug_$i` read -p "Delete $BRANCHES? " -n 1 -r echo # (optional) move to a new line if [[ $REPLY =~ ^[Yy]$ ]]; then for j in `echo $BRANCHES`; do git branch -D $j done fi done BUGS2DEL=`grep 'RESOLVED' ~/bugs2check/REPORT | cut -f1 -d' '` for i in `echo $BUGS2DEL`; do BRANCHES=`git branch | grep bug_$i` read -p "Delete $BRANCHES? " -n 1 -r echo # (optional) move to a new line if [[ $REPLY =~ ^[Yy]$ ]]; then for j in `echo $BRANCHES`; do git branch -D $j done fi done

2 1

Re: [Koha-devel] make test in new installation fails (Hector Castro)
by Hector Castro 04 Jun '15

04 Jun '15

Hi, Jonathan Why did you install module from CPAN? > Which ones? > How did you install Koha? > I follow-up INSTALL.debian that come with my koha clone. So, I only installed some dependencies that need to be updated or installed from CPAN. But all was made it whit the repositories from Debian. Maybe the problem is that I'm not using the koha repository <deb http://debian.koha-community.org/koha stable main> in my sources.list file. Maybe the problem is that this is an old installation started when I was newbie in Koha (I'm still newbie). I've returned to retake the installation. Which modules? I don't remember at all which ones. Regards -- Atte, Héctor Eduardo Castro Avalos

1 0

Proposal on how to skip articles on sorting titles (only MARC21)
by Tajoli Zeno 04 Jun '15

04 Jun '15

Hi to all, here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 there is a proposal on how to skip articles on sorting titles using indicator n. 2 of field 245. Clearly it works only on MARC21 I'm not sure to have used a good way to do the result, but I find very difficult to use the three files of Zebra xslt setup (marc21/biblios/biblio-koha-indexdefs.xml, marc21/biblios/biblio-zebra-indexdefs.xsl and zebradb/xsl/koha-indexdefs-to-zebra.xsl). Bye Zeno Tajoli -- Zeno Tajoli /Dipartimento Sviluppi Innovativi/ - Automazione Biblioteche Email: z.tajoli(a)cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)

1 0

Moose vs Moo
by Paul Poulain 04 Jun '15

04 Jun '15

Hi the list, Just reading Frédéric thoughts about Moose & Moo written on bug 11190. For those who missed the IRC dev meeting yesterday, this bug was discussed yesterday : http://meetings.koha-community.org/2015/development_irc_meeting_15_april_20… I don't know which decision we must take, but I strongly think that we must all read Frédéric arguments. Maybe Moo/Moose was a good decision, maybe not. Anyway, there are not so many scripts using Moo/Moose, so we can stil change our minds. Next steps ? I'd like to have more informations. For example: * arguments in favor of Moo ? * is the argument "the overhead is cancelled by Plack persistency" valid & is it removing this argument in favor of Moo ? * I'd like to have more details about "too many important features are lost" with Moo ? *Comment # 36 <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190#c36> on bug 11190 <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190> from Frédéric Demians <mailto:frederic@tamil.fr> * Few personal notes about Moose vs Moo (just seen IRC dev meeting logs): There is an overhead using Moose for small short lived programs. But for long- running cronjob/maintenance scripts, there isn't any problem using Moose. For Koha WUI scripts, Moose start time is a problem as long as Koha operates in CGI mode. As soon as there is persistence (Plack), it isn't a problem anymore. This issue of runtime penaly due to using a large and complex library, doing a lot of stuff behind the scene, is not different with Moose and DBIx::Class I don't say DBIx::Class is bad. Moose it bad too => So let's go with Moose! I'd say both libraries share a lot of good things. I think that Moose has various advantages over other OO frameworks. It's complete, very well documented, widely used, a standard, carefully packaged for all major Linux distro. All books about the so-called "modern-Perl movement" deals with using Moose as OO. There is the Perl's famous moto: There's more than one way to do it. Applied to OO, this could conduct to chaos. There are so many ways to do OO in Perl. Code become unreadable and unreliable. Moose forces to adopt a proper and consistent OO approach. Moo try to solve a non-issue (library weight, startup time) in modern execution environments at high price: too many important features are lost. -- Paul Poulain, Associé-gérant / co-owner BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Open Source software and services for libraries

3 2

mirroring the release-tools.git repo
by Mason James 04 Jun '15

04 Jun '15

hey Folks, could someone (Galen or ByWS?) setup the syncing of the release-tools.git repo to the kc.org github mirror? https://github.com/Koha-Community/release-tools thanks, Mason

1 1

Re: [Koha-devel] make test in new installation fails
by Jonathan Druart 04 Jun '15

04 Jun '15

Why did you install module from CPAN? Which ones? How did you install Koha? 2015-06-04 1:54 GMT+01:00 Hector Castro <hector.hecaxmmx(a)gmail.com>: > Hi Jonathan, I'm using perl 5.14 and Debian 7 (oldstable), Tomás sent me a > image showing the unit test in Jenkins and the test work excellent. The > problem is that i'm working in an old mini-laptop and also I don't know if > the problem is that I installed a few modules from CPAN. > > If I run prove t/DateUtils.t fails, the xt/author/Text_CSV_Various.t fails > too. Zebra and Yaz give the error that someone reported before. > > In advance thank you very much, Jonathan > > On Wed, Jun 3, 2015 at 2:08 AM, Jonathan Druart > <jonathan.druart(a)biblibre.com> wrote: >> >> Which version of perl are you using? >> >> 2015-05-30 5:02 GMT+01:00 Hector Castro <hector.hecaxmmx(a)gmail.com>: >> > Hi Koha fellows >> > >> > I was doing a new installation and "make test" FAIL me. >> > Launchs at the end of the test make: *** [test_dynamic] Error 255 and >> > some >> > test give me this: >> > t/NorwegianPatronDB.t ............... strictures.pm extra testing active >> > but >> > couldn't load all modules. Missing were: >> > >> > indirect multidimensional >> > >> > Extra testing is auto-enabled in checkouts only, so if you're the author >> > of a strictures using module you need to run: >> > >> > cpan indirect multidimensional bareword::filehandles >> > >> > Someone can tell me if i did something wrong or this is a bug?. >> > >> > make install worked well. >> > >> > Regards >> > >> > -- >> > Atte, >> > >> > Hector Castro >> > >> > _______________________________________________ >> > Koha-devel mailing list >> > Koha-devel(a)lists.koha-community.org >> > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> > website : http://www.koha-community.org/ >> > git : http://git.koha-community.org/ >> > bugs : http://bugs.koha-community.org/ > > > > > -- > Atte, > > Héctor Eduardo Castro Avalos

1 0