- Koha-devel - lists.koha-community.org

We need Koha Naming Standards
by Kyle Hall 22 Jun '15

22 Jun '15

It's been discussed a few times, but I think we need to formalize naming conventions when writing patches for Koha. The worse offenders are those things that we use many different names for both internally and externally. I think patrons/borrowers/members is the worst offender. List come to mind as well ( previously being virtual shelves ). I believe that our internal nomenclature should reflect our outward nomenclature. So if the staff and/or OPAC use the term "patron" we should be using the term "patron" in our code as well, especially for namespaces. What does everyone think? The more we hammer out now the easier it will be to vote on naming rules at the dev meeting. Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) Mill Run Technology Solutions ( http://millruntech.com )

7 9

How to fix XSS potential attacks? [again]
by Jonathan Druart 22 Jun '15

22 Jun '15

Hi devs, I have already sent a message on the list, 6 months ago [1] There is some news on the bug report [2]. Please go and test it deeply. I would say we should apply the patch on top of master when we develop/test something, it is the only way to test it massively and correctly and guarantee that we won't find a big regression once it will be pushed. Cheers, Jonathan [1] http://lists.koha-community.org/pipermail/koha-devel/2015-January/041113.ht… [2] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

1 0

Reminder: next dev meeting 24th June 2015
by Tomas Cohen Arazi 22 Jun '15

22 Jun '15

Hi everyone, this is just a reminder that an important dev meeting is taking place next wednesday. Please take the time to dig into the topics so we can discuss such important thignns with a good basis. Agenda: http://wiki.koha-community.org/wiki/Development_IRC_meeting_24_June_2015 Kind regards -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 5353750 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

1 0

C4::Input
by Mark Tompsett 22 Jun '15

22 Jun '15

Greetings, While looking at bug 9006, I came across C4::Context->prepare in C4::Input. So, I just noticed that this checkdigit routine seems unused, and perhaps all of C4::Input could be removed. What do you think? Feedback and thoughts sought. GPML, Mark Tompsett

2 1

AGPL
by Mirko Tietgen 20 Jun '15

20 Jun '15

Hello everybody, there has been a short discussion about AGPL as a license for Koha on IRC http://irc.koha-community.org/koha/2015-06-10#i_1687231 I, for one, would welcome our new AGPL overlords -- or at least a discussion about it. I propose to start arguments and all things flame war here and now, and have a mannered summary/discussion (maybe even a vote, depending on what comes out of this) at the July 8 IRC meeting. I have added it to the agenda. Cheers, Mirko -- Mirko Tietgen mirko(a)abunchofthings.net http://koha.abunchofthings.net http://meinkoha.de

1 1

Call for development news: June Newsletter
by kohanews 18 Jun '15

18 Jun '15

Let the community hear what cool things you're working on! Bugs that need testing, sign-offs and user feedback? ...I'll push them in the public's eye. Tips on how to help/contribute perhaps? k o h a news AT gmail dot com Thank you! -- Chad Roseburg Editor, Koha Newsletter

1 0

Call for news: June Newsletter
by kohanews 18 Jun '15

18 Jun '15

Fellow Koha users ~ I'm collecting news for the June newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria [ UPDATES ]: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events -- **** one month back is the cut-off ***. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the end of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. -- Chad Roseburg Editor, Koha Newsletter

1 0

Question about adding new email/print notifications
by Indranil Das Gupta 15 Jun '15

15 Jun '15

Hi all, When adding a new letter in mandatory/sample_notices.sql, what is the standard practise - add only in the 'en' or also copy it over into all the locale specific sample_notices.sql file? thanks in advance -indranil -- Indranil Das Gupta Phone : +91-98300-20971 Blog : http://indradg.randomink.org/blog IRC : indradg on irc://irc.freenode.net Twitter : indradg -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=- Please exchange editable Office documents only in ODF Format. No other format is acceptable. Support Open Standards. For a free editor supporting ODF, please visit LibreOffice - http://www.documentfoundation.org

2 1

String freeze for Koha 3.20.1
by Chris Cormack 14 Jun '15

14 Jun '15

Hi all It's that time again, string freeze. I will not be pushing any more patches that change templates (unless it is for security reasons) before the release on the 22nd. So once the po files are updated please feel free to start translating Chris

1 0

Issues with DBIx and nested transactions
by Tomas Cohen Arazi 12 Jun '15

12 Jun '15

I've just pushed bug 13967 [1]. It introduces a new package (Koha::Config::SysPrefs) that heavily relies on DBIx::Class to deal with the required CRUD for system preferences. It should be no surprise that the first widespread use of DBIx on Koha's codebase raises problems. Widespread means every call to anything is using it :-D. The point: it noticeably broke lots of our t/db_dependent/ tests. A first guess would point to the package itself. But such doesn't seem to be the case. It is highlighting an underlaying problem in how we deal with the DB: the errors are related to nested transactions taking place, so I would point to our (abuse?) of $dbh->{AutoCommit} = 0 on the tests. Actually, if you pick any db_dependent test that is currently failing on master and set the AutoCommit = 1 you will notice the tests work as expected (with the side effect of altering the DB of course). So, this is a call for all of you, whenever you find some time, to try to figure what's going on and possible solutions to this. I ain't no DBIx expert and will be doing my best but really need your help. Before someone says it: reverting the commits will put us back to the previous state, of course. But it will just hide the problem for a while. [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 5353750 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

5 7