- Koha-devel - lists.koha-community.org

Feature Freeze September 22nd
by Chris Cormack 19 Sep '11

19 Sep '11

Hi All As previously mentioned a few times, the 22nd of September is one month out from the 3.6.0 release. Which makes it the feature freeze date also. No new features submitted after this will be in consideration for 3.6.0. It is strongly recommended that you submit patches as soon as possible and find people to sign those patches off for you. Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand

1 0

Re: [Koha-devel] tt style point
by Paul 16 Sep '11

16 Sep '11

At 08:33 AM 9/16/2011 -0400, Ian Walls wrote: >Colin, > > >I made the decision to require parentheses around the variables for the >sake of consistency.Â All the other template in Koha do it that way, >right or not.Â I'm certainly open to it dropping the parentheses; they >don't seem to follow standard practice, and while I'm sure no >complications are introduced by them, it does add extra keystrokes and one >more "little Koha nuance" to any patch submitted. > >We have not revisited the Coding Style Guidelines for Koha since switching >to Template Toolkit, and I think this should certainly be one of the >issues we address when we do.Â Until then, I recommend we maintain a >consistent style in this, even if we're eventually going to drop it. > >What does the rest of the community think?Â Is it worth being picky about >such a thing until we can decide for sure one way or the other?Â Or, more >pragmatically, should such a thing impede QA? My two cents -- as I had noticed this, but hadn't bothered to look into it as "if it ain't broke, don't fix it". However, I do have a question: is there any case where a () *must* be used within a [% IF .* %] construct? If not, then surely a one time grep -E, or perl -i could revert matters to documented standards? If something is not in the Koha Coding Style Guidelines wiki, then surely we should be able to rely on the standards set by the original coders? Ian, I really do not mean to say you're wrong, just that I think that Colin is on a good track. After nearly a year dealing with Koha, learning a lot, having some fun, and supplying a working system to our staff, volunteers and members/visitors, the one "negative" factor about Koha that stands out to me (personal opinion only) is the untidiness rather than complexity of the coding, all leading to a general sluggishness of the system and an increase in setup, update, modification and maintenance time. As to your last question, QA is an absolute to ensure proper functionality (security, etc) and intrinsically should not worry about *style*; however, when QA is a team responsibility I have always found that lack of clarity, including normalized practices, is counterproductive. Best - Paul tired old sys-admin >Cheers, > > >-Ian > >On Fri, Sep 16, 2011 at 8:13 AM, Colin Campbell ><colin.campbell(a)ptfs-europe.com> wrote: >Hi >Â I noticed that in QA someone is changing tt constructs from >[% IF variable %] >to >[% IF (variable) %] >as style issues > >I think this is very bad style for the following reasons: >You'll not see it in any of the documentation for tt either the perldoc, >on the tt site or in the badger book. (and I've never seen it on any tt >using project). >It adds nothing (we hope) syntactically. >My initial response is that as we are not using normal tt syntax, >something "clever" or magic is going on here rather than a usual [% IF %] >It detracts from readability. (ok slightly subjective but the >environment already makes full use of the top row of the keyboard.) >Whats its relation with the legitimate use of brackets e.g. to call >vmethods in regexps [% IF variable1( variable2 ) %] >The authors didn't require brackets around more complex boolean >expressions [% IF variable == 0 %] why bring em back in for simple >variables. >Could it have unforeseen side effects (don't know but I don't want to >spend time researching it) >It confuses the reader of the code and the writer of subsequent code - >'should I use () no? when? why? >It strikes me as weird (!!) > >In short I'm arguing for clarity... > >I realise that Chris bracketed things in the great template conversion >but I think that was defensive programming when he couldn't rely on >variable always being one. And we shouldn't be encouraging or enforcing >others to use a peculiar idiolect rather than standard practice. > >Colin > > >-- >Colin Campbell >Chief Software Engineer, >PTFS Europe Limited >Content Management and Library Solutions >+44 (0) 845 557 5634Â (phone) >+44 (0) 7759 633626 Â (mobile) >colin.campbell(a)ptfs-europe.com >skype: colin_campbell2 > >http://www.ptfs-europe.com >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/ > > > > >-- >Ian Walls >Lead Development Specialist >ByWater Solutions >Phone # (888) 900-8944 >http://bywatersolutions.com >ian.walls(a)bywatersolutions.com >Twitter: @sekjal >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/

1 0

3.4.x String Freeze
by Chris Nighswonger 16 Sep '11

16 Sep '11

Ok everybody... 3.4.x is presently in a string freeze. The only string affecting patches that will be accepted at this point are blocker and security related bugs. Other patches will be pushed up to the release date. Kind Regards, Chris

1 1

tools should they be command line executable as well ?
by Paul Poulain 15 Sep '11

15 Sep '11

Hello all, On http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5636 Ian asked a question last month no-one answered. So I ask it here: > Style question to the community: should core pages in the staff client (like > tools/cleanborrowers.pl) have both a templated page in the staff client AND a > command-line presence, or should the commandline tool be a separate script in > misc/? > > At this time, there doesn't seem to be any precedent for inclusion in the core > script. Before passing this patch for QA, I'd like to get some feedback, as > this may both open doors for us, as well as create additional work to create > consistency of implementation for existing jobs. My answer is: * right, there is no precedent * This feature to clean borrowers from command line is highly useful : most libraries want to define a rule, and have it applied every week, through a cronjob. But some want to clean manually. So it's meaningful to have a script for both cases. * I think it's fair to have this script run from both, and it's better than having 2 scripts for that, it's easier to maintain * I think a few other script could usefully have the same feature : import_borrowers, batchMod (that does both mod and deletion of items), and that's probably all. So, overally, my choice is : let the need decide. If it's useful for some, do it, but double check for security issues. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

3 2

KohaAdminEmailAddress error - Koha 3.05
by Hartman, David W. - GBTS Library 14 Sep '11

14 Sep '11

For sending emails .... Is there a way to make the To: and From: addresses different in the auto generated messages? I am getting error messages that we are sending to and from the same address. It looks like koha is using the admin address (KohaAdminEmailAddress) for both. I am wondering if there is a configuration setting we are missing. David W. Hartman Global Business Technology Strategy Library

2 3

Notices/Overdues Meeting Reminder
by Elliott Davis 14 Sep '11

14 Sep '11

Hi All, I'd just like to remind you that there will be an IRC meeting tomorrow September 15, 2011 at 1800 UTC. Feel free to visit the wiki<http://wiki.koha-community.org/wiki/Notifications_RFC> and see what we have currently laid out. Best Regards, Elliott Davis

1 0

Database Schema
by Chris Cormack 13 Sep '11

13 Sep '11

Hi All For everyone who writes reports, or develops on Koha, we have a new site available to help. http://schema.koha-community.org/ This, combined with the work Nicole has been doing to add comments allows for nice information like this http://schema.koha-community.org/tables/biblio.html It is up to date with master (what will be 3.6.0 on October 22), and will continue to track master thereafter. Thanks to Robin for rediscovering SchemaSpy and to Nicole for adding comments. Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand

2 2

Recall: KohaAdminEmailAddress FW: User Request for update of Record.
by Hartman, David W. - GBTS Library 12 Sep '11

12 Sep '11

Hartman, David W. - GBTS Library would like to recall the message, "KohaAdminEmailAddress FW: User Request for update of Record.".

1 0

FW: User Request for update of Record.
by Hartman, David W. - GBTS Library 12 Sep '11

12 Sep '11

I am getting this error message when I try to send admin notices. Can anyone help? _____________________________________________ From: postmaster(a)int1.disney.pvt [mailto:postmaster@int1.disney.pvt] Sent: Friday, September 09, 2011 4:05 PM To: Hartman, David W. - GBTS Library Subject: Undeliverable: User Request for update of Record. Delivery has failed to these recipients or distribution lists: david.w.hartman(a)disney.com<mailto:david.w.hartman@disney.com> NOTE: If you are sending a message to an ESPN employee and using Outlook 2007 on a PC, click the To: field and click on the name in the Global Address List to add it. Then click OK. The recipient's e-mail address was not found in the recipient's e-mail system. Exchange will not try to redeliver this message for you. Please check the e-mail address and try resending this message, or provide the following diagnostic text to your system administrator. Diagnostic information for administrators: Generating server: int1.disney.pvt david.w.hartman(a)disney.com #< #5.1.1> #SMTP# Original message headers: Received: from WW-R-ITLWDW1K5M.wdw.disney.com ([ww-r-itlwdw1k5m.wdw.disney.com [172.16.190.240]]) by int11.disney.pvt with ESMTP id p89K51ud009424 ; Fri, 9 Sep 2011 20:05:01 +0000 Received: from WW-R-ITLWDW1K5M.wdw.disney.com (WW-R-ITLWDW1K5M.wdw.disney.com [127.0.0.1]) by WW-R-ITLWDW1K5M.wdw.disney.com (Postfix) with ESMTP id B7CF63DAAD for <david.w.hartman(a)disney.com>; Fri, 9 Sep 2011 16:03:34 -0400 (EDT) Subject: User Request for update of Record. Date: Fri, 9 Sep 2011 16:03:34 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="utf8" To: <david.w.hartman(a)disney.com> Content-Transfer-Encoding: quoted-printable From: <david.w.hartman(a)disney.com> Message-ID: <20110909200334.B7CF63DAAD(a)WW-R-ITLWDW1K5M.wdw.disney.com>

2 2

kohacon11 : Update..
by Koustubha Kale 12 Sep '11

12 Sep '11

Hi All, My apologies for missing yet another meeting. I had an accident. Right arm ( my working arm ) bone & elbow broken. Had to be hospitalized and operated on. I had actually logged in for the meeting with my mobile & left thumb but I was overwhelmed by the medicines during the 3.4 discussion. Anyway I am home now with a couple of weeks compulsory rest. Kohacon11 program as put up by Brooke here<http://wiki.koha-community.org/wiki/Kohacon2011>( http://wiki.koha-community.org/wiki/Kohacon2011 ) looks good. All ground preparations are in hand by VPM authorities. I have requested an additional hall/classroom may be made available in case we require it to run parallel tracks. I will communicate more details about the planned cultural program & dinner, planned one day Mumbai trip for 3rd November etc.. So looks like we will have a great Kohacon11. Looking forward to meeting you all there.. Regards, Koustubha Kale Anant Corporation Contact Details : Address : 103, Armaan Residency, R. W Sawant Road, Nr. Golden Dyes Naka, Thane (w), Maharashtra, India, Pin : 400601. TeleFax : +91-22-21720108, +91-22-21720109 Mobile : +919820715876 Website : http://www.anantcorp.com Blog : http://www.anantcorp.com/blog/?author=2

2 1