- Koha-devel - lists.koha-community.org

Meeting solr doodle tendencies closing tomorrow
by LAURENT Henri-Damien 02 Dec '10

02 Dec '10

Hi, here are the tendencies for the solr meeting : Tuesday, 7th december, 21h UTC and Wednesday, 15th December, 11h UTC I propose that we close the vote on Monday, at 21PM UTC in order to be able to have the time to send a mail for final votes. As a side note, non techy people are welcome at this meeting. Even though techy questions will be assigned. Feel free to invite. mibbit is a very handy tool to attend irc. I still have to make a real agenda for this meeting with all the questions people raised, why we did this, how we solved some issues, what drove our choices and what is the plan, and how we can work all together is still a good starting point. It will be posted on the wiki and here. Only 12 people voted. It is a good start though. I think there are many things that we could work on in groups. The search engine is one of them, Data persistance, and Plack another, Template organisation another, choosing one javascript framework (concensus seems to be in favour of jquery, but how, who when actions ?) .... if you like the idea of those meetings, please feel free to support the idea and come to those meetings and eventually organize one on the theme you favor or need. -- Henri-Damien LAURENT

5 4

ICU chains
by Ian Walls 01 Dec '10

01 Dec '10

Fellow Kohackers, There has been some talk before of using ICU chains with Zebra in order to resolve issues with diacritic search. I've looked at the patch from BibLibre ( http://git.biblibre.com/?p=koha;a=commit;h=c2465153cccb8965b0008186cdb0a94a…) and it seems pretty straightfoward, but it's nearly a year old, and I'm wondering if any work has been done since then. Does this commit resolve the issue (at least for French diacritics)? There has also been some recent posting on handling both Roman and Devangari script ( http://old.nabble.com/Re:-display-search-result-problem-p28106148.html) It references the BibLibre commit. If this methodology is working, what should we do to get it committed to Koha? I'd imagine that we'd need to generalize it to work with all languages... either by making a master set of rules, or having different xml files that can be called depending on your language choice... ideas? Cheers, -Ian -- Ian Walls Lead Development Specialist ByWater Solutions Phone # (888) 900-8944 http://bywatersolutions.com ian.walls(a)bywatersolutions.com Twitter: @sekjal

3 2

meeting solr
by LAURENT Henri-Damien 29 Nov '10

29 Nov '10

Two weeks ago, I said that we would organise a meeting around solr and our developments in progress. We think we may now plan that. We think we could do that next week or the week after in order to tell the community the point what we achieved, what we are missing (And the first and most time-consuming task would be to gather some biblios and some use cases to test so that we donot induce regressions, what we plan to work on, and what the community could help us to do.) Our plan is to share our work on a regular base so that you can all see the direction we are willing to take, and the reasons why we implemented things that way. I would like to invite you to the Doodle poll "meeting solr". I donot want to interfere with the regular meeting. It is more a kind of "Come and play". We will have an up and running interface. Every body interested or even skeptical about this development may come and make his own opinion. Please follow the link in order to participate in the poll: http://doodle.com/2eh7spytgmydduca We will take at least two meetings at two different time in the day so that the wider audience can benefit and ask questions. We will try and assign the questions that you may have. We will therefore take the top two options. One in the morning, and one in the evening. I hope you will join us. -- Henri-Damien LAURENT BibLibre

1 0

Fwd: [koha-commits] main Koha release repository branch, master, updated. v3.02.00-188-g4b69538
by Nicole Engard 29 Nov '10

29 Nov '10

I think this was brought up before but how do I know what has changed in these files? Commit emails that tell me bug numbers and a short title/summary are much more helpful than this. I use these emails to determine what to update in the manual and I can't keep track if I have to go hunt down these commit numbers. Is there another way to format these types of messages to look like the ones that include details about each patch? Nicole ---------- Forwarded message ---------- From: Git repo owner <gitmaster(a)git.koha-community.org> Date: Sun, Nov 14, 2010 at 9:22 PM Subject: [koha-commits] main Koha release repository branch, master, updated. v3.02.00-188-g4b69538 To: koha-commits(a)lists.koha-community.org This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4b69538f9bf6809126cc404a7bc09b02c3830328 (commit) via 38360b766c32ab89c6e5ee87d2459692b47f2b29 (commit) from c0272a6b66e053a86010c7eb8fce1bf080bf428b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: admin/aqbudgetperiods.pl | 4 +++- admin/aqbudgets.pl | 4 +++- admin/aqplan.pl | 5 +++-- .../prog/en/includes/budgets-active-currency.inc | 1 + .../prog/en/modules/admin/aqbudgetperiods.tmpl | 4 +++- .../prog/en/modules/admin/aqbudgets.tmpl | 6 +++--- .../prog/en/modules/admin/aqplan.tmpl | 2 +- .../prog/en/modules/virtualshelves/shelves.tmpl | 6 +++++- koha-tmpl/opac-tmpl/prog/en/css/opac.css | 5 ++++- .../opac-tmpl/prog/en/modules/opac-shelves.tmpl | 3 ++- 10 files changed, 28 insertions(+), 12 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/budgets-active-currency.inc hooks/post-receive -- main Koha release repository _______________________________________________ koha-commits mailing list koha-commits(a)lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits

3 6

flaw in C4/Biblio.pm when controlnumber not set
by Reed Wade 29 Nov '10

29 Nov '10

Hi, I was playing around with strange records (one with no setting for control number) and managed to tickle this-- 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1266) sub GetMarcControlnumber { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1267) my ( $record, $marcflavour ) = @_; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1268) my $controlnumber = ""; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1269) # Control number or Record identifier are the same field in MARC21 and UNIMARC 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1270) # Keep $marcflavour for possible later use 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1271) if ($marcflavour eq "MARC21" || $marcflavour eq "UNIMARC") { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1272) $controlnumber = $record->field('001')->data(); 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1273) } 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1274) } which causes-- Can't call method "data" on an undefined value at /home/reedpetone/koha/dev/koha/C4/Biblio.pm line 1272. when I do this-- http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=2 ------- Since it's a small and recent item, advice on IRC was to just send this to the list. -reed

2 2

Circular references
by LAURENT Henri-Damien 29 Nov '10

29 Nov '10

Hi During KohaCon, Plack and Data persistance was discussed and wome work was done on that. Ian posted a perl script. Marc did another script. It works quite fast. I wanted to publicise this in order to contribute code so that eventually all the circular references could be solved. Find enclosed both scripts : CIRCDeps.pl from Marc and dep_check.pl We will try and keep you informed of what we achieved with that. -- Henri-Damien LAURENT

2 3

FW: [Koha-patches] [PATCH] Bug 4959 (Language inconsistencies on basket groups; skip confirmation when closing basket.)
by Marcel de Rooy 26 Nov '10

26 Nov '10

Hi, I would welcome any input from you on the following proposed patch. Regards, Marcel -----Oorspronkelijk bericht----- Van: koha-patches-bounces(a)lists.koha-community.org [mailto:koha-patches-bounces@lists.koha-community.org] Namens Marcel de Rooy Verzonden: donderdag 25 november 2010 13:50 Aan: koha-patches(a)lists.koha-community.org Onderwerp: [Koha-patches] [PATCH] Bug 4959 (Language inconsistencies on basket groups; skip confirmation when closing basket.) This patch adds a new pref SkipBasketConfirmations. This adds the option to skip confirmations on closing and reopening a basket. If you skip the confirm, you do not create a new basket group. The confusing line Create a purchase order (when closing a basket) is replaced by Attach basket to a new basket group with the same name. A warning for a null value on basketgroupid is fixed. --- acqui/basket.pl | 7 +++++-- .../prog/en/modules/acqui/basket.tmpl | 9 ++++----- .../en/modules/admin/preferences/acquisitions.pref | 6 ++++++ 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/acqui/basket.pl b/acqui/basket.pl index 005fcb9..57308b1 100755 --- a/acqui/basket.pl +++ b/acqui/basket.pl @@ -90,6 +90,9 @@ if (!defined $op) { $op = q{}; } +my $skip_pref= C4::Context->preference("SkipBasketConfirmations") || 0; +$template->param( skip_confirm_reopen => 1) if $skip_pref; + if ( $op eq 'delete_confirm' ) { my $basketno = $query->param('basketno'); DelBasket($basketno); @@ -144,7 +147,7 @@ if ( $op eq 'delete_confirm' ) { print GetBasketAsCSV($query->param('basketno')); exit; } elsif ($op eq 'close') { - my $confirm = $query->param('confirm'); + my $confirm = $query->param('confirm') || $skip_pref; if ($confirm) { my $basketno = $query->param('basketno'); my $booksellerid = $query->param('booksellerid'); @@ -197,7 +200,7 @@ if ( $op eq 'delete_confirm' ) { if ($basket->{closedate} && haspermission({ flagsrequired => { acquisition => 'group_manage'} })) { $basketgroups = GetBasketgroups($basket->{booksellerid}); for my $bg ( @{$basketgroups} ) { - if ($basket->{basketgroupid} == $bg->{id}){ + if ($basket->{basketgroupid} && $basket->{basketgroupid} == $bg->{id}){ $bg->{default} = 1; } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tmpl index 9079b6d..3084b48 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tmpl @@ -39,8 +39,8 @@  <script type="text/javascript"> //<![CDATA[ - function confirm_reopen() { - var is_confirmed = confirm(_('Are you sure you want to reopen this basket?')); + function confirm_reopen(skip) { + var is_confirmed = skip || confirm(_('Are you sure you want to reopen this basket?')); if (is_confirmed) { window.location = "?op=reopen&basketno="; } @@ -95,7 +95,6 @@ <li><a href="basketheader.pl?basketno=&op=add_form" class="button" id="basketheadbutton">Edit basket header information</a></li> <li><a href="javascript:confirm_deletion();" class="button" id="delbasketbutton">Delete this basket</a></li>  - <li><button onclick="confirm_close()" class="yui-button-disabled" id="closebutton" type="button" disabled="disabled" title="You can not close this basket">Can not close basket</button></li>  <li><a href="/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=&owner=1" class="button" id="uncertpricesbutton">Uncertain prices</a></li>  @@ -121,7 +120,7 @@ //]]> </script> <ul id="toolbar-list" class="toolbar"> - <li><a href="javascript:confirm_reopen();" class="button" id="reopenbutton">Reopen this basket</a></li> + <li><a href="javascript:confirm_reopen();" class="button" id="reopenbutton">Reopen this basket</a></li> </ul> </div>  @@ -313,7 +312,7 @@ <form action="/cgi-bin/koha/acqui/basket.pl" class="confirm"> <h1>Are you sure you want to close basket ?</h1> <p> - <label for="createbasketgroup">create a purchase order now?</label> + <label for="createbasketgroup">Attach this basket to a new basket group with the same name</label> <input type="checkbox" id="createbasketgroup" name="createbasketgroup"/> </p> <input type="hidden" id="basketno" value="" name="basketno" /> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref index 2a900f0..41ebe78 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref @@ -18,6 +18,12 @@ Acquisitions: - The default tax rate is - pref: gist - (enter in numeric form, 0.12 for 12%) + - + - When closing or reopening a basket, + - pref: SkipBasketConfirmations + choices: + 0: always ask for confirmation. + 1: do not ask for confirmation. Printing: - -- 1.6.0.6 _______________________________________________ Koha-patches mailing list Koha-patches(a)lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/

3 2

use cases for authentication [was externalising translator and etc]
by LAURENT Henri-Damien 26 Nov '10

26 Nov '10

Hi, as I spotted in previous email some design flaws (in my opinion) in Authentication. >> It gets >> > worse if you consider changes such as adding or modifying an >> > authentication module, for which the default configuration changes are >> > almost invariably associated with code changes. > Same for authentication. I consider this as a design flaw. > We should split authentication and identification. > And manage identification in a modular way... So that administrators > would just have to edit configuration files in order to make correct > mappings, and not dive into the code, change and commit (if they know > git enough...) > I would like to gather some use cases of what hardcoded customization people had to implement in Auth_with_ldap in order to make them run. We have some... Most of which consist in date calculation for users, and hash values mappings for categories or other data or encoding. We also implemented search against multiple branches... (patch to be sent soon (still need some sanitizing) ). But I would be quite interested in more use cases. So that we could have a kind of test cases to implement in order to generalize the thing at its best. -- Henri-Damien LAURENT

1 0

Facets performance
by Fridolyn SOMERS 26 Nov '10

26 Nov '10

Hie, I have posted a proposed patch for Bug 3154 : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3154 It's about the fact that facets computation is limited to the records in search results page. I think I've found a good way to improve the facets extraction performance. Any comment or modification is welcome. Regards, -- Fridolyn SOMERS ICT engineer PROGILONE - Lyon - France fridolyn.somers(a)gmail.com

4 4

Deleting Orders
by Colin Campbell 26 Nov '10

26 Nov '10

Hi, I'm just looking at the branch of acquisitions fixes from Biblibre one fix in there is an addition to DelOrder to delete any items associated with the order on its deletion. However it goes further and deletes the associated bib record if it has no items. thus: > diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm > index c1b837b..54b01fa 100644 > --- a/C4/Acquisition.pm > +++ b/C4/Acquisition.pm > @@ -28,6 +28,7 @@ use C4::Suggestions; > use C4::Biblio; > use C4::Debug; > use C4::SQLHelper qw(InsertInTable); > +use C4::Items; > > use Time::localtime; > use HTML::Entities; > @@ -1219,6 +1220,10 @@ sub DelOrder { > my $sth = $dbh->prepare($query); > $sth->execute( $bibnum, $ordernumber ); > $sth->finish; > + > + my @itemnumbers = GetItemnumbersFromOrder( $ordernumber ); > + C4::Items::DelItem( $dbh, $bibnum, $_ ) for @itemnumbers; > + DelBiblio( $dbh, $bibnum ) if C4::Items::GetItemsCount( $bibnum ) == 0; > } My gut feeling is that deleting the biblio automatically at this point is not a good idea but I thought I'd throw it open for comments. Cheers Colin -- Colin Campbell Chief Software Engineer, PTFS Europe Limited Content Management and Library Solutions +44 (0) 208 366 1295 (phone) +44 (0) 7759 633626 (mobile) colin.campbell(a)ptfs-europe.com skype: colin_campbell2 http://www.ptfs-europe.com

3 4