July 2008 - Koha-devel - lists.koha-community.org

Re: [Koha-devel] [Koha-patches] [PATCH] Fix a bug affecting C4::Context and default context
by Andrew Moore 03 Jul '08

03 Jul '08

On Wed, Jul 2, 2008 at 11:36 AM, Andrew Moore <andrew.moore(a)liblime.com> wrote: > I can't quite track down the problems yet. Can you run the test suite, > or hunt for problems any other way? After some investigation with Frederic, it appears that the failures in the test suite are because the tests assume that they can update the systempreferences table and have those updates appear immediately in the C4::Context. Since this is no longer the case, that assumption is invalid. We'll have to patch the test suite to deal with that change. So, as far as the test suite is concerned, there's no problem with this patch. I haven't really heard any other objections, so I guess it should go in. Shouldn't it? -Andy _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

2 2

mod_perl & Koha 3.0 on Solaris
by Paul POULAIN 03 Jul '08

03 Jul '08

Hello, BibLibre has deployed Koha 3.0 at "Ecole des Mines de Nantes" on a sun server (4 or 5 years old), the DB is 10k biblios (very small then), with 3 librarians and something like 600 patrons. NoZebra set up. The response time on Koha 2.2 was OK With 3.0, it's AWFUL !!! Really. Every page needs 6 seconds or more !!! not joking. so : - it seems there is a problem with Solaris / Perl / Apache / ... We (BibLibre) had the same problem some months ago, for another customer, but he had a debian box also, so we switched and did not investigate further. but now it's sure : there's a problem with sun / Perl / Apache. dunno where exactly. does anyone experiment this too ? - EMN will switch to mod_perl next week. They know it's untested & at their own risk. But they'll report success or failure, so we will know ;-) cheers. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : 04 91 31 45 19 _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

1 0

page size & speed display
by Paul POULAIN 03 Jul '08

03 Jul '08

Hello, I just did some tests on opac (a simple search), and save the html/css/js/... Here is my analysis : - opac-results = 16kB (3 results in my tests). OK, not too much - css = opac.css is 28kB, others (ui.css & print.css) are 2.xkB. Could opac.css be "smallified" ? - js = 300KB !!! with utilities.js being 100KB !!! that's huge !!! Some questions : - is cached in the browser ? (how to be sure / test that it is ?) - do we need all this javascript everytime & can't we avoid what is unneeded ? - isn't it slowing the page display ? on a DSL connection, one need between 3 and 4 seconds to see a result Which is slow imo (300KB/s line, firefox v2, server doing nothing else than answering me) comments/ideas welcomed ! -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : 04 91 31 45 19 _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

9 23

RFC - remove circ/transferstodo.pl prior to general release
by Galen Charlton 03 Jul '08

03 Jul '08

Hi, As noted in bug 2171 (http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2171) the transfers to-do report is not working. The intention of the report seems to be: * get a list of hold requests grouped by branches; specifically, those that already have a specific item associated with them to fill the request (i.e., reserves.priority = 0 and reserves.itemnumber is not null) but have not been transferred yet (i.e., don't have a branchtransfers record). * let the operator initiate the transfer (this doesn't work at all at present) However, by the time any given hold request has priority set to 0, a branchtransfer has already been initiated. In addition, the help for the report implies that this is for potential transfers that are going out other branches; however, the only time this report shows results is when items are due into the current branch, thus duplicating the functionality of circ/transferstoreceive.pl. Is anybody using this report? If so, can you explain what it is supposed to do? If not, I suggest that this be removed prior to the general release. By the way, there seems to be a need for a general report of items that are in transit from one branch to another and which would catch items that haven't arrived in a timely fashion. In its current form, circ/transferstodo.pl isn't it, but I think such a report should be considered for 3.2. Regards, Galen -- Galen Charlton Koha Application Developer LibLime galen.charlton(a)liblime.com p: 1-888-564-2457 x709 _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

2 2

Choose anothero language problems
by constantine 03 Jul '08

03 Jul '08

On Wed, Jul 2, 2008 at 5:15 PM, Andrew Moore <andrew.moore(a)liblime.com> wrote: > I suggest that you ignore these known test failures and continue with > installation. And so I did... BUT, after following the INSTALL file and visiting localhost:8080 I logged in, and chose Greek language which leads me to a blank webpage (http://lsangre:8080/cgi-bin/koha/installer/install.pl) and the koha-error.log contains the: [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Languages.pm line 297. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: DBD::mysql::st execute failed: Table 'koha3rulez.language_descriptions' doesn't exist at /usr/share/koha/lib/C4/Languages.pm line 318. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /usr/share/koha/lib/C4/Languages.pm line 319. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: DBD::mysql::st execute failed: Table 'koha3rulez.language_descriptions' doesn't exist at /usr/share/koha/lib/C4/Languages.pm line 324. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /usr/share/koha/lib/C4/Languages.pm line 325. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Languages.pm line 297. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: DBD::mysql::st execute failed: Table 'koha3rulez.systempreferences' doesn't exist at /usr/share/koha/intranet/cgi-bin/installer/install.pl line 466. [Thu Jul 03 03:17:29 2008] [error] [client 127.0.0.1] [Thu Jul 3 03:17:29 2008] install.pl: HTML::Template::Pro:template /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/el-GR/modules/installer/step1.tmpl not found! at /usr/share/koha/intranet/cgi-bin/installer/install.pl line 475 [Thu Jul 03 03:17:30 2008] [debug] mod_deflate.c(619): [client 127.0.0.1] Zlib: Compressed 0 to 2 : URL /cgi-bin/koha/installer/install.pl Is there a way to start over the installer, or choose the default-english language, instead of doing a clean re-installation? (Because the last few days I've done at least 15 installation of koha 3 / 2.2!!! >:D Thank you in advance, Constantine Tsardounis http://www.costis.name _______________________________________________ Koha-devel mailing list Koha-devel(a)nongnu.org http://lists.nongnu.org/mailman/listinfo/koha-devel _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

2 2

RTL language support -- part 2
by Frederic Demians 03 Jul '08

03 Jul '08

Hello again koha-translate list, Here is what I've find out about RTL support. It seems that CSS opac.css has to be tweaked to handle correctly RTL languages. For this issue: In a LTR language (English/French), in a form you have on a single line: * label * input box * button. In a RTL language, it must be inversed: * button * input box * label. It could be fixed by modifying css opac.css: * delete ligne 38 : float : left; * delete ligne 53 : float : left; Could a templating guy validate this solution (Owen)? Thanks. -- FrÃ©dÃ©ric _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

1 0

translations do not appear
by Georgia Katsarou 03 Jul '08

03 Jul '08

Dear all, We have noticed that even we have translated some words (into Greek) these do not appear on opac/staff. We keep on seeing them in English. Does anybody know why this happen and how we can fix it? Thank you in advance, Georgia Library & Information Service DIKEMES/ College Year in Athens _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

2 1

RTL language support
by Frederic Demians 03 Jul '08

03 Jul '08

Hello koha-translate list, Currently, Koha translation into Arabic raises issues concerning RTL (right-to-left) support. See attached screenshots: * koha-rtl.png -- That's how a page is displayed now in Arabic. * koha-rtl-modified.png -- That's how this page should look like. In a LTR language (English/French), in a form you have on a single line: * label * input box * button. In a RTL language, it must be inversed: * button * input box * label. On all OPAC header, you get a banner with from left to right: * A blank line with at far right a welcome text and connexion link * A blue section with: o Koha logo o 'Search' label o Fields combo box o input box o Search button o Cart and List buttons For a RTL, it must be inverted, from left to right: * A blank line with at far left a connexion link and a welcome text * A blue section with: o Cart and List buttons o Search button o input box o Fields combo box o 'Search' label o Koha logo Koha RTL support seems to be done now by changing <html> parameter 'dir': <html lang="ar-Arab" xml:lang="ar-Arab" dir="rtl" xmlns="http://www.w3.org/1999/xhtml"> Who decided to implement that this way? Why don't use CSS direction property? Like this: http://www.w3schools.com/Css/pr_text_direction.asp Have templates been designed to support RTL languages? Any comment/idea? -- FrÃ©dÃ©ric DEMIANS http://www.tamil.fr/u/fdemians.html _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

1 0

Re: [Koha-devel] [Koha-patches] [PATCH] Fix a bug affecting C4::Context and default context
by Joe Atzberger 02 Jul '08

02 Jul '08

I believe the problem of the XML file being read for each "use" statement is primarily attributable to the bad way Context uses an "import" function that then calls its own constructor (each time!). This also prevents us from doing something intelligent like: use C4::Context qw(marcfromkohafield); and actually get the right result, i.e. "marcfromkohafield" in our namespace. In fact, Context's import does *nothing* in the way of actual import/export and blocks Context being an Exporter. That might be fine if Context were entirely OO, but it clearly is not. IMHO, the intended purpose is better suited to the INIT block, that should only happen once per execution at the class level. If it is going to read KOHA_CONF on import, certainly it should do so only once, but I would argue it shouldn't do it on import in ANY case. --Joe Atzberger On Wed, Jul 2, 2008 at 3:28 AM, Frederic Demians <f.demians(a)tamil.fr> wrote: > Each time a Perl script or a module has this statement: > > use C4::Context > > a default context was created and XML config file was loaded. > > A syspref hash caches syspref already read for the whole > session. A better approach would cash syspref for the > whole application: mod_perl required (or memcached) > --- > C4/Context.pm | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/C4/Context.pm b/C4/Context.pm > index e81fd95..ac2255f 100644 > --- a/C4/Context.pm > +++ b/C4/Context.pm > @@ -248,11 +248,10 @@ sub db_scheme2dbi { > sub import { > my $package = shift; > my $conf_fname = shift; # Config file name > - my $context; > > # Create a new context from the given config file name, if > # any, then set it as the current context. > - $context = new C4::Context($conf_fname); > + $context = new C4::Context($conf_fname) unless $context; > return undef if !defined($context); > $context->set_context; > } > @@ -445,10 +444,14 @@ variable is not set, or in case of error, returns the > undefined value. > # FIXME - The preferences aren't likely to change over the lifetime of > # the script (and things might break if they did change), so perhaps > # this function should cache the results it finds. > + > +my %syspref; > + > sub preference > { > my $self = shift; > my $var = shift; # The system preference to return > + return $syspref{$var} if $syspref{$var}; > my $retval; # Return value > my $dbh = C4::Context->dbh or return 0; > # Look up systempreferences.variable==$var > @@ -458,6 +461,7 @@ sub preference > WHERE variable='$var' > LIMIT 1 > EOT > + $syspref{$var} = $retval; > return $retval; > } > _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

1 0

How do I run the test suite? (was Re: Fix a bug affecting C4::Context and default context)
by Andrew Moore 02 Jul '08

02 Jul '08

On Wed, Jul 2, 2008 at 11:45 AM, Frederic Demians <frederic(a)tamil.fr> wrote: > Yes. It works for me. How can I run the appropriate test suite? There is some information about the test suite at http://wiki.koha.org/doku.php?id=en:development:unit_testing but that documentation certainly has room for improvement. I'll be working on that. In the meantime, here is some instruction to help get you going: During the installation process of Koha, answer "yes" to the question about whether you want to be able to run the automated test suite. This will then ask you some questions about a test database that the test suite can use. Once you have done that once, the test suite will be configured. Assuming that the test suite is configured properly, you can run commands like this from within the 't' directory: * 'make test' will run the bulk of the tests over the code. * You can select individual modules to test (and skip the rest of the tests) with 'make test TEST_CLASS=Search' or 'make test TEST_CLASS=Members' for whatever portion of the application you want to test. Your options are the .pm files in t/lib/KohaTest * To run some tests that take a really long time, but that also test database access, set the "RUN_EXPENSIVE_TESTS" environment variable, like this: 'RUN_EXPENSIVE_TESTS=1 make test' If you have any problems getting going on this, please let me know. It may not be you, the test suite still has plenty of room to grow. Thanks! -Andy _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

1 0