November 2012 - Koha-devel - lists.koha-community.org

QA Re: FIX in qa-tools
by Mason James 02 Nov '12

02 Nov '12

On 2012-10-25, at 1:40 AM, Jonathan Druart wrote: > Hi Mason, > > I did not rebase my qa-tools repo and I found a bug in the check of perlcritic. > So I fixed it and ... I was not able to push, I was not up-to-date :) > > In fact you already tried to fix it in the commit "fixed perlcritic test". > But It is not the good way: > # If the tested file is deleted in the commit, we return 0 > return 0 unless -e $self->path; > > # If the tested file is newly created int the commit, (ie: nothing existing to compare too), we call Perl::Critic, not Test::Perl::Critic::Progressive > unless (-e $self->path) { > > if the path does not exist, the routine returns 0 and does not execute the second unless statement. (and print a warning launching tests: An error occured : Can't use string ("0") as an ARRAY ref while "strict refs" in use at t/Perl.t line 72.). > > I think my last commit ("add a new flag "new_file" to mark a file if it is a newly created") fixes correctly the problem but... be careful :) > > Jonathan heya Jonathan thanks for this, ill do some testing then push your changes up to the kc.rg github repo https://github.com/Koha-Community/koha-qa-tools

5 8

Minor change in bugzilla parameters
by Paul Poulain 02 Nov '12

02 Nov '12

Hi, Yesterday, I was pointing that is was hard to differenciate rel_3_10 and rel_3_10 and rel_3_8 versions in bugzilla lists because the version field is cut to 5 characters. It had been improved to 10 in the past, but each upgrade remove that so chris_c told me we should find a proper/long lasting way to fix this problem I was annoyed until I realized it was trivial to fix ! I've changed the field values to set them to 3.8, 3.10, 3.12 ! So now, you see a useful value in the lists. WARNING: If you have some personal bugzilla filters, they must be updated !!! -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper

1 0

'Subroutine $FOO redefined' warnings in Koha
by Mason James 02 Nov '12

02 Nov '12

hi Folks i was looking at bug 8559, and spotted some unusable 'Subroutine $FOO redefined' errors http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 i did a google, and got some general info about the common problem, but the info did was not enough for me to understand this specific problem in Koha :/ does anyone have an idea what is happening here? are these warnings harmless enough to ignore? or do they reveal a bigger problem? any ideas? these warnings... $ perl -w ./C4/Accounts.pm Subroutine recordpayment redefined at ./C4/Accounts.pm line 85. Subroutine makepayment redefined at ./C4/Accounts.pm line 165. Subroutine getnextacctno redefined at ./C4/Accounts.pm line 246. Subroutine chargelostitem redefined at ./C4/Accounts.pm line 289. Subroutine manualinvoice redefined at ./C4/Accounts.pm line 347. Subroutine fixcredit redefined at ./C4/Accounts.pm line 425. Subroutine refund redefined at ./C4/Accounts.pm line 534. Subroutine getcharges redefined at ./C4/Accounts.pm line 587. Subroutine ModNote redefined at ./C4/Accounts.pm line 604. Subroutine getcredits redefined at ./C4/Accounts.pm line 611. Subroutine getrefunds redefined at ./C4/Accounts.pm line 630. Subroutine ReversePayment redefined at ./C4/Accounts.pm line 652. Subroutine recordpayment_selectaccts redefined at ./C4/Accounts.pm line 686. Subroutine makepartialpayment redefined at ./C4/Accounts.pm line 739. Subroutine WriteOffFee redefined at ./C4/Accounts.pm line 785. and these warnings... $ perl -w ./C4/Reserves.pm Subroutine AddReserve redefined at ./C4/Reserves.pm line 142. Subroutine GetReservesFromBiblionumber redefined at ./C4/Reserves.pm line 255. Subroutine GetReservesFromItemnumber redefined at ./C4/Reserves.pm line 336. Subroutine GetReservesFromBorrowernumber redefined at ./C4/Reserves.pm line 361. Subroutine CanBookBeReserved redefined at ./C4/Reserves.pm line 393. Subroutine CanItemBeReserved redefined at ./C4/Reserves.pm line 417. Subroutine GetReserveCount redefined at ./C4/Reserves.pm line 508. Subroutine GetOtherReserves redefined at ./C4/Reserves.pm line 532. Subroutine GetReserveFee redefined at ./C4/Reserves.pm line 582. Subroutine GetReservesToBranch redefined at ./C4/Reserves.pm line 685. Subroutine GetReservesForBranch redefined at ./C4/Reserves.pm line 710. Subroutine GetReserveStatus redefined at ./C4/Reserves.pm line 737. Subroutine CheckReserves redefined at ./C4/Reserves.pm line 776. Subroutine CancelExpiredReserves redefined at ./C4/Reserves.pm line 870. Subroutine AutoUnsuspendReserves redefined at ./C4/Reserves.pm line 913. Subroutine CancelReserve redefined at ./C4/Reserves.pm line 941. Subroutine ModReserve redefined at ./C4/Reserves.pm line 1056. Subroutine ModReserveFill redefined at ./C4/Reserves.pm line 1125. Subroutine ModReserveStatus redefined at ./C4/Reserves.pm line 1193. Subroutine ModReserveAffect redefined at ./C4/Reserves.pm line 1223. Subroutine ModReserveCancelAll redefined at ./C4/Reserves.pm line 1281. Subroutine ModReserveMinusPriority redefined at ./C4/Reserves.pm line 1303. Subroutine GetReserveInfo redefined at ./C4/Reserves.pm line 1329. Subroutine IsAvailableForItemLevelRequest redefined at ./C4/Reserves.pm line 1402. Subroutine AlterPriority redefined at ./C4/Reserves.pm line 1456. Subroutine ToggleLowestPriority redefined at ./C4/Reserves.pm line 1492. Subroutine ToggleSuspend redefined at ./C4/Reserves.pm line 1521. Subroutine SuspendAll redefined at ./C4/Reserves.pm line 1562. Subroutine _FixPriority redefined at ./C4/Reserves.pm line 1616. Subroutine _Findgroupreserve redefined at ./C4/Reserves.pm line 1721. Subroutine _koha_notify_reserve redefined at ./C4/Reserves.pm line 1830. Subroutine _ShiftPriorityByDateAndPriority redefined at ./C4/Reserves.pm line 1938. Subroutine MoveReserve redefined at ./C4/Reserves.pm line 1978. Subroutine MergeHolds redefined at ./C4/Reserves.pm line 2027. Subroutine RevertWaitingStatus redefined at ./C4/Reserves.pm line 2077. Subroutine ReserveSlip redefined at ./C4/Reserves.pm line 2131.

3 3

Patches for 3.10 and 3.12
by Jared Camins-Esakov 01 Nov '12

01 Nov '12

Hello. Earlier today I went through Bugzilla and marked all the *bugs* with a status of Needs Signoff or Signed Off that will be held for 3.12. Please concentrate your efforts on those bugs which are versioned for master or rel_3.10 (I think I updated all the bugs that were versioned for older versions). The more attention we can get on the 3.10-destined code, the more stable the release will be. Thanks. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins(a)cpbibliography.com (web) http://www.cpbibliography.com/

3 2

Question (to Jared) about pushing/bugzilla
by Paul Poulain 01 Nov '12

01 Nov '12

Dear 3.12 Release Manager ( ;-) ), I see that you started pushing on master. Great ! I started to check what you push to see if it must be pushed for 3.10, and find the bug 8707. I see on bugzilla that you obsoleted the patch you've pushed (so there's no patch attached). Is it a behaviour that you plan to do for each patch you push ? That's not what I did, so it's a change in the workflow that must be announced (I've nothing against it). So please, confirm ;-) -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper

3 4

Koha 3.10 : git branch created
by Paul Poulain 01 Nov '12

01 Nov '12

Hello koha-devel, The branch 3.10.x has been created and the 3.12 Release Manager has endorsed the master branch. As Release Manager for 3.10 that will be released in 3 weeks, I'm responsible for the 3.10.x branch. Depending on what you want to work with, if you have a git setup, you can/must do * git checkout -b 3.10.x origin/3.10.x => use 3.10 * git checkout origin/master => use master (that will be 3.12 in 6+ months) We will follow the following rules : * Jared pushes first on master branch * I then push on 3.10 branch It mean Jared won't probably push anything large before the 3.10.0 release, and I'll point him the bugfixes that need to be "promoted" to "patch pushed" -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper

1 0

Batch item modification problems in 3.8.x?
by Tomas Cohen Arazi 01 Nov '12

01 Nov '12

Has anyone noticed a bug on batch item updates? Two different librarians reported that bulk changing the itemtype (provided a file with the barcodes) results in NULL values for the rest of the items on those biblios. If someone had that problem just let me know. I'll try to investigate i bit tomorrow. Regards To+

1 0

100$a mapping fixed
by Paul 01 Nov '12

01 Nov '12

I wrote earlier: "All that remains is to work out why our cataloguers cannot get the 100$a into the correct column" but have now found a "fix" that worked for us (I am *not* saying that this might work under other circumstances). From <http://koha-community.org/faqs/relationship-koha-marc-mapping-marc-bibliogr…>: "Mapping can be defined through 'MARC Bibliographic Frameworks' OR 'Koha to MARC Mapping'. 'Koha to MARC Mapping' is just a shortcut to speed up linkage. If you change a mapping in one of these modules, the mapping will change in the other as well. (In other words, the two modules 'overwrite' each other in order to prevent conflicts from existing in Koha). " After upgrade to 3.8.5, both the frameworks and the mapping showed "Author ==> 100$a". On the sandbox yesterday, I deleted all the biblio (not biblioitems nor items) 'Mappings' late in the day and closed the machine down. I restored them (same values as before, only framework code, timestamp and datecreated blank since 3.6.1) and rebooted. Bingo! Cataloguing now fills biblio.author and the XML counterpart. Just done the same on the production box (including two reboots, first time since the upgrade to 3.8.5) and it is also fixed. I have no clue what went wrong; whether it's something corrupt in our Koha db, whether it could be related to Koha, dependencies or other combinations of software (that box runs memcached, several other cgi web-based modules, other db's on MySQL, and SendMail) or whatever. Serendipity is ... Best regards, Paul

2 1

Re: [Koha-devel] Losing biblio.author in 3.8.5
by Paul 01 Nov '12

01 Nov '12

At 02:27 PM 10/31/2012 -0600, Mike Hafen wrote: >Would an SQL Update statement be more effective here? Like: >UPDATE biblio SET author = >ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') WHERE >author IS NULL Many thanks for the suggestion, but I ran into problems -- I think it's to do with mixing a straightforward 'table/column' as in biblio.author with an 'ExtractValue' from a different table. Here's your suggestion: mysql> UPDATE biblio SET author = ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') WHERE author IS NULL; ERROR 1054 (42S22): Unknown column 'marcxml' in 'field list' So I tried a second FROM to point to the 'table/column' with marcxml FROM biblioitems: mysql> UPDATE biblio SET author = ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') FROM biblioitems WHERE author IS NULL; ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM biblioitems WHERE author IS NULL' at line 1 No joy; so bracket the 'ExtractValue' with the table in front of it: mysql> UPDATE biblio SET author = (biblioitems(ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]')) WHERE author IS NULL; ERROR 1305 (42000): FUNCTION koha384.biblioitems does not exist MySQL reads that as a FUNCTION, so put biblioitems. inside the bracket: mysql> UPDATE biblio SET author = ExtractValue(biblioitems.marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') WHERE author IS NULL; ERROR 1054 (42S22): Unknown column 'biblioitems.marcxml' in 'field list' MySQL is really touchy ;={ I hate bothering you, but do you have thoughts on this? Thanks - Paul >On Wed, Oct 31, 2012 at 1:00 PM, Paul ><<mailto:paul.a@aandc.org>paul.a(a)aandc.org> wrote: >At 08:09 PM 10/29/2012 +0100, you wrote: >Hi Paul, > >[snip] > >For your reports you always have the option to query the MARCXML data >directly, nothing should be lost. > > >I agree -- in fact for staff, I've already written a new report replacing >biblio.author with >ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') and >it works perfectly. > >But this doesn't "correct" the MySQL db. Where/why on earth has it gone >wrong, and how to correct it? > > >Could some kind soul with knowledge of using XML in MySQL assist? > >I'm trying to copy the XML 100$a to biblio.author where this latter is >NULL, but: > >mysql> INSERT INTO biblio (biblio.author) > -> SELECT > ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') FROM > biblioitems > -> WHERE biblio.author IS NULL; >ERROR 1054 (42S22): Unknown column 'biblio.author' in 'where clause' > >so I tried to be more explicit for biblio.author and now the XML has an error > >mysql> INSERT INTO biblio (biblio.author) > -> SELECT author FROM biblio, > ExtractValue(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') FROM > biblioitems > -> WHERE biblio.author IS NULL; >ERROR 1064 (42000): You have an error in your SQL syntax; check the manual >that corresponds to your MySQL server version for the right syntax to use >near '(marcxml,'//datafield[@tag="100"]/subfield[@code>="a"]') FROM biblioitems >WHERE' at line 2 > >I have tried various combinations of LEFT|RIGHT JOIN biblio ON ( >biblioitems.biblionumber = biblio.biblionumber) but with no success so far. > > >Thanks and regards -- Paul > > > > > > > >Hope that helps, >Katrin > >-----Ursprüngliche Nachricht----- >Von: ><mailto:koha-devel-bounces@lists.koha-community.org>koha-devel-bounces(a)lists.koha-community.org >im Auftrag von Paul >Gesendet: Mo 29.10.2012 19:55 >An: ><mailto:koha-devel@lists.koha-community.org>koha-devel(a)lists.koha-community.org > >Betreff: [Koha-devel] Losing biblio.author in 3.8.5 >We have a [rather important, it's for donors' tax receipts] report that >includes: >SELECT >items.barcode AS Barcode,items.dateaccessioned AS 'Acc Date', >biblio.title AS Title, biblio.author AS Author,biblioitems.publishercode AS >Publisher,biblioitems.publicationyear AS Year, >biblioitems.editionstatement AS Edition, >items.price as FMV, etc etc etc >It worked perfectly from 3.6.1 up to and including 3.8.4 >Since we upgraded to 3.8.5 (24 Sep, to fix bug 8520), something has changed >-- biblio.author systematically comes up empty (all 245$a fields are >present) while *all* the other field are perfect. (added later: just >checked some other reports that use biblio.author -- same result, other >fields are good, author fails.) >I've looked around release notes and bugs without finding anything >relevant, and am now at a loss as to what I should look for. >Any suggestions warmly accepted. >Thanks and regards, >Paul >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org > >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > >--- >Maritime heritage and history, preservation and conservation, >research and education through the written word and the arts. ><<http://NavalMarineArchive.com>http://NavalMarineArchive.com> and ><<http://UltraMarine.ca>http://UltraMarine.ca> > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > > >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/ --- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>

3 3