- Koha-devel - lists.koha-community.org

Re: [Koha-devel] [Koha-patches] [PATCH 5/5] Bug 6298 : Add optional dependency on Gravatar::URL 1.03
by Robin Sheat 09 May '11

09 May '11

However, the version now in the koha debian repositories should work (it's at 1.04.) Francois Marier schreef op zo 08-05-2011 om 11:20 [+1200]: > This CPAN module is needed for the ShowReviewerPhoto functionality. > > Unfortunately the version in Squeeze (1.02) is not sufficient so it > has to be installed from CPAN: > > sudo apt-get install libnet-dns-perl libtest-warn-perl > sudo cpan Gravatar::URL > > Signed-off-by: Francois Marier <francois(a)debian.org> > --- > C4/Installer/PerlDependencies.pm | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm > index 576dde4..63d14a6 100644 > --- a/C4/Installer/PerlDependencies.pm > +++ b/C4/Installer/PerlDependencies.pm > @@ -479,6 +479,11 @@ our $PERL_DEPS = { > 'required' => '1', > 'min_ver' => '2.22', > }, > + 'Gravatar::URL' => { > + 'usage' => 'Photos in OPAC reviews', > + 'required' => '0', > + 'min_ver' => '1.03', > + }, > }; > > 1; -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5957 6D23 8B16 EFAB FEF8 7175 14D3 6485 A99C EB6D

1 0

Enabling SSL for Koha staff view
by Altaf Mahmud 07 May '11

07 May '11

Hello, I'm trying to implement SSL in my Koha server running on Debian 6.0 (squeeze). I've implemented it for my OPAC view, I've created another file 'koha-ssl' in ../apache2/sites-available/ directory and enabled it. I've edited ../apache2/sites-available/koha like following: NameVirtualHost *:80 <VirtualHost 127.0.1.1:80> ..... ..... </VirtualHost> And ../apache2/sites-available/koha-ssl like following: NameVirtualHost *:443 <VirtualHost 127.0.1.1:443> ..... SSLEngine On SSLCertificateFile /etc/ssl/certs/ssl-cert-snakeoil.pem SSLCertificateKeyFile /etc/ssl/private/ssl-cert-snakeoil.key ..... </VirtualHost> Now https://127.0.1.1/ is showing the OPAC. But I can't figure it out how to implement it for staff-view <VirtualHost 127.0.1.1:8080> Request for port 80 is redirecting to port 443, how can I do that for port 8080? In fact, I don't have any prior idea on doing this; a descriptive suggestion is appropriate for me. Thanks. -- Altaf Mahmud System Programmer Ayesha Abed Library BRAC University Bangladesh.

1 0

[PATCH 1/2] Bug 6298 : Add avatar picture of comment author in OPAC
by Francois Marier 06 May '11

06 May '11

Use Libravatar::URL to pull the avatar picture for comment authors if we have an email address for them. Signed-off-by: Francois Marier <francois(a)debian.org> --- koha-tmpl/opac-tmpl/prog/en/css/opac.css | 3 +++ koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 3 +++ opac/opac-detail.pl | 10 ++++++++++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css index aa295c9..a1e1663 100644 --- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css +++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css @@ -1873,6 +1873,9 @@ a#MARCview, a#MARCviewPop, a#ISBDview, a#Normalview, a#Fullhistory, a#Briefhisto #comments .yours { background-color : #effed5; } +.commentline .avatar { + float : right; +} #comments #addcomment { margin : 0 -1em -1em -1em; padding : .3em 1em; diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt index c063bb3..cfd23d0 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ -675,6 +675,9 @@ YAHOO.util.Event.onContentReady("furtherm", function () { [% ELSE %] <div class="commentline"> [% IF ( ShowReviewer ) %] + [% IF ( review.avatarurl ) %] + <img class="avatar" src="[% review.avatarurl %]" height="80" width="80"/> + [% END %] <h5> Comment by [% review.title %] diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 3e4c76c..cf63a17 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -295,6 +295,13 @@ $template->param( ocoins => GetCOinSBiblio($biblionumber), ); +my $libravatar_available = 0; + +eval 'use Libravatar::URL'; +if (! $@) { + $libravatar_available = 1; +} + my $reviews = getreviews( $biblionumber, 1 ); my $loggedincommenter; foreach ( @$reviews ) { @@ -303,6 +310,9 @@ foreach ( @$reviews ) { $_->{title} = $borrowerData->{'title'}; $_->{surname} = $borrowerData->{'surname'}; $_->{firstname} = $borrowerData->{'firstname'}; + if ($libravatar_available and $borrowerData->{'email'}) { + $_->{avatarurl} = libravatar_url(email => $borrowerData->{'email'}, https => $ENV{HTTPS}); + } $_->{userid} = $borrowerData->{'userid'}; $_->{cardnumber} = $borrowerData->{'cardnumber'}; $_->{datereviewed} = format_date($_->{datereviewed}); -- 1.7.4.4

1 1

Undocumented Behaviour in C4::Dates
by Colin Campbell 04 May '11

04 May '11

Interesting, C4::Dates allows you to instantiate a Date with a day value of 00. Not sure why you really want this behaviour but nowhere does it actually document what this means. We assume that this is intended behaviour as t/Dates.t actually confirms it. But there's no documentation of what it does to a date. If you look at the output from t/Dates.t creating a date with 0/1/1952 (I'm using dmy here) returns a formatted version of 31/12/1951. i.e. ) has a "kind of -1" effect Odd? Confused? Poor Interface? C. -- Colin Campbell Chief Software Engineer, PTFS Europe Limited Content Management and Library Solutions +44 (0) 845 557 5634 (phone) +44 (0) 7759 633626 (mobile) colin.campbell(a)ptfs-europe.com skype: colin_campbell2 http://www.ptfs-europe.com

3 3

Weekly stuff to sign off email
by Chris Cormack 03 May '11

03 May '11

Hi All Ian (the QA manager) and I thought for 3.6.x it might be an idea to send an email each week, highlighting some bugs we would love people to look at. This is not to say, you shouldn't try to sign off all of them :-) But I will attempt to highlight ones that are critical, major, or just cool. Bug 4993 ldap search always uses anonymous when binding by auth Bug 5683 link_bibs_to_authorites.pl can corrupt records Bug 5995 Glitch with checkauth Bug 5724 Sometimes deletes aren't processed correctly by rebuild zebra Bug 5093 JS in IE8 when choosing authority record Bug 6034 Sheliving cart feature can wipe shelving location Bug 5872 Enhancemens to circulation management Bug 5905 Partial fine payments Bug 5184 Upgrade Jquery 1.4.2 Bug 5605 Add Support for SIP Fee Paid Message Bug 5572 refinements to function merge sub merge in C4::AuthoritiesMarc Bug 5009 add autocomplete="off" to borrowernumbers and barcode forms This is just a selection I pulled out, if you have time take a look, the earlier they get checked, the easier they are to merge :) Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand

3 2

related searches?
by Marcel de Rooy 02 May '11

02 May '11

Hi, Just a dumb question. grep -r -l --exclude=*.po "related_search" * on current master gives me 5 five template files: koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc koha-tmpl/opac-tmpl/prog/nl-NL/includes/opac-facets.inc koha-tmpl/opac-tmpl/prog/nl-NL/includes/masthead.inc koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc Apparently, the template vars related, related_search are not used (anymore) ? Does anyone know about it? Marcel

1 0

Why is Dewey in the su index?
by Magnus Enger 29 Apr '11

29 Apr '11

Hi, all! I just had a library ask me about how they could best search for a specific Dewey number (and not as part of a call number, but on it's own). After a bit of head-scratching I discovered that searching for the Dewey-number as a subject gave good results (e.g. /cgi-bin/koha/catalogue/search.pl?idx=su&q=355&op=and&idx=kw&op=and&idx=kw&sort_by=relevance). Now the trouble is I was unable to leave well enough alone, and started trying to figure out why Dewey is included in the su index. And I'm still scratching my head... Normally I would expect to find the answer in one of the following files, but this seems like a dead end: etc/zebradb/marc_defs/normarc/biblios/record.abs melm 082 Dewey-classification:w,Dewey-classification:s etc/zebradb/biblios/etc/bib1.att att 13 Dewey-classification etc/zebradb/ccl.properties #Classification-Dewey 13 A classification number from 082 # the Dewey Decimal # Classification, developed by # Melvyl Dewey. #Dewey-classification 1=13 I have tried also tried grep'ing throught the source for Dewey-classification, with meager results (the mention in Search.pm is just in a list of "available indexes"): C4/Search.pm: 'Dewey-classification', etc/zebradb/biblios/etc/bib1.att:att 13 Dewey-classification etc/zebradb/ccl.properties:#Dewey-classification 1=13 etc/zebradb/marc_defs/unimarc/biblios/record.abs:melm 676$a Dewey-classification:w,Dewey-classification:s etc/zebradb/marc_defs/normarc/biblios/record.abs:melm 082 Dewey-classification:w,Dewey-classification:s etc/zebradb/marc_defs/marc21/biblios/record.abs:melm 082 Dewey-classification:w,Dewey-classification:s koha-tmpl/opac-tmpl/prog/en/modules/opac-browser.tt: <a href="opac-search.pl?q=Dewey-classification:[% LEVEL_LOO.classification |uri %]">[% LEVEL_LOO.description |html %]</a> koha-tmpl/opac-tmpl/prog/nb-NO/modules/opac-browser.tt: <a href="opac-search.pl?q=Dewey-classification:[% LEVEL_LOO.classification |uri %]">[% LEVEL_LOO.description |html %]</a> If anyone could shed some light on why Dewey-numbers are available in the su index I would be eternally grateful! Best regards, Magnus Enger libriotech.no

2 2

Translation bug 6278 (XSLT subfield select pars)
by Marcel de Rooy 28 Apr '11

28 Apr '11

Could not reach the translate list, but this may be interesting for dev too: If your translation file translates the English word "at", please check your XSLT files for >at<. See problem below. English XSLT contains constructs as: <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">at</xsl:with-param> </xsl:call-template> The translated Dutch XSLT contains: <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">bij</xsl:with-param> </xsl:call-template> Since at is not a word here, but just two subfields a and t, they should not have been translated of course. Incidentally, bij is the Dutch translation of the English at. The word gets translated and so subfields a and t are replaced by b, i and j. In most cases resulting in no information. Note: Occurs 5 times in MARC21slim2OPACDetail.xsl. And affects display of fields 490/8XX, 773, 780/785.

3 2

Label Batch Management Broken?
by Bernard Shiundu 27 Apr '11

27 Apr '11

Hi all, Just giving 3.4 a spin on a clean install and find that "Manage Batches" does not pick the branch details and therefore breaks. "Manage Templates" et al correctly register the branch and work fine in my cursory test. Anyone else seen this before I raise a bug report? Bernard Shiundu Strathmore University Library Nairobi, Kenya ________________________________ Strathmore University provides all-round education in an atmosphere of freedom and responsibility. This email and any files transmitted with it are intended solely for use by the recipient(s) to whom it is addressed and may contain confidential information. If you have received this email in error please notify the sender immediately and permanently delete this email and/or any files attached to it from your computer. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Strathmore University. The University accepts no liability whatsoever for any loss or damages incurred, or suffered, resulting, or arising, from the use of this email and/or its attachments. The University warrants neither the integrity of the e-mail nor its freedom from errors, viruses, interception or any other form of interference. ............................................................................ Website: www.strathmore.edu

1 0

DB Documentation
by Nicole Engard 27 Apr '11

27 Apr '11

Hello all, I see that no one volunteered to do the DB Documentation for Koha 3.6 and I'm willing to take this on under the Documentation Manager role. I just wanted to ask for a refresher on what we decided was the way we were going to manage this project. There is the 'COMMENT' option in MySQL or we can just use the '--' notation after every field. Once I know what we want to use I can start documenting the database to the best of my ability so that it will make reporting easier on people new to Koha and Koha language (borrowers instead of patrons, reserves instead of holds, etc etc). Thanks Nicole C. Engard

2 1