- Koha-devel - lists.koha-community.org

Software error: substr outside of string
by harry wykman 06 Nov '08

06 Nov '08

In performing a z39.50 search in my new koha installation, I get the following error: Software error: substr outside of string at /usr/share/koha/lib/C4/Charset.pm line 241. CGI::Carp Any ideas? Thanks, Harry _______________________________________________ Koha-devel mailing list Koha-devel(a)nongnu.org http://lists.nongnu.org/mailman/listinfo/koha-devel

2 1

Re: [Koha-devel] [Koha] error in Amazon.pm script?
by Rick Welykochy 05 Nov '08

05 Nov '08

Emrys Minnig wrote: > Something that might be of interest to the development team... > I think there's a small oversight in C4/Amazon.pm. On line 101 it reads: > > my $uri = "http://www.amazon.com/gp/reader/$isbn/ref=sib_dp_pt/002-7879865-0184864#rea…"; > > This line ignores the locale settings (in my case UK) which the majority of times breaks the 'Search Inside' capability. Which raises another question: why is there a URL such as the above hard-coded in the software? This kind of data should be treated as data ... and stored in the configuration database. cheers rickw

3 2

Whitespace fixes
by Galen Charlton 05 Nov '08

05 Nov '08

Hi, As was pointed out in connection with a recent patch, it can be difficult to evaluate patches that combine both functional and whitespace fixes, particularly if a significant amount of the patch simply changes indentation. If you find it necessary to reformat a large chunk of code, please consider structuring your patches so that whitespace fixes are completely separate from functional changes. Regards, Galen -- Galen Charlton VP, Research & Development, LibLime galen.charlton(a)liblime.com p: 1-888-564-2457 x709 skype: gmcharlt

1 0

problem with CGI::Session (Auth ERROR : cannot get_session() )
by Paul POULAIN 05 Nov '08

05 Nov '08

Hello, The maintainers of the CGI::Session package have splitted the package in smaller pieces. If you install or upgrade CGI::Session to 4.38, you won't have CGI::Session::serialize::yaml, and Koha won't work anymore at all (impossible to get a session, so, you'll get a nasty "Auth ERROR: Cannot get_session()" The solution is to install the CGI::Session::serialize::yaml package, it's simple ! We will update Koha installer for 3.0.1 to check for this dependancy explicitly. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc NOUVEAU TELEPHONE : 04 91 81 35 08 _______________________________________________ Koha-devel mailing list Koha-devel(a)nongnu.org http://lists.nongnu.org/mailman/listinfo/koha-devel

1 0

Trouble with Business::ISBN for Lenny
by harry wykman 05 Nov '08

05 Nov '08

Hello, I am trying to install koha3 on Debian 'lenny' using the instructions for 'sarge'. I know that this is a problem straight up but it was the best strategy I could come up with given no other resources that I could find. All has worked well to this point. I ran: # perl -MCPAN -e 'install Business::ISBN' and got the following output: CPAN: Storable loaded ok (v2.18) Going to read /root/.cpan/Metadata Database was generated on Thu, 30 Oct 2008 22:26:50 GMT Running install for module 'Business::ISBN' CPAN: Data::Dumper loaded ok (v2.121_14) 'YAML' not installed, falling back to Data::Dumper and Storable to read prefs '/root/.cpan/prefs' Running make for B/BD/BDFOY/Business-ISBN-2.04.tar.gz CPAN: Digest::SHA loaded ok (v5.45) CPAN: Compress::Zlib loaded ok (v2.008) Checksum for /root/.cpan/sources/authors/id/B/BD/BDFOY/Business-ISBN-2.04.tar.gz ok Business-ISBN-2.04/ Business-ISBN-2.04/bad-isbn13s.txt Business-ISBN-2.04/bad-isbns.txt Business-ISBN-2.04/Changes Business-ISBN-2.04/examples/ Business-ISBN-2.04/examples/README Business-ISBN-2.04/isbn13s.txt Business-ISBN-2.04/isbns.txt Business-ISBN-2.04/lib/ Business-ISBN-2.04/lib/ISBN.pm Business-ISBN-2.04/lib/ISBN10.pm Business-ISBN-2.04/lib/ISBN13.pm Business-ISBN-2.04/LICENSE Business-ISBN-2.04/Makefile.PL Business-ISBN-2.04/MANIFEST Business-ISBN-2.04/META.yml Business-ISBN-2.04/README Business-ISBN-2.04/scripts/ Business-ISBN-2.04/scripts/get_isbn_data.pl Business-ISBN-2.04/t/ Business-ISBN-2.04/t/albania.t Business-ISBN-2.04/t/constants.t Business-ISBN-2.04/t/interface.t Business-ISBN-2.04/t/isbn10.t Business-ISBN-2.04/t/isbn13.t Business-ISBN-2.04/t/load.t Business-ISBN-2.04/t/png_barcode.t Business-ISBN-2.04/t/pod.t Business-ISBN-2.04/t/pod_coverage.t Business-ISBN-2.04/t/rt/ Business-ISBN-2.04/t/rt/27107.t Business-ISBN-2.04/t/rt/28843.t Business-ISBN-2.04/t/rt/29089.t Business-ISBN-2.04/t/rt/29292.t Business-ISBN-2.04/t/test_manifest Business-ISBN-2.04/t/valid_isbn_checksum.t Business-ISBN-2.04/t/xisbn10.t CPAN: File::Temp loaded ok (v0.18) Warning (usually harmless): 'YAML' not installed, will not store persistent state CPAN.pm: Going to build B/BD/BDFOY/Business-ISBN-2.04.tar.gz Checking if your kit is complete... Looks good Writing Makefile for Business::ISBN Could not read '/root/.cpan/build/Business-ISBN-2.04-LqgiB9/META.yml'. Falling back to other methods to determine prerequisites cp lib/ISBN10.pm blib/lib/Business/ISBN10.pm cp lib/ISBN13.pm blib/lib/Business/ISBN13.pm cp lib/ISBN.pm blib/lib/Business/ISBN.pm Manifying blib/man3/ISBN10.3pm Manifying blib/man3/ISBN13.3pm Manifying blib/man3/ISBN.3pm BDFOY/Business-ISBN-2.04.tar.gz /usr/bin/make -- OK Warning (usually harmless): 'YAML' not installed, will not store persistent state Running make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/albania................ok t/constants..............ok t/interface..............ok t/isbn10.................ok 1/0# # Checking ISBNs... (this may take a bit) t/isbn10.................ok 38/0# # Checking bad ISBNs... (this should be fast) t/isbn10.................ok t/isbn13.................ok 1/0# # Checking ISBN13s... (this may take a bit) # # Checking bad ISBN13s... (this should be fast) t/isbn13.................ok t/load...................ok t/png_barcode............NOK 5/8 # Failed test 'PNG defined for 0596527241' # at t/png_barcode.t line 31. # Eval error for 0596527241: Can't locate object method "Small" via package "GD::Font" (perhaps you forgot to load "GD::Font"?) at /usr/local/share/perl/5.10.0/GD/Barcode/EAN13.pm line 153. t/png_barcode............NOK 8/8 # Failed test 'PNG defined for 9780596527242' # at t/png_barcode.t line 31. # Eval error for 9780596527242: Can't locate object method "Small" via package "GD::Font" (perhaps you forgot to load "GD::Font"?) at /usr/local/share/perl/5.10.0/GD/Barcode/EAN13.pm line 153. # Looks like you failed 2 tests of 8. t/png_barcode............dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 5, 8 Failed 2/8 tests, 75.00% okay t/pod....................skipped all skipped: Test::Pod 1.00 required for testing POD t/pod_coverage...........ok t/valid_isbn_checksum....ok t/xisbn10................ok 1/13You need LWP::Simple to use xisbn() at t/xisbn10.t line 58 You need LWP::Simple to use xisbn() at t/xisbn10.t line 65 You need LWP::Simple to use xisbn() at t/xisbn10.t line 58 You need LWP::Simple to use xisbn() at t/xisbn10.t line 65 t/xisbn10................ok Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/png_barcode.t 2 512 8 2 5 8 1 test skipped. Failed 1/11 test scripts. 2/139 subtests failed. Files=11, Tests=139, 41 wallclock secs (40.29 cusr + 0.20 csys = 40.49 CPU) Failed 1/11 test programs. 2/139 subtests failed. make: *** [test_dynamic] Error 255 BDFOY/Business-ISBN-2.04.tar.gz /usr/bin/make test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports BDFOY/Business-ISBN-2.04.tar.gz Warning (usually harmless): 'YAML' not installed, will not store persistent state Running make install make test had returned bad status, won't install without force Any help would be appreciated. Thanks, Harry _______________________________________________ Koha-devel mailing list Koha-devel(a)nongnu.org http://lists.nongnu.org/mailman/listinfo/koha-devel

3 2

availability of a reserved item
by Paul POULAIN 05 Nov '08

05 Nov '08

Hello, If I don't mind, a book that has a hold on it is, in koha 3.0, displayed as "available" in OPAC. That sound strange, and a bug to me. Am I missing something, or does it have to be fixed ? -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc NOUVEAU TELEPHONE : 04 91 81 35 08

8 15

Fwd: [RFC: DBIx::Class 2/3] DBix::Class - moving C4::ClassSource over to using DBIx::Class
by Adam Thick 04 Nov '08

04 Nov '08

Hi All, Andrew thought it would be a good idea to forward this onto the list to get some discussion going about the use of DBIx::Class in Koha. I sent him an email about it's use, I think it's a great idea! Cheers, Adam T. Begin forwarded message: > From: "Andrew Moore" <andrew.moore(a)liblime.com> > Date: 31 October 2008 12:46:06 AM > To: "Adam Thick" <adam.thick(a)strategicdata.com.au> > Subject: Re: [Koha-devel] [RFC: DBIx::Class 2/3] DBix::Class - > moving C4::ClassSource over to using DBIx::Class > > Hi Adam - > > Thanks for taking the time to look over the patch and make your > comments. I'm glad that you agree that something like this would help > Koha. I'm hopeful that I can get it refined enough to get it accepted. > I think you and I agree on a lot of the points you brought up. Let me > hit a few of them one at a time: > > On Wed, Oct 29, 2008 at 7:47 PM, Adam Thick > <adam.thick(a)strategicdata.com.au> wrote: >> I also think it would be a really good fit for Koha to >> standardise the calls to the database and ensure the SQL is >> sanitised. >> I'd love to one day see Koha as a set of objects, like Koha::Member >> or >> Koha::Biblio, where Koha has attributes that can be handed round to >> each >> object, and each object with it's own set of attributes and methods >> to get >> things done, ah but one day! > > Yes, I'd like to make many of the C4::* packages into classes of > objects, and probably inherit properties from a base class, too. I > think that's a step that will be easier to take after this one, > though. Joe Atzburger and I have been playing with a few different > possibilities, so stay tuned for proposals along those lines. If you > have an example implementation of this, I encourage you to send it > along to the koha-devel list to gauge the community response. > >> I'd recommend creating the DBIx::Class schema with detailed column >> information and inflator/deflators for things like dates and such >> as a start >> too. This is time consuming to go back and add later, and having >> this kind >> of information helps create SQL from your schema and provide >> upgrade scripts >> :) > > That's a good point. In the improvements that I've made since Friday, > I'm using the Schema::Loader to make files that represent each of the > tables, instead of loading them to memory each time. In them, I'm > inflating dates, but nothing else. What else should I be inflating? > >>> my $sources = GetClassSources(); >>> @@ -91,13 +94,11 @@ foreach my $cn_source (sort keys %$sources) { >>> sub GetClassSources { >>> >>> my %class_sources = (); >>> - my $dbh = C4::Context->dbh; >>> - my $sth = $dbh->prepare_cached("SELECT * FROM >>> `class_sources`"); >>> - $sth->execute(); >>> - while (my $source = $sth->fetchrow_hashref) { >>> - $class_sources{ $source->{'cn_source'} } = $source; >>> + >>> + my @class_sources = $schema->resultset('ClassSources')- >>> >search(); >>> + foreach my $row ( @class_sources ) { >>> + $class_sources{ $row->get_column('cn_source') } = { >>> $row->get_columns }; >>> } >>> - $sth->finish(); >>> >>> return \%class_sources; >>> >> >> I found rather than using arrays to store the search in it was a >> bit faster >> ( cause your not loading up an array of data ) and syntactically >> prettier to >> get a result set like this >> >> my $class_sources = $schema->resultset('ClassSources')->search(); >> while ( my $row = $class_sources->next() ) { >> $class_sources->{$row->cn_source} = $row->get_columns >> #not sure if this can be called on a cursor or not, might want to >> look at >> something like >> http://search.cpan.org/~ash/DBIx-Class-0.08010/lib/DBIx/Class/ResultClass/H… > > I'm not a DBIC expert, but I tried sometime similar to that at first > and then switched to my method for some reason. I think it was so that > I could get ahold of the ->columns call. I was probably overlooking a > call like the one you show. I'm sure that we'll get better at using > DBIC as we go along. I'll depend on folks like you to help us use it > better. > >> I am really, really happy that database abstraction is being >> considered for >> Koha. It will mean the code base will be easier to maintain and can >> potentially make database upgrading easier too. I'd like to know if >> you are >> considering a MVC approach to Koha ( in the long run :) I've been >> running >> with Catalyst for a while now too and find that it's great for >> separation >> between Controller, Model and View and definitely makes maintenance >> and >> coding easier. Separating out the code like this also means we can >> re-purpose elements like the Model to perform other tasks like >> providing a >> webservice :) or cron scripts etc... > > I'd like to switch to something like Catalyst at some point, but > that's a pretty long-term goal. If you have any ways to help move in > that direction, I encourage you to share them with us. The roadmap > that I'm working on kind of goes along the lines of: > * abstract out the SQL using DBIC or maybe SQL::Abstract or > DBIx::Abstract > * improve the database upgrade tools by relying on something like > SQL::Translator and DBIx::Class::Schema::Versioned > * start making packages into classes. Maybe use something like Moose? > * Move to something like Catalyst or whatever is good by this point > in time. > > I'm glad that you and I seem to be in agreement on the kinds of things > that would make Koha easier to use, maintain, and extend. Please don't > hesitate to contribute your thoughts (or patches!) to the koha-devel > list. > > Thanks! > -Andy Adam Thick Strategic Data Pty Ltd Ph : +61 (3) 9340-9000 Fax: +61 (3) 9348-2015 Mob: 0404 032 763 Email: Adam.Thick(a)StrategicData.com.au Web: http://www.StrategicData.com.au/ Post: P.O. Box 1166 Carlton, VIC 3053 Australia

1 0

Congratulations to Rosalie Blake
by Chris Cormack 04 Nov '08

04 Nov '08

Hi all Just wanted to bring to the community's attention the fact that Rosalie Blake (the Head librarian at Horowhenua Library trust, and a massive reason why Koha exists) was just awarded a lianza fellowship. Lianza is the Library and Information association of NZ Aotearoa, and a fellowship is the highest honour they bestow. The article on the lianza site is http://www.lianza.org.nz/development/awards/professional/2008-recipients.ht… And I did a quick blog post at http://blog.bigballofwax.co.nz/2008/11/03/rosalie-blake-is-now-a-lianza-fel… So huge congrats to Rosalie and all her team at Horowhenua Library trust, may they always continue their trail blazing ways :) Chris

4 3

configuration files for Debian packaging 1/3 (servers and ports)
by Vincent Danjean 04 Nov '08

04 Nov '08

Hi, As I've a few free time, I'm trying to complete a first version of Debian Koha packaging. I've a few questions for koha/zebra/.. guru that I separate in 3 mails. Here is the first mail. If I understand correctly, a working koha server run several process (apache2, mysqld, ...) and some of them can be run on different machine (apache2 and mysql is the most obvious example). I need some help to correctly identify all the involved processes and to know, for each of them, the configuration files under /etc/koha used and the port(s) they are listening on if any. So, here is my guesses: * apache2 run on the 'main' machine. Would it be possible to setup opac and intranet on different machines ? (I think yes if the configuration is duplicated and koha-http.conf adapted) Port used: __WEBSERVER_PORT__, __WEBSERVER_PORT_LIBRARIAN__ Koha config files needed: koha-conf.xml koha-httpd.conf * mysqld can run on another machine (__DB_HOST__) Port used: __DB_PORT__ Koha config files needed: None * zebrasrv must run on the same machine as apache ? (in this case, opac and intranet cannot be separated) Or *** <listen id="biblioserver" >unix:__ZEBRA_RUN_DIR__/bibliosocket</listen> <listen id="authorityserver" >unix:__ZEBRA_RUN_DIR__/authoritysocket</listen> *** can be changed to point to another machine ? Started with misc/bin/koha-zebra-ctl.sh ? Port used (if SRU is enabled): ZEBRA_SRU_HOST:ZEBRA_SRU_BIBLIOS_PORT and ZEBRA_SRU_HOST:ZEBRA_SRU_AUTHORITIES_PORT Can SRU really be not enabled ? I see nothing in Makefile.PL to disable it. ZEBRA_SRU_HOST must be localhost or the hostname of the machine, must not it ? Port used (if PAZPAR2 is enabled): __MERGE_SERVER_PORT__ Koha config files needed: koha-conf.xml (again ? => which part of the file is needed by koha and which part be zebra ?) zebradb/* * pazpar2 can be run on another machine ? (__PAZPAR2_HOST__) Started with misc/bin/koha-pazpar2-ctl.sh Port used: __PAZPAR2_PORT__ Koha config files needed: pazpar2/* * zebraidx must be run on the same machine as zebrasrv ? Port used: None Koha config files needed: koha-conf.xml (again ?) zebradb/* So, if any guru can confirm/answer to my guesses, it would be easier for me to manage the configuration files without messing up all things and allowing a flexible koha installation on Debian. Best regards, Vincent -- Vincent Danjean GPG key ID 0x9D025E87 vdanjean(a)debian.org GPG key fingerprint: FC95 08A6 854D DB48 4B9A 8A94 0BF7 7867 9D02 5E87 Unofficial pacakges: http://www-id.imag.fr/~danjean/deb.html#package APT repo: deb http://perso.debian.org/~vdanjean/debian unstable main

5 5

Binding journal option iin koha 3
by mallikarjun dora 04 Nov '08

04 Nov '08

HI All, we are planning to switch to koha 3 , we have practice to bind the old journal but in koha 3 , i didn t find that option. if there , please guide me how it? thanks

1 0