- Koha-devel - lists.koha-community.org

Output.pm and include files
by Owen Leonard 08 Dec '03

08 Dec '03

I was deleting some include files from the directory of our custom template, and now we're getting errors about missing files. It looks like Output.pm is trying to find some of these includes, but why? What's it trying to do here: sub startmenu($) { # edit the paths in here my ($type)=shift; if ($type eq 'issue') { open (FILE,"$path/issues-top.inc") || die "could not find : $path/issues- top.inc"; } elsif ($type eq 'opac') { open (FILE,"$path/opac-top.inc") || die "could not find : $path/opac- top.inc"; } elsif ($type eq 'member') { open (FILE,"$path/members-top.inc") || die "could not find : $path/members- top.inc"; } elsif ($type eq 'acquisitions'){ open (FILE,"$path/acquisitions-top.inc") || die "could not find : $path/acquisition-top.inc"; } elsif ($type eq 'report'){ open (FILE,"$path/reports-top.inc") || die "could not find : $path/reports- top.inc"; } elsif ($type eq 'circulation') { open (FILE,"$path/circulation-top.inc") || die "could not find : $path/circulation-top.inc"; } elsif ($type eq 'admin') { open (FILE,"$path/parameters-top.inc") || die "could not find : $path/parameters-top.inc"; } else { open (FILE,"$path/cat-top.inc") || die "could not find : $path/cat- top.inc"; } my @string=<FILE>; close FILE; # my $count=@string; # $string[$count]="<BLOCKQUOTE>"; return @string; } -- Owen ---- Nelsonville Public Library Koha 2.0.0-pre-x (CVS)

2 1

hard coded stuff?
by Benedykt 08 Dec '03

08 Dec '03

Hi all, I am wondering whether this is good or not but in the directory of the includes there appeared a css file with hard coded path of .koha { text-align:center; background-image:url("/intranet-tmpl/default/en/images/background-mem.gif"); } Now if the whole idea by introducing templates was to separate the code from the design then this behavior does not stick to the rules. A person who tries to maintain a given translation needs to visually inspect every aspect of code in order not to overlook those kind of changes. An example: a file in .default/en directory changes. The modification includes a language string and a path to a perl file ON THE SAME LINE OF CODE. Not all diff software packages will show both but rather the whole line will be highlighted as having been modified. For a translator that means visual inspection of the code. Translators are NOT programmers. They may overlook a lot of such little modifications. I have voiced this over and over again that there is something wrong about the way koha chose to internationalize. Before koha-1.2.3 all the language strings where in the perl scripts. Now they are found in the template files. I wonder whether there exists a method of still going back to a flavor of GETTEXT to take care of translations? Benedict

3 6

character encodings in koha 2.0.0
by Benedykt 08 Dec '03

08 Dec '03

Hi, Is there a general, worked-out policy about character encodings so they stay consistent throughout a translation? By this I mean character encodings of the data in mysql, in template files. I know that the perl scripts generate "an obligatory" content-type headers to the template files before output is generated. . But the headers provide to browsers only the first part of the header, without encodings information in it, hence incomplete. Has any work been done on putting it in order? By the way, what does this mean: output_html_with_http_headers $query, $cookie, $template->output; Is the first part of the line a variable? thanks Benedict

3 2

for Chris
by paul POULAIN 04 Dec '03

04 Dec '03

Hi chris, In the DB schema (see previous post), i've listed 10 tables that are not used, or almost not used in Koha. Could you check the list & confirm deletion (look at branchcategories & branchrelations specifically) Note : i'll drop tables only in 2.0.x branch, not in 2.0.0 one (to avoid last-minut bugs) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)

2 1

Koha 2.0.0RC1 released
by paul POULAIN 04 Dec '03

04 Dec '03

Hi, I've just released Koha 2.0.0RC1 : http://sourceforge.net/project/shownotes.php?release_id=201672 Pate should do a press release on friday, as this release has been put in the STABLE tree. Some bugs still present, but fully useable (& used in +5 libraries) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)

1 0

english stopwords
by paul POULAIN 04 Dec '03

04 Dec '03

Hi, Could someone send me a mysqldump of an english version of stopwords table. For instance, this table is empty when you install Koha (& it can be filled, like in french installation) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)

1 0

for Chris
by paul POULAIN 03 Dec '03

03 Dec '03

Hi chris, In the DB schema (see previous post), i've listed 10 tables that are not used, or almost not used in Koha. Could you check the list & confirm deletion (look at branchcategories & branchrelations specifically) Note : i'll drop tables only in 2.0.x branch, not in 2.0.0 one (to avoid last-minut bugs) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)

1 0

DB schema
by paul POULAIN 03 Dec '03

03 Dec '03

Hi guys, An uptodate DB schema is avaible :-) Many people asked for this schema. I've done it. Look at Koha wiki (www.koha.org/wiki) Developper link chapter. The 2 pages schema is avaible in 3 formats : jpg (2 images), PDF and OpenOffice.org (original format) HTH -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)

1 0

Many DBI updates going through as part of bug 662 fix
by MJ Ray 03 Dec '03

03 Dec '03

I'm reviewing nearly all DBI calls in koha after finding non-placeholder use of user values. They could leave koha open to SQL insertion attacks, possible from users. I really don't want that to happen. I'm about 10% done. The main changes I'm making are: 1. Rephrasing anything like $sth = $dbh->prepare("select * from borrowers where borrowernum=$bornum"); $sth->execute(); into $sth = $dbh->prepare("select * from borrowers where borrowernum=?"); $sth->execute($bornum); 2. Rephrasing $query = "some string"; $sth = $dbh->prepare($query); into $sth = $dbh->prepare("some string"); 3. Removing suggestions about using $dbh->do("select * from foo where id=$bar") from comments. I'm trying to be really careful about this, but the sheer number of calls may mean that I introduce a new bug. The various search pages are the most likely to show symptoms, so I'll try to test those before the next release. If any maintainers want to warn me off their code and make these changes themselves, please email me. I'm still wandering around C4/Circulation and working in roughly alphabetical order. -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef(a)jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/

1 0

polish version in 2.0.0RC1
by paul POULAIN 03 Dec '03

03 Dec '03

Hi benedikt & al, do you think the polish version is stable enough to be included as an option during the installation of Koha ? A new version 2.0.0RC1 will be released before end of week. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)

1 0