- Koha-devel - lists.koha-community.org

Zebra and deleted biblios
by Paul 05 Nov '12

05 Nov '12

A couple of weeks ago I mentioned that in 3.8.5, deleting a biblio, after deleting any items attached, requires a complete re-index by Zebra, the cron -z fails. Logging the cron as verbose, I get: Records exported: 0 ==================== REINDEXING zebra ==================== ==================== CLEANING ==================== 17:48:02-04/11 zebraidx(7610) [warn] cannot delete record above (seems new) The error is reproducible: e.g. two biblios, one with a typo important enough that Koha doesn't ask "Duplicate?" during the cataloguing, both with a single item; "attach" the barcode of one to the other and delete the "empty" biblio. After cron -z, the unwanted biblio appears (with no item) in both staff and OPAC until a complete re-index is done. Could someone else please verify, and I'll file a bug if confirmed. For the record, I've tried (sandbox only) the cron with and without -x; the behaviour is identical (sandbox and production.) Best regards, Paul

3 2

Fwd: QA: Passed-QA-by line in commit?
by Chris Cormack 05 Nov '12

05 Nov '12

---------- Forwarded message ---------- From: Chris Cormack <chris(a)bigballofwax.co.nz> Date: 5 November 2012 23:02 Subject: Re: [Koha-devel] QA: Passed-QA-by line in commit? To: Marcel de Rooy <M.de.Rooy(a)rijksmuseum.nl> On 5 November 2012 22:59, Marcel de Rooy <M.de.Rooy(a)rijksmuseum.nl> wrote: > > Hi QA team, > > > > I see lines with Passed-QA-by: in some newer commits. > > Do we need them, should we add them? > > I think if we should, all qa team members should conform. > > > > Those were added where members of the QA team had marked the bug passed qa, but hadn't signed off the patch. It would be better if people signed off on the patches. Chris > > Marcel > > > > > > > _______________________________________________ > Koha-devel mailing list > Koha-devel(a)lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/

1 0

Some thoughts from QA team
by Paul Poulain 05 Nov '12

05 Nov '12

Hi koha-devel, The 3.10 and 3.12 QA teams ( Mason, Jonathan, Marcel & me, with the freshly elected Travis, Katrin -and Jared as RM-) have had a discussion about QA process and would like to propose the 2 following things: * Create a QA specific mailing list (qa(a)lists.koha-community.org ?) This list would be used for QA related discussions. We had some private discussions in the last months (mostly about koha-qa.pl tool = should we add this, remove that,...), and think it's better to have a public mailing list. [ One thing that worried us is "should we let anyone subscribe to the list or moderate list subscriptions to avoid non-QA threads". Not a big deal, but if you've an opinion... ] * Change the priority flag use on bugzilla. Currently, this flag is not really used by anyone. We would like to change it's content to the following values, to reflect the complexity of a patch: 1- trivial patch template/doc only 2- trivial patch - minor Perl code 3- low risk of side-effect 4- medium risk of side effect, but don't underestimate it 5- High risk of side effect, be very careful ! We would also add a wiki page explaining how to choose the value. The value can be set by anyone (patch submitter, sign-offer, QA team, RM), and will just be a helper when someone want to pick up a patch for testing or QAing. Comments welcomed. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

16 21

RSS and SMS overdues cronjob
by Jared Camins-Esakov 05 Nov '12

05 Nov '12

Hello. As they currently stand, the cron jobs at misc/cronjobs/smsoverdues.pl and misc/cronjobs/rss/rss.pl will not work on an out-of-the-box Koha installation, as they require an obsolete templating system. I am wondering if anyone still uses these cron jobs, or whether they are obsolete legacy scripts that should just be removed at this point. So, are you using either of these scripts? Do you know anyone else who does? Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins(a)cpbibliography.com (web) http://www.cpbibliography.com/

4 4

docbook-xml triggers scary update-catalog message(s) under Ubuntu 12.10
by Mark Tompsett 05 Nov '12

05 Nov '12

Greetings, I know the instructions say use LTS for Ubuntu, so this shouldn’t be an immediate problem, but it seems like Ubuntu 12.10 may have a problem. Updating the super catalog... Setting up docbook-xml (4.5-7ubuntu1) ... update-catalog: Suppressing action on super catalog. Invoking trigger instead. update-catalog: Please rebuild the package being set up with a version of debhelper fixing #477751. Which is like: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=675007 I'll keep going, but I think the docbook-xml for debian and ubuntu differ and ubuntu's is broken. Is there a way to force the previous version to be used? 4.5.7? I think the Ubuntu 12.10 is using 4.5.7-1. Given that I have seen a lot of people do Ubuntu lately in the lists and on IRC, this may need consideration. GPML, Mark Tompsett

3 3

QA Re: FIX in qa-tools
by Mason James 02 Nov '12

02 Nov '12

On 2012-10-25, at 1:40 AM, Jonathan Druart wrote: > Hi Mason, > > I did not rebase my qa-tools repo and I found a bug in the check of perlcritic. > So I fixed it and ... I was not able to push, I was not up-to-date :) > > In fact you already tried to fix it in the commit "fixed perlcritic test". > But It is not the good way: > # If the tested file is deleted in the commit, we return 0 > return 0 unless -e $self->path; > > # If the tested file is newly created int the commit, (ie: nothing existing to compare too), we call Perl::Critic, not Test::Perl::Critic::Progressive > unless (-e $self->path) { > > if the path does not exist, the routine returns 0 and does not execute the second unless statement. (and print a warning launching tests: An error occured : Can't use string ("0") as an ARRAY ref while "strict refs" in use at t/Perl.t line 72.). > > I think my last commit ("add a new flag "new_file" to mark a file if it is a newly created") fixes correctly the problem but... be careful :) > > Jonathan heya Jonathan thanks for this, ill do some testing then push your changes up to the kc.rg github repo https://github.com/Koha-Community/koha-qa-tools

5 8

Minor change in bugzilla parameters
by Paul Poulain 02 Nov '12

02 Nov '12

Hi, Yesterday, I was pointing that is was hard to differenciate rel_3_10 and rel_3_10 and rel_3_8 versions in bugzilla lists because the version field is cut to 5 characters. It had been improved to 10 in the past, but each upgrade remove that so chris_c told me we should find a proper/long lasting way to fix this problem I was annoyed until I realized it was trivial to fix ! I've changed the field values to set them to 3.8, 3.10, 3.12 ! So now, you see a useful value in the lists. WARNING: If you have some personal bugzilla filters, they must be updated !!! -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper

1 0

'Subroutine $FOO redefined' warnings in Koha
by Mason James 02 Nov '12

02 Nov '12

hi Folks i was looking at bug 8559, and spotted some unusable 'Subroutine $FOO redefined' errors http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 i did a google, and got some general info about the common problem, but the info did was not enough for me to understand this specific problem in Koha :/ does anyone have an idea what is happening here? are these warnings harmless enough to ignore? or do they reveal a bigger problem? any ideas? these warnings... $ perl -w ./C4/Accounts.pm Subroutine recordpayment redefined at ./C4/Accounts.pm line 85. Subroutine makepayment redefined at ./C4/Accounts.pm line 165. Subroutine getnextacctno redefined at ./C4/Accounts.pm line 246. Subroutine chargelostitem redefined at ./C4/Accounts.pm line 289. Subroutine manualinvoice redefined at ./C4/Accounts.pm line 347. Subroutine fixcredit redefined at ./C4/Accounts.pm line 425. Subroutine refund redefined at ./C4/Accounts.pm line 534. Subroutine getcharges redefined at ./C4/Accounts.pm line 587. Subroutine ModNote redefined at ./C4/Accounts.pm line 604. Subroutine getcredits redefined at ./C4/Accounts.pm line 611. Subroutine getrefunds redefined at ./C4/Accounts.pm line 630. Subroutine ReversePayment redefined at ./C4/Accounts.pm line 652. Subroutine recordpayment_selectaccts redefined at ./C4/Accounts.pm line 686. Subroutine makepartialpayment redefined at ./C4/Accounts.pm line 739. Subroutine WriteOffFee redefined at ./C4/Accounts.pm line 785. and these warnings... $ perl -w ./C4/Reserves.pm Subroutine AddReserve redefined at ./C4/Reserves.pm line 142. Subroutine GetReservesFromBiblionumber redefined at ./C4/Reserves.pm line 255. Subroutine GetReservesFromItemnumber redefined at ./C4/Reserves.pm line 336. Subroutine GetReservesFromBorrowernumber redefined at ./C4/Reserves.pm line 361. Subroutine CanBookBeReserved redefined at ./C4/Reserves.pm line 393. Subroutine CanItemBeReserved redefined at ./C4/Reserves.pm line 417. Subroutine GetReserveCount redefined at ./C4/Reserves.pm line 508. Subroutine GetOtherReserves redefined at ./C4/Reserves.pm line 532. Subroutine GetReserveFee redefined at ./C4/Reserves.pm line 582. Subroutine GetReservesToBranch redefined at ./C4/Reserves.pm line 685. Subroutine GetReservesForBranch redefined at ./C4/Reserves.pm line 710. Subroutine GetReserveStatus redefined at ./C4/Reserves.pm line 737. Subroutine CheckReserves redefined at ./C4/Reserves.pm line 776. Subroutine CancelExpiredReserves redefined at ./C4/Reserves.pm line 870. Subroutine AutoUnsuspendReserves redefined at ./C4/Reserves.pm line 913. Subroutine CancelReserve redefined at ./C4/Reserves.pm line 941. Subroutine ModReserve redefined at ./C4/Reserves.pm line 1056. Subroutine ModReserveFill redefined at ./C4/Reserves.pm line 1125. Subroutine ModReserveStatus redefined at ./C4/Reserves.pm line 1193. Subroutine ModReserveAffect redefined at ./C4/Reserves.pm line 1223. Subroutine ModReserveCancelAll redefined at ./C4/Reserves.pm line 1281. Subroutine ModReserveMinusPriority redefined at ./C4/Reserves.pm line 1303. Subroutine GetReserveInfo redefined at ./C4/Reserves.pm line 1329. Subroutine IsAvailableForItemLevelRequest redefined at ./C4/Reserves.pm line 1402. Subroutine AlterPriority redefined at ./C4/Reserves.pm line 1456. Subroutine ToggleLowestPriority redefined at ./C4/Reserves.pm line 1492. Subroutine ToggleSuspend redefined at ./C4/Reserves.pm line 1521. Subroutine SuspendAll redefined at ./C4/Reserves.pm line 1562. Subroutine _FixPriority redefined at ./C4/Reserves.pm line 1616. Subroutine _Findgroupreserve redefined at ./C4/Reserves.pm line 1721. Subroutine _koha_notify_reserve redefined at ./C4/Reserves.pm line 1830. Subroutine _ShiftPriorityByDateAndPriority redefined at ./C4/Reserves.pm line 1938. Subroutine MoveReserve redefined at ./C4/Reserves.pm line 1978. Subroutine MergeHolds redefined at ./C4/Reserves.pm line 2027. Subroutine RevertWaitingStatus redefined at ./C4/Reserves.pm line 2077. Subroutine ReserveSlip redefined at ./C4/Reserves.pm line 2131.

3 3

Patches for 3.10 and 3.12
by Jared Camins-Esakov 01 Nov '12

01 Nov '12

Hello. Earlier today I went through Bugzilla and marked all the *bugs* with a status of Needs Signoff or Signed Off that will be held for 3.12. Please concentrate your efforts on those bugs which are versioned for master or rel_3.10 (I think I updated all the bugs that were versioned for older versions). The more attention we can get on the 3.10-destined code, the more stable the release will be. Thanks. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins(a)cpbibliography.com (web) http://www.cpbibliography.com/

3 2

Question (to Jared) about pushing/bugzilla
by Paul Poulain 01 Nov '12

01 Nov '12

Dear 3.12 Release Manager ( ;-) ), I see that you started pushing on master. Great ! I started to check what you push to see if it must be pushed for 3.10, and find the bug 8707. I see on bugzilla that you obsoleted the patch you've pushed (so there's no patch attached). Is it a behaviour that you plan to do for each patch you push ? That's not what I did, so it's a change in the workflow that must be announced (I've nothing against it). So please, confirm ;-) -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper

3 4